Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nebari upgrade basic test workflow #2867

Closed
viniciusdc opened this issue Nov 28, 2024 · 1 comment · Fixed by #2780
Closed

Add nebari upgrade basic test workflow #2867

viniciusdc opened this issue Nov 28, 2024 · 1 comment · Fixed by #2780

Comments

@viniciusdc
Copy link
Contributor

viniciusdc commented Nov 28, 2024

From an offline convo I had with @dcmcand:

  • We want the workflow to be triggered by pre-releases or optionally manually
  • We want to use local provider

The steps should be

  1. Deploy the most recent released version of nebari
  2. Perform a health check (curl some endpoints for now)
  3. Run nebari upgrade for the version that triggered the workflow
  4. Perform the health check again

Depending on the scope of the health checks, which we want to keep minimal for the initial version of this test, this might or might not detect whether the upgrade does not break anything.

In any case, it will not be able to prevent the data loss described in the top comment that happened because a resource was deleted and recreated. To test that we would need to add some state in between step 1. and 2. above and verify its integrity after step 4.

Originally posted by @pmeier in #2701 (comment)

@viniciusdc
Copy link
Contributor Author

completed by referenced PR

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Nov 28, 2024
@viniciusdc viniciusdc added this to the 2024.12.1 release milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant