Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support level / time ranges with (ip1,ip2,ip3) triplets. #72

Open
neishm opened this issue Oct 11, 2023 · 2 comments
Open

Support level / time ranges with (ip1,ip2,ip3) triplets. #72

neishm opened this issue Oct 11, 2023 · 2 comments

Comments

@neishm
Copy link
Owner

neishm commented Oct 11, 2023

Currently, only single ip1 values are decoded by fstd2nc.mixins.decode_ip1. This should be extended to properly decode the triplets rp1, rp2, rp3 and handle possible ranges encoded in those elements. Probably this logic should be moved outside of vcoords and put in another mixin, since both forecasts and vertical levels can encode this range information.

This is needed in order to support certain accumulated fields like precipitation.

@neishm neishm changed the title Support level time ranges with (ip1,ip2,ip3) triplets. Support level / time ranges with (ip1,ip2,ip3) triplets. Oct 11, 2023
@neishm
Copy link
Owner Author

neishm commented Oct 12, 2023

I originally thought it would be a straightforward case of passing ip1,ip2,ip3 through the rpnpy function DecodeIp, but after some testing it appears that function doesn't always give the appropriate ranges? May need to settle for patching in support piecemeal for each case based on what end users are expecting the ranges to be.

@neishm
Copy link
Owner Author

neishm commented Nov 8, 2023

Some support added with 'accum' mixin, for specific case where ip2 represents either the accumulation period (in hours) or the starting hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant