Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HexStringInterpreter in Testing utils may accept non-hexadecimal char #1264

Open
Hecate2 opened this issue Dec 12, 2024 · 0 comments
Open

HexStringInterpreter in Testing utils may accept non-hexadecimal char #1264

Hecate2 opened this issue Dec 12, 2024 · 0 comments

Comments

@Hecate2
Copy link
Contributor

Hecate2 commented Dec 12, 2024

public static readonly Regex HexRegex = new(@"^[a-zA-Z0-9_]+$");

It should only take a-fA-F, though it does not really matter. The current test system works with bugs (as features).
A larger problem (handled in #1265 ) is that if (instruction.Operand.Span.TryGetString(out var str) makes the tests slow. I am writing a PR to accelerate tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant