From a513faa9c4ee98f1ee26c9a9fc4a08832be0b10d Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 09:34:32 -0500 Subject: [PATCH 01/21] Fix Windows workflow action --- .github/workflows/main.yml | 22 ++++------------------ tests/Directory.Build.props | 3 ++- 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e3a0b6fd3d..f54fbc7c59 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,7 +7,6 @@ on: env: DOTNET_VERSION: 9.0.x - COVERLET_EXCLUDE_COVERAGE: -p:Exclude="[Neo.UnitTests]*" jobs: @@ -70,34 +69,21 @@ jobs: run: | brew install leveldb brew install gperftools - dotnet build + dotnet build --disable-build-servers dotnet test --no-build - name: Test (windows) if: matrix.os == 'windows-latest' run: | - dotnet build + dotnet build --disable-build-servers dotnet test --no-build - name: Test for coverall if: matrix.os == 'ubuntu-latest' run: | sudo apt-get --assume-yes install libleveldb-dev librocksdb-dev - - dotnet test ./tests/Neo.Cryptography.BLS12_381.Tests --output ./bin/tests/Neo.Cryptography.BLS12_381.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.ConsoleService.Tests --output ./bin/tests/Neo.ConsoleService.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.UnitTests --output ./bin/tests/Neo.UnitTests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.VM.Tests --output ./bin/tests/Neo.VM.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.Json.UnitTests --output ./bin/tests/Neo.Json.UnitTests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.Extensions.Tests --output ./bin/tests/Neo.Extensions.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - - # Plugins - dotnet test ./tests/Neo.Cryptography.MPTTrie.Tests --output ./bin/tests/Neo.Cryptography.MPTTrie.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.Network.RPC.Tests --output ./bin/tests/Neo.Network.RPC.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.Plugins.OracleService.Tests --output ./bin/tests/Neo.Plugins.OracleService.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.Plugins.RpcServer.Tests --output ./bin/tests/Neo.Plugins.RpcServer.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.Plugins.Storage.Tests --output ./bin/tests/Neo.Plugins.Storage.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} - dotnet test ./tests/Neo.Plugins.ApplicationLogs.Tests --output ./bin/tests/Neo.Plugins.ApplicationLogs.Tests ${{ env.COVERLET_EXCLUDE_COVERAGE }} + dotnet build --disable-build-servers + dotnet test --no-build -p:Exclude="[Neo.UnitTests]*" - name: Coveralls if: matrix.os == 'ubuntu-latest' diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index 2753f78406..734fd61e48 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -7,11 +7,12 @@ false true true - TestResults/ + ../../tests/$(MSBuildProjectName)/TestResults lcov true 4 latest + ../../bin/tests/$(MSBuildProjectName) From 51ac973c783542894ddd3578cee42a8767c837fa Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 09:41:34 -0500 Subject: [PATCH 02/21] Changed dotnet test command --- .github/workflows/main.yml | 2 +- tests/Directory.Build.props | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f54fbc7c59..56cfee85b2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -76,7 +76,7 @@ jobs: if: matrix.os == 'windows-latest' run: | dotnet build --disable-build-servers - dotnet test --no-build + dotnet test --no-build --disable-build-servers - name: Test for coverall if: matrix.os == 'ubuntu-latest' diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index 734fd61e48..4b56776a72 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -7,7 +7,7 @@ false true true - ../../tests/$(MSBuildProjectName)/TestResults + ../../TestResults/$(MSBuildProjectName) lcov true 4 From 709f00f568441930cfb2977c47a4615adfba56c0 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 09:56:42 -0500 Subject: [PATCH 03/21] fix some stuff --- .github/workflows/main.yml | 23 +++++++++++------------ tests/Directory.Build.props | 4 +++- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 56cfee85b2..02cba49ed4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -91,18 +91,17 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} files: - ${{ github.workspace }}/tests/Neo.Cryptography.BLS12_381.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.ConsoleService.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.UnitTests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.VM.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Json.UnitTests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Cryptography.MPTTrie.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Network.RPC.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Plugins.OracleService.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Plugins.RpcServer.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Plugins.Storage.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Plugins.ApplicationLogs.Tests/TestResults/coverage.info - ${{ github.workspace }}/tests/Neo.Extensions.Tests/TestResults/coverage.info + ${{ github.workspace }}/TestResults/Neo.Cryptography.BLS12_381.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.ConsoleService.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.VM.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Json.UnitTests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Cryptography.MPTTrie.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Network.RPC.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Plugins.OracleService.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Plugins.RpcServer.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Plugins.Storage.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Plugins.ApplicationLogs.Tests/coverage.info + ${{ github.workspace }}/TestResults/Neo.Extensions.Tests/coverage.info PublishPackage: if: github.ref == 'refs/heads/master' && startsWith(github.repository, 'neo-project/') diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index 4b56776a72..a6f528d01b 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -7,12 +7,14 @@ false true true - ../../TestResults/$(MSBuildProjectName) + ../../TestResults/$(MSBuildProjectName)/ lcov true 4 latest ../../bin/tests/$(MSBuildProjectName) + true + true From 691a895956d7db38f487654fbe033d53eac27744 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 10:04:59 -0500 Subject: [PATCH 04/21] Fix --- tests/Directory.Build.props | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index a6f528d01b..370aae7f44 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -13,7 +13,6 @@ 4 latest ../../bin/tests/$(MSBuildProjectName) - true true From 791dd49d153e6b352640998577cb2fb72e824cfe Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 10:08:45 -0500 Subject: [PATCH 05/21] fix windows action --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 02cba49ed4..30af5f3d55 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -76,7 +76,7 @@ jobs: if: matrix.os == 'windows-latest' run: | dotnet build --disable-build-servers - dotnet test --no-build --disable-build-servers + dotnet test --no-build - name: Test for coverall if: matrix.os == 'ubuntu-latest' From 8106cd32b440269d006623e0a4fe9c5877a96e10 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 10:16:38 -0500 Subject: [PATCH 06/21] Added `OverwriteReadOnlyFiles` --- src/Directory.Build.props | 1 + tests/Directory.Build.props | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 3525fd55f5..b3e34bb7dc 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -22,6 +22,7 @@ 4 latest ../../bin/$(PackageId) + true diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index 370aae7f44..dcfe402e3a 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -13,7 +13,8 @@ 4 latest ../../bin/tests/$(MSBuildProjectName) - true + true + true From 50862b40b7ab7a685a6f11b4fc067f3b79839222 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 10:20:08 -0500 Subject: [PATCH 07/21] revert some stuff --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 30af5f3d55..05bc335caa 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -69,20 +69,20 @@ jobs: run: | brew install leveldb brew install gperftools - dotnet build --disable-build-servers + dotnet build dotnet test --no-build - name: Test (windows) if: matrix.os == 'windows-latest' run: | - dotnet build --disable-build-servers + dotnet build dotnet test --no-build - name: Test for coverall if: matrix.os == 'ubuntu-latest' run: | sudo apt-get --assume-yes install libleveldb-dev librocksdb-dev - dotnet build --disable-build-servers + dotnet build dotnet test --no-build -p:Exclude="[Neo.UnitTests]*" - name: Coveralls From 171cea73df5ba2e73860fcc28a4f0b42f3a7d946 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 10:24:00 -0500 Subject: [PATCH 08/21] update version for coverallsapp action --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 05bc335caa..7414b3b5e5 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -87,7 +87,7 @@ jobs: - name: Coveralls if: matrix.os == 'ubuntu-latest' - uses: coverallsapp/github-action@v2.3.0 + uses: coverallsapp/github-action@v2.3.6 with: github-token: ${{ secrets.GITHUB_TOKEN }} files: From 9b46d35e50811a6cda3b0073e6cac21b9297caa1 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 10:35:33 -0500 Subject: [PATCH 09/21] fixes to tests --- .github/workflows/main.yml | 4 ++++ tests/Directory.Build.props | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7414b3b5e5..eec52c5bc5 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -90,6 +90,10 @@ jobs: uses: coverallsapp/github-action@v2.3.6 with: github-token: ${{ secrets.GITHUB_TOKEN }} + debug: true + measure: true + allow-empty: true + coverage-reporter-platform: linux-x86_64 files: ${{ github.workspace }}/TestResults/Neo.Cryptography.BLS12_381.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.ConsoleService.Tests/coverage.info diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index dcfe402e3a..60bfc6a9ce 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -18,11 +18,11 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive From a265a89945e5e5062c2e066f644b1a453660b00d Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 10:54:41 -0500 Subject: [PATCH 10/21] Fixes --- src/Plugins/Directory.Build.props | 6 +++++- tests/Directory.Build.props | 10 ++++------ .../Neo.ConsoleService.Tests.csproj | 3 +-- .../Neo.Cryptography.MPTTrie.Tests.csproj | 3 +-- .../Neo.Network.RPC.Tests/Neo.Network.RPC.Tests.csproj | 3 +-- .../Neo.Plugins.ApplicationLogs.Tests.csproj | 3 +-- .../Neo.Plugins.OracleService.Tests.csproj | 4 +--- .../Neo.Plugins.RpcServer.Tests.csproj | 4 +--- .../Neo.Plugins.Storage.Tests.csproj | 3 +-- tests/Neo.VM.Tests/Neo.VM.Tests.csproj | 3 +-- 10 files changed, 17 insertions(+), 25 deletions(-) diff --git a/src/Plugins/Directory.Build.props b/src/Plugins/Directory.Build.props index ecd9a2735f..f5eaeb6226 100644 --- a/src/Plugins/Directory.Build.props +++ b/src/Plugins/Directory.Build.props @@ -1,8 +1,12 @@ - + + + true + + diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index 60bfc6a9ce..bfc17f908d 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -18,13 +18,11 @@ - - all - runtime; build; native; contentfiles; analyzers; buildtransitive + + all - - all - runtime; build; native; contentfiles; analyzers; buildtransitive + + all diff --git a/tests/Neo.ConsoleService.Tests/Neo.ConsoleService.Tests.csproj b/tests/Neo.ConsoleService.Tests/Neo.ConsoleService.Tests.csproj index 2afe2e4a8c..6b5e313990 100644 --- a/tests/Neo.ConsoleService.Tests/Neo.ConsoleService.Tests.csproj +++ b/tests/Neo.ConsoleService.Tests/Neo.ConsoleService.Tests.csproj @@ -1,8 +1,7 @@ - + net9.0 - neo_cli.Tests diff --git a/tests/Neo.Cryptography.MPTTrie.Tests/Neo.Cryptography.MPTTrie.Tests.csproj b/tests/Neo.Cryptography.MPTTrie.Tests/Neo.Cryptography.MPTTrie.Tests.csproj index 311405a2da..00d44fee26 100644 --- a/tests/Neo.Cryptography.MPTTrie.Tests/Neo.Cryptography.MPTTrie.Tests.csproj +++ b/tests/Neo.Cryptography.MPTTrie.Tests/Neo.Cryptography.MPTTrie.Tests.csproj @@ -1,8 +1,7 @@ - + net9.0 - Neo.Cryptography.MPT.Tests diff --git a/tests/Neo.Network.RPC.Tests/Neo.Network.RPC.Tests.csproj b/tests/Neo.Network.RPC.Tests/Neo.Network.RPC.Tests.csproj index 4410657db8..9464dab74c 100644 --- a/tests/Neo.Network.RPC.Tests/Neo.Network.RPC.Tests.csproj +++ b/tests/Neo.Network.RPC.Tests/Neo.Network.RPC.Tests.csproj @@ -1,8 +1,7 @@ - + net9.0 - Neo.Network.RPC.Tests diff --git a/tests/Neo.Plugins.ApplicationLogs.Tests/Neo.Plugins.ApplicationLogs.Tests.csproj b/tests/Neo.Plugins.ApplicationLogs.Tests/Neo.Plugins.ApplicationLogs.Tests.csproj index 8e3798d475..b8a51974ef 100644 --- a/tests/Neo.Plugins.ApplicationLogs.Tests/Neo.Plugins.ApplicationLogs.Tests.csproj +++ b/tests/Neo.Plugins.ApplicationLogs.Tests/Neo.Plugins.ApplicationLogs.Tests.csproj @@ -1,8 +1,7 @@ - + net9.0 - Neo.Plugins.ApplicationsLogs.Tests diff --git a/tests/Neo.Plugins.OracleService.Tests/Neo.Plugins.OracleService.Tests.csproj b/tests/Neo.Plugins.OracleService.Tests/Neo.Plugins.OracleService.Tests.csproj index 22932994a6..bbc9a91f3e 100644 --- a/tests/Neo.Plugins.OracleService.Tests/Neo.Plugins.OracleService.Tests.csproj +++ b/tests/Neo.Plugins.OracleService.Tests/Neo.Plugins.OracleService.Tests.csproj @@ -1,9 +1,7 @@ - + net9.0 - OracleService.Tests - Neo.Plugins diff --git a/tests/Neo.Plugins.RpcServer.Tests/Neo.Plugins.RpcServer.Tests.csproj b/tests/Neo.Plugins.RpcServer.Tests/Neo.Plugins.RpcServer.Tests.csproj index 8b1cb9ca8f..258e03d0b2 100644 --- a/tests/Neo.Plugins.RpcServer.Tests/Neo.Plugins.RpcServer.Tests.csproj +++ b/tests/Neo.Plugins.RpcServer.Tests/Neo.Plugins.RpcServer.Tests.csproj @@ -1,9 +1,7 @@ - + net9.0 - Neo.Plugins.RpcServer.Tests - Neo.Plugins.RpcServer.Tests true diff --git a/tests/Neo.Plugins.Storage.Tests/Neo.Plugins.Storage.Tests.csproj b/tests/Neo.Plugins.Storage.Tests/Neo.Plugins.Storage.Tests.csproj index eb0369dd53..edb490afcf 100644 --- a/tests/Neo.Plugins.Storage.Tests/Neo.Plugins.Storage.Tests.csproj +++ b/tests/Neo.Plugins.Storage.Tests/Neo.Plugins.Storage.Tests.csproj @@ -1,8 +1,7 @@ - + net9.0 - Neo.Plugins.Storage.Tests diff --git a/tests/Neo.VM.Tests/Neo.VM.Tests.csproj b/tests/Neo.VM.Tests/Neo.VM.Tests.csproj index ece7531e75..adb83a8d25 100644 --- a/tests/Neo.VM.Tests/Neo.VM.Tests.csproj +++ b/tests/Neo.VM.Tests/Neo.VM.Tests.csproj @@ -1,8 +1,7 @@ - + net9.0 - Neo.Test true From 52759a556528c93e8c17dd324ce4ee180dfd7974 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 11:06:12 -0500 Subject: [PATCH 11/21] fixed --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index eec52c5bc5..c263328d07 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -90,10 +90,10 @@ jobs: uses: coverallsapp/github-action@v2.3.6 with: github-token: ${{ secrets.GITHUB_TOKEN }} - debug: true + debug: false measure: true allow-empty: true - coverage-reporter-platform: linux-x86_64 + format: lcov files: ${{ github.workspace }}/TestResults/Neo.Cryptography.BLS12_381.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.ConsoleService.Tests/coverage.info From 74b03753cfd47d5e0b1e3e180ecc0ce43202b5f4 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Thu, 13 Feb 2025 11:13:41 -0500 Subject: [PATCH 12/21] continue on error --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c263328d07..0f3fe4947d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -88,6 +88,7 @@ jobs: - name: Coveralls if: matrix.os == 'ubuntu-latest' uses: coverallsapp/github-action@v2.3.6 + continue-on-error: true with: github-token: ${{ secrets.GITHUB_TOKEN }} debug: false From bc1f9377576fae3e8f75d8f64e463d3d96658686 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 01:09:21 -0500 Subject: [PATCH 13/21] Update .github/workflows/main.yml Co-authored-by: Shargon --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0f3fe4947d..c263328d07 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -88,7 +88,6 @@ jobs: - name: Coveralls if: matrix.os == 'ubuntu-latest' uses: coverallsapp/github-action@v2.3.6 - continue-on-error: true with: github-token: ${{ secrets.GITHUB_TOKEN }} debug: false From 6488f31e3f0836d606418921acbdd1edeb2399b1 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 08:01:04 -0500 Subject: [PATCH 14/21] fix --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4b1a84fba4..4300634805 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -95,6 +95,7 @@ jobs: allow-empty: true format: lcov files: + ${{ github.workspace }}/TestResults/Neo.UnitTests/coverage.info ${{ github.workspace }}/TestResults/Neo.Cryptography.BLS12_381.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.ConsoleService.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.VM.Tests/coverage.info From 61eac5a6a8ad7b69b6e640d2c8b012f50c21001a Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 08:08:18 -0500 Subject: [PATCH 15/21] revert to do what @shargon wants --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4300634805..4b1a84fba4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -95,7 +95,6 @@ jobs: allow-empty: true format: lcov files: - ${{ github.workspace }}/TestResults/Neo.UnitTests/coverage.info ${{ github.workspace }}/TestResults/Neo.Cryptography.BLS12_381.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.ConsoleService.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.VM.Tests/coverage.info From e91469178ee70bba9879185934a59b9542a8ab49 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 08:10:06 -0500 Subject: [PATCH 16/21] Upload --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4b1a84fba4..4300634805 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -95,6 +95,7 @@ jobs: allow-empty: true format: lcov files: + ${{ github.workspace }}/TestResults/Neo.UnitTests/coverage.info ${{ github.workspace }}/TestResults/Neo.Cryptography.BLS12_381.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.ConsoleService.Tests/coverage.info ${{ github.workspace }}/TestResults/Neo.VM.Tests/coverage.info From 5824ed5e9433d5546aa48f041fa88e87cac28562 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 09:56:48 -0500 Subject: [PATCH 17/21] Update .github/workflows/main.yml --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4300634805..de69b0d86d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -83,7 +83,7 @@ jobs: run: | sudo apt-get --assume-yes install libleveldb-dev librocksdb-dev dotnet build - dotnet test --no-build -p:Exclude="[Neo.UnitTests]*" + dotnet test --no-build - name: Coveralls if: matrix.os == 'ubuntu-latest' From 212a80b29107df69b2b7dcc56d100f2ec88c1212 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 12:41:27 -0500 Subject: [PATCH 18/21] Fixed readonly --- src/Plugins/LevelDBStore/LevelDBStore.csproj | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Plugins/LevelDBStore/LevelDBStore.csproj b/src/Plugins/LevelDBStore/LevelDBStore.csproj index 7021dc8f2b..b28a51a520 100644 --- a/src/Plugins/LevelDBStore/LevelDBStore.csproj +++ b/src/Plugins/LevelDBStore/LevelDBStore.csproj @@ -10,9 +10,9 @@ - - - + + + From fa969376f2f22debcac0defbfd3af504bb0fd21a Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 13:15:46 -0500 Subject: [PATCH 19/21] ci fix --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index de69b0d86d..7eea98d370 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -82,7 +82,7 @@ jobs: if: matrix.os == 'ubuntu-latest' run: | sudo apt-get --assume-yes install libleveldb-dev librocksdb-dev - dotnet build + dotnet build -p:GITHUB_ACTIONS=true dotnet test --no-build - name: Coveralls From d5aa9fc901535c61f518fc3bdf0278fcf5bc5838 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 13:26:27 -0500 Subject: [PATCH 20/21] added `--disable-parallel` --- .github/workflows/main.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7eea98d370..628eb2bf71 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -38,7 +38,7 @@ jobs: dotnet-version: ${{ env.DOTNET_VERSION }} - name: Build (Everything) - run: dotnet build -p:GITHUB_ACTIONS=true + run: dotnet build --disable-parallel -p:GITHUB_ACTIONS=true - name: Install dependencies run: | @@ -69,21 +69,21 @@ jobs: run: | brew install leveldb brew install gperftools - dotnet build -p:GITHUB_ACTIONS=true + dotnet build --disable-parallel -p:GITHUB_ACTIONS=true dotnet test --no-build -p:GITHUB_ACTIONS=true - name: Test (windows) if: matrix.os == 'windows-latest' run: | - dotnet build -p:GITHUB_ACTIONS=true + dotnet build --disable-parallel -p:GITHUB_ACTIONS=true dotnet test --no-build -p:GITHUB_ACTIONS=true - name: Test for coverall if: matrix.os == 'ubuntu-latest' run: | sudo apt-get --assume-yes install libleveldb-dev librocksdb-dev - dotnet build -p:GITHUB_ACTIONS=true - dotnet test --no-build + dotnet build --disable-parallel -p:GITHUB_ACTIONS=true + dotnet test --no-build -p:GITHUB_ACTIONS=true - name: Coveralls if: matrix.os == 'ubuntu-latest' From f5b83d90fa88637f22f0b05cb850ce511ca06f3b Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt Date: Fri, 14 Feb 2025 13:27:53 -0500 Subject: [PATCH 21/21] fix `-p:Exclude="[Neo.UnitTests]*"` --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 628eb2bf71..cd7ee9f793 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -83,7 +83,7 @@ jobs: run: | sudo apt-get --assume-yes install libleveldb-dev librocksdb-dev dotnet build --disable-parallel -p:GITHUB_ACTIONS=true - dotnet test --no-build -p:GITHUB_ACTIONS=true + dotnet test --no-build -p:GITHUB_ACTIONS=true -p:Exclude="[Neo.UnitTests]*" - name: Coveralls if: matrix.os == 'ubuntu-latest'