Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: erratic behavior and display on TV series #830

Open
Dehelssey opened this issue Jan 7, 2025 · 6 comments
Open

Bug: erratic behavior and display on TV series #830

Dehelssey opened this issue Jan 7, 2025 · 6 comments

Comments

@Dehelssey
Copy link

Currently we can only rate and review seasons of a show.

A nice addition would be to be able to do so for the complete series.

@pmakholm
Copy link

pmakholm commented Jan 7, 2025

I seem to be able to add comments and tags to TV Series and after I mark series as "Watching" I can add notes and reviews as well.

I prefer to do this due to the titles of most seasons on TMDB to be just "Season N", which isn't really informative when viewing posts in the feed. I might open a request for title handling of seasons, but I don't have a clear idea of how I would fix it myself yet.

@Dehelssey
Copy link
Author

OK my bad, I don't understand why but on some TV Shows things are displayed like this:
image
so yeah, obviously i can rate/mark them (but notice how button links to seasons are not displayed)

While on others I have this:
image
I realized I can rate and mark them by clicking on the my comment and tags link but it's not displayed as on other pages so I felt like I wasn't able to rate/mark them at all^^

There's a third type of tv shows, where I can both rate the complete show or select seaons one by one:
image

So yeah, not as broken as I thought first, maybe not a top priority, but kinda confusing though :)

@Dehelssey Dehelssey changed the title [Request] would be nice to be able to rate or review complete tv series Bug: erratic behavior and display on TV series Jan 22, 2025
@Dehelssey
Copy link
Author

Changed the title of the issue so it's a bit more accurate to actual issue: not all TV show/series are displayed the same way, some have seasons listed (which links to different items) some don't (you might even have items for the same series, one with the seasons, one without.

When TV show/series has seasons listed, the "to watch" / "watching" / "watched" buttons are not displayed, you're asked to select a season to comment (you have to click on "my comments & tags" to actually mark that item and not one of its children, which is sub-optimal^^)

@alphatownsman
Copy link
Member

Thanks for the feedback.

I prefer to do this due to the titles of most seasons on TMDB to be just "Season N",

I worked on this quite a while ago but only covered zh and en, now I just added more languages, so hopefully it's more acceptable:

curl -sH'accept-language:fr' https://eggplant.place/api/tv/season/1SkOtvwTFVjHBoO0Q3y8in | jq .| grep 'display_title'
  "display_title": "Breaking Bad — Saison 2",

@alphatownsman
Copy link
Member

alphatownsman commented Jan 23, 2025

if there's still strong preference to do this at TV level after the fix above, I'll make an option for it later.

@pmakholm
Copy link

I worked on this quite a while ago but only covered zh and en

That explains why I suddenly ended up with nice looking names. During the latest translation updates I ended up with English as my preferred language.

Then I am not quite sure if I personally would prefer to rate and comment on series or season level. Probably depends on the show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Wishlist
Development

No branches or pull requests

3 participants