Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldCauseReequipAnimation not patched in to ItemInHandRenderer? #1883

Open
Tslat opened this issue Jan 21, 2025 · 1 comment
Open

shouldCauseReequipAnimation not patched in to ItemInHandRenderer? #1883

Tslat opened this issue Jan 21, 2025 · 1 comment
Assignees
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering

Comments

@Tslat
Copy link

Tslat commented Jan 21, 2025

It looks like the patch that put ClientHooks.shouldCauseReequipAnimation into ItemInHandRenderer#tick has been removed
I didn't check all versions, but in 1.21.1 it was there, and as of 21.4.65-beta, it's not patched in anymore, and as a result that method doesn't work/do anything

@Tslat Tslat added the triage Needs triaging and confirmation label Jan 21, 2025
@XFactHD XFactHD added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.21.4 Targeted at Minecraft 1.21.4 and removed triage Needs triaging and confirmation labels Jan 21, 2025
@XFactHD
Copy link
Member

XFactHD commented Jan 21, 2025

This is a known issue. The patch was dropped during the port to 1.21.4 as that introduced the vanilla flag on "client items" (similar idea but limited to switching between different items) which broke this feature in several ways.
Getting this to work again is on my agenda but the primary reason this hasn't happened yet is that just reintroducing an effectively equivalent patch doesn't actually make this work properly again. When the vanilla flag is set on a "client item", the held item will switch immediately but the hand movement will still play (see video from vanilla below where the paper item has the flag set). The Neo hook excibits the exact same (arguably broken) behaviour with a minimal fix.

Minecraft.2024.12.03.-.03.39.23.01.-.edit.mp4

@XFactHD XFactHD self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Development

No branches or pull requests

2 participants