[1.21.4] Revert Registries to Frozen on Disconnect when a connection is present #1934
+11
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 2ea2e0c22efea2a89dbaddc0ad20661f8a05a4ae. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1934' // https://github.com/neoforged/NeoForge/pull/1934
url 'https://prmaven.neoforged.net/NeoForge/pr1934'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
}MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1934
cd NeoForge-pr1934
curl -L https://prmaven.neoforged.net/NeoForge/pr1934/net/neoforged/neoforge/21.4.82-beta-pr-1934-fix-i1932/mdk-pr1934.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zipTo test a production environment, you can download the installer from here. |
embeddedt
reviewed
Feb 2, 2025
embeddedt
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1932
Moves the call to
RegistryManager#revertToFrozentoMinecraft#disconnectto handle every case of the vanilla client disconnecting from some server instance. As we don't want to revert the registries until after all potential usecases are handled, the logic is cached before the connection is released and ran at the end of the method. There is no need to include the memory connection check as this is called regardless of the type of channel used, as evidenced by its prior use inServerLifecycleHooks#handleServerStopped.The test provided in the issue was used to verify the logic.