Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.4] Reimplement EntityRenderersEvent.CreateSkullModels #1936

Open
wants to merge 4 commits into
base: 1.21.x
Choose a base branch
from
Open

[1.21.4] Reimplement EntityRenderersEvent.CreateSkullModels #1936

wants to merge 4 commits into from
+84 −27

Conversation

ChampionAsh5357
Copy link
Contributor

Closes #1935

Reimplements the hook to EntityRenderersEvent.CreateSkullModels. The initialization of the event has been moved to just after registering layer definitions as the hook is now a function instead of a map. CustomHeadTest was also updated so that the reimplemented event can be properly tested.

@ChampionAsh5357 ChampionAsh5357 added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore breaking change Breaks binary compatibility 1.21.4 Targeted at Minecraft 1.21.4 labels Feb 3, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Feb 3, 2025 •
edited
Loading

  • Publish PR to GitHub Packages

Last commit published: 2a357ae583055d8c41fe908d01d25001503bff9c.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1936' // https://github.com/neoforged/NeoForge/pull/1936
        url 'https://prmaven.neoforged.net/NeoForge/pr1936'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1936.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1936
cd NeoForge-pr1936
curl -L https://prmaven.neoforged.net/NeoForge/pr1936/net/neoforged/neoforge/21.4.85-beta-pr-1936-fix-i1935/mdk-pr1936.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Feb 3, 2025 •
edited
Loading

@ChampionAsh5357, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 2a357ae583055d8c41fe908d01d25001503bff9c.

neoforge (:neoforge)

  • net/neoforged/neoforge/client/event/EntityRenderersEvent$CreateSkullModels
    • <init>(Lcom/google/common/collect/ImmutableMap$Builder;Lnet/minecraft/client/model/geom/EntityModelSet;)V: ⚠ API method was removed
    • getEntityModelSet()Lnet/minecraft/client/model/geom/EntityModelSet;: ❗ API method was removed
    • registerSkullModel(Lnet/minecraft/world/level/block/SkullBlock$Type;Lnet/minecraft/client/model/SkullModelBase;)V: ❗ API method was removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XFactHD XFactHD Awaiting requested review from XFactHD

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
1.21.4 Targeted at Minecraft 1.21.4 breaking change Breaks binary compatibility bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.21.4] EntityRenderersEvent$CreateSkullModels no longer seems to be called
2 participants
@ChampionAsh5357 @XFactHD