Check if main render target is initialized before resizing it #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user resizes the window after the early display has handed off to Minecraft, but prior to Minecraft finishing initialization of the renderer, a crash can occur due to the render target not yet being present.
|
|
|
shartte
approved these changes
Feb 7, 2025
embeddedt
approved these changes
Feb 8, 2025
|
🚀 This PR has been released as NeoForge version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user resizes the window after the early display has handed off to Minecraft, but prior to Minecraft finishing initialization of the renderer, a crash can occur due to the render target not yet being present. The crash can occasionally be reproduced by continuously resizing the window during startup.
This patch fixes the problem by checking if the main render target is initialized before trying to resize it.