Fix iterating over relationship data generator when generator is empty #252 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #252
|
Closing this - it's still required, but ultimately it looks like this package is no longer maintained. Someone can reopen if that situation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the issue, if relationship data was an empty generator, an error would be triggered as the generator was iterated over twice when including related resources.
This is because the cache in
RelationshipDataIsCollectionwas not being set to an empty array.This PR adds two tests: one for a non-empty generator, and another for an empty generator. The empty generator test was failing before the single line fix was put into
RelationshipDataIsCollection.Closes #252