FEATURE: Introduce RoleId and RoleIds value objects
#3415
+202
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsunet
reviewed
Nov 12, 2024
| $this->name = $matches[2]; | ||
| $this->label = $label ?: $matches[2]; | ||
| $this->id = RoleId::fromString($identifier); | ||
| $this->label = $label ?: $this->id->getName(); | ||
| $this->description = $description; | ||
| $this->parentRoles = $parentRoles; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| public static function fromRoleId(RoleId $id, array $parentRoles = [], string $label = '', string $description = ''): self | |
| { | |
| return new ($id->value, array $parentRoles = [], string $label = '', string $description = ''); | |
| } | |
| public static function fromIdentifierString(string $identifier, array $parentRoles = [], string $label = '', string $description = ''): self | |
| { | |
| return new ($identifier, array $parentRoles = [], string $label = '', string $description = ''); | |
| } |
And then deprecate the __construct as it is so we can at least open a window for refactoring internally?
There was a problem hiding this comment.
@kitsunet mh, Role::fromRoleId() and Role::fromIdentifierString() sounds wrong to me.. But what do you think of
public function __construct(RoleId|string $id, array $parentRoles = [], string $label = '', string $description = '') {
if (is_string($id)) {
$id = RoleId::fromString($id);
}
// ...
}There was a problem hiding this comment.
Sure, sounds good! My thought train was not finished really. I was thinking / hoping how we can refactor towards something like RoleIds $parentRoles or somthing, but the static constructors would not necessarily make that easier :D
kitsunet
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3414