From 2b4021a32068b8eb822835a641cc0833cfa08edc Mon Sep 17 00:00:00 2001 From: marvim Date: Thu, 7 Dec 2023 02:02:07 +0000 Subject: [PATCH] Backup update --- last_update | 2 +- repositories/neovim/issues/11620.json | 12 +- repositories/neovim/issues/1248.json | 19 +- repositories/neovim/issues/19354.json | 1270 ++++++++++++++ repositories/neovim/issues/20451.json | 4 +- repositories/neovim/issues/20757.json | 258 +++ repositories/neovim/issues/21342.json | 12 +- repositories/neovim/issues/23528.json | 178 ++ repositories/neovim/issues/24100.json | 170 ++ repositories/neovim/issues/25844.json | 50 +- repositories/neovim/issues/26372.json | 62 +- repositories/neovim/issues/26388.json | 60 +- repositories/neovim/issues/26408.json | 48 +- repositories/neovim/issues/26409.json | 12 +- repositories/neovim/issues/26419.json | 116 ++ repositories/neovim/issues/26422.json | 715 ++++++++ repositories/neovim/issues/26424.json | 214 +++ repositories/neovim/issues/26425.json | 134 ++ repositories/neovim/issues/26427.json | 125 ++ repositories/neovim/issues/26428.json | 424 +++++ repositories/neovim/issues/26432.json | 214 +++ repositories/neovim/issues/3344.json | 56 +- repositories/neovim/issues/4454.json | 460 +++++ repositories/neovim/issues/5052.json | 942 ++++++++++ repositories/neovim/issues/6875.json | 120 +- repositories/neovim/issues/7225.json | 293 ++++ repositories/neovim/issues/7769.json | 377 ++++ repositories/neovim/issues/9800.json | 628 +++++++ repositories/neovim/pulls/21370.json | 26 +- repositories/neovim/pulls/22649.json | 407 +++++ repositories/neovim/pulls/25154.json | 18 +- repositories/neovim/pulls/25289.json | 36 +- repositories/neovim/pulls/25461.json | 282 ++- repositories/neovim/pulls/25564.json | 385 ++++- repositories/neovim/pulls/25599.json | 26 +- repositories/neovim/pulls/25990.json | 26 +- repositories/neovim/pulls/26198.json | 76 +- repositories/neovim/pulls/26381.json | 224 ++- repositories/neovim/pulls/26384.json | 368 +++- repositories/neovim/pulls/26390.json | 189 +- repositories/neovim/pulls/26398.json | 387 ++++- repositories/neovim/pulls/26401.json | 28 +- repositories/neovim/pulls/26403.json | 136 +- repositories/neovim/pulls/26404.json | 70 +- repositories/neovim/pulls/26406.json | 1618 +++++++++++++++++- repositories/neovim/pulls/26407.json | 379 +++- repositories/neovim/pulls/26410.json | 736 +++++++- repositories/neovim/pulls/26415.json | 36 +- repositories/neovim/pulls/26416.json | 431 +++++ repositories/neovim/pulls/26417.json | 371 ++++ repositories/neovim/pulls/26418.json | 362 ++++ repositories/neovim/pulls/26420.json | 362 ++++ repositories/neovim/pulls/26421.json | 388 +++++ repositories/neovim/pulls/26423.json | 362 ++++ repositories/neovim/pulls/26426.json | 407 +++++ repositories/neovim/pulls/26429.json | 412 +++++ repositories/neovim/pulls/26430.json | 834 +++++++++ repositories/neovim/pulls/26431.json | 380 ++++ repositories/neovim/pulls/26434.json | 371 ++++ repositories/neovim/pulls/26435.json | 371 ++++ repositories/neovim/pulls/26436.json | 412 +++++ repositories/neovim/pulls/26437.json | 362 ++++ repositories/neovim/pulls/26438.json | 362 ++++ repositories/nvim-lspconfig/issues/1220.json | 248 +++ repositories/nvim-lspconfig/issues/2765.json | 48 +- repositories/nvim-lspconfig/pulls/2923.json | 32 +- repositories/nvim-lspconfig/pulls/2924.json | 373 ++++ repositories/pynvim/pulls/544.json | 34 +- 68 files changed, 18654 insertions(+), 696 deletions(-) create mode 100644 repositories/neovim/issues/19354.json create mode 100644 repositories/neovim/issues/20757.json create mode 100644 repositories/neovim/issues/23528.json create mode 100644 repositories/neovim/issues/24100.json create mode 100644 repositories/neovim/issues/26419.json create mode 100644 repositories/neovim/issues/26422.json create mode 100644 repositories/neovim/issues/26424.json create mode 100644 repositories/neovim/issues/26425.json create mode 100644 repositories/neovim/issues/26427.json create mode 100644 repositories/neovim/issues/26428.json create mode 100644 repositories/neovim/issues/26432.json create mode 100644 repositories/neovim/issues/4454.json create mode 100644 repositories/neovim/issues/5052.json create mode 100644 repositories/neovim/issues/7225.json create mode 100644 repositories/neovim/issues/7769.json create mode 100644 repositories/neovim/issues/9800.json create mode 100644 repositories/neovim/pulls/22649.json create mode 100644 repositories/neovim/pulls/26416.json create mode 100644 repositories/neovim/pulls/26417.json create mode 100644 repositories/neovim/pulls/26418.json create mode 100644 repositories/neovim/pulls/26420.json create mode 100644 repositories/neovim/pulls/26421.json create mode 100644 repositories/neovim/pulls/26423.json create mode 100644 repositories/neovim/pulls/26426.json create mode 100644 repositories/neovim/pulls/26429.json create mode 100644 repositories/neovim/pulls/26430.json create mode 100644 repositories/neovim/pulls/26431.json create mode 100644 repositories/neovim/pulls/26434.json create mode 100644 repositories/neovim/pulls/26435.json create mode 100644 repositories/neovim/pulls/26436.json create mode 100644 repositories/neovim/pulls/26437.json create mode 100644 repositories/neovim/pulls/26438.json create mode 100644 repositories/nvim-lspconfig/issues/1220.json create mode 100644 repositories/nvim-lspconfig/pulls/2924.json diff --git a/last_update b/last_update index ca41cdfd..37fba198 100644 --- a/last_update +++ b/last_update @@ -1 +1 @@ -2023-12-06T01:25:21Z \ No newline at end of file +2023-12-07T01:52:10Z \ No newline at end of file diff --git a/repositories/neovim/issues/11620.json b/repositories/neovim/issues/11620.json index 1e022a8b..a7a50dc5 100644 --- a/repositories/neovim/issues/11620.json +++ b/repositories/neovim/issues/11620.json @@ -8,7 +8,7 @@ "comment_data": [ { "author_association": "CONTRIBUTOR", - "body": "Here is a proof of concept: https://asciinema.org/a/IK0MXFdcePbxIRJMK9Q9sTM43\r\n\r\nI didn't open a PR because this implementation https://github.com/neovim/neovim/commit/3cd9b5c66245ff4954772fc3ab7e7c68347babad has some problems. It saves `old_redobuff` when `ResetRedobuff()` gets called, which is when the recording for `.` begins. Because of this, the history doesn't contain the last two edits, so I had to add them manually when the `dot_hist()` function gets called from the demo.\r\n\r\nTo make it work with the `q:` and `q/` history mechanism, we would need to call [add_to_history](https://github.com/neovim/neovim/blob/bcaff309b6073b66635bd51d6fbd6900f4baba1d/src/nvim/cmdhist.c#L296) from `cmdhist.c` to add edits to the history. \r\nSo we need to know when the recording for a motion/operator stops and add it to the history then, but I'm too new to the code base to know if there is a way to tell when a motion or edit ends, or if it isn't, how to implement it.\r\n", + "body": "Here is a proof of concept: https://asciinema.org/a/IK0MXFdcePbxIRJMK9Q9sTM43\r\n\r\nI didn't open a PR because this implementation https://github.com/neovim/neovim/commit/3cd9b5c66245ff4954772fc3ab7e7c68347babad has some problems. It saves `old_redobuff` when `ResetRedobuff()` gets called, which is when the recording for `.` begins. Because of this, the history doesn't contain the last two edits, so I had to add them manually when the `dot_hist()` function gets called from the demo.\r\n\r\nTo make it work with the `q:` and `q/` history mechanism, we would need to call [add_to_history](https://github.com/neovim/neovim/blob/bcaff309b6073b66635bd51d6fbd6900f4baba1d/src/nvim/cmdhist.c#L296) from `cmdhist.c` to add edits to the history. \r\nSo we need to know when the recording for a motion/operator stops and add it to the history then, but I'm too new to the code base to know if there is a way to tell when a motion or edit ends, and if it isn't, how to implement it.\r\n", "created_at": "2023-11-28T20:08:12Z", "html_url": "https://github.com/neovim/neovim/issues/11620#issuecomment-1830641359", "id": 1830641359, @@ -27,7 +27,7 @@ "total_count": 0, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1830641359/reactions" }, - "updated_at": "2023-11-28T20:13:48Z", + "updated_at": "2023-12-06T11:31:41Z", "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1830641359", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/20646330?v=4", @@ -90,7 +90,7 @@ "locked": false, "milestone": { "closed_at": null, - "closed_issues": 590, + "closed_issues": 592, "created_at": "2014-05-10T20:43:04Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", @@ -119,10 +119,10 @@ "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", "number": 6, - "open_issues": 424, + "open_issues": 427, "state": "open", "title": "backlog", - "updated_at": "2023-11-30T01:41:47Z", + "updated_at": "2023-12-06T23:16:41Z", "url": "https://api.github.com/repos/neovim/neovim/milestones/6" }, "node_id": "MDU6SXNzdWU1NDI2NTg0Njc=", @@ -145,7 +145,7 @@ "state_reason": null, "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/11620/timeline", "title": "\"q.\" command (history of dot-repeatable actions)", - "updated_at": "2023-11-29T16:26:04Z", + "updated_at": "2023-12-06T11:31:41Z", "url": "https://api.github.com/repos/neovim/neovim/issues/11620", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/19694718?v=4", diff --git a/repositories/neovim/issues/1248.json b/repositories/neovim/issues/1248.json index deca2443..6598a295 100644 --- a/repositories/neovim/issues/1248.json +++ b/repositories/neovim/issues/1248.json @@ -243,10 +243,19 @@ "node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==", "url": "https://api.github.com/repos/neovim/neovim/labels/enhancement" }, + { + "color": "c5def5", + "default": false, + "description": "issues or PRs involving changing the defaults", + "id": 103777064, + "name": "defaults", + "node_id": "MDU6TGFiZWwxMDM3NzcwNjQ=", + "url": "https://api.github.com/repos/neovim/neovim/labels/defaults" + }, { "color": "BFDADC", "default": false, - "description": "Low-risk, unlikely to cause distant/indirect damage", + "description": "Low-risk. Do NOT ask \"can I work on this\", just read CONTRIBUTING.md", "id": 407246773, "name": "complexity:low", "node_id": "MDU6TGFiZWw0MDcyNDY3NzM=", @@ -275,7 +284,7 @@ "locked": false, "milestone": { "closed_at": null, - "closed_issues": 588, + "closed_issues": 592, "created_at": "2014-05-10T20:43:04Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", @@ -304,10 +313,10 @@ "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", "number": 6, - "open_issues": 411, + "open_issues": 427, "state": "open", "title": "backlog", - "updated_at": "2023-10-21T13:52:49Z", + "updated_at": "2023-12-06T23:16:41Z", "url": "https://api.github.com/repos/neovim/neovim/milestones/6" }, "node_id": "MDU6SXNzdWU0NDExOTY5Mw==", @@ -330,7 +339,7 @@ "state_reason": null, "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/1248/timeline", "title": "implement default titlestring using statusline", - "updated_at": "2023-10-22T09:50:47Z", + "updated_at": "2023-12-06T19:42:31Z", "url": "https://api.github.com/repos/neovim/neovim/issues/1248", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/7495?v=4", diff --git a/repositories/neovim/issues/19354.json b/repositories/neovim/issues/19354.json new file mode 100644 index 00000000..1e04fba5 --- /dev/null +++ b/repositories/neovim/issues/19354.json @@ -0,0 +1,1270 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "body": "previous: #6289 \r\n\r\n### Feature description\r\n\r\nA few more proposals for defaults:\r\n\r\n- [ ] 'shada' oldfiles exclude https://github.com/neovim/neovim/issues/21637\r\n- [ ] change eob fillchar to middle-dot instead of tilde \"~\" https://github.com/neovim/neovim/issues/21694\r\n- [X] `nnoremap & &&`\r\n - **Rationale**: The `&` key repeats the last `:s` command, but does not re-use the flags of the last command. Meaning if you last ran `:s/foo/bar/g` to replace all instances of `foo` in a line with `bar`, then move your cursor to a different line and press `&`, it will still only replace the first instance of `foo` with `bar`. The `:&&` ex command *does* re-use the flags, but is relatively more cumbersome (four key presses rather than one). The latter is much more useful and a more common operation. To regain the original behavior, users can still use the `:&` ex command.\r\n - **Status**: Done #19365 \r\n- 🚫 ~~Swap `p` and `P` in visual mode (`xnoremap p P | xnoremap P p`)~~\r\n - **Rationale**: The fact that \"pasting\" in visual mode clobbers the yanked contents is a common footgun in Vim. The `P` key was added to avoid this: it preserves the contents of the unnamed register so that you can use `P` repeatedly to \"paste\" the same contents. This behavior is more intuitive and commonplace in other editing environments, so let's make it the default for `p`. If a user wants the original behavior, they can use `P` (or unmap the defaults).\r\n - **Status**: There are a number of good arguments against this; see [here](https://github.com/neovim/neovim/issues/19354#issuecomment-1184425231) and [here](https://github.com/neovim/neovim/issues/19354#issuecomment-1188301778).\r\n- [ ] Map `gs` to `:sort`\r\n - **Rationale**: The default `gs` mapping is so utterly useless it almost seems like a joke. Instead, make `gs` an operator in normal mode that sorts the given range (in visual mode, make it sort the selection). I currently use this:\r\n ```vim\r\n function! Sort(...) abort\r\n '[,']sort\r\n call setpos('.', getpos(\"''\"))\r\n endfunction\r\n nnoremap gs m'set operatorfunc=Sortg@\r\n xnoremap gs :sort\r\n ```\r\n - **Status**: Make `gs` some kind of \"substitute\" operator for consistency with the default `s` mapping. Example: `xnoremap gs mr:s/\\%V` (and an equivalent operator in normal mode)\r\n- [ ] 'title' and 'titlestring' ? https://github.com/neovim/neovim/issues/1248\r\n- [x] `shortmess+=C` #23907\r\n- [ ] `smoothscroll` #23939\r\n- [x] `termguicolors` #26407 ", + "closed_at": null, + "comment_data": [ + { + "author_association": "MEMBER", + "body": "> `nnoremap & &&`\r\n\r\n👍 \r\nref: https://github.com/tpope/vim-sensible/commit/e48a40534c132e6dd88176b666a8b1ff7bcf3800\r\n\r\n> Swap `p` and `P` in visual mode (`xnoremap p P | xnoremap P p`)\r\n\r\nidk about this, feels like entropy. `P` is, thankfully, available by default now and pretty easy to use. Swapping p/P could feel like randomization, hard to remember.\r\n\r\n\r\n> Map `gs` to `:sort` ... The default `gs` mapping is so utterly useless\r\n\r\nMapping `gs` to some sort of useful operator is a good idea. But not sure about \"sort\", I find that `{visual}:sort` works well when I need it. What about a \"subsitute\" mapping? Currently I have `xnoremap gs mr:s/\\%V` in my config, have wanted to make a normal-mode operator too, idk if this is useful enough though.", + "created_at": "2022-07-14T08:06:48Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184131746", + "id": 1184131746, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GlGqi", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184131746/reactions" + }, + "updated_at": "2022-07-14T08:09:59Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184131746", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "MEMBER", + "body": "> Swap p and P in visual mode (xnoremap p P | xnoremap P p)\r\n\r\nI'm in favour of this. I **always** forget `P` even exists and end up using `p` which disrupts my workflow. I would bet a majority of users are the same.\r\n\r\n> Mapping gs to some sort of useful operator is a good idea. But not sure about \"sort\", I find that {visual}:sort works well when I need it. What about a \"subsitute\" mapping? Currently I have xnoremap gs mr:s/\\%V in my config, have wanted to make a normal-mode operator too, idk if this is useful enough though.\r\n@justinmk\r\n\r\nMapping to 'substitute' makes much more sense given how `s` and `S` are already substitute mappings. I currently have `nnoremap s :%s/\\<\\>\\C//g` for substituting the word under the cursor (**which I use all the time**), but something more general would be preferable.\r\n\r\nAnother option would be to just unmap it entirely, as I bet more people hit this by accident than on purpose.\r\n\r\n", + "created_at": "2022-07-14T08:50:45Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184176716", + "id": 1184176716, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GlRpM", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184176716/reactions" + }, + "updated_at": "2022-07-14T08:50:45Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184176716", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "author_association": "MEMBER", + "body": "I'm quite fond of my sort mapping (I use `gsip` to sort `#include`s in C files all the time), but as long as we can agree on *something*, I'd be happy. The substitute mapping could be made an operator too, of course.\r\n\r\nRe: the `p`/`P` swap, I think the biggest argument against it is that for better or worse `p` has been around in Vim for so long that a lot of people have just gotten used to it, and changing it now might be disruptive. I'm still in favor of changing it though, because I think `P` as the default behavior is much more sane. In ~10 years of using Vim as my primary editor, I don't think I have ever intentionally used the fact that `p` replaces the unnamed register. It's always been something I've lived with or worked around. Granted I'm a sample size of one, but I wouldn't be surprised if many others feel the same.", + "created_at": "2022-07-14T12:55:32Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184414729", + "id": 1184414729, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GmLwJ", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184414729/reactions" + }, + "updated_at": "2022-07-14T12:55:32Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184414729", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } + }, + { + "author_association": "MEMBER", + "body": "> In ~10 years of using Vim as my primary editor, I don't think I have ever intentionally used the fact that `p` replaces the unnamed register\r\n\r\nIt's commonly used as a poor man's \"swap\". I use it when stuck on a machine without my config. The behavior of `P` is definitely a better default, but `P` is quite easy to use, so the churn of swapping p/P is hard to justify. But we could try it, maybe I'm wrong...", + "created_at": "2022-07-14T13:06:00Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184425231", + "id": 1184425231, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GmOUP", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184425231/reactions" + }, + "updated_at": "2022-07-14T14:31:02Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184425231", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "NONE", + "body": "> I'm quite fond of my sort mapping (I use `gsip` to sort `#include`s in C files all the time), but as long as we can agree on _something_, I'd be happy. The substitute mapping could be made an operator too, of course.\r\n\r\nFor a contrasting perspective, I think quite a lot of folks use `gs` already as some kind of sort operator. For example, I've had [vim-sort-motion](https://github.com/christoomey/vim-sort-motion) in my `init.lua` (and before that, `~/.vimrc`), as I sort *all the time*, and it uses `gs` by default. That plugin is popular, although not quite as popular as it used to be (it's very much Vim-era). It would wonderful to have a built-in way to do this, and kill the plugin, for simple sorting usecases.", + "created_at": "2022-07-14T14:17:21Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184504569", + "id": 1184504569, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5Gmhr5", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184504569/reactions" + }, + "updated_at": "2022-07-14T14:17:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184504569", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/107015?v=4", + "events_url": "https://api.github.com/users/andrewferrier/events{/privacy}", + "followers_url": "https://api.github.com/users/andrewferrier/followers", + "following_url": "https://api.github.com/users/andrewferrier/following{/other_user}", + "gists_url": "https://api.github.com/users/andrewferrier/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/andrewferrier", + "id": 107015, + "login": "andrewferrier", + "node_id": "MDQ6VXNlcjEwNzAxNQ==", + "organizations_url": "https://api.github.com/users/andrewferrier/orgs", + "received_events_url": "https://api.github.com/users/andrewferrier/received_events", + "repos_url": "https://api.github.com/users/andrewferrier/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/andrewferrier/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/andrewferrier/subscriptions", + "type": "User", + "url": "https://api.github.com/users/andrewferrier" + } + }, + { + "author_association": "MEMBER", + "body": "What's all this sorting for? Doesn't `{visual}:sort` get you 98% of the way there? Are you dot-repeating these sort operations?? Organizing imports is more of an LSP or treesitter task, which implies the value of a sort operation has limited shelf-life as those mature.\r\n\r\nIt sounds more like we want a `g:` operator that allows any `:` command to be invoked as a dot-repeatable operation. Then one could do `g:{motion}sort`. \r\n\r\n", + "created_at": "2022-07-14T14:24:19Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184512413", + "id": 1184512413, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5Gmjmd", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184512413/reactions" + }, + "updated_at": "2022-07-14T14:32:00Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184512413", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "MEMBER", + "body": "Most `g` mappings are alternatives to the non-`g` mappings, or, as some form of goto mapping. E.g:\r\n\r\n- `j`/`k` and `gj`/`gk`\r\n- `*`/`#` and `g*`/`g#`\r\n- `^`/`$` and `g^`/`g$`\r\n- `n`/`N` and `gn`/`gN`\r\n- `e`/`E` and `ge`/`gE`\r\n- `i`/`I` and `gi`/`gI`\r\n- `p`/`P` and `gp`/`gP`\r\n- `~` and `g~`\r\n- `r` and `gr`\r\n- `R` and `gR`\r\n- `J` and `gJ`\r\n- `%` and `g%`\r\n- `gd`/`gD`: goto declaration\r\n- `gg`: goto line\r\n- `gf`/`gF`: goto file\r\n- `g'`/```g` ```: goto mark\r\n- `g,`/`g;`: goto newer/older posiiton in change list\r\n- `gt`/`gT`: goto tab\r\n\r\nCurrent exceptions to this rule:\r\n\r\n- `gu`/`gU`\r\n- `g?`\r\n- `gq`\r\n- `g@`\r\n- `ga` (this should be another candidate for changing)\r\n- `gO`\r\n- `gQ` (I **hate** this one)\r\n- `gh`/`gH`\r\n- `gV`\r\n- `gv` (though this relates to visual selection)\r\n\r\nI think if we want to map `gs` to anything, it should relate to `s` in some way, otherwise it would be best to unmap it and let user continue to map it to what they want.", + "created_at": "2022-07-14T14:28:04Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184516821", + "id": 1184516821, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GmkrV", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184516821/reactions" + }, + "updated_at": "2022-07-14T14:46:01Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184516821", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "author_association": "MEMBER", + "body": "Also exception: `gq` -- which _would_ be a precedent for `gs` as proposed here.", + "created_at": "2022-07-14T14:29:55Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184519030", + "id": 1184519030, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GmlN2", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184519030/reactions" + }, + "updated_at": "2022-07-14T14:29:55Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184519030", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "NONE", + "body": "> What's all this sorting for? Doesn't `{visual}:sort` get you 98% of the way there? Are you dot-repeating these sort operations??\r\n\r\nIn many cases, yes :) Besides, `gsip` is a bit nimbler than `vip:sort`. Visual mode is always a second-class citizen to a well-defined operator IMHO.\r\n\r\n> It sounds more like we want a `g:` operator that allows any `:` command to be invoked as a dot-repeatable operation. Then one could do `g:{motion}sort`.\r\n\r\nThat would definitely be really interesting (EDIT: Actually, super-cool, now I think about it!)\r\n\r\n> Saving the trouble of typing out \"sort\" is rather low-value for such a nice mapping as `gs`. Organizing imports is more of an LSP or treesitter task, which implies the value of a sort operation has near-term shelf-life as those mature.\r\n\r\nPerhaps. That's very far from the only reason for sorting lists (for example, for many non-programming usecases I like to sort lists in Markdown), but point taken.\r\n\r\nI don't have a super-strong opinion about this. After all, these are only defaults, and I can always remap myself. Just giving you a view from someone who's been using Vim a while and has his fingers hardcoded to `gs` meaning sort ;)", + "created_at": "2022-07-14T14:33:10Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184522774", + "id": 1184522774, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GmmIW", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184522774/reactions" + }, + "updated_at": "2022-07-14T14:43:34Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184522774", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/107015?v=4", + "events_url": "https://api.github.com/users/andrewferrier/events{/privacy}", + "followers_url": "https://api.github.com/users/andrewferrier/followers", + "following_url": "https://api.github.com/users/andrewferrier/following{/other_user}", + "gists_url": "https://api.github.com/users/andrewferrier/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/andrewferrier", + "id": 107015, + "login": "andrewferrier", + "node_id": "MDQ6VXNlcjEwNzAxNQ==", + "organizations_url": "https://api.github.com/users/andrewferrier/orgs", + "received_events_url": "https://api.github.com/users/andrewferrier/received_events", + "repos_url": "https://api.github.com/users/andrewferrier/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/andrewferrier/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/andrewferrier/subscriptions", + "type": "User", + "url": "https://api.github.com/users/andrewferrier" + } + }, + { + "author_association": "NONE", + "body": "> Also exception: `gq` -- which _would_ be a precedent for `gs` as proposed here.\r\n\r\nAlso, `ga`, and `gf`, and `gF`, and `gt` ;)", + "created_at": "2022-07-14T14:34:56Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1184524751", + "id": 1184524751, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GmmnP", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184524751/reactions" + }, + "updated_at": "2022-07-14T14:34:56Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1184524751", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/107015?v=4", + "events_url": "https://api.github.com/users/andrewferrier/events{/privacy}", + "followers_url": "https://api.github.com/users/andrewferrier/followers", + "following_url": "https://api.github.com/users/andrewferrier/following{/other_user}", + "gists_url": "https://api.github.com/users/andrewferrier/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/andrewferrier", + "id": 107015, + "login": "andrewferrier", + "node_id": "MDQ6VXNlcjEwNzAxNQ==", + "organizations_url": "https://api.github.com/users/andrewferrier/orgs", + "received_events_url": "https://api.github.com/users/andrewferrier/received_events", + "repos_url": "https://api.github.com/users/andrewferrier/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/andrewferrier/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/andrewferrier/subscriptions", + "type": "User", + "url": "https://api.github.com/users/andrewferrier" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "How about making the following settings the defaults?\r\n\r\n```\r\nvim.o.ignorecase = true\r\nvim.o.smartcase = true\r\n```\r\nIt seems that [kickstart.nvim](https://github.com/nvim-lua/kickstart.nvim) and many others are also set, and other editors seem to be able to search case-insensitively by default.\r\nAre there any disadvantages to setting?", + "created_at": "2022-07-15T02:23:29Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1185101745", + "id": 1185101745, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5Gozex", + "performed_via_github_app": null, + "reactions": { + "+1": 3, + "-1": 1, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 4, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1185101745/reactions" + }, + "updated_at": "2022-07-15T02:29:04Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1185101745", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/42740055?v=4", + "events_url": "https://api.github.com/users/yamatsum/events{/privacy}", + "followers_url": "https://api.github.com/users/yamatsum/followers", + "following_url": "https://api.github.com/users/yamatsum/following{/other_user}", + "gists_url": "https://api.github.com/users/yamatsum/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/yamatsum", + "id": 42740055, + "login": "yamatsum", + "node_id": "MDQ6VXNlcjQyNzQwMDU1", + "organizations_url": "https://api.github.com/users/yamatsum/orgs", + "received_events_url": "https://api.github.com/users/yamatsum/received_events", + "repos_url": "https://api.github.com/users/yamatsum/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/yamatsum/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/yamatsum/subscriptions", + "type": "User", + "url": "https://api.github.com/users/yamatsum" + } + }, + { + "author_association": "MEMBER", + "body": "'ignorecase' discussed in https://github.com/tpope/vim-sensible/issues/132 . Doesn't seem like a clear win, will need a lot of discussion.\r\n\r\nI just noticed that 'title' and 'titlestring' are not set by default, maybe it's time to set those https://github.com/neovim/neovim/issues/1248 ", + "created_at": "2022-07-15T12:22:12Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1185492221", + "id": 1185492221, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5GqSz9", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1185492221/reactions" + }, + "updated_at": "2022-07-15T12:22:12Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1185492221", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "MEMBER", + "body": "If one wants to use replace whole lines with same lines multiple times, they'll use `V` to select the lines to replace, and in this case `P` is better.", + "created_at": "2022-07-16T13:05:19Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1186180165", + "id": 1186180165, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5Gs6xF", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1186180165/reactions" + }, + "updated_at": "2022-07-16T13:05:19Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1186180165", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "I didn't know about this way of using `p` in Visual mode, and actually it solves a long-standing problem for me, namely having a poor-man's swap, as @justinmk put it. So I am excited about using `p` this way (as it works by default).\r\n\r\nI just tried the Vim emulation plugins in VS Code and the JetBrains suite, and they both implement Visual-mode `p` \"correctly\", as in, they match the current Vim/Neovim behavior. (Interestingly, as long as we're talking about consistency, VSCodeVim uses the equivalent of `:nnoremap Y y$` and IdeaVim does not.) I think consistency in the text-editing DSL layer is a big strength of the Vim ecosystem, so my humble vote is to leave `p` and `P` alone in Visual mode.", + "created_at": "2022-07-18T20:56:32Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1188301778", + "id": 1188301778, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5G1AvS", + "performed_via_github_app": null, + "reactions": { + "+1": 2, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 2, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1188301778/reactions" + }, + "updated_at": "2022-07-18T20:56:32Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1188301778", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/5308024?v=4", + "events_url": "https://api.github.com/users/andmis/events{/privacy}", + "followers_url": "https://api.github.com/users/andmis/followers", + "following_url": "https://api.github.com/users/andmis/following{/other_user}", + "gists_url": "https://api.github.com/users/andmis/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/andmis", + "id": 5308024, + "login": "andmis", + "node_id": "MDQ6VXNlcjUzMDgwMjQ=", + "organizations_url": "https://api.github.com/users/andmis/orgs", + "received_events_url": "https://api.github.com/users/andmis/received_events", + "repos_url": "https://api.github.com/users/andmis/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/andmis/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/andmis/subscriptions", + "type": "User", + "url": "https://api.github.com/users/andmis" + } + }, + { + "author_association": "NONE", + "body": "> nnoremap & &&\r\nRationale: The & key repeats the last :s command, but does not re-use the flags of the last command. Meaning if you last ran :s/foo/bar/g to replace all instances of foo in a line with bar, then move your cursor to a different line and press &, it will still only replace the first instance of foo with bar. The :&& ex command does re-use the flags, but is relatively more cumbersome (four key presses rather than one). The latter is much more useful and a more common operation. To regain the original behavior, users can still use the :& ex command.\r\n\r\nI wonder if it would make sense to have [`gdefault`](https://neovim.io/doc/user/options.html#'gdefault') instead of that, because almost all the time I am using `/g`\r\n", + "created_at": "2022-08-24T07:21:48Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1225302162", + "id": 1225302162, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5JCKCS", + "performed_via_github_app": null, + "reactions": { + "+1": 2, + "-1": 2, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 4, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225302162/reactions" + }, + "updated_at": "2022-08-24T07:23:14Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225302162", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/90276965?v=4", + "events_url": "https://api.github.com/users/ad-chaos/events{/privacy}", + "followers_url": "https://api.github.com/users/ad-chaos/followers", + "following_url": "https://api.github.com/users/ad-chaos/following{/other_user}", + "gists_url": "https://api.github.com/users/ad-chaos/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ad-chaos", + "id": 90276965, + "login": "ad-chaos", + "node_id": "MDQ6VXNlcjkwMjc2OTY1", + "organizations_url": "https://api.github.com/users/ad-chaos/orgs", + "received_events_url": "https://api.github.com/users/ad-chaos/received_events", + "repos_url": "https://api.github.com/users/ad-chaos/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ad-chaos/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ad-chaos/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ad-chaos" + } + }, + { + "author_association": "MEMBER", + "body": "> would make sense to have [`gdefault`](https://neovim.io/doc/user/options.html#'gdefault') instead of that, because almost all the time I am using `/g`\r\n\r\ngdefault was rejected previously:\r\n\r\n- breaks plugins: https://github.com/neovim/neovim/issues/6158#issuecomment-281840229\r\n- breaks plugins: https://github.com/neovim/neovim/issues/5181\r\n- rationale: https://github.com/tpope/vim-sensible/issues/39\r\n > This makes it so if you do use a `/g`, you _don't_ get all matches. Gross, and screws with anyone with muscle memory for the proper way.\r\n\r\n\r\n\r\n", + "created_at": "2022-08-24T09:59:29Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1225499839", + "id": 1225499839, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5JC6S_", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225499839/reactions" + }, + "updated_at": "2022-08-24T11:02:48Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225499839", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "NONE", + "body": "For what its worth, `:Man` looks perfectlly normal to me with `:set gdefault` on `HEAD` with `nvim --clean` and the rationale is muscle memory which is fair, but to me `/g` is two characters too many :) and I am fairly certain new users would love to have `gdefault` since the cases where you substitute without `/g` are too few and far in between.\r\n\r\nI am not sure if it actually breaks plugins, None of my plugins are broken, here's a list of them\r\n
\r\nPlugins\r\n\r\n- wbthomason/packer.nvim\r\n- nvim-lua/popup.nvim\r\n- Mofiqul/dracula.nvim\r\n- folke/tokyonight.nvim\r\n- hrsh7th/nvim-cmp\r\n- hrsh7th/cmp-buffer\r\n- hrsh7th/cmp-path\r\n- hrsh7th/cmp-cmdline\r\n- hrsh7th/cmp-nvim-lsp\r\n- L3MON4D3/LuaSnip\r\n- saadparwaiz1/cmp_luasnip\r\n- nvim-telescope/telescope.nvim\r\n- nvim-telescope/telescope-fzf-native.nvim\r\n- lewis6991/gitsigns.nvim\r\n- neovim/nvim-lspconfig\r\n- nvim-treesitter/nvim-treesitter\r\n- chrisbra/Colorizer\r\n- godlygeek/tabular\r\n- terrortylor/nvim-comment\r\n- lewis6991/spellsitter.nvim\r\n- sbdchd/neoformat\r\n- kylechui/nvim-surround\r\n- nvim-treesitter/playground\r\n\r\nAnd this is excluding the `matchit` and `netrw` which also work perfectly with `gdefault`\r\n\r\n
", + "created_at": "2022-08-24T10:21:39Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1225523477", + "id": 1225523477, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5JDAEV", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225523477/reactions" + }, + "updated_at": "2022-08-24T10:31:59Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225523477", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/90276965?v=4", + "events_url": "https://api.github.com/users/ad-chaos/events{/privacy}", + "followers_url": "https://api.github.com/users/ad-chaos/followers", + "following_url": "https://api.github.com/users/ad-chaos/following{/other_user}", + "gists_url": "https://api.github.com/users/ad-chaos/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ad-chaos", + "id": 90276965, + "login": "ad-chaos", + "node_id": "MDQ6VXNlcjkwMjc2OTY1", + "organizations_url": "https://api.github.com/users/ad-chaos/orgs", + "received_events_url": "https://api.github.com/users/ad-chaos/received_events", + "repos_url": "https://api.github.com/users/ad-chaos/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ad-chaos/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ad-chaos/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ad-chaos" + } + }, + { + "author_association": "MEMBER", + "body": "I see no `tpope` plugins in this list, which makes it of limited relevance to this question...", + "created_at": "2022-08-24T10:24:36Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1225526603", + "id": 1225526603, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5JDA1L", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225526603/reactions" + }, + "updated_at": "2022-08-24T10:24:36Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225526603", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "NONE", + "body": "fair, but the statement was `it breaks plugins` not `it breaks *tim pope* plugins`.", + "created_at": "2022-08-24T10:35:47Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1225538498", + "id": 1225538498, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5JDDvC", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225538498/reactions" + }, + "updated_at": "2022-08-24T10:35:47Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225538498", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/90276965?v=4", + "events_url": "https://api.github.com/users/ad-chaos/events{/privacy}", + "followers_url": "https://api.github.com/users/ad-chaos/followers", + "following_url": "https://api.github.com/users/ad-chaos/following{/other_user}", + "gists_url": "https://api.github.com/users/ad-chaos/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ad-chaos", + "id": 90276965, + "login": "ad-chaos", + "node_id": "MDQ6VXNlcjkwMjc2OTY1", + "organizations_url": "https://api.github.com/users/ad-chaos/orgs", + "received_events_url": "https://api.github.com/users/ad-chaos/received_events", + "repos_url": "https://api.github.com/users/ad-chaos/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ad-chaos/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ad-chaos/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ad-chaos" + } + }, + { + "author_association": "MEMBER", + "body": "Sorry, but for \"it breaks plugins\" to hold true, it suffices to break _some_ plugins. And for various reasons, `tpope` plugins are of prime concern here -- both as the ones most likely to break, and the ones we most care about in this regard.", + "created_at": "2022-08-24T10:37:49Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1225540700", + "id": 1225540700, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5JDERc", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225540700/reactions" + }, + "updated_at": "2022-08-24T10:37:49Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225540700", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "NONE", + "body": "I agree, if that's the case then maybe I am wrong and `set gdefault` is a bad idea to be set by default 👍 ", + "created_at": "2022-08-24T10:40:29Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1225543407", + "id": 1225543407, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5JDE7v", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225543407/reactions" + }, + "updated_at": "2022-08-24T10:40:42Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1225543407", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/90276965?v=4", + "events_url": "https://api.github.com/users/ad-chaos/events{/privacy}", + "followers_url": "https://api.github.com/users/ad-chaos/followers", + "following_url": "https://api.github.com/users/ad-chaos/following{/other_user}", + "gists_url": "https://api.github.com/users/ad-chaos/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ad-chaos", + "id": 90276965, + "login": "ad-chaos", + "node_id": "MDQ6VXNlcjkwMjc2OTY1", + "organizations_url": "https://api.github.com/users/ad-chaos/orgs", + "received_events_url": "https://api.github.com/users/ad-chaos/received_events", + "repos_url": "https://api.github.com/users/ad-chaos/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ad-chaos/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ad-chaos/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ad-chaos" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "> 'ignorecase' discussed in https://github.com/tpope/vim-sensible/issues/132 . Doesn't seem like a clear win, will need a lot of discussion.\r\n\r\n\r\n\r\nignorecase | true | 185 | 81%\r\n-- | -- | -- | --\r\nsmartcase | true | 183 | 81%\r\n\r\nhttps://github.com/neovim/neovim/issues/21342", + "created_at": "2022-12-24T08:00:45Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1364483100", + "id": 1364483100, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5RVFwc", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1364483100/reactions" + }, + "updated_at": "2023-12-06T02:21:39Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1364483100", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/42740055?v=4", + "events_url": "https://api.github.com/users/yamatsum/events{/privacy}", + "followers_url": "https://api.github.com/users/yamatsum/followers", + "following_url": "https://api.github.com/users/yamatsum/following{/other_user}", + "gists_url": "https://api.github.com/users/yamatsum/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/yamatsum", + "id": 42740055, + "login": "yamatsum", + "node_id": "MDQ6VXNlcjQyNzQwMDU1", + "organizations_url": "https://api.github.com/users/yamatsum/orgs", + "received_events_url": "https://api.github.com/users/yamatsum/received_events", + "repos_url": "https://api.github.com/users/yamatsum/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/yamatsum/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/yamatsum/subscriptions", + "type": "User", + "url": "https://api.github.com/users/yamatsum" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "> enabling ignorecase and smartcase violates the principle of least surprise\r\n\r\nhttps://github.com/neovim/neovim/issues/21342#issuecomment-1343240405", + "created_at": "2022-12-24T10:54:00Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1364509089", + "id": 1364509089, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5RVMGh", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1364509089/reactions" + }, + "updated_at": "2022-12-24T10:54:00Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1364509089", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/17800844?v=4", + "events_url": "https://api.github.com/users/ggandor/events{/privacy}", + "followers_url": "https://api.github.com/users/ggandor/followers", + "following_url": "https://api.github.com/users/ggandor/following{/other_user}", + "gists_url": "https://api.github.com/users/ggandor/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ggandor", + "id": 17800844, + "login": "ggandor", + "node_id": "MDQ6VXNlcjE3ODAwODQ0", + "organizations_url": "https://api.github.com/users/ggandor/orgs", + "received_events_url": "https://api.github.com/users/ggandor/received_events", + "repos_url": "https://api.github.com/users/ggandor/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ggandor/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ggandor/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ggandor" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "Sorry for out of nowhere comment, as I had a thought which seems worth sharing.\r\n\r\nThe `gs` mapping seems like an ideal prefix candidate for a possible surround operator (_**if**_ it is decided to be worth adding to core). Like `gsa` - add surrounding, `gsd` - delete surrounding, `gsr` - replace surrounding.\r\n\r\n(Very side note. If using only Lua code for surrounding implementation will be considered enough, I am happy to collaborate, as I have relevant experience)", + "created_at": "2023-01-07T07:49:34Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1374408170", + "id": 1374408170, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5R683q", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1374408170/reactions" + }, + "updated_at": "2023-01-07T07:49:34Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1374408170", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", + "events_url": "https://api.github.com/users/echasnovski/events{/privacy}", + "followers_url": "https://api.github.com/users/echasnovski/followers", + "following_url": "https://api.github.com/users/echasnovski/following{/other_user}", + "gists_url": "https://api.github.com/users/echasnovski/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/echasnovski", + "id": 24854248, + "login": "echasnovski", + "node_id": "MDQ6VXNlcjI0ODU0MjQ4", + "organizations_url": "https://api.github.com/users/echasnovski/orgs", + "received_events_url": "https://api.github.com/users/echasnovski/received_events", + "repos_url": "https://api.github.com/users/echasnovski/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/echasnovski/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/echasnovski/subscriptions", + "type": "User", + "url": "https://api.github.com/users/echasnovski" + } + }, + { + "author_association": "MEMBER", + "body": "why wouldn't vim-surround's `ys`, `ds` be used for surround? moot point though, we aren't going to add a default surround plugin.", + "created_at": "2023-01-07T11:10:05Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1374442018", + "id": 1374442018, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5R7FIi", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1374442018/reactions" + }, + "updated_at": "2023-01-07T11:10:05Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1374442018", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "> why wouldn't vim-surround's `ys`, `ds` be used for surround?\r\n\r\nSome people (quite reasonably) prefer the \"prefix style\" as it is more descriptive (as `ys` is not a \"yank surrounding\" but \"add surrounding\"). So I thought I'd share my thought.\r\n\r\n> moot point though, we aren't going to add a default surround plugin.\r\n\r\nSure, understood. Sorry for the noise.", + "created_at": "2023-01-07T11:15:18Z", + "html_url": "https://github.com/neovim/neovim/issues/19354#issuecomment-1374443424", + "id": 1374443424, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "node_id": "IC_kwDOAPphoM5R7Feg", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1374443424/reactions" + }, + "updated_at": "2023-01-07T11:15:18Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1374443424", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", + "events_url": "https://api.github.com/users/echasnovski/events{/privacy}", + "followers_url": "https://api.github.com/users/echasnovski/followers", + "following_url": "https://api.github.com/users/echasnovski/following{/other_user}", + "gists_url": "https://api.github.com/users/echasnovski/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/echasnovski", + "id": 24854248, + "login": "echasnovski", + "node_id": "MDQ6VXNlcjI0ODU0MjQ4", + "organizations_url": "https://api.github.com/users/echasnovski/orgs", + "received_events_url": "https://api.github.com/users/echasnovski/received_events", + "repos_url": "https://api.github.com/users/echasnovski/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/echasnovski/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/echasnovski/subscriptions", + "type": "User", + "url": "https://api.github.com/users/echasnovski" + } + } + ], + "comments": 26, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/19354/comments", + "created_at": "2022-07-13T15:56:13Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/19354/events", + "html_url": "https://github.com/neovim/neovim/issues/19354", + "id": 1303638463, + "labels": [ + { + "color": "c2e0c6", + "default": true, + "description": "feature request", + "id": 77997476, + "name": "enhancement", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==", + "url": "https://api.github.com/repos/neovim/neovim/labels/enhancement" + }, + { + "color": "c5def5", + "default": false, + "description": "issues or PRs involving changing the defaults", + "id": 103777064, + "name": "defaults", + "node_id": "MDU6TGFiZWwxMDM3NzcwNjQ=", + "url": "https://api.github.com/repos/neovim/neovim/labels/defaults" + }, + { + "color": "FBCA04", + "default": false, + "description": "For PRs that propose significant changes to some part of the architecture or API", + "id": 212680983, + "name": "needs:discussion", + "node_id": "MDU6TGFiZWwyMTI2ODA5ODM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/needs:discussion" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/19354/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 592, + "created_at": "2014-05-10T20:43:04Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "Low priority. Not planned for the current target, may be reassigned.", + "due_on": null, + "html_url": "https://github.com/neovim/neovim/milestone/6", + "id": 655037, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", + "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", + "number": 6, + "open_issues": 427, + "state": "open", + "title": "backlog", + "updated_at": "2023-12-06T23:16:41Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/6" + }, + "node_id": "I_kwDOAPphoM5Ns_G_", + "number": 19354, + "performed_via_github_app": null, + "reactions": { + "+1": 18, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 18, + "url": "https://api.github.com/repos/neovim/neovim/issues/19354/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/19354/timeline", + "title": "defaults, part 3", + "updated_at": "2023-12-06T19:34:57Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/19354", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/20451.json b/repositories/neovim/issues/20451.json index 86019d5e..8c7a4c15 100644 --- a/repositories/neovim/issues/20451.json +++ b/repositories/neovim/issues/20451.json @@ -3,7 +3,7 @@ "assignee": null, "assignees": [], "author_association": "MEMBER", - "body": "_This post lists the conditions for declaring Nvim `v1.0`. This is not a roadmap; the project roadmap is here: https://neovim.io/roadmap/_\r\n\r\n# What is the plan for 1.0?\r\n\r\nStick to 0.x until the following conditions:\r\n\r\n1. we have a full picture of what the RPC API and Lua APIs look like, this means conventions for:\r\n - function signatures (all RPC functions should have `opt` param and return a `Dict` to ensure ability to augment them without breaking back-compat)\r\n - naming conventions, `:help dev-api` `:help dev-lua`\r\n - https://github.com/neovim/neovim/issues/22287\r\n - https://github.com/neovim/neovim/issues/19624\r\n - https://github.com/neovim/neovim/issues/18585\r\n - https://github.com/neovim/neovim/issues/11311\r\n - https://github.com/neovim/neovim/issues/19918\r\n2. we have made any necessary breaking changes to the \"remote plugin\" concept\r\n3. Deprecated RPC APIs emit warnings in some visible place when used.\r\n4. `:checkhealth` reports use of deprecated RPC and Lua APIs.\r\n5. `:lua foo.` completion should not suggest deprecated things. https://github.com/neovim/neovim/issues/21660\r\n\r\n# 1.0\r\n\r\nRelease 1.0 when we have fully-specified conventions for RPC API and Lua stdlib.\r\n\r\n- During 0.x, and continuing through 1.x, we will aggressively deprecate interfaces. This means:\r\n 1. they will be listed in `:help deprecated`, and\r\n 2. where possible they will be flagged by `vim.deprecate()`.\r\n- No APIs will be removed from the RPC API during 1.x.\r\n\r\n# 2.0\r\n\r\n- REMOVE all deprecated things in the 2.0 release. See also `:help api-contract`.\r\n- Create `nvim_xx` functions that alias all `nvim_xx2` functions.\r\n - Deprecate the existing `nvim_xx2` names.\r\n - Example: `nvim_exec` will alias `nvim_exec2`. `nvim_exec2` will still exist but will be deprecated, and clients using `nvim_exec2` can easily migrate to `nvim_exec`.", + "body": "_This post lists the conditions for declaring Nvim `v1.0`. This is not a roadmap; the project roadmap is here: https://neovim.io/roadmap/_\r\n\r\n# What is the plan for 1.0?\r\n\r\nStick to 0.x until the following conditions:\r\n\r\n1. we have a full picture of what the RPC API and Lua APIs look like, this means conventions for:\r\n - function signatures (all RPC functions should have `opts` param and return a `Dict` to ensure ability to augment them without breaking back-compat)\r\n - naming conventions, `:help dev-api` `:help dev-lua`\r\n - https://github.com/neovim/neovim/issues/22287\r\n - https://github.com/neovim/neovim/issues/19624\r\n - https://github.com/neovim/neovim/issues/18585\r\n - https://github.com/neovim/neovim/issues/11311\r\n - https://github.com/neovim/neovim/issues/19918\r\n2. we have made any necessary breaking changes to the \"remote plugin\" concept\r\n3. Deprecated RPC APIs emit warnings in some visible place when used.\r\n4. `:checkhealth` reports use of deprecated RPC and Lua APIs.\r\n5. `:lua foo.` completion should not suggest deprecated things. https://github.com/neovim/neovim/issues/21660\r\n\r\n# 1.0\r\n\r\nRelease 1.0 when we have fully-specified conventions for RPC API and Lua stdlib.\r\n\r\n- During 0.x, and continuing through 1.x, we will aggressively deprecate interfaces. This means:\r\n 1. they will be listed in `:help deprecated`, and\r\n 2. where possible they will be flagged by `vim.deprecate()`.\r\n- No APIs will be removed from the RPC API during 1.x.\r\n\r\n# 2.0\r\n\r\n- REMOVE all deprecated things in the 2.0 release. See also `:help api-contract`.\r\n- Create `nvim_xx` functions that alias all `nvim_xx2` functions.\r\n - Deprecate the existing `nvim_xx2` names.\r\n - Example: `nvim_exec` will alias `nvim_exec2`. `nvim_exec2` will still exist but will be deprecated, and clients using `nvim_exec2` can easily migrate to `nvim_exec`.", "closed_at": null, "comment_data": [], "comments": 0, @@ -100,7 +100,7 @@ "state_reason": null, "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/20451/timeline", "title": "Path to version 1.0", - "updated_at": "2023-12-04T21:28:49Z", + "updated_at": "2023-12-06T12:47:23Z", "url": "https://api.github.com/repos/neovim/neovim/issues/20451", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", diff --git a/repositories/neovim/issues/20757.json b/repositories/neovim/issues/20757.json new file mode 100644 index 00000000..fa4145fb --- /dev/null +++ b/repositories/neovim/issues/20757.json @@ -0,0 +1,258 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "CONTRIBUTOR", + "body": "### Neovim version (nvim -v)\r\n\r\n0.8.0\r\n\r\n### Vim (not Nvim) behaves the same?\r\n\r\nno\r\n\r\n### Operating system/version\r\n\r\nlinux 5.19.7\r\n\r\n### Terminal name/version\r\n\r\nkitty 0.26.2\r\n\r\n### $TERM environment variable\r\n\r\ntmux-256color\r\n\r\n### Installation\r\n\r\npacman\r\n\r\n### How to reproduce the issue\r\n\r\n```vim\r\nec json_decode('{\"\": \"1\"}')\r\n```\r\n\r\nIn neovim, it return\r\n\r\n```vim\r\n{'_TYPE': [], '_VAL': [['', '1']]}\r\n```\r\n\r\nIn vim, it return\r\n\r\n```vim\r\n{'': '1'}\r\n``` \r\n\r\n### Expected behavior\r\n\r\nSame as vim.\r\n\r\n### Actual behavior\r\n\r\nDifferent from vim.", + "closed_at": "2023-12-06T15:56:05Z", + "comment_data": [ + { + "author_association": "MEMBER", + "body": "Surprisingly it works as intended when used through Lua `vim.call()`:\r\n```vim\r\n:echo v:lua.vim.call('json_decode', '{\"\": \"1\"}')\r\n```", + "created_at": "2022-10-21T05:11:34Z", + "html_url": "https://github.com/neovim/neovim/issues/20757#issuecomment-1286469677", + "id": 1286469677, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/20757", + "node_id": "IC_kwDOAPphoM5Mrfgt", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1286469677/reactions" + }, + "updated_at": "2022-10-21T05:11:43Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1286469677", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + { + "author_association": "MEMBER", + "body": "This seems to come from [`e303ea8` (#4131)](https://github.com/neovim/neovim/pull/4131/commits/e303ea8a19bcd385eb7829beb7f2ef691c064b35)", + "created_at": "2022-10-21T05:27:22Z", + "html_url": "https://github.com/neovim/neovim/issues/20757#issuecomment-1286478567", + "id": 1286478567, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/20757", + "node_id": "IC_kwDOAPphoM5Mrhrn", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1286478567/reactions" + }, + "updated_at": "2022-10-21T05:27:22Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1286478567", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + { + "author_association": "MEMBER", + "body": "The _TYPE and _VAL things were designed to support roundtripping. E.g.:\r\n\r\n```\r\n:echo json_encode(json_decode('{\"\": \"1\"}'))\r\n{\"\": \"1\"}\r\n```\r\n\r\nand a strict adherence to JSON spec. However, empty keys are allowed in JSON so I'm not sure why this happens here. Looks like we could fix this without issue.\r\n\r\nAlso happens with duplicate keys, again to support roundtripping with full fidelity. In that case I wouldn't change the behavior, except perhaps the \"msgpack-special-dict\" should contain an `_ERR` key that has an error message like \"duplicate key\".", + "created_at": "2022-10-21T08:28:34Z", + "html_url": "https://github.com/neovim/neovim/issues/20757#issuecomment-1286635969", + "id": 1286635969, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/20757", + "node_id": "IC_kwDOAPphoM5MsIHB", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1286635969/reactions" + }, + "updated_at": "2022-10-21T08:35:37Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1286635969", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comments": 3, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/20757/comments", + "created_at": "2022-10-21T04:55:18Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/20757/events", + "html_url": "https://github.com/neovim/neovim/issues/20757", + "id": 1417737882, + "labels": [ + { + "color": "f9d0c4", + "default": true, + "description": "issues reporting wrong behavior", + "id": 77997474, + "name": "bug", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3NA==", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug" + }, + { + "color": "c7def8", + "default": false, + "description": "", + "id": 109899557, + "name": "vimscript", + "node_id": "MDU6TGFiZWwxMDk4OTk1NTc=", + "url": "https://api.github.com/repos/neovim/neovim/labels/vimscript" + }, + { + "color": "BFDADC", + "default": false, + "description": "Low-risk. Do NOT ask \"can I work on this\", just read CONTRIBUTING.md", + "id": 407246773, + "name": "complexity:low", + "node_id": "MDU6TGFiZWw0MDcyNDY3NzM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/complexity:low" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/20757/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 201, + "created_at": "2023-02-02T14:11:43Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", + "events_url": "https://api.github.com/users/bfredl/events{/privacy}", + "followers_url": "https://api.github.com/users/bfredl/followers", + "following_url": "https://api.github.com/users/bfredl/following{/other_user}", + "gists_url": "https://api.github.com/users/bfredl/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/bfredl", + "id": 1363104, + "login": "bfredl", + "node_id": "MDQ6VXNlcjEzNjMxMDQ=", + "organizations_url": "https://api.github.com/users/bfredl/orgs", + "received_events_url": "https://api.github.com/users/bfredl/received_events", + "repos_url": "https://api.github.com/users/bfredl/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/bfredl/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/bfredl/subscriptions", + "type": "User", + "url": "https://api.github.com/users/bfredl" + }, + "description": "", + "due_on": "2024-03-01T08:00:00Z", + "html_url": "https://github.com/neovim/neovim/milestone/36", + "id": 8997654, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/36/labels", + "node_id": "MI_kwDOAPphoM4AiUsW", + "number": 36, + "open_issues": 128, + "state": "open", + "title": "0.10", + "updated_at": "2023-12-06T23:35:54Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/36" + }, + "node_id": "I_kwDOAPphoM5UgPaa", + "number": 20757, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/20757/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "closed", + "state_reason": "completed", + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/20757/timeline", + "title": "json_decode: empty key emits *msgpack-special-dict* ", + "updated_at": "2023-12-06T15:56:07Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/20757", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/32936898?v=4", + "events_url": "https://api.github.com/users/Freed-Wu/events{/privacy}", + "followers_url": "https://api.github.com/users/Freed-Wu/followers", + "following_url": "https://api.github.com/users/Freed-Wu/following{/other_user}", + "gists_url": "https://api.github.com/users/Freed-Wu/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Freed-Wu", + "id": 32936898, + "login": "Freed-Wu", + "node_id": "MDQ6VXNlcjMyOTM2ODk4", + "organizations_url": "https://api.github.com/users/Freed-Wu/orgs", + "received_events_url": "https://api.github.com/users/Freed-Wu/received_events", + "repos_url": "https://api.github.com/users/Freed-Wu/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Freed-Wu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Freed-Wu/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Freed-Wu" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/21342.json b/repositories/neovim/issues/21342.json index f1966987..76b3472c 100644 --- a/repositories/neovim/issues/21342.json +++ b/repositories/neovim/issues/21342.json @@ -52,7 +52,7 @@ }, { "author_association": "MEMBER", - "body": "This is great data, thanks. \r\n\r\n- 'termguicolors' is probably worth considering but will require some work. \r\n- Many of these are (useful) indications about needed documentation improvements rather than signals that we need to set these defaults. \r\n - E.g. 'number' is a signal that `'ruler'` and `g ctrl-g` should be mentioned it at `:help 'number'`, to start with.\r\n- Perhaps we could add a `:checkhealth` section that gives advice.", + "body": "This is great data, thanks. \r\n\r\n- ✅ 'termguicolors' is probably worth considering (done: https://github.com/neovim/neovim/pull/26407) \r\n- Many of these are (useful) indications about needed documentation improvements rather than signals that we need to set these defaults. \r\n - E.g. 'number' is a signal that `'ruler'` and `g ctrl-g` should be mentioned it at `:help 'number'`, to start with.\r\n- Perhaps we could add a `:checkhealth` section that gives advice.", "created_at": "2022-12-08T20:09:51Z", "html_url": "https://github.com/neovim/neovim/issues/21342#issuecomment-1343296366", "id": 1343296366, @@ -71,7 +71,7 @@ "total_count": 0, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1343296366/reactions" }, - "updated_at": "2022-12-09T12:45:15Z", + "updated_at": "2023-12-06T02:18:16Z", "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1343296366", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", @@ -609,7 +609,7 @@ "locked": false, "milestone": { "closed_at": null, - "closed_issues": 591, + "closed_issues": 592, "created_at": "2014-05-10T20:43:04Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", @@ -638,10 +638,10 @@ "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", "number": 6, - "open_issues": 426, + "open_issues": 427, "state": "open", "title": "backlog", - "updated_at": "2023-12-04T18:54:47Z", + "updated_at": "2023-12-06T23:16:41Z", "url": "https://api.github.com/repos/neovim/neovim/milestones/6" }, "node_id": "I_kwDOAPphoM5Yg1RE", @@ -664,7 +664,7 @@ "state_reason": null, "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/21342/timeline", "title": "survey: options defaults", - "updated_at": "2023-12-04T16:07:20Z", + "updated_at": "2023-12-06T02:18:16Z", "url": "https://api.github.com/repos/neovim/neovim/issues/21342", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", diff --git a/repositories/neovim/issues/23528.json b/repositories/neovim/issues/23528.json new file mode 100644 index 00000000..e446b662 --- /dev/null +++ b/repositories/neovim/issues/23528.json @@ -0,0 +1,178 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "### Problem\n\nI've had neovim hang at 100% CPU about once a week. I think this started with 0.9.0 but I'm not completely certain. This time I attached and took a backtrace:\r\n\r\n```\r\n(gdb) bt\r\n#0 0x00005575f8a9a118 in peekkey_simple ()\r\n#1 0x00005575f8a9a113 in peekkey_simple ()\r\n#2 0x00005575f8a9a113 in peekkey_simple ()\r\n⋮\r\n#214 0x00005575f8a9a113 in peekkey_simple ()\r\n#215 0x00005575f8a9a113 in peekkey_simple ()\r\n#216 0x00005575f8a9abc3 in termkey_getkey ()\r\n#217 0x00005575f8a1c278 in tk_getkeys ()\r\n#218 0x00005575f8a1ca3f in handle_raw_buffer ()\r\n#219 0x00005575f8a1cde8 in tinput_read_cb.lto_priv ()\r\n#220 0x00005575f885ed3c in read_event ()\r\n#221 0x00005575f885fbe6 in invoke_read_cb ()\r\n#222 0x00005575f8b4f041 in uv.read ()\r\n#223 0x00005575f8b4f9a0 in uv.stream_io ()\r\n#224 0x00005575f8b55b84 in uv.io_poll ()\r\n#225 0x00005575f8b4494f in uv_run ()\r\n#226 0x00005575f8a2a752 in ui_client_run ()\r\n#227 0x00005575f877201c in main ()\r\n(gdb) generate-core-file\r\n````\r\n\r\n[core.3883052.gz](https://github.com/neovim/neovim/files/11416072/core.3883052.gz)\n\n### Steps to reproduce\n\n I have not noticed any particular action triggering the problem.\r\n\r\n\n\n### Expected behavior\n\nNot to hang.\n\n### Neovim version (nvim -v)\n\nNVIM v0.9.0 Build type: Release LuaJIT 2.1.0-beta3\n\n### Vim (not Nvim) behaves the same?\n\nn/a\n\n### Operating system/version\n\nLinux (Debian 12.0 6.1.0-7-amd64)\n\n### Terminal name/version\n\nmlterm version 3.9.3 post/2023-04-02\n\n### $TERM environment variable\n\nmlterminal\n\n### Installation\n\nhttps://github.com/neovim/neovim/releases/download/stable/nvim-linux64.tar.gz", + "closed_at": null, + "comment_data": [ + { + "author_association": "NONE", + "body": "I've switched to a local debug build in hope of collecting more information if/when it happens again.", + "created_at": "2023-05-08T18:23:57Z", + "html_url": "https://github.com/neovim/neovim/issues/23528#issuecomment-1538838114", + "id": 1538838114, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/23528", + "node_id": "IC_kwDOAPphoM5buM5i", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1538838114/reactions" + }, + "updated_at": "2023-05-08T18:23:57Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1538838114", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/67607049?v=4", + "events_url": "https://api.github.com/users/kpschoedel/events{/privacy}", + "followers_url": "https://api.github.com/users/kpschoedel/followers", + "following_url": "https://api.github.com/users/kpschoedel/following{/other_user}", + "gists_url": "https://api.github.com/users/kpschoedel/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/kpschoedel", + "id": 67607049, + "login": "kpschoedel", + "node_id": "MDQ6VXNlcjY3NjA3MDQ5", + "organizations_url": "https://api.github.com/users/kpschoedel/orgs", + "received_events_url": "https://api.github.com/users/kpschoedel/received_events", + "repos_url": "https://api.github.com/users/kpschoedel/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/kpschoedel/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/kpschoedel/subscriptions", + "type": "User", + "url": "https://api.github.com/users/kpschoedel" + } + }, + { + "author_association": "MEMBER", + "body": "The nightlies are built with relwithdebinfo if you wanna go that route", + "created_at": "2023-05-09T06:22:20Z", + "html_url": "https://github.com/neovim/neovim/issues/23528#issuecomment-1539503241", + "id": 1539503241, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/23528", + "node_id": "IC_kwDOAPphoM5bwvSJ", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1539503241/reactions" + }, + "updated_at": "2023-05-09T06:22:20Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1539503241", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", + "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", + "followers_url": "https://api.github.com/users/dundargoc/followers", + "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", + "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/dundargoc", + "id": 33953936, + "login": "dundargoc", + "node_id": "MDQ6VXNlcjMzOTUzOTM2", + "organizations_url": "https://api.github.com/users/dundargoc/orgs", + "received_events_url": "https://api.github.com/users/dundargoc/received_events", + "repos_url": "https://api.github.com/users/dundargoc/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", + "type": "User", + "url": "https://api.github.com/users/dundargoc" + } + } + ], + "comments": 2, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/23528/comments", + "created_at": "2023-05-07T22:06:06Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/23528/events", + "html_url": "https://github.com/neovim/neovim/issues/23528", + "id": 1699256603, + "labels": [ + { + "color": "f9d0c4", + "default": true, + "description": "issues reporting wrong behavior", + "id": 77997474, + "name": "bug", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3NA==", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug" + }, + { + "color": "c5def5", + "default": false, + "description": "", + "id": 197254545, + "name": "tui", + "node_id": "MDU6TGFiZWwxOTcyNTQ1NDU=", + "url": "https://api.github.com/repos/neovim/neovim/labels/tui" + }, + { + "color": "FBCA04", + "default": false, + "description": "waiting for reply from the author", + "id": 248229439, + "name": "needs:response", + "node_id": "MDU6TGFiZWwyNDgyMjk0Mzk=", + "url": "https://api.github.com/repos/neovim/neovim/labels/needs:response" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/23528/labels{/name}", + "locked": false, + "milestone": null, + "node_id": "I_kwDOAPphoM5lSJkb", + "number": 23528, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/23528/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/23528/timeline", + "title": "Stuck in peekkey_simple()", + "updated_at": "2023-12-06T15:43:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/23528", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/67607049?v=4", + "events_url": "https://api.github.com/users/kpschoedel/events{/privacy}", + "followers_url": "https://api.github.com/users/kpschoedel/followers", + "following_url": "https://api.github.com/users/kpschoedel/following{/other_user}", + "gists_url": "https://api.github.com/users/kpschoedel/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/kpschoedel", + "id": 67607049, + "login": "kpschoedel", + "node_id": "MDQ6VXNlcjY3NjA3MDQ5", + "organizations_url": "https://api.github.com/users/kpschoedel/orgs", + "received_events_url": "https://api.github.com/users/kpschoedel/received_events", + "repos_url": "https://api.github.com/users/kpschoedel/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/kpschoedel/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/kpschoedel/subscriptions", + "type": "User", + "url": "https://api.github.com/users/kpschoedel" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/24100.json b/repositories/neovim/issues/24100.json new file mode 100644 index 00000000..37ee4427 --- /dev/null +++ b/repositories/neovim/issues/24100.json @@ -0,0 +1,170 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "body": "### Problem\r\n\r\nSeen in https://github.com/neovim/neovim/pull/24087/checks?check_run_id=14463584829 : \r\n\r\n```\r\nERROR: typval.c dict extend() works\r\ntest/unit/helpers.lua:751: child process errored out with status 256!\r\nstack traceback:\r\n\ttest/unit/helpers.lua:772: in function 'itp'\r\n\ttest/unit/eval/typval_spec.lua:2138: in function \r\n\t[C]: in function 'xpcall'\r\n\t.../cirrus-ci-build/build/usr/share/lua/5.1/busted/core.lua:178: in function 'safe'\r\n\t...cirrus-ci-build/build/usr/share/lua/5.1/busted/block.lua:146: in function 'execute'\r\n\t.../cirrus-ci-build/build/usr/share/lua/5.1/busted/init.lua:15: in function 'executor'\r\n\t.../cirrus-ci-build/build/usr/share/lua/5.1/busted/core.lua:314: in function <.../cirrus-ci-build/build/usr/share/lua/5.1/busted/core.lua:314>\r\nstack traceback:\r\n\ttest/unit/helpers.lua:751: in function 'itp_parent'\r\n\ttest/unit/helpers.lua:783: in function \r\n```\r\n\r\nPrevious: https://github.com/neovim/neovim/issues/6404\r\n\r\n### Expected behavior\r\n\r\npossible bug in extend()", + "closed_at": null, + "comment_data": [ + { + "author_association": "MEMBER", + "body": "Similar recent (flaky) failures:\r\n\r\nhttps://github.com/neovim/neovim/actions/runs/7007850368/job/19062862827\r\n\r\n```\r\nERROR test/unit/helpers.lua @ 776: typval.c tv get string_chk() works\r\ntest/unit/helpers.lua:754: child process errored out with status 256!\r\n\r\nstack traceback:\r\n\ttest/unit/helpers.lua:775: in function 'itp'\r\n\ttest/unit/eval/typval_spec.lua:3050: in function \r\n\t[C]: in function 'xpcall'\r\n\t...rk/neovim/neovim/build/usr/share/lua/5.1/busted/core.lua:178: in function 'safe'\r\n```\r\n\r\nhttps://github.com/neovim/neovim/actions/runs/7117334596/job/19377836442\r\n\r\n```\r\nERROR test/unit/helpers.lua @ 782: typval.c dict extend() works\r\ntest/unit/helpers.lua:758: child process errored out with status 256!\r\n\r\nstack traceback:\r\n\ttest/unit/helpers.lua:781: in function 'itp'\r\n\ttest/unit/eval/typval_spec.lua:2329: in function \r\n\t[C]: in function 'xpcall'\r\n\t...rk/neovim/neovim/build/usr/share/lua/5.1/busted/core.lua:178: in function 'safe'\r\n```\r\n\r\n\r\n\r\n", + "created_at": "2023-12-06T21:24:57Z", + "html_url": "https://github.com/neovim/neovim/issues/24100#issuecomment-1843714400", + "id": 1843714400, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/24100", + "node_id": "IC_kwDOAPphoM5t5Nlg", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843714400/reactions" + }, + "updated_at": "2023-12-06T21:24:57Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843714400", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comments": 1, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/24100/comments", + "created_at": "2023-06-22T08:34:53Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/24100/events", + "html_url": "https://github.com/neovim/neovim/issues/24100", + "id": 1769212179, + "labels": [ + { + "color": "c5def5", + "default": false, + "description": "", + "id": 110418643, + "name": "test", + "node_id": "MDU6TGFiZWwxMTA0MTg2NDM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/test" + }, + { + "color": "e6e6e6", + "default": false, + "description": "automation for build, test, and release", + "id": 212701006, + "name": "ci", + "node_id": "MDU6TGFiZWwyMTI3MDEwMDY=", + "url": "https://api.github.com/repos/neovim/neovim/labels/ci" + }, + { + "color": "F9D0C4", + "default": false, + "description": "issue reporting a crash or segfault", + "id": 435854234, + "name": "bug-crash", + "node_id": "MDU6TGFiZWw0MzU4NTQyMzQ=", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug-crash" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/24100/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 592, + "created_at": "2014-05-10T20:43:04Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "Low priority. Not planned for the current target, may be reassigned.", + "due_on": null, + "html_url": "https://github.com/neovim/neovim/milestone/6", + "id": 655037, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", + "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", + "number": 6, + "open_issues": 427, + "state": "open", + "title": "backlog", + "updated_at": "2023-12-06T23:16:41Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/6" + }, + "node_id": "I_kwDOAPphoM5pdAkT", + "number": 24100, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/24100/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/24100/timeline", + "title": "test failure: \"dict extend()\" in typval_spec", + "updated_at": "2023-12-06T21:26:18Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/24100", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/25844.json b/repositories/neovim/issues/25844.json index fded1e0d..14aa9665 100644 --- a/repositories/neovim/issues/25844.json +++ b/repositories/neovim/issues/25844.json @@ -49,9 +49,53 @@ "type": "User", "url": "https://api.github.com/users/zeertzjq" } + }, + { + "author_association": "MEMBER", + "body": "For reference from https://github.com/neovim/neovim/pull/26430#discussion_r1418087057 : \r\n\r\n> autocmds can change windows, so all _event context_ such as \"current window\" is relevant to pretty much any event, just like buffer (``). Consider the following:\r\n> \r\n> ```vim\r\n> nvim --clean\r\n> :edit a\r\n> :rightbelow vsplit b\r\n> :wincmd w\r\n> :autocmd ColorScheme * wincmd w\r\n> :autocmd ColorScheme * echomsg 'win='..winnr() 'buf='..expand('')\r\n> :colorscheme blue\r\n> ```\r\n> \r\n> Even though the event triggered in window 1, the 2nd autocmd prints `win=2 buf=a`, it has no way of knowing the original window (but `` gives it the original buffer).\r\n\r\nSimilar to ``, it seems to me that passing the \"window at trigger-time\" is useful for any event, not only `Win*` events, because autocmds can change windows.", + "created_at": "2023-12-06T23:20:48Z", + "html_url": "https://github.com/neovim/neovim/issues/25844#issuecomment-1843845378", + "id": 1843845378, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/25844", + "node_id": "IC_kwDOAPphoM5t5tkC", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843845378/reactions" + }, + "updated_at": "2023-12-06T23:20:48Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843845378", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } } ], - "comments": 1, + "comments": 2, "comments_url": "https://api.github.com/repos/neovim/neovim/issues/25844/comments", "created_at": "2023-10-30T20:31:05Z", "events_url": "https://api.github.com/repos/neovim/neovim/issues/25844/events", @@ -108,8 +152,8 @@ "state": "open", "state_reason": null, "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/25844/timeline", - "title": "Pass Window ID as a Callback Argument for Autocommands with the Win* events", - "updated_at": "2023-10-31T16:55:45Z", + "title": "Pass Window ID as event argument for autocommands", + "updated_at": "2023-12-06T23:20:49Z", "url": "https://api.github.com/repos/neovim/neovim/issues/25844", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/73707948?v=4", diff --git a/repositories/neovim/issues/26372.json b/repositories/neovim/issues/26372.json index a5d770fd..c14a55ae 100644 --- a/repositories/neovim/issues/26372.json +++ b/repositories/neovim/issues/26372.json @@ -4,7 +4,7 @@ "assignees": [], "author_association": "MEMBER", "body": "### Problem\r\n\r\nWhen Nvim starts up, it is possible for the default colorscheme to be visible before any user colorscheme is loaded. This can result in a very annoying glitch in the colorscheme each time I open Nvim. This wasn't a problem before since the old default colorscheme did not set a background.\r\n\r\n\r\nhttps://github.com/neovim/neovim/assets/7904185/6919505e-c09d-49db-b811-452685f556e1\r\n\r\n\r\nSince I don't plan to use the default colorscheme I consider this a fairly large regression.\r\n\r\n### Steps to reproduce\r\n\r\n`nvim --clean -u NORC --cmd 'call system([\"sleep\", \"1\"])' --cmd 'color vim'`\r\n\r\n\r\n### Expected behavior\r\n\r\nThe background should not change as nvim is starting up.\r\n\r\n### Neovim version (nvim -v)\r\n\r\nNVIM v0.10.0-dev-1744+g0d885247\r\n\r\n### Vim (not Nvim) behaves the same?\r\n\r\nno\r\n\r\n### Operating system/version\r\n\r\nmacOS 14\r\n\r\n### Terminal name/version\r\n\r\nwezterm\r\n\r\n### $TERM environment variable\r\n\r\nxterm-256color\r\n\r\n### Installation\r\n\r\nSource\r\n\r\n---\r\n\r\nOne solution is to revert the background color in the new colorscheme so it is not set for `notermguicolors`.\n\n@echasnovski ", - "closed_at": null, + "closed_at": "2023-12-06T18:58:05Z", "comment_data": [ { "author_association": "CONTRIBUTOR", @@ -544,7 +544,7 @@ "node_id": "IC_kwDOAPphoM5tlap4", "performed_via_github_app": null, "reactions": { - "+1": 0, + "+1": 3, "-1": 0, "confused": 0, "eyes": 0, @@ -552,7 +552,7 @@ "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 0, + "total_count": 3, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1838525048/reactions" }, "updated_at": "2023-12-04T12:22:04Z", @@ -621,9 +621,53 @@ "type": "User", "url": "https://api.github.com/users/scy" } + }, + { + "author_association": "CONTRIBUTOR", + "body": "Thanks, Björn!", + "created_at": "2023-12-06T19:05:27Z", + "html_url": "https://github.com/neovim/neovim/issues/26372#issuecomment-1843526243", + "id": 1843526243, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26372", + "node_id": "IC_kwDOAPphoM5t4fpj", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843526243/reactions" + }, + "updated_at": "2023-12-06T19:05:27Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843526243", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", + "events_url": "https://api.github.com/users/echasnovski/events{/privacy}", + "followers_url": "https://api.github.com/users/echasnovski/followers", + "following_url": "https://api.github.com/users/echasnovski/following{/other_user}", + "gists_url": "https://api.github.com/users/echasnovski/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/echasnovski", + "id": 24854248, + "login": "echasnovski", + "node_id": "MDQ6VXNlcjI0ODU0MjQ4", + "organizations_url": "https://api.github.com/users/echasnovski/orgs", + "received_events_url": "https://api.github.com/users/echasnovski/received_events", + "repos_url": "https://api.github.com/users/echasnovski/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/echasnovski/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/echasnovski/subscriptions", + "type": "User", + "url": "https://api.github.com/users/echasnovski" + } } ], - "comments": 14, + "comments": 15, "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26372/comments", "created_at": "2023-12-03T17:30:18Z", "events_url": "https://api.github.com/repos/neovim/neovim/issues/26372/events", @@ -683,7 +727,7 @@ "number": 26372, "performed_via_github_app": null, "reactions": { - "+1": 5, + "+1": 7, "-1": 0, "confused": 0, "eyes": 1, @@ -691,15 +735,15 @@ "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 6, + "total_count": 8, "url": "https://api.github.com/repos/neovim/neovim/issues/26372/reactions" }, "repository_url": "https://api.github.com/repos/neovim/neovim", - "state": "open", - "state_reason": null, + "state": "closed", + "state_reason": "completed", "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26372/timeline", "title": "The new default colorscheme causes the background to change during startup", - "updated_at": "2023-12-04T17:36:31Z", + "updated_at": "2023-12-06T19:05:28Z", "url": "https://api.github.com/repos/neovim/neovim/issues/26372", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", diff --git a/repositories/neovim/issues/26388.json b/repositories/neovim/issues/26388.json index 2e144414..a0b38d26 100644 --- a/repositories/neovim/issues/26388.json +++ b/repositories/neovim/issues/26388.json @@ -225,9 +225,53 @@ "type": "User", "url": "https://api.github.com/users/ray-x" } + }, + { + "author_association": "NONE", + "body": "repro\r\n```lua\r\n-- repro.lua\r\nlocal ns = vim.api.nvim_create_namespace('test')\r\nvim.opt.softtabstop = 3\r\nvim.api.nvim_buf_set_extmark(0, ns, 0, 5, {\r\n virt_text_pos = 'inline',\r\n ephemeral = false,\r\n virt_text = {{'[virtual text]'}},\r\n })\r\n```\r\nsource`repro.lua` then go to `1:7` then press backspace\r\n```\r\nnvim --clean repro.lua\r\n```\r\nthe issues seems to only happen if the inline virtual text is placed before a space", + "created_at": "2023-12-06T02:36:08Z", + "html_url": "https://github.com/neovim/neovim/issues/26388#issuecomment-1841990034", + "id": 1841990034, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26388", + "node_id": "IC_kwDOAPphoM5tyomS", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841990034/reactions" + }, + "updated_at": "2023-12-06T10:23:31Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841990034", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/130783534?v=4", + "events_url": "https://api.github.com/users/Sam-programs/events{/privacy}", + "followers_url": "https://api.github.com/users/Sam-programs/followers", + "following_url": "https://api.github.com/users/Sam-programs/following{/other_user}", + "gists_url": "https://api.github.com/users/Sam-programs/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Sam-programs", + "id": 130783534, + "login": "Sam-programs", + "node_id": "U_kgDOB8uZLg", + "organizations_url": "https://api.github.com/users/Sam-programs/orgs", + "received_events_url": "https://api.github.com/users/Sam-programs/received_events", + "repos_url": "https://api.github.com/users/Sam-programs/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Sam-programs/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Sam-programs/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Sam-programs" + } } ], - "comments": 5, + "comments": 6, "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26388/comments", "created_at": "2023-12-04T14:02:11Z", "events_url": "https://api.github.com/repos/neovim/neovim/issues/26388/events", @@ -244,13 +288,13 @@ "url": "https://api.github.com/repos/neovim/neovim/labels/bug" }, { - "color": "FBCA04", + "color": "c5def5", "default": false, - "description": "We need minimal steps to reproduce the issue", - "id": 298863445, - "name": "needs:repro", - "node_id": "MDU6TGFiZWwyOTg4NjM0NDU=", - "url": "https://api.github.com/repos/neovim/neovim/labels/needs:repro" + "description": "extmarks, decorations, virtual text, namespaces", + "id": 1680119719, + "name": "extmarks", + "node_id": "MDU6TGFiZWwxNjgwMTE5NzE5", + "url": "https://api.github.com/repos/neovim/neovim/labels/extmarks" } ], "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26388/labels{/name}", @@ -276,7 +320,7 @@ "state_reason": null, "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26388/timeline", "title": "Strange white space padding when using nvim_buf_set_extmark for inlay virtual text", - "updated_at": "2023-12-06T01:33:23Z", + "updated_at": "2023-12-06T10:23:31Z", "url": "https://api.github.com/repos/neovim/neovim/issues/26388", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1681295?v=4", diff --git a/repositories/neovim/issues/26408.json b/repositories/neovim/issues/26408.json index 000ec3bd..911cf018 100644 --- a/repositories/neovim/issues/26408.json +++ b/repositories/neovim/issues/26408.json @@ -665,9 +665,53 @@ "type": "User", "url": "https://api.github.com/users/rickyelopez" } + }, + { + "author_association": "NONE", + "body": "I implemented everything myself. It wasn't as bad as I was expecting, but it was still definitely more work than the lspconfig implementation I had previously. Agreed that this way is better, though. Thanks for the tips", + "created_at": "2023-12-06T02:28:27Z", + "html_url": "https://github.com/neovim/neovim/issues/26408#issuecomment-1841984271", + "id": 1841984271, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26408", + "node_id": "IC_kwDOAPphoM5tynMP", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 1, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841984271/reactions" + }, + "updated_at": "2023-12-06T02:28:27Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841984271", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31072564?v=4", + "events_url": "https://api.github.com/users/rickyelopez/events{/privacy}", + "followers_url": "https://api.github.com/users/rickyelopez/followers", + "following_url": "https://api.github.com/users/rickyelopez/following{/other_user}", + "gists_url": "https://api.github.com/users/rickyelopez/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/rickyelopez", + "id": 31072564, + "login": "rickyelopez", + "node_id": "MDQ6VXNlcjMxMDcyNTY0", + "organizations_url": "https://api.github.com/users/rickyelopez/orgs", + "received_events_url": "https://api.github.com/users/rickyelopez/received_events", + "repos_url": "https://api.github.com/users/rickyelopez/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/rickyelopez/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rickyelopez/subscriptions", + "type": "User", + "url": "https://api.github.com/users/rickyelopez" + } } ], - "comments": 15, + "comments": 16, "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26408/comments", "created_at": "2023-12-05T18:31:27Z", "events_url": "https://api.github.com/repos/neovim/neovim/issues/26408/events", @@ -734,7 +778,7 @@ "state_reason": "completed", "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26408/timeline", "title": "Slow-starting LSP server locks up UI", - "updated_at": "2023-12-05T22:32:15Z", + "updated_at": "2023-12-06T02:28:28Z", "url": "https://api.github.com/repos/neovim/neovim/issues/26408", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/31072564?v=4", diff --git a/repositories/neovim/issues/26409.json b/repositories/neovim/issues/26409.json index 723a3f2d..64324b1b 100644 --- a/repositories/neovim/issues/26409.json +++ b/repositories/neovim/issues/26409.json @@ -4,7 +4,7 @@ "assignees": [], "author_association": "MEMBER", "body": "### Problem\r\n\r\nThere is no method in vim.iter to collapse an iterator into a delimited string. Currently this must be done using `:totable()` and `table.concat()`. This works, but is awkward and causes control flow to \"jump\". Example:\r\n\r\n```lua\r\ntable.concat(vim.iter({'a', 'b', 'c', 'd'}):map(function(x) return transform(x) end):totable(), ',')\r\n```\r\n\r\nWith vim.iter pipelines it is natural to read control flow from left to right (in the example above, we start with the table `{'a', 'b', 'c', 'd'}`, then every element is mapped, then the iterator is converted into a table). But since the entire thing is wrapped in `table.concat`, control flow \"jumps\" back to the outer call.\r\n\r\n### Expected behavior\r\n\r\nAdd a `:join()` method that also collapses an iterator (similar to `:totable()` or `:fold()`) but instead of returning a table, returns a string.\r\n\r\n```lua\r\nvim.iter({'a', 'b', 'c', 'd'}):map(function(x) return transform(x) end):join(',')\r\n```", - "closed_at": null, + "closed_at": "2023-12-06T02:35:23Z", "comment_data": [], "comments": 0, "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26409/comments", @@ -36,7 +36,7 @@ "locked": false, "milestone": { "closed_at": null, - "closed_issues": 591, + "closed_issues": 592, "created_at": "2014-05-10T20:43:04Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", @@ -68,7 +68,7 @@ "open_issues": 427, "state": "open", "title": "backlog", - "updated_at": "2023-12-05T23:35:55Z", + "updated_at": "2023-12-06T23:16:41Z", "url": "https://api.github.com/repos/neovim/neovim/milestones/6" }, "node_id": "I_kwDOAPphoM541GxK", @@ -87,11 +87,11 @@ "url": "https://api.github.com/repos/neovim/neovim/issues/26409/reactions" }, "repository_url": "https://api.github.com/repos/neovim/neovim", - "state": "open", - "state_reason": null, + "state": "closed", + "state_reason": "completed", "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26409/timeline", "title": "Add a `:join()` method to vim.iter", - "updated_at": "2023-12-05T23:35:55Z", + "updated_at": "2023-12-06T02:35:23Z", "url": "https://api.github.com/repos/neovim/neovim/issues/26409", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", diff --git a/repositories/neovim/issues/26419.json b/repositories/neovim/issues/26419.json new file mode 100644 index 00000000..9f338526 --- /dev/null +++ b/repositories/neovim/issues/26419.json @@ -0,0 +1,116 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "### Problem\n\nHello,\r\nRespected devs,\r\n\r\nI am using nvim-dap and while running debugger got an error of connection refused for js files.\r\ndap.lua >\r\n```lua\r\nlocal dap = require(\"dap\")\r\n\r\ndap.adapters[\"pwa-node\"] = {\r\n type = \"server\",\r\n host = \"127.0.0.1\",\r\n port = 9229,\r\n executable = {\r\n command = \"js-debug-adapter\",\r\n }\r\n}\r\n\r\nfor _, language in ipairs { \"typescript\", \"javascript\" } do\r\n dap.configurations[language] = {\r\n {\r\n type = \"pwa-node\",\r\n request = \"launch\",\r\n name = \"Launch file\",\r\n program = \"${file}\",\r\n cwd = \"${workspaceFolder}\",\r\n runtimeExecutable = \"/usr/bin/node\",\r\n },\r\n }\r\nend\r\n```\r\nThe Strange thing is that earlier it was working perfectly but now showing error.\r\n\r\n**Error:**\r\nCouldn't connect to 127.0.0.1:9229 ECONNREFUSED \r\n\r\n\n\n### Steps to reproduce\n\nSetup nvim-dap,\r\nSetup nvim-dap-ui,\r\nMake the same config file.\n\n### Expected behavior\n\nIt should open the debugger.\n\n### Neovim version (nvim -v)\n\nNVIM v0.9.4, Build type: Release, LuaJIT 2.1.1700008891\n\n### Vim (not Nvim) behaves the same?\n\nNA\n\n### Operating system/version\n\nArch linux\n\n### Terminal name/version\n\nGnome-console (kgx)\n\n### $TERM environment variable\n\nNA\n\n### Installation\n\nAUR", + "closed_at": "2023-12-06T08:06:13Z", + "comment_data": [ + { + "author_association": "MEMBER", + "body": "Please report this with nvim-dap (first).", + "created_at": "2023-12-06T08:06:13Z", + "html_url": "https://github.com/neovim/neovim/issues/26419#issuecomment-1842368600", + "id": 1842368600, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26419", + "node_id": "IC_kwDOAPphoM5t0FBY", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842368600/reactions" + }, + "updated_at": "2023-12-06T08:06:13Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842368600", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + } + ], + "comments": 1, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26419/comments", + "created_at": "2023-12-06T08:05:01Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/26419/events", + "html_url": "https://github.com/neovim/neovim/issues/26419", + "id": 2027944355, + "labels": [ + { + "color": "e6e6e6", + "default": false, + "description": "Issues that are closed as \"invalid\"", + "id": 77997477, + "name": "closed:invalid", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3Nw==", + "url": "https://api.github.com/repos/neovim/neovim/labels/closed:invalid" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26419/labels{/name}", + "locked": false, + "milestone": null, + "node_id": "I_kwDOAPphoM543_mj", + "number": 26419, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/26419/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "closed", + "state_reason": "not_planned", + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26419/timeline", + "title": "Error while using dap with node.js (connection refused).", + "updated_at": "2023-12-06T08:08:14Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/26419", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/144369627?v=4", + "events_url": "https://api.github.com/users/dir1337/events{/privacy}", + "followers_url": "https://api.github.com/users/dir1337/followers", + "following_url": "https://api.github.com/users/dir1337/following{/other_user}", + "gists_url": "https://api.github.com/users/dir1337/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/dir1337", + "id": 144369627, + "login": "dir1337", + "node_id": "U_kgDOCJrn2w", + "organizations_url": "https://api.github.com/users/dir1337/orgs", + "received_events_url": "https://api.github.com/users/dir1337/received_events", + "repos_url": "https://api.github.com/users/dir1337/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dir1337/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dir1337/subscriptions", + "type": "User", + "url": "https://api.github.com/users/dir1337" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/26422.json b/repositories/neovim/issues/26422.json new file mode 100644 index 00000000..8d935b7f --- /dev/null +++ b/repositories/neovim/issues/26422.json @@ -0,0 +1,715 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "### Problem\r\n\r\nI found this problem in nightly with using `incline` or `fidget` plugins. Also tried in kitty and alacritty. Alacritty seems to be ok(i'm not sure for all cases), but kitty not. These plugins make floating windows(i guess) in right up/down corners to display some information, incline filename, fidget lsp info. When some of them on the screen there are weird `cursors`(kind of) through all screen(mostly on the right side) when scrolling.\r\nNightly:\r\nhttps://github.com/neovim/neovim/assets/62308020/fc570b6d-a1d8-484e-aad0-6ee17a409eec\r\n0.9.4:\r\nhttps://github.com/neovim/neovim/assets/62308020/d12de68a-4e4c-44c4-9683-1beef48019c9\r\n\r\nConfig to reproduce:\r\n```lua\r\nfor name, url in pairs({\r\n\t-- ADD PLUGINS _NECESSARY_ TO REPRODUCE THE ISSUE, e.g:\r\n\t-- some_plugin = 'https://github.com/author/plugin.nvim'\r\n\t\"https://github.com/b0o/incline.nvim\",\r\n}) do\r\n\tlocal install_path = vim.fn.fnamemodify(\"nvim_issue/\" .. name, \":p\")\r\n\tif vim.fn.isdirectory(install_path) == 0 then\r\n\t\tvim.fn.system({ \"git\", \"clone\", \"--depth=1\", url, install_path })\r\n\tend\r\n\tvim.opt.runtimepath:append(install_path)\r\nend\r\n\r\nrequire(\"incline\").setup()\r\n```\r\n\r\n### Steps to reproduce\r\n\r\n1.Open kitty term\r\n2. Copy config to reproduce.\r\n3. nvim `some file with ability to scroll` --clean -u `repro_conf.lua`\r\n4. There should be filename in right up corner.\r\n5. Scroll in file.\r\n\r\n\r\n### Expected behavior\r\n\r\nScreen rendering like `0.9.4`\r\n\r\n### Neovim version (nvim -v)\r\n\r\nv0.10.0-dev-988b472\r\n\r\n### Vim (not Nvim) behaves the same?\r\n\r\nidk\r\n\r\n### Operating system/version\r\n\r\narch\r\n\r\n### Terminal name/version\r\n\r\nkitty `0.31`\r\n\r\n### $TERM environment variable\r\n\r\nxterm256-color\r\n\r\n### Installation\r\n\r\nbuild from repo", + "closed_at": null, + "comment_data": [ + { + "author_association": "MEMBER", + "body": "Can you bisect to the specific commit that introduced this?", + "created_at": "2023-12-06T14:09:47Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1842963086", + "id": 1842963086, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t2WKO", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842963086/reactions" + }, + "updated_at": "2023-12-06T14:09:47Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842963086", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "MEMBER", + "body": "And please always test the _latest_ commit on `master`; 988b472 is already outdated and missing several possibly relevant fixup commits.", + "created_at": "2023-12-06T14:10:44Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1842964675", + "id": 1842964675, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t2WjD", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842964675/reactions" + }, + "updated_at": "2023-12-06T14:15:28Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842964675", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "NONE", + "body": "> Can you bisect to the specific commit that introduced this?\r\n\r\nMaybe later", + "created_at": "2023-12-06T14:14:17Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1842970870", + "id": 1842970870, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t2YD2", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842970870/reactions" + }, + "updated_at": "2023-12-06T14:14:17Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842970870", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "NONE", + "body": "> And please always test the _latest_ commit on `master`; [988b472](https://github.com/neovim/neovim/commit/988b472d902e6116353fc2ae605bed32a37e6391) is already outdated and missing several possibly relevant fixup commits.\r\n\r\nlatest(same):\r\nhttps://github.com/neovim/neovim/assets/62308020/4ba88f3f-1d57-446f-8343-d48147bb40ac\r\n\r\n", + "created_at": "2023-12-06T14:18:08Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1842977418", + "id": 1842977418, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t2ZqK", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842977418/reactions" + }, + "updated_at": "2023-12-06T14:18:08Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842977418", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "NONE", + "body": "Actually happens in both alacritty and kitty and caused by f54806fd7f4c0bae273ffcf8a4598a2d872e5a9e (0.9.2). For best test you should zoom out a lot.\r\n\r\nhttps://github.com/neovim/neovim/assets/62308020/7cd755bd-5622-48c4-a20c-225eab66ddca\r\n\r\n", + "created_at": "2023-12-06T15:19:54Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843099091", + "id": 1843099091, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t23XT", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843099091/reactions" + }, + "updated_at": "2023-12-06T21:44:19Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843099091", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "MEMBER", + "body": "It's better to bisect on `master`, not the release branch.\r\n\r\nThis commit was backported from https://github.com/neovim/neovim/pull/24982 @zeertzjq \r\n", + "created_at": "2023-12-06T15:25:40Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843109419", + "id": 1843109419, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t254r", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843109419/reactions" + }, + "updated_at": "2023-12-06T15:25:40Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843109419", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "NONE", + "body": "> It's better to bisect on `master`, not the release branch.\r\n> \r\n> This commit was backported from #24982 @zeertzjq\r\n\r\nYeah, but hard to detect good commit(bisected from 0.9.0 to 0.9.4), tested, bb1df1221d567e3f682a177d55772f49801f5e80 seems to be good, 0c86828 has \"artifacts\"", + "created_at": "2023-12-06T15:39:49Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843135581", + "id": 1843135581, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t3ARd", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843135581/reactions" + }, + "updated_at": "2023-12-06T21:44:46Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843135581", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "MEMBER", + "body": "I can't understand the comments. Does the bug exist in v0.9.4 or not? If the bug doesn't exist in v0.9.4 why were you bisecting the release branch?", + "created_at": "2023-12-06T16:33:59Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843253072", + "id": 1843253072, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t3c9Q", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843253072/reactions" + }, + "updated_at": "2023-12-06T16:34:50Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843253072", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + { + "author_association": "MEMBER", + "body": "Also you `$TERM` value is wrong. For kitty it should be `xterm-kitty` and for Alacritty it should be `alacritty`. Does the bug happen if you set the correct `$TERM` value?", + "created_at": "2023-12-06T16:42:05Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843266948", + "id": 1843266948, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t3gWE", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843266948/reactions" + }, + "updated_at": "2023-12-06T16:42:39Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843266948", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + { + "author_association": "NONE", + "body": "\r\n> I can't understand the comments. Does the bug exist in v0.9.4 or not? If the bug doesn't exist in v0.9.4 why were you bisecting the release branch?\r\n\r\n@zeertzjq Firstly, I thought that version 0.9.4 did not have this issue. However, after starting bisect, I discovered that 0.9.4 also has artifacts. My bisect was from release branch, after finding backport commit which caused this issue, i checked master branch and for me https://github.com/neovim/neovim/pull/24982 introduces this one.\r\n", + "created_at": "2023-12-06T16:50:41Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843280810", + "id": 1843280810, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t3juq", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843280810/reactions" + }, + "updated_at": "2023-12-06T16:50:41Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843280810", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "NONE", + "body": "> Also you `$TERM` value is wrong. For kitty it should be `xterm-kitty` and for Alacritty it should be `alacritty`. Does the bug happen if you set the correct `$TERM` value?\r\n\r\nYeah, you are right, but changing to `xterm-kitty` and `alacritty` makes no difference.Checked with tmux, without tmux, same problem.\r\nCan record, if you need.", + "created_at": "2023-12-06T16:51:38Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843282296", + "id": 1843282296, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t3kF4", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843282296/reactions" + }, + "updated_at": "2023-12-06T16:58:07Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843282296", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "NONE", + "body": "@zeertzjq It's so hard to detect which one, because seems to be more than one commit problem, i thinked testing with a lot of zoom out helps me to detect problem easier, but by another bisect i found that kitty starts flickering on 405bad5e085fb359879646b6fd6fbcddae83eac5 (probably it just got worse after this one) with normal zoom/font size. There are some catches that i found :\r\n1. All terms work fine with <30 visible lines;\r\n2. On 405bad5e085fb359879646b6fd6fbcddae83eac5 kitty starts flickering on 37 (i guess after 30) visible lines, alacritty works fine untill 120 visible lines (i guess from 0c86828).\r\n\r\nThey all are flickering on 405bad5e085fb359879646b6fd6fbcddae83eac5 in tmux with ~35 visible lines, i tried different `$TERM` but it just increase/decrease flickering.\r\n\r\nTested on 24 inch full hd monitor with 16 font size `JetBrainsMono Nerd Font`", + "created_at": "2023-12-06T18:30:42Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843454790", + "id": 1843454790, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t4ONG", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843454790/reactions" + }, + "updated_at": "2023-12-06T21:46:37Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843454790", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "NONE", + "body": "Wezterm also has flickering", + "created_at": "2023-12-06T18:45:25Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843490341", + "id": 1843490341, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t4W4l", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843490341/reactions" + }, + "updated_at": "2023-12-06T18:45:25Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843490341", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } + }, + { + "author_association": "MEMBER", + "body": "Hmm, does `:set notermsync` change anything?\r\n\r\nAlso, if the bug starts in kitty in 405bad5e085fb359879646b6fd6fbcddae83eac5, then it doesn't happen in kitty in v0.9.4?", + "created_at": "2023-12-06T21:48:35Z", + "html_url": "https://github.com/neovim/neovim/issues/26422#issuecomment-1843743909", + "id": 1843743909, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "node_id": "IC_kwDOAPphoM5t5Uyl", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843743909/reactions" + }, + "updated_at": "2023-12-06T22:08:07Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843743909", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + } + ], + "comments": 14, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26422/comments", + "created_at": "2023-12-06T14:04:46Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/26422/events", + "html_url": "https://github.com/neovim/neovim/issues/26422", + "id": 2028636564, + "labels": [ + { + "color": "c5def5", + "default": false, + "description": "", + "id": 113026979, + "name": "ui", + "node_id": "MDU6TGFiZWwxMTMwMjY5Nzk=", + "url": "https://api.github.com/repos/neovim/neovim/labels/ui" + }, + { + "color": "c5def5", + "default": false, + "description": "", + "id": 197254545, + "name": "tui", + "node_id": "MDU6TGFiZWwxOTcyNTQ1NDU=", + "url": "https://api.github.com/repos/neovim/neovim/labels/tui" + }, + { + "color": "FBCA04", + "default": false, + "description": "waiting for reply from the author", + "id": 248229439, + "name": "needs:response", + "node_id": "MDU6TGFiZWwyNDgyMjk0Mzk=", + "url": "https://api.github.com/repos/neovim/neovim/labels/needs:response" + }, + { + "color": "f9d0c4", + "default": false, + "description": "wrong behavior that was introduced in a previous commit (please bisect)", + "id": 619474658, + "name": "bug-regression", + "node_id": "MDU6TGFiZWw2MTk0NzQ2NTg=", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug-regression" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26422/labels{/name}", + "locked": false, + "milestone": null, + "node_id": "I_kwDOAPphoM546omU", + "number": 26422, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/26422/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26422/timeline", + "title": "Rendering bug when scrolling in kitty term with specific plugins.", + "updated_at": "2023-12-06T22:08:07Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/26422", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/62308020?v=4", + "events_url": "https://api.github.com/users/geril2207/events{/privacy}", + "followers_url": "https://api.github.com/users/geril2207/followers", + "following_url": "https://api.github.com/users/geril2207/following{/other_user}", + "gists_url": "https://api.github.com/users/geril2207/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/geril2207", + "id": 62308020, + "login": "geril2207", + "node_id": "MDQ6VXNlcjYyMzA4MDIw", + "organizations_url": "https://api.github.com/users/geril2207/orgs", + "received_events_url": "https://api.github.com/users/geril2207/received_events", + "repos_url": "https://api.github.com/users/geril2207/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/geril2207/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/geril2207/subscriptions", + "type": "User", + "url": "https://api.github.com/users/geril2207" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/26424.json b/repositories/neovim/issues/26424.json new file mode 100644 index 00000000..b18a8d00 --- /dev/null +++ b/repositories/neovim/issues/26424.json @@ -0,0 +1,214 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "body": "### Problem\r\n\r\nMultibyte sign text leaks into buffer text.\r\nRegression from #25724.\r\n\r\n### Steps to reproduce\r\n\r\n```vim\r\n\" test.vim\r\ncall setline(1, ['aaaaa']->repeat(10))\r\nsign define piet1 text=𐌢𐌢 texthl=Search\r\nsign define piet2 text=𠜎 texthl=Search\r\nsign place 1 line=1 name=piet1 buffer=1\r\nsign place 2 line=2 name=piet2 buffer=1\r\nsign place 3 line=7 name=piet1 buffer=1\r\nsign place 4 line=8 name=piet2 buffer=1\r\nlet ns = nvim_create_namespace('')\r\ncall nvim_buf_set_extmark(0, ns, 3, 0, {'sign_text':'𐌢𐌢'})\r\ncall nvim_buf_set_extmark(0, ns, 4, 0, {'sign_text':'𐌢'})\r\n```\r\n1. Run `nvim --clean -S test.vim`\r\n2. Type dddd\r\n3. Observe the problem.\r\n\r\n~~For some reason the problem only occurs when deleting a line with a legacy sign.~~\r\nI first suspected the `get_sign_display()` refactor done in #25724 but I can't detect anything going wrong there. Maybe `init_sign_text()` or `decor_redraw_signs()`.\r\n\r\n### Expected behavior\r\n\r\nSign text doesn't leak into buffer text.", + "closed_at": null, + "comment_data": [ + { + "author_association": "MEMBER", + "body": "OK the difference in behavior comes from the `invalidate` extmark property.\r\nWith `call nvim_buf_set_extmark(0, ns, 3, 0, {'sign_text':'𐌢̀́̂̃̅̄𐌢̀́̂̃̅̄', 'invalidate':1})` the problem also occurs when deleting a line with an extmark sign.", + "created_at": "2023-12-06T15:53:19Z", + "html_url": "https://github.com/neovim/neovim/issues/26424#issuecomment-1843183067", + "id": 1843183067, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26424", + "node_id": "IC_kwDOAPphoM5t3L3b", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843183067/reactions" + }, + "updated_at": "2023-12-06T15:53:19Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843183067", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "author_association": "MEMBER", + "body": "Bruh I can no longer reproduce this. I've had this happen before when I was working on a branch that edited `buffer_defs.h`. Where I would no longer be able to reproduce an issue after `make distclean`. Indicating that somehow the `buffer_defs.h` edits would leak into adjacent memory in the buffer/window struct or something. Can it be that our CMake config is somehow not strict enough in rebuilding for edits to `buffer_defs.h`? Can anyone reproduce this issue?", + "created_at": "2023-12-06T20:42:17Z", + "html_url": "https://github.com/neovim/neovim/issues/26424#issuecomment-1843658851", + "id": 1843658851, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26424", + "node_id": "IC_kwDOAPphoM5t5ABj", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 1, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843658851/reactions" + }, + "updated_at": "2023-12-06T20:54:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843658851", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + } + ], + "comments": 2, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26424/comments", + "created_at": "2023-12-06T15:23:21Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/26424/events", + "html_url": "https://github.com/neovim/neovim/issues/26424", + "id": 2028799817, + "labels": [ + { + "color": "f9d0c4", + "default": false, + "description": "wrong behavior that was introduced in a previous commit (please bisect)", + "id": 619474658, + "name": "bug-regression", + "node_id": "MDU6TGFiZWw2MTk0NzQ2NTg=", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug-regression" + }, + { + "color": "c5def5", + "default": false, + "description": "(multibyte) unicode characters", + "id": 2882115256, + "name": "unicode 💩", + "node_id": "MDU6TGFiZWwyODgyMTE1MjU2", + "url": "https://api.github.com/repos/neovim/neovim/labels/unicode%20%20%F0%9F%92%A9" + }, + { + "color": "c5def5", + "default": false, + "description": "sign/number column", + "id": 2962322085, + "name": "column", + "node_id": "MDU6TGFiZWwyOTYyMzIyMDg1", + "url": "https://api.github.com/repos/neovim/neovim/labels/column" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26424/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 592, + "created_at": "2014-05-10T20:43:04Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "Low priority. Not planned for the current target, may be reassigned.", + "due_on": null, + "html_url": "https://github.com/neovim/neovim/milestone/6", + "id": 655037, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", + "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", + "number": 6, + "open_issues": 427, + "state": "open", + "title": "backlog", + "updated_at": "2023-12-06T23:16:41Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/6" + }, + "node_id": "I_kwDOAPphoM547QdJ", + "number": 26424, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/26424/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26424/timeline", + "title": "corrupted display with multibyte signs", + "updated_at": "2023-12-06T20:54:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/26424", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/26425.json b/repositories/neovim/issues/26425.json new file mode 100644 index 00000000..c8d934fa --- /dev/null +++ b/repositories/neovim/issues/26425.json @@ -0,0 +1,134 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "body": "\r\nLooks like `tui_stop` is called before `event_teardown`, but `event_teardown` may process a pending event which calls `tk_getkeys`.\r\n\r\n```\r\n= ==24175==ERROR: AddressSanitizer: heap-use-after-free on address 0x51700000208d at pc 0x55b5982e626a bp 0x7ffe1d0a4cb0 sp 0x7ffe1d0a4ca8\r\n= READ of size 1 at 0x51700000208d thread T0\r\n= #0 0x55b5982e6269 in peekkey /home/runner/work/neovim/neovim/src/termkey/termkey.c:863:11\r\n= #1 0x55b5982e7460 in termkey_getkey_force /home/runner/work/neovim/neovim/src/termkey/termkey.c:1058:23\r\n= #2 0x55b597fcec9b in tk_getkey /home/runner/work/neovim/neovim/src/nvim/tui/input.c:434:18\r\n= #3 0x55b597fce346 in tk_getkeys /home/runner/work/neovim/neovim/src/nvim/tui/input.c:442:20\r\n= #4 0x55b597fcbf46 in tinput_timer_cb /home/runner/work/neovim/neovim/src/nvim/tui/input.c:485:3\r\n= #5 0x55b597163f7c in time_event /home/runner/work/neovim/neovim/src/nvim/event/time.c:44:3\r\n= #6 0x55b59714a45b in multiqueue_process_events /home/runner/work/neovim/neovim/src/nvim/event/multiqueue.c:149:7\r\n= #7 0x55b5968d0e2d in event_teardown /home/runner/work/neovim/neovim/src/nvim/main.c:161:3\r\n= #8 0x55b5968e731d in os_exit /home/runner/work/neovim/neovim/src/nvim/main.c:662:8\r\n= #9 0x55b5968eef77 in preserve_exit /home/runner/work/neovim/neovim/src/nvim/main.c:831:5\r\n= #10 0x55b597a0a43b in deadly_signal /home/runner/work/neovim/neovim/src/nvim/os/signal.c:178:3\r\n= #11 0x55b597a0a0d9 in on_signal /home/runner/work/neovim/neovim/src/nvim/os/signal.c:203:7\r\n= #12 0x55b59715bc05 in signal_event /home/runner/work/neovim/neovim/src/nvim/event/signal.c:44:3\r\n= #13 0x55b59714a45b in multiqueue_process_events /home/runner/work/neovim/neovim/src/nvim/event/multiqueue.c:149:7\r\n= #14 0x55b5968d0e2d in event_teardown /home/runner/work/neovim/neovim/src/nvim/main.c:161:3\r\n= #15 0x55b5968e731d in os_exit /home/runner/work/neovim/neovim/src/nvim/main.c:662:8\r\n= #16 0x55b597fc7b92 in tinput_done_event /home/runner/work/neovim/neovim/src/nvim/tui/input.c:185:3\r\n= #17 0x55b59714a45b in multiqueue_process_events /home/runner/work/neovim/neovim/src/nvim/event/multiqueue.c:149:7\r\n= #18 0x55b597143887 in loop_poll_events /home/runner/work/neovim/neovim/src/nvim/event/loop.c:86:3\r\n= #19 0x55b598046816 in ui_client_run /home/runner/work/neovim/neovim/src/nvim/ui_client.c:120:5\r\n= #20 0x55b5968d3076 in main /home/runner/work/neovim/neovim/src/nvim/main.c:389:5\r\n= #21 0x7f989cc29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16\r\n= #22 0x7f989cc29e3f in __libc_start_main csu/../csu/libc-start.c:392:3\r\n= #23 0x55b5967f7f24 in _start (/home/runner/work/neovim/neovim/build/bin/nvim+0xbeaf24) (BuildId: 5e742510816fa584a52d7165da0d3520aa9f8ed6)\r\n= \r\n= 0x51700000208d is located 141 bytes inside of 704-byte region [0x517000002000,0x5170000022c0)\r\n= freed by thread T0 here:\r\n= #0 0x55b596894026 in free (/home/runner/work/neovim/neovim/build/bin/nvim+0xc87026) (BuildId: 5e742510816fa584a52d7165da0d3520aa9f8ed6)\r\n= #1 0x55b5982e3409 in termkey_free /home/runner/work/neovim/neovim/src/termkey/termkey.c:477:3\r\n= #2 0x55b5982e34e8 in termkey_destroy /home/runner/work/neovim/neovim/src/termkey/termkey.c:485:3\r\n= #3 0x55b597fc6fb7 in tinput_destroy /home/runner/work/neovim/neovim/src/nvim/tui/input.c:168:3\r\n= #4 0x55b597fdb35d in tui_stop /home/runner/work/neovim/neovim/src/nvim/tui/tui.c:505:3\r\n= #5 0x55b59804685b in ui_client_stop /home/runner/work/neovim/neovim/src/nvim/ui_client.c:127:5\r\n= #6 0x55b5968e72ec in os_exit /home/runner/work/neovim/neovim/src/nvim/main.c:652:5\r\n= #7 0x55b597fc7b92 in tinput_done_event /home/runner/work/neovim/neovim/src/nvim/tui/input.c:185:3\r\n= #8 0x55b59714a45b in multiqueue_process_events /home/runner/work/neovim/neovim/src/nvim/event/multiqueue.c:149:7\r\n= #9 0x55b597143887 in loop_poll_events /home/runner/work/neovim/neovim/src/nvim/event/loop.c:86:3\r\n= #10 0x55b598046816 in ui_client_run /home/runner/work/neovim/neovim/src/nvim/ui_client.c:120:5\r\n= #11 0x55b5968d3076 in main /home/runner/work/neovim/neovim/src/nvim/main.c:389:5\r\n= #12 0x7f989cc29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16\r\n= \r\n= previously allocated by thread T0 here:\r\n= #0 0x55b5968942ce in malloc (/home/runner/work/neovim/neovim/build/bin/nvim+0xc872ce) (BuildId: 5e742510816fa584a52d7165da0d3520aa9f8ed6)\r\n= #1 0x55b5982dea5c in termkey_alloc /home/runner/work/neovim/neovim/src/termkey/termkey.c:280:17\r\n= #2 0x55b5982e2cab in termkey_new_abstract /home/runner/work/neovim/neovim/src/termkey/termkey.c:441:17\r\n= #3 0x55b597fc6322 in tinput_init /home/runner/work/neovim/neovim/src/nvim/tui/input.c:146:15\r\n= #4 0x55b597fd9935 in tui_start /home/runner/work/neovim/neovim/src/nvim/tui/tui.c:166:3\r\n= #5 0x55b598046693 in ui_client_run /home/runner/work/neovim/neovim/src/nvim/ui_client.c:114:3\r\n= #6 0x55b5968d3076 in main /home/runner/work/neovim/neovim/src/nvim/main.c:389:5\r\n= #7 0x7f989cc29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16\r\n```\r\n\r\nhttps://github.com/neovim/neovim/actions/runs/7116564210/job/19375282158?pr=26423\r\n\r\n", + "closed_at": "2023-12-06T23:35:53Z", + "comment_data": [], + "comments": 0, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26425/comments", + "created_at": "2023-12-06T15:48:09Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/26425/events", + "html_url": "https://github.com/neovim/neovim/issues/26425", + "id": 2028858126, + "labels": [ + { + "color": "f9d0c4", + "default": true, + "description": "issues reporting wrong behavior", + "id": 77997474, + "name": "bug", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3NA==", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug" + }, + { + "color": "c5def5", + "default": false, + "description": "", + "id": 110418643, + "name": "test", + "node_id": "MDU6TGFiZWwxMTA0MTg2NDM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/test" + }, + { + "color": "e6e6e6", + "default": false, + "description": "automation for build, test, and release", + "id": 212701006, + "name": "ci", + "node_id": "MDU6TGFiZWwyMTI3MDEwMDY=", + "url": "https://api.github.com/repos/neovim/neovim/labels/ci" + }, + { + "color": "F9D0C4", + "default": false, + "description": "issue reporting a crash or segfault", + "id": 435854234, + "name": "bug-crash", + "node_id": "MDU6TGFiZWw0MzU4NTQyMzQ=", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug-crash" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26425/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 201, + "created_at": "2023-02-02T14:11:43Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", + "events_url": "https://api.github.com/users/bfredl/events{/privacy}", + "followers_url": "https://api.github.com/users/bfredl/followers", + "following_url": "https://api.github.com/users/bfredl/following{/other_user}", + "gists_url": "https://api.github.com/users/bfredl/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/bfredl", + "id": 1363104, + "login": "bfredl", + "node_id": "MDQ6VXNlcjEzNjMxMDQ=", + "organizations_url": "https://api.github.com/users/bfredl/orgs", + "received_events_url": "https://api.github.com/users/bfredl/received_events", + "repos_url": "https://api.github.com/users/bfredl/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/bfredl/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/bfredl/subscriptions", + "type": "User", + "url": "https://api.github.com/users/bfredl" + }, + "description": "", + "due_on": "2024-03-01T08:00:00Z", + "html_url": "https://github.com/neovim/neovim/milestone/36", + "id": 8997654, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/36/labels", + "node_id": "MI_kwDOAPphoM4AiUsW", + "number": 36, + "open_issues": 128, + "state": "open", + "title": "0.10", + "updated_at": "2023-12-06T23:35:54Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/36" + }, + "node_id": "I_kwDOAPphoM547esO", + "number": 26425, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/26425/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "closed", + "state_reason": "completed", + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26425/timeline", + "title": "heap-use-after-free in event_teardown .. tk_getkeys", + "updated_at": "2023-12-06T23:35:54Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/26425", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/26427.json b/repositories/neovim/issues/26427.json new file mode 100644 index 00000000..14c0e298 --- /dev/null +++ b/repositories/neovim/issues/26427.json @@ -0,0 +1,125 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "### Problem\n\nWhen adding a new pack the helptags don't get automatically updated, having an autocommand event for this would be helpful, to execute something when a package is added, like refreshing file types so the plugin applies, or to update helptags.\n\n### Expected behavior\n\nEvents that we can address with autocommand, similar to VimEnter, or BufWritePost.", + "closed_at": "2023-12-06T16:53:41Z", + "comment_data": [ + { + "author_association": "MEMBER", + "body": "`OptionSet` is triggered when `:packadd` updates 'runtimepath':\r\n\r\n autocmd OptionSet runtimepath echom v:option_old v:option_new v:option_command\r\n packadd foo\r\n\r\nMore generally, I think most of Nvim core considers Vim packages to be unnecessary and we might even deprecate parts of it. So, unlikely that we would enhance it.", + "created_at": "2023-12-06T16:53:41Z", + "html_url": "https://github.com/neovim/neovim/issues/26427#issuecomment-1843285628", + "id": 1843285628, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26427", + "node_id": "IC_kwDOAPphoM5t3k58", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 1, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843285628/reactions" + }, + "updated_at": "2023-12-06T16:55:10Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843285628", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comments": 1, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26427/comments", + "created_at": "2023-12-06T16:48:07Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/26427/events", + "html_url": "https://github.com/neovim/neovim/issues/26427", + "id": 2028978437, + "labels": [ + { + "color": "c2e0c6", + "default": true, + "description": "feature request", + "id": 77997476, + "name": "enhancement", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==", + "url": "https://api.github.com/repos/neovim/neovim/labels/enhancement" + }, + { + "color": "c5def5", + "default": false, + "description": "plugins and Vim \"pack\"", + "id": 117905553, + "name": "plugin", + "node_id": "MDU6TGFiZWwxMTc5MDU1NTM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/plugin" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26427/labels{/name}", + "locked": false, + "milestone": null, + "node_id": "I_kwDOAPphoM5478EF", + "number": 26427, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/26427/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "closed", + "state_reason": "completed", + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26427/timeline", + "title": "autocommand for :packadd", + "updated_at": "2023-12-06T16:55:43Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/26427", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6476691?v=4", + "events_url": "https://api.github.com/users/ekiim/events{/privacy}", + "followers_url": "https://api.github.com/users/ekiim/followers", + "following_url": "https://api.github.com/users/ekiim/following{/other_user}", + "gists_url": "https://api.github.com/users/ekiim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ekiim", + "id": 6476691, + "login": "ekiim", + "node_id": "MDQ6VXNlcjY0NzY2OTE=", + "organizations_url": "https://api.github.com/users/ekiim/orgs", + "received_events_url": "https://api.github.com/users/ekiim/received_events", + "repos_url": "https://api.github.com/users/ekiim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ekiim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ekiim/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ekiim" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/26428.json b/repositories/neovim/issues/26428.json new file mode 100644 index 00000000..15f31828 --- /dev/null +++ b/repositories/neovim/issues/26428.json @@ -0,0 +1,424 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "### Problem\r\n\r\nI am often trying to determine the age of the nvim software on my systems to decide whether an old build could be the cause of a problem.\r\nThere's no great way to do this, currently.\r\n\r\n`nvim --version` gives me a build SHA1 which I can look up in the nvim git history, but this is a pain.\r\nWithin nvim, there is `:version` which gives the same information.\r\n\r\nNvim should include a build date in the version information to simplify this common task.\r\n\r\nThis would be especially valuable for people using the nvim packaged by their OS maintainers. These are typically very old, but since users only see a release number and SHA1, it is not obvious how old the software actually is.\r\n\r\n### Expected behavior\r\n\r\nInclude a build timestamp (or even just a date) in the version information.\r\n\r\nCurrent:\r\n```\r\n❯ nvim --version\r\nNVIM v0.10.0-dev-1896+g91f57723a-Homebrew\r\nBuild type: Release\r\nLuaJIT 2.1.1700008891\r\n\r\n system vimrc file: \"$VIM/sysinit.vim\"\r\n fall-back for $VIM: \"/opt/homebrew/Cellar/neovim/HEAD-91f5772/share/nvim\"\r\n\r\nRun :checkhealth for more info\r\n```\r\n\r\nExpected:\r\n```\r\n❯ nvim --version\r\nNVIM v0.10.0-dev-1896+g91f57723a-Homebrew\r\nBuild type: Release\r\nBuild time: 2023-12-06T17:59:17Z\r\nLuaJIT 2.1.1700008891\r\n\r\n system vimrc file: \"$VIM/sysinit.vim\"\r\n fall-back for $VIM: \"/opt/homebrew/Cellar/neovim/HEAD-91f5772/share/nvim\"\r\n\r\nRun :checkhealth for more info\r\n```\r\n\r\nWithin nvim, the `:version` command should also include the build timestamp", + "closed_at": "2023-12-06T18:07:00Z", + "comment_data": [ + { + "author_association": "MEMBER", + "body": "> nvim --version gives me a build SHA1 which I can look up in the nvim git history, but this is a pain.\r\n\r\nBut this is the single most useful information; just build date is not. Who cares whether you built an outdated commit ten minutes ago?\r\n\r\nConversely, if you (only) saw that the software was built a year ago, how would you know that it's not the latest version?", + "created_at": "2023-12-06T18:06:43Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843410484", + "id": 1843410484, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4DY0", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843410484/reactions" + }, + "updated_at": "2023-12-06T18:07:46Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843410484", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "MEMBER", + "body": "Including build date/time in the compiled output is an antipattern anyway, as this makes builds [non-reproducible](https://reproducible-builds.org).", + "created_at": "2023-12-06T18:11:54Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843420365", + "id": 1843420365, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4FzN", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843420365/reactions" + }, + "updated_at": "2023-12-06T18:11:54Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843420365", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } + }, + { + "author_association": "NONE", + "body": "Good point, the commit timestamp would be more useful than the build time.\r\nFor the appimage release builds or the debian builds, there is not much difference really, from a user perspective.\r\n\r\nThis is speaking purely as an nvim user. Nvim gets packaged and put out there as official appimage releases, as debian packages, brew packages, rpm packages. For a user who is not following nvim developing closely, the current version information is just not good enough to tell at a glance exactly how current the software is.", + "created_at": "2023-12-06T18:12:43Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843421813", + "id": 1843421813, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4GJ1", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843421813/reactions" + }, + "updated_at": "2023-12-06T18:14:20Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843421813", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4277142?v=4", + "events_url": "https://api.github.com/users/gongfarmer/events{/privacy}", + "followers_url": "https://api.github.com/users/gongfarmer/followers", + "following_url": "https://api.github.com/users/gongfarmer/following{/other_user}", + "gists_url": "https://api.github.com/users/gongfarmer/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gongfarmer", + "id": 4277142, + "login": "gongfarmer", + "node_id": "MDQ6VXNlcjQyNzcxNDI=", + "organizations_url": "https://api.github.com/users/gongfarmer/orgs", + "received_events_url": "https://api.github.com/users/gongfarmer/received_events", + "repos_url": "https://api.github.com/users/gongfarmer/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gongfarmer/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gongfarmer/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gongfarmer" + } + }, + { + "author_association": "MEMBER", + "body": "> the current version information\r\n\r\nI don't know what could be simpler, though -- just compare the version to the top of https://github.com/neovim/neovim/tags.\r\n\r\n(And we do not support distro nightly builds; nightly is for development and testing, and we want to find issues with _our_ code, not what some packager has done to it.)", + "created_at": "2023-12-06T18:15:07Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843426641", + "id": 1843426641, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4HVR", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843426641/reactions" + }, + "updated_at": "2023-12-06T18:15:07Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843426641", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "NONE", + "body": "There are a lot of users who are not developing nvim but have received the advice that \"nvim development moves fast, so you should use the nightlies for now:.\r\n\r\nThis is still relevant advice as far as I can tell. The plugin ecosystem is supporting features that are only in the nightlies for now, such as inlay hints.\r\n\r\nSo there is a large group of users who are on nightly builds but are NOT nvim devs or even terribly knowledgeable about nvim. I know this is personally true on my dev team.\r\n\r\nThe website that you linked is good for determining the binary information about whether the build I have is or is not the current nightly -- but this is very binary and is not what I am asking for.\r\n\r\nAs an nvim user, I want to know how old my software is -- not just if it is on the tip.\r\n\r\nCurrently on my Mac, I get this:\r\nNVIM v0.10.0-dev-1896+g91f57723a-Homebrew\r\n\r\nI have been using v0.10.0-dev builds all year, the rest is just random looking characters that don't give me any meaningful information about the age of the software -- unless I go `git pull` my local tracking branch of neovim and do `git log` to look up the history.\r\nIf there is a way to look up this specific commit on GitHub, I have never managed to find it , and many users would have no idea how to even look for that.\r\n\r\nSo is this build days old, weeks old or months old? That's what I want to know, and having to go to a website to look it up makes this too hard for many users that could really use this information.\r\n", + "created_at": "2023-12-06T18:23:45Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843441765", + "id": 1843441765, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4LBl", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843441765/reactions" + }, + "updated_at": "2023-12-06T18:23:45Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843441765", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4277142?v=4", + "events_url": "https://api.github.com/users/gongfarmer/events{/privacy}", + "followers_url": "https://api.github.com/users/gongfarmer/followers", + "following_url": "https://api.github.com/users/gongfarmer/following{/other_user}", + "gists_url": "https://api.github.com/users/gongfarmer/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gongfarmer", + "id": 4277142, + "login": "gongfarmer", + "node_id": "MDQ6VXNlcjQyNzcxNDI=", + "organizations_url": "https://api.github.com/users/gongfarmer/orgs", + "received_events_url": "https://api.github.com/users/gongfarmer/received_events", + "repos_url": "https://api.github.com/users/gongfarmer/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gongfarmer/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gongfarmer/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gongfarmer" + } + }, + { + "author_association": "MEMBER", + "body": ">There are a lot of users who are not developing nvim but have received the advice that \"nvim development moves fast, so you should use the nightlies for now:.\r\n\r\nThis is not good advice. **Nightlies are intended to be used by people interested in participating in the Neovim development process.**\r\n\r\nIf that does not describe you, please stick to a stable release.", + "created_at": "2023-12-06T18:28:48Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843451220", + "id": 1843451220, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4NVU", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843451220/reactions" + }, + "updated_at": "2023-12-06T18:28:48Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843451220", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } + }, + { + "author_association": "NONE", + "body": "Even if I stick with the packaged nvim version on my Ubuntu system, it is a development release.\r\nHelpfully, the debian packaged versions do include the compilation command, which includes timestamps that tell me how old the software is:\r\n\r\n```\r\n$ nvim --version\r\nNVIM v0.10.0-dev\r\nBuild type: RelWithDebInfo\r\nLuaJIT 2.1.0-beta3\r\nCompilation: /usr/bin/cc -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wvla -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -fno-common -Wno-unused-result -Wimplicit-fallthrough -fdiagnostics-color=auto -fstack-protector-strong -DUNIT_TESTING -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -I/usr/include/luajit-2.1 -I/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/.deps/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/build/src/nvim/auto -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/build/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/build/cmake.config -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/src -I/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/.deps/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/.deps/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/.deps/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/.deps/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/.deps/usr/include -I/build/neovim-AMRFck/neovim-0.10.0~ubuntu1+git202304222018-1cb46abff-9b397864c/.deps/usr/include\r\n\r\n system vimrc file: \"$VIM/sysinit.vim\"\r\n fall-back for $VIM: \"/usr/share/nvim\"\r\n\r\nRun :checkhealth for more info\r\n```", + "created_at": "2023-12-06T18:36:45Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843465645", + "id": 1843465645, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4Q2t", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843465645/reactions" + }, + "updated_at": "2023-12-06T18:36:45Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843465645", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4277142?v=4", + "events_url": "https://api.github.com/users/gongfarmer/events{/privacy}", + "followers_url": "https://api.github.com/users/gongfarmer/followers", + "following_url": "https://api.github.com/users/gongfarmer/following{/other_user}", + "gists_url": "https://api.github.com/users/gongfarmer/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gongfarmer", + "id": 4277142, + "login": "gongfarmer", + "node_id": "MDQ6VXNlcjQyNzcxNDI=", + "organizations_url": "https://api.github.com/users/gongfarmer/orgs", + "received_events_url": "https://api.github.com/users/gongfarmer/received_events", + "repos_url": "https://api.github.com/users/gongfarmer/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gongfarmer/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gongfarmer/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gongfarmer" + } + }, + { + "author_association": "MEMBER", + "body": "> Even if I stick with the packaged nvim version on my Ubuntu system, it is a development release.\r\n\r\nNo it is not! It is outdated, unfortunately (but that is actively being worked on by the maintainer). If that's the issue, use a (stable!) PPA, or download an appimage from Github.\r\n\r\nIf you don't know your way around git DO NOT USE NIGHTLY BUILDS, period. If you do, the information we show is meaningful (and in fact the only meaningful information). Nightlies are meant for testing and helping find and fix errors, not for production use. \r\n\r\nTo be clear:\r\n\r\n> but have received the advice that \"nvim development moves fast, so you should use the nightlies for now\r\n\r\nI do not know where you got the advice from, but it is not _our_ advice -- quite the opposite. Feel free to point these people to this issue.\r\n", + "created_at": "2023-12-06T18:42:20Z", + "html_url": "https://github.com/neovim/neovim/issues/26428#issuecomment-1843482511", + "id": 1843482511, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "node_id": "IC_kwDOAPphoM5t4U-P", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843482511/reactions" + }, + "updated_at": "2023-12-06T18:42:20Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843482511", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + } + ], + "comments": 8, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26428/comments", + "created_at": "2023-12-06T18:04:07Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/26428/events", + "html_url": "https://github.com/neovim/neovim/issues/26428", + "id": 2029111449, + "labels": [ + { + "color": "c2e0c6", + "default": true, + "description": "feature request", + "id": 77997476, + "name": "enhancement", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==", + "url": "https://api.github.com/repos/neovim/neovim/labels/enhancement" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26428/labels{/name}", + "locked": false, + "milestone": null, + "node_id": "I_kwDOAPphoM548ciZ", + "number": 26428, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/26428/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "closed", + "state_reason": "not_planned", + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26428/timeline", + "title": "nvim should tell me how old it is", + "updated_at": "2023-12-06T18:42:32Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/26428", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4277142?v=4", + "events_url": "https://api.github.com/users/gongfarmer/events{/privacy}", + "followers_url": "https://api.github.com/users/gongfarmer/followers", + "following_url": "https://api.github.com/users/gongfarmer/following{/other_user}", + "gists_url": "https://api.github.com/users/gongfarmer/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gongfarmer", + "id": 4277142, + "login": "gongfarmer", + "node_id": "MDQ6VXNlcjQyNzcxNDI=", + "organizations_url": "https://api.github.com/users/gongfarmer/orgs", + "received_events_url": "https://api.github.com/users/gongfarmer/received_events", + "repos_url": "https://api.github.com/users/gongfarmer/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gongfarmer/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gongfarmer/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gongfarmer" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/26432.json b/repositories/neovim/issues/26432.json new file mode 100644 index 00000000..f5493469 --- /dev/null +++ b/repositories/neovim/issues/26432.json @@ -0,0 +1,214 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "body": "### Problem\r\n\r\nGo to any failed unittest CI job and notice the `Output to stderr` part of the logs. It shows some build warnings:\r\n\r\n- `tmp_pseudoheader.h:4:10: fatal error: './src/nvim/types.h' file not found`\r\n- `warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined`\r\n\r\n```\r\n2023-12-06T16:38:02.9039230Z -- Output to stderr:\r\n2023-12-06T16:38:02.9040030Z tmp_pseudoheader.h:4:10: fatal error: './src/nvim/types.h' file not found\r\n2023-12-06T16:38:02.9040690Z #include \"./src/nvim/types.h\"\r\n2023-12-06T16:38:02.9041220Z ^~~~~~~~~~~~~~~~~~~~\r\n2023-12-06T16:38:02.9041570Z 1 error generated.\r\n2023-12-06T16:38:02.9042240Z tmp_pseudoheader.h:4:10: fatal error: './src/nvim/types.h' file not found\r\n2023-12-06T16:38:02.9042860Z #include \"./src/nvim/types.h\"\r\n2023-12-06T16:38:02.9043230Z ^~~~~~~~~~~~~~~~~~~~\r\n2023-12-06T16:38:02.9043580Z 1 error generated.\r\n2023-12-06T16:38:02.9043960Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9044530Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9045540Z CMake Error at /Users/runner/work/neovim/neovim/cmake/RunTests.cmake:107 (message):\r\n2023-12-06T16:38:02.9046270Z unit tests failed with error: 1\r\n2023-12-06T16:38:02.9046650Z \r\n2023-12-06T16:38:02.9046650Z \r\n2023-12-06T16:38:02.9047080Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9048020Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9049140Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9050070Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9050980Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9052460Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9053520Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9053930Z ^\r\n2023-12-06T16:38:02.9054350Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9055540Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9056400Z ^\r\n```\r\n\r\n
\r\nmore logs...\r\n\r\n```\r\n2023-12-06T16:38:02.9056740Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9057300Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9058030Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9059180Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9060130Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9061060Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9061980Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9063450Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9065060Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9065440Z ^\r\n2023-12-06T16:38:02.9065990Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9066730Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9067280Z ^\r\n2023-12-06T16:38:02.9067550Z 2 warnings generated.\r\n2023-12-06T16:38:02.9067950Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9068500Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9069230Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9070150Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9071440Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9072440Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9073360Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9075020Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9076190Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9076640Z ^\r\n2023-12-06T16:38:02.9077060Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9086740Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9087690Z ^\r\n2023-12-06T16:38:02.9088050Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9088610Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9089360Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9090470Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9091430Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9092380Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9093290Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9094970Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9096020Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9096400Z ^\r\n2023-12-06T16:38:02.9096970Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9097680Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9098220Z ^\r\n2023-12-06T16:38:02.9098500Z 2 warnings generated.\r\n2023-12-06T16:38:02.9098860Z E94: No matching buffer for _test_\r\n2023-12-06T16:38:02.9099270Z E94: No matching buffer for _test_\r\n2023-12-06T16:38:02.9100100Z E94: No matching buffer for _test_E94: No matching buffer for testIn file included from tmp_pseudoheader.h:6915:\r\n2023-12-06T16:38:02.9101410Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9102180Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9103140Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9104090Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9105000Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9106540Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9107610Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9108000Z ^\r\n2023-12-06T16:38:02.9108430Z tmp_pseudoheader.h:3337:9: note: previous definition is here\r\n2023-12-06T16:38:02.9110160Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9111030Z ^\r\n2023-12-06T16:38:02.9111370Z In file included from tmp_pseudoheader.h:6915:\r\n2023-12-06T16:38:02.9111900Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9112640Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9113600Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9114520Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9115430Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9117190Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9118290Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9118690Z ^\r\n2023-12-06T16:38:02.9119090Z tmp_pseudoheader.h:3336:9: note: previous definition is here\r\n2023-12-06T16:38:02.9119780Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9120330Z ^\r\n2023-12-06T16:38:02.9120610Z 2 warnings generated.\r\n2023-12-06T16:38:02.9121010Z In file included from tmp_pseudoheader.h:6915:\r\n2023-12-06T16:38:02.9121530Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9122270Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9123220Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9124250Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9125180Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9126660Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9127720Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9128100Z ^\r\n2023-12-06T16:38:02.9128520Z tmp_pseudoheader.h:3337:9: note: previous definition is here\r\n2023-12-06T16:38:02.9129700Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9130570Z ^\r\n2023-12-06T16:38:02.9130910Z In file included from tmp_pseudoheader.h:6915:\r\n2023-12-06T16:38:02.9131440Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9132180Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9133130Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9134090Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9135010Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9136440Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9137490Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9137860Z ^\r\n2023-12-06T16:38:02.9138280Z tmp_pseudoheader.h:3336:9: note: previous definition is here\r\n2023-12-06T16:38:02.9139100Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9139660Z ^\r\n2023-12-06T16:38:02.9139940Z 2 warnings generated.\r\n2023-12-06T16:38:02.9140330Z In file included from tmp_pseudoheader.h:7069:\r\n2023-12-06T16:38:02.9140870Z In file included from ././src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9141610Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9142570Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9143500Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9144930Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9146410Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9147460Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9147850Z ^\r\n2023-12-06T16:38:02.9148250Z tmp_pseudoheader.h:3459:9: note: previous definition is here\r\n2023-12-06T16:38:02.9149430Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9150300Z ^\r\n2023-12-06T16:38:02.9150640Z In file included from tmp_pseudoheader.h:7069:\r\n2023-12-06T16:38:02.9151180Z In file included from ././src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9152260Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9153270Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9154320Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9155240Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9156700Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9157740Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9158120Z ^\r\n2023-12-06T16:38:02.9158520Z tmp_pseudoheader.h:3458:9: note: previous definition is here\r\n2023-12-06T16:38:02.9159220Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9159780Z ^\r\n2023-12-06T16:38:02.9160050Z 2 warnings generated.\r\n2023-12-06T16:38:02.9160450Z In file included from tmp_pseudoheader.h:7069:\r\n2023-12-06T16:38:02.9160990Z In file included from ././src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9161730Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9162690Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9163630Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9164550Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9166060Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9167110Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9167500Z ^\r\n2023-12-06T16:38:02.9167910Z tmp_pseudoheader.h:3459:9: note: previous definition is here\r\n2023-12-06T16:38:02.9169090Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9169950Z ^\r\n2023-12-06T16:38:02.9170300Z In file included from tmp_pseudoheader.h:7069:\r\n2023-12-06T16:38:02.9170850Z In file included from ././src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9171600Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9172550Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9173500Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9174410Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9175850Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9176890Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9177250Z ^\r\n2023-12-06T16:38:02.9177670Z tmp_pseudoheader.h:3458:9: note: previous definition is here\r\n2023-12-06T16:38:02.9178390Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9178940Z ^\r\n2023-12-06T16:38:02.9179210Z 2 warnings generated.\r\n2023-12-06T16:38:02.9179550Z E474: No container to close: ]\r\n2023-12-06T16:38:02.9180460Z E474: Closing list with curly bracket: }\r\n2023-12-06T16:38:02.9180960Z E474: Closing dictionary with square bracket: ]\r\n2023-12-06T16:38:02.9181440Z E474: Trailing comma: ]\r\n2023-12-06T16:38:02.9181790Z E474: Expected value after colon: }\r\n2023-12-06T16:38:02.9182200Z E474: Expected value: }\r\n2023-12-06T16:38:02.9182550Z E474: Comma not inside container: ,\r\n2023-12-06T16:38:02.9182970Z E474: Duplicate comma: ,1]\r\n2023-12-06T16:38:02.9183330Z E474: Comma after colon: ,}\r\n2023-12-06T16:38:02.9183720Z E474: Using comma in place of colon: ,}\r\n2023-12-06T16:38:02.9184370Z E474: Leading comma: ,}\r\n2023-12-06T16:38:02.9184720Z E474: Leading comma: ,]\r\n2023-12-06T16:38:02.9185080Z E474: Colon not inside container: :\r\n2023-12-06T16:38:02.9185510Z E474: Using colon not in dictionary: :]\r\n2023-12-06T16:38:02.9185940Z E474: Unexpected colon: :}\r\n2023-12-06T16:38:02.9186720Z E474: Duplicate colon: :1}\r\n2023-12-06T16:38:02.9187140Z E474: Expected null: n\r\n2023-12-06T16:38:02.9187470Z E474: Expected true: t\r\n2023-12-06T16:38:02.9187810Z E474: Expected false: f\r\n2023-12-06T16:38:02.9188180Z E474: Unfinished escape sequence: \"\\\r\n2023-12-06T16:38:02.9188640Z E474: Unfinished unicode escape sequence: \"\\u\"\r\n2023-12-06T16:38:02.9189180Z E474: Expected four hex digits after \\u: \\uXXXX\"\r\n2023-12-06T16:38:02.9189670Z E474: Unknown escape sequence: \\?\"\r\n2023-12-06T16:38:02.9190240Z E474: ASCII control characters cannot be present inside string: ^I\"\r\n2023-12-06T16:38:02.9191040Z E474: Only UTF-8 strings allowed: \"\r\n2023-12-06T16:38:02.9191920Z E474: Only UTF-8 code points up to U+10FFFF are allowed to appear unescaped: ������\"\r\n2023-12-06T16:38:02.9192630Z E474: Expected string end: \"\r\n2023-12-06T16:38:02.9193030Z E474: Missing number after minus sign: -\r\n2023-12-06T16:38:02.9193600Z E474: Missing number after decimal dot: -1.\r\n2023-12-06T16:38:02.9194250Z E474: Missing exponent: -1.0e\r\n2023-12-06T16:38:02.9194650Z E474: Unidentified byte: ?\r\n2023-12-06T16:38:02.9195010Z E474: Trailing characters: ?\r\n2023-12-06T16:38:02.9196030Z E474: Unexpected end of input: [1E474: Missing number after minus sign: -In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9196990Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9197720Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9198630Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9200560Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9201540Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9203070Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9205960Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9207080Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9207460Z ^\r\n2023-12-06T16:38:02.9207900Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9209150Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9210020Z ^\r\n2023-12-06T16:38:02.9210360Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9210910Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9211650Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9212570Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9213530Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9214460Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9215370Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9217300Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9218350Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9218730Z ^\r\n2023-12-06T16:38:02.9219150Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9219840Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9220390Z ^\r\n2023-12-06T16:38:02.9220660Z 2 warnings generated.\r\n2023-12-06T16:38:02.9221060Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9221620Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9222340Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9223260Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9224650Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9225670Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9226580Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9228070Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9229130Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9229520Z ^\r\n2023-12-06T16:38:02.9229920Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9231100Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9231970Z ^\r\n2023-12-06T16:38:02.9232310Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9232880Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9233600Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9234530Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9235480Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9236420Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9237330Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9238770Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9239800Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9240180Z ^\r\n2023-12-06T16:38:02.9240590Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9241290Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9241850Z ^\r\n2023-12-06T16:38:02.9242120Z 2 warnings generated.\r\n2023-12-06T16:38:02.9242520Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9243090Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9243810Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9244730Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9245670Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9246610Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9247530Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9248980Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9250040Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9250430Z ^\r\n2023-12-06T16:38:02.9250830Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9252470Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9253340Z ^\r\n2023-12-06T16:38:02.9253680Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9254330Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9255070Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9255980Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9256920Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9257870Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9258770Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9260540Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9261650Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9262030Z ^\r\n2023-12-06T16:38:02.9262440Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9263140Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9263690Z ^\r\n2023-12-06T16:38:02.9263950Z 2 warnings generated.\r\n2023-12-06T16:38:02.9264350Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9264910Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9265640Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9266550Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9267500Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9268440Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9269360Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9271420Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9272580Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9272980Z ^\r\n2023-12-06T16:38:02.9273390Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9274640Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9275510Z ^\r\n2023-12-06T16:38:02.9275850Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9276410Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9277150Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9278070Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9279030Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9279980Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9280890Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9282330Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9283380Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9283750Z ^\r\n2023-12-06T16:38:02.9284170Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9284860Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9285410Z ^\r\n2023-12-06T16:38:02.9285690Z 2 warnings generated.\r\n2023-12-06T16:38:02.9286090Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9286650Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9287870Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9288790Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9289730Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9290660Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9291580Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9293060Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9294220Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9294870Z ^\r\n2023-12-06T16:38:02.9295420Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9297310Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9298390Z ^\r\n2023-12-06T16:38:02.9298860Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9299780Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9307840Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9308830Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9309790Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9310730Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9311640Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9313140Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9314190Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9314560Z ^\r\n2023-12-06T16:38:02.9314980Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9315680Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9316220Z ^\r\n2023-12-06T16:38:02.9316500Z 2 warnings generated.\r\n2023-12-06T16:38:02.9316890Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9317450Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9318180Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9319090Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9320040Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9320980Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9321880Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9323340Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9324500Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9324890Z ^\r\n2023-12-06T16:38:02.9325310Z tmp_pseudoheader.h:3615:9: note: previous definition is here\r\n2023-12-06T16:38:02.9326490Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9327350Z ^\r\n2023-12-06T16:38:02.9327690Z In file included from tmp_pseudoheader.h:7211:\r\n2023-12-06T16:38:02.9328240Z In file included from ././src/nvim/eval/typval.h:17:\r\n2023-12-06T16:38:02.9328970Z In file included from /Users/runner/work/neovim/neovim/src/nvim/message.h:10:\r\n2023-12-06T16:38:02.9329890Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9330830Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9332330Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9333240Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9334700Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9335740Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9336110Z ^\r\n2023-12-06T16:38:02.9336520Z tmp_pseudoheader.h:3614:9: note: previous definition is here\r\n2023-12-06T16:38:02.9337220Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9337770Z ^\r\n2023-12-06T16:38:02.9338040Z 2 warnings generated.\r\n2023-12-06T16:38:02.9338430Z In file included from tmp_pseudoheader.h:6883:\r\n2023-12-06T16:38:02.9338950Z In file included from ././src/nvim/eval.h:7:\r\n2023-12-06T16:38:02.9340000Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9340980Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9342450Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9343500Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9343880Z ^\r\n2023-12-06T16:38:02.9344290Z tmp_pseudoheader.h:3317:9: note: previous definition is here\r\n2023-12-06T16:38:02.9345470Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9346330Z ^\r\n2023-12-06T16:38:02.9346670Z In file included from tmp_pseudoheader.h:6883:\r\n2023-12-06T16:38:02.9347190Z In file included from ././src/nvim/eval.h:7:\r\n2023-12-06T16:38:02.9347910Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9348830Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9350260Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9351310Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9351680Z ^\r\n2023-12-06T16:38:02.9352090Z tmp_pseudoheader.h:3316:9: note: previous definition is here\r\n2023-12-06T16:38:02.9352780Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9353330Z ^\r\n2023-12-06T16:38:02.9353600Z 2 warnings generated.\r\n2023-12-06T16:38:02.9354000Z In file included from tmp_pseudoheader.h:6883:\r\n2023-12-06T16:38:02.9354620Z In file included from ././src/nvim/eval.h:7:\r\n2023-12-06T16:38:02.9355340Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9356250Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9357720Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9358780Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9359150Z ^\r\n2023-12-06T16:38:02.9359570Z tmp_pseudoheader.h:3317:9: note: previous definition is here\r\n2023-12-06T16:38:02.9360740Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9361600Z ^\r\n2023-12-06T16:38:02.9361940Z In file included from tmp_pseudoheader.h:6883:\r\n2023-12-06T16:38:02.9362460Z In file included from ././src/nvim/eval.h:7:\r\n2023-12-06T16:38:02.9363170Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9364090Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9365520Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9366560Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9366930Z ^\r\n2023-12-06T16:38:02.9367770Z tmp_pseudoheader.h:3316:9: note: previous definition is here\r\n2023-12-06T16:38:02.9368470Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9369020Z ^\r\n2023-12-06T16:38:02.9369290Z 2 warnings generated.\r\n2023-12-06T16:38:02.9369690Z In file included from tmp_pseudoheader.h:7287:\r\n2023-12-06T16:38:02.9370260Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9371000Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9371950Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9372890Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9373790Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9375580Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9376700Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9377090Z ^\r\n2023-12-06T16:38:02.9377500Z tmp_pseudoheader.h:3647:9: note: previous definition is here\r\n2023-12-06T16:38:02.9378700Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9379570Z ^\r\n2023-12-06T16:38:02.9379910Z In file included from tmp_pseudoheader.h:7287:\r\n2023-12-06T16:38:02.9380440Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9381180Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9382130Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9383070Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9383980Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9385510Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9386550Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9386930Z ^\r\n2023-12-06T16:38:02.9387340Z tmp_pseudoheader.h:3646:9: note: previous definition is here\r\n2023-12-06T16:38:02.9388040Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9388590Z ^\r\n2023-12-06T16:38:02.9388860Z 2 warnings generated.\r\n2023-12-06T16:38:02.9389260Z In file included from tmp_pseudoheader.h:7287:\r\n2023-12-06T16:38:02.9389790Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9390520Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9391470Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9392420Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9393340Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9394860Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9395920Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9396300Z ^\r\n2023-12-06T16:38:02.9396700Z tmp_pseudoheader.h:3647:9: note: previous definition is here\r\n2023-12-06T16:38:02.9397890Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9398750Z ^\r\n2023-12-06T16:38:02.9399090Z In file included from tmp_pseudoheader.h:7287:\r\n2023-12-06T16:38:02.9399800Z In file included from ././src/nvim/globals.h:9:\r\n2023-12-06T16:38:02.9400560Z In file included from /Users/runner/work/neovim/neovim/src/nvim/ex_cmds_defs.h:10:\r\n2023-12-06T16:38:02.9401510Z In file included from /Users/runner/work/neovim/neovim/src/nvim/regexp_defs.h:84:\r\n2023-12-06T16:38:02.9403210Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9404120Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9405580Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9406620Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9406990Z ^\r\n2023-12-06T16:38:02.9407400Z tmp_pseudoheader.h:3646:9: note: previous definition is here\r\n2023-12-06T16:38:02.9408090Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9408640Z ^\r\n2023-12-06T16:38:02.9408910Z 2 warnings generated.\r\n\r\n[...snipped...]\r\n\r\n2023-12-06T16:38:02.9455750Z In file included from ././src/nvim/grid.h:7:\r\n2023-12-06T16:38:02.9456470Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9457390Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9458930Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9460000Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9460390Z ^\r\n2023-12-06T16:38:02.9460800Z tmp_pseudoheader.h:3251:9: note: previous definition is here\r\n2023-12-06T16:38:02.9461980Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9462840Z ^\r\n2023-12-06T16:38:02.9463180Z In file included from tmp_pseudoheader.h:6769:\r\n2023-12-06T16:38:02.9463710Z In file included from ././src/nvim/grid.h:7:\r\n2023-12-06T16:38:02.9464410Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9465330Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9466760Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9468230Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9468610Z ^\r\n2023-12-06T16:38:02.9469020Z tmp_pseudoheader.h:3250:9: note: previous definition is here\r\n2023-12-06T16:38:02.9469700Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9470250Z ^\r\n2023-12-06T16:38:02.9470520Z 2 warnings generated.\r\n2023-12-06T16:38:02.9470930Z In file included from tmp_pseudoheader.h:6769:\r\n2023-12-06T16:38:02.9471450Z In file included from ././src/nvim/grid.h:7:\r\n2023-12-06T16:38:02.9472160Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9473070Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9474550Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9475920Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9476370Z ^\r\n2023-12-06T16:38:02.9476770Z tmp_pseudoheader.h:3251:9: note: previous definition is here\r\n2023-12-06T16:38:02.9477980Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9478840Z ^\r\n2023-12-06T16:38:02.9479180Z In file included from tmp_pseudoheader.h:6769:\r\n2023-12-06T16:38:02.9479700Z In file included from ././src/nvim/grid.h:7:\r\n2023-12-06T16:38:02.9480410Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9481320Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9482760Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9483800Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9484250Z ^\r\n2023-12-06T16:38:02.9484690Z tmp_pseudoheader.h:3250:9: note: previous definition is here\r\n2023-12-06T16:38:02.9485370Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9485930Z ^\r\n2023-12-06T16:38:02.9486200Z 2 warnings generated.\r\n2023-12-06T16:38:02.9486530Z ERROR in finalizer: ?\r\n2023-12-06T16:38:02.9486870Z ERROR in finalizer: ?\r\n2023-12-06T16:38:02.9487730Z E685: Internal error: os_setenv_append_path()E116: Invalid arguments for function expandIn file included from tmp_pseudoheader.h:6751:\r\n2023-12-06T16:38:02.9488740Z In file included from ././src/nvim/fileio.h:7:\r\n2023-12-06T16:38:02.9489470Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9490380Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9491850Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9492910Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9493290Z ^\r\n2023-12-06T16:38:02.9493700Z tmp_pseudoheader.h:3239:9: note: previous definition is here\r\n2023-12-06T16:38:02.9494990Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9495850Z ^\r\n2023-12-06T16:38:02.9496190Z In file included from tmp_pseudoheader.h:6751:\r\n2023-12-06T16:38:02.9496710Z In file included from ././src/nvim/fileio.h:7:\r\n2023-12-06T16:38:02.9497440Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9498360Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9499950Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9501010Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9501390Z ^\r\n2023-12-06T16:38:02.9501790Z tmp_pseudoheader.h:3238:9: note: previous definition is here\r\n2023-12-06T16:38:02.9502490Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9503480Z ^\r\n2023-12-06T16:38:02.9503750Z 2 warnings generated.\r\n2023-12-06T16:38:02.9504150Z In file included from tmp_pseudoheader.h:6751:\r\n2023-12-06T16:38:02.9504670Z In file included from ././src/nvim/fileio.h:7:\r\n2023-12-06T16:38:02.9505400Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9506600Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9515840Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:49:9: warning: 'STATIC_ASSERT_PRAGMA_START' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9516920Z #define STATIC_ASSERT_PRAGMA_START\r\n2023-12-06T16:38:02.9517300Z ^\r\n2023-12-06T16:38:02.9517720Z tmp_pseudoheader.h:3239:9: note: previous definition is here\r\n2023-12-06T16:38:02.9519280Z #define STATIC_ASSERT_PRAGMA_START _Pragma(\"clang diagnostic push\") _Pragma(\"clang diagnostic ignored \\\"-Wc11-extensions\\\"\")\r\n2023-12-06T16:38:02.9520210Z ^\r\n2023-12-06T16:38:02.9520570Z In file included from tmp_pseudoheader.h:6751:\r\n2023-12-06T16:38:02.9521090Z In file included from ././src/nvim/fileio.h:7:\r\n2023-12-06T16:38:02.9521820Z In file included from /Users/runner/work/neovim/neovim/src/nvim/buffer_defs.h:26:\r\n2023-12-06T16:38:02.9522730Z In file included from /Users/runner/work/neovim/neovim/src/nvim/map_defs.h:8:\r\n2023-12-06T16:38:02.9524270Z /Users/runner/work/neovim/neovim/src/nvim/assert_defs.h:50:9: warning: 'STATIC_ASSERT_PRAGMA_END' macro redefined [-Wmacro-redefined]\r\n2023-12-06T16:38:02.9525330Z #define STATIC_ASSERT_PRAGMA_END\r\n2023-12-06T16:38:02.9525700Z ^\r\n2023-12-06T16:38:02.9526110Z tmp_pseudoheader.h:3238:9: note: previous definition is here\r\n2023-12-06T16:38:02.9526800Z #define STATIC_ASSERT_PRAGMA_END _Pragma(\"clang diagnostic pop\")\r\n2023-12-06T16:38:02.9527350Z ^\r\n2023-12-06T16:38:02.9527630Z 2 warnings generated.\r\n2023-12-06T16:38:02.9527990Z E5113: Error while calling lua chunk: \r\n2023-12-06T16:38:02.9528290Z \r\n\r\n```\r\n
\r\n\r\n### Expected behavior\r\n\r\nno build warnings", + "closed_at": null, + "comment_data": [ + { + "author_association": "MEMBER", + "body": "This showed up after we replaced header guards with pragma once", + "created_at": "2023-12-06T23:56:09Z", + "html_url": "https://github.com/neovim/neovim/issues/26432#issuecomment-1843883740", + "id": 1843883740, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26432", + "node_id": "IC_kwDOAPphoM5t527c", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843883740/reactions" + }, + "updated_at": "2023-12-06T23:56:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843883740", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", + "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", + "followers_url": "https://api.github.com/users/dundargoc/followers", + "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", + "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/dundargoc", + "id": 33953936, + "login": "dundargoc", + "node_id": "MDQ6VXNlcjMzOTUzOTM2", + "organizations_url": "https://api.github.com/users/dundargoc/orgs", + "received_events_url": "https://api.github.com/users/dundargoc/received_events", + "repos_url": "https://api.github.com/users/dundargoc/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", + "type": "User", + "url": "https://api.github.com/users/dundargoc" + } + }, + { + "author_association": "MEMBER", + "body": "maybe `test/unit/preprocess.lua` needs an adjustment?", + "created_at": "2023-12-07T00:10:16Z", + "html_url": "https://github.com/neovim/neovim/issues/26432#issuecomment-1843914852", + "id": 1843914852, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26432", + "node_id": "IC_kwDOAPphoM5t5-hk", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843914852/reactions" + }, + "updated_at": "2023-12-07T00:10:16Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843914852", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comments": 2, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26432/comments", + "created_at": "2023-12-06T21:41:31Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/26432/events", + "html_url": "https://github.com/neovim/neovim/issues/26432", + "id": 2029431374, + "labels": [ + { + "color": "c2e0c6", + "default": true, + "description": "feature request", + "id": 77997476, + "name": "enhancement", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==", + "url": "https://api.github.com/repos/neovim/neovim/labels/enhancement" + }, + { + "color": "c5def5", + "default": false, + "description": "building and installing Neovim using the provided scripts", + "id": 84723321, + "name": "build", + "node_id": "MDU6TGFiZWw4NDcyMzMyMQ==", + "url": "https://api.github.com/repos/neovim/neovim/labels/build" + }, + { + "color": "c5def5", + "default": false, + "description": "", + "id": 110418643, + "name": "test", + "node_id": "MDU6TGFiZWwxMTA0MTg2NDM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/test" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/26432/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 592, + "created_at": "2014-05-10T20:43:04Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "Low priority. Not planned for the current target, may be reassigned.", + "due_on": null, + "html_url": "https://github.com/neovim/neovim/milestone/6", + "id": 655037, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", + "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", + "number": 6, + "open_issues": 427, + "state": "open", + "title": "backlog", + "updated_at": "2023-12-06T23:16:41Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/6" + }, + "node_id": "I_kwDOAPphoM549qpO", + "number": 26432, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/26432/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/26432/timeline", + "title": "build: \"types.h not found\", \"'STATIC_ASSERT_PRAGMA_END' macro redefined\" in unittest stderr", + "updated_at": "2023-12-07T00:10:18Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/26432", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/3344.json b/repositories/neovim/issues/3344.json index 7dd7ce6d..0e6bbf7a 100644 --- a/repositories/neovim/issues/3344.json +++ b/repositories/neovim/issues/3344.json @@ -936,7 +936,7 @@ "node_id": "IC_kwDOAPphoM5tqy2n", "performed_via_github_app": null, "reactions": { - "+1": 0, + "+1": 1, "-1": 0, "confused": 0, "eyes": 0, @@ -944,7 +944,7 @@ "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 0, + "total_count": 1, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1839934887/reactions" }, "updated_at": "2023-12-05T03:20:28Z", @@ -969,9 +969,53 @@ "type": "User", "url": "https://api.github.com/users/majutsushi" } + }, + { + "author_association": "NONE", + "body": "@majutsushi Thank you for the tip. But, I ended up using [smart-yank](https://github.com/ibhagwan/smartyank.nvim) with 0.9.4 since 0.10 is still too unstable for me.", + "created_at": "2023-12-06T17:46:02Z", + "html_url": "https://github.com/neovim/neovim/issues/3344#issuecomment-1843375539", + "id": 1843375539, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/3344", + "node_id": "IC_kwDOAPphoM5t362z", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843375539/reactions" + }, + "updated_at": "2023-12-06T17:46:02Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843375539", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/14161807?v=4", + "events_url": "https://api.github.com/users/schiegl/events{/privacy}", + "followers_url": "https://api.github.com/users/schiegl/followers", + "following_url": "https://api.github.com/users/schiegl/following{/other_user}", + "gists_url": "https://api.github.com/users/schiegl/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/schiegl", + "id": 14161807, + "login": "schiegl", + "node_id": "MDQ6VXNlcjE0MTYxODA3", + "organizations_url": "https://api.github.com/users/schiegl/orgs", + "received_events_url": "https://api.github.com/users/schiegl/received_events", + "repos_url": "https://api.github.com/users/schiegl/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/schiegl/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/schiegl/subscriptions", + "type": "User", + "url": "https://api.github.com/users/schiegl" + } } ], - "comments": 21, + "comments": 22, "comments_url": "https://api.github.com/repos/neovim/neovim/issues/3344/comments", "created_at": "2015-09-15T12:49:41Z", "events_url": "https://api.github.com/repos/neovim/neovim/issues/3344/events", @@ -1019,7 +1063,7 @@ "locked": false, "milestone": { "closed_at": null, - "closed_issues": 199, + "closed_issues": 201, "created_at": "2023-02-02T14:11:43Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", @@ -1051,7 +1095,7 @@ "open_issues": 128, "state": "open", "title": "0.10", - "updated_at": "2023-12-05T23:23:32Z", + "updated_at": "2023-12-06T23:35:54Z", "url": "https://api.github.com/repos/neovim/neovim/milestones/36" }, "node_id": "MDU6SXNzdWUxMDY1NDg1NzE=", @@ -1074,7 +1118,7 @@ "state_reason": "completed", "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/3344/timeline", "title": "TUI: use OSC 52 for copy/paste", - "updated_at": "2023-12-05T13:07:50Z", + "updated_at": "2023-12-06T17:46:03Z", "url": "https://api.github.com/repos/neovim/neovim/issues/3344", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", diff --git a/repositories/neovim/issues/4454.json b/repositories/neovim/issues/4454.json new file mode 100644 index 00000000..d9f82587 --- /dev/null +++ b/repositories/neovim/issues/4454.json @@ -0,0 +1,460 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "Currently we can align text to the left or right hand side of the statusline and tagline by using the `%=` delimiter. Would it be possible to add an extra delimiter so that text can be centre-aligned?\n", + "closed_at": "2016-06-15T06:27:36Z", + "comment_data": [ + { + "author_association": "MEMBER", + "body": "@justinmk, I would be willing to take a look at the work for this enhancement. I have not yet contributed to the project, but I've been a long time lurker and been using Neovim for several months. I could use a little guidance on where I should start looking for this, if that would be alright.\n", + "created_at": "2016-03-22T12:50:57Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-199796632", + "id": 199796632, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "MDEyOklzc3VlQ29tbWVudDE5OTc5NjYzMg==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/199796632/reactions" + }, + "updated_at": "2016-03-22T12:50:57Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/199796632", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4466899?v=4", + "events_url": "https://api.github.com/users/tjdevries/events{/privacy}", + "followers_url": "https://api.github.com/users/tjdevries/followers", + "following_url": "https://api.github.com/users/tjdevries/following{/other_user}", + "gists_url": "https://api.github.com/users/tjdevries/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tjdevries", + "id": 4466899, + "login": "tjdevries", + "node_id": "MDQ6VXNlcjQ0NjY4OTk=", + "organizations_url": "https://api.github.com/users/tjdevries/orgs", + "received_events_url": "https://api.github.com/users/tjdevries/received_events", + "repos_url": "https://api.github.com/users/tjdevries/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tjdevries/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tjdevries/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tjdevries" + } + }, + { + "author_association": "MEMBER", + "body": "@tjdevries It happens in `build_stl_str_hl()` and makes use of an enum from `options_defs.h` (search for `STL_`). If you search for `STL_MIDDLEMARK` in that function, you find the place where it separates between left and right alignment.\n", + "created_at": "2016-03-22T13:21:21Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-199810856", + "id": 199810856, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "MDEyOklzc3VlQ29tbWVudDE5OTgxMDg1Ng==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/199810856/reactions" + }, + "updated_at": "2016-03-22T13:21:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/199810856", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/972014?v=4", + "events_url": "https://api.github.com/users/mhinz/events{/privacy}", + "followers_url": "https://api.github.com/users/mhinz/followers", + "following_url": "https://api.github.com/users/mhinz/following{/other_user}", + "gists_url": "https://api.github.com/users/mhinz/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mhinz", + "id": 972014, + "login": "mhinz", + "node_id": "MDQ6VXNlcjk3MjAxNA==", + "organizations_url": "https://api.github.com/users/mhinz/orgs", + "received_events_url": "https://api.github.com/users/mhinz/received_events", + "repos_url": "https://api.github.com/users/mhinz/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mhinz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mhinz/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mhinz" + } + }, + { + "author_association": "MEMBER", + "body": "Awesome! Thanks for the help. I will start looking at that this week.\n", + "created_at": "2016-03-22T13:31:14Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-199815502", + "id": 199815502, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "MDEyOklzc3VlQ29tbWVudDE5OTgxNTUwMg==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/199815502/reactions" + }, + "updated_at": "2016-03-22T13:31:14Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/199815502", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4466899?v=4", + "events_url": "https://api.github.com/users/tjdevries/events{/privacy}", + "followers_url": "https://api.github.com/users/tjdevries/followers", + "following_url": "https://api.github.com/users/tjdevries/following{/other_user}", + "gists_url": "https://api.github.com/users/tjdevries/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tjdevries", + "id": 4466899, + "login": "tjdevries", + "node_id": "MDQ6VXNlcjQ0NjY4OTk=", + "organizations_url": "https://api.github.com/users/tjdevries/orgs", + "received_events_url": "https://api.github.com/users/tjdevries/received_events", + "repos_url": "https://api.github.com/users/tjdevries/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tjdevries/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tjdevries/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tjdevries" + } + }, + { + "author_association": "MEMBER", + "body": "@motdef, check out #4489 and let me know if that's the general idea you were thinking of. I have a picture of a current working version that I have. There's still quite a bit more work to be done, but the idea is definitely there now.\n\nYou can now use `%[` and `%]` to center text in the middle of your statusline.\n", + "created_at": "2016-03-24T23:55:06Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-201076925", + "id": 201076925, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "MDEyOklzc3VlQ29tbWVudDIwMTA3NjkyNQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/201076925/reactions" + }, + "updated_at": "2016-03-24T23:55:06Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/201076925", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4466899?v=4", + "events_url": "https://api.github.com/users/tjdevries/events{/privacy}", + "followers_url": "https://api.github.com/users/tjdevries/followers", + "following_url": "https://api.github.com/users/tjdevries/following{/other_user}", + "gists_url": "https://api.github.com/users/tjdevries/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tjdevries", + "id": 4466899, + "login": "tjdevries", + "node_id": "MDQ6VXNlcjQ0NjY4OTk=", + "organizations_url": "https://api.github.com/users/tjdevries/orgs", + "received_events_url": "https://api.github.com/users/tjdevries/received_events", + "repos_url": "https://api.github.com/users/tjdevries/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tjdevries/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tjdevries/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tjdevries" + } + }, + { + "author_association": "NONE", + "body": "That's pretty much what I had in mind. Nice work :)\n", + "created_at": "2016-03-25T19:30:02Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-201444755", + "id": 201444755, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "MDEyOklzc3VlQ29tbWVudDIwMTQ0NDc1NQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/201444755/reactions" + }, + "updated_at": "2016-03-25T19:30:02Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/201444755", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/12588098?v=4", + "events_url": "https://api.github.com/users/tpict/events{/privacy}", + "followers_url": "https://api.github.com/users/tpict/followers", + "following_url": "https://api.github.com/users/tpict/following{/other_user}", + "gists_url": "https://api.github.com/users/tpict/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tpict", + "id": 12588098, + "login": "tpict", + "node_id": "MDQ6VXNlcjEyNTg4MDk4", + "organizations_url": "https://api.github.com/users/tpict/orgs", + "received_events_url": "https://api.github.com/users/tpict/received_events", + "repos_url": "https://api.github.com/users/tpict/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tpict/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tpict/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tpict" + } + }, + { + "author_association": "MEMBER", + "body": "Awesome :+1: I still have to work out several truncation issues, and some different combinations of `%[` and `%]` with `%=`. It does look quite cool having some text centered there. Hoping to get those fixed in another few days and then clean it up.\n", + "created_at": "2016-03-26T01:54:04Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-201660540", + "id": 201660540, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "MDEyOklzc3VlQ29tbWVudDIwMTY2MDU0MA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/201660540/reactions" + }, + "updated_at": "2016-03-26T01:54:38Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/201660540", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4466899?v=4", + "events_url": "https://api.github.com/users/tjdevries/events{/privacy}", + "followers_url": "https://api.github.com/users/tjdevries/followers", + "following_url": "https://api.github.com/users/tjdevries/following{/other_user}", + "gists_url": "https://api.github.com/users/tjdevries/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tjdevries", + "id": 4466899, + "login": "tjdevries", + "node_id": "MDQ6VXNlcjQ0NjY4OTk=", + "organizations_url": "https://api.github.com/users/tjdevries/orgs", + "received_events_url": "https://api.github.com/users/tjdevries/received_events", + "repos_url": "https://api.github.com/users/tjdevries/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tjdevries/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tjdevries/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tjdevries" + } + }, + { + "author_association": "MEMBER", + "body": "#4489 has been closed. This is now implemented :D. \n\nThis issue can be closed I think.\n", + "created_at": "2016-06-15T02:30:11Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-226071941", + "id": 226071941, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "MDEyOklzc3VlQ29tbWVudDIyNjA3MTk0MQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/226071941/reactions" + }, + "updated_at": "2016-06-15T02:30:11Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/226071941", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4466899?v=4", + "events_url": "https://api.github.com/users/tjdevries/events{/privacy}", + "followers_url": "https://api.github.com/users/tjdevries/followers", + "following_url": "https://api.github.com/users/tjdevries/following{/other_user}", + "gists_url": "https://api.github.com/users/tjdevries/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tjdevries", + "id": 4466899, + "login": "tjdevries", + "node_id": "MDQ6VXNlcjQ0NjY4OTk=", + "organizations_url": "https://api.github.com/users/tjdevries/orgs", + "received_events_url": "https://api.github.com/users/tjdevries/received_events", + "repos_url": "https://api.github.com/users/tjdevries/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tjdevries/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tjdevries/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tjdevries" + } + }, + { + "author_association": "NONE", + "body": "does this work? I tried it and it doesnt work in the latest neovim", + "created_at": "2023-12-06T11:15:39Z", + "html_url": "https://github.com/neovim/neovim/issues/4454#issuecomment-1842668812", + "id": 1842668812, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "node_id": "IC_kwDOAPphoM5t1OUM", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842668812/reactions" + }, + "updated_at": "2023-12-06T11:21:14Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842668812", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/24680989?v=4", + "events_url": "https://api.github.com/users/X3eRo0/events{/privacy}", + "followers_url": "https://api.github.com/users/X3eRo0/followers", + "following_url": "https://api.github.com/users/X3eRo0/following{/other_user}", + "gists_url": "https://api.github.com/users/X3eRo0/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/X3eRo0", + "id": 24680989, + "login": "X3eRo0", + "node_id": "MDQ6VXNlcjI0NjgwOTg5", + "organizations_url": "https://api.github.com/users/X3eRo0/orgs", + "received_events_url": "https://api.github.com/users/X3eRo0/received_events", + "repos_url": "https://api.github.com/users/X3eRo0/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/X3eRo0/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/X3eRo0/subscriptions", + "type": "User", + "url": "https://api.github.com/users/X3eRo0" + } + } + ], + "comments": 8, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/4454/comments", + "created_at": "2016-03-15T17:01:07Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/4454/events", + "html_url": "https://github.com/neovim/neovim/issues/4454", + "id": 141037118, + "labels": [ + { + "color": "c2e0c6", + "default": true, + "description": "feature request", + "id": 77997476, + "name": "enhancement", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==", + "url": "https://api.github.com/repos/neovim/neovim/labels/enhancement" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/4454/labels{/name}", + "locked": false, + "milestone": { + "closed_at": "2017-05-01T16:59:47Z", + "closed_issues": 278, + "created_at": "2015-06-27T19:05:24Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "", + "due_on": "2017-03-17T07:00:00Z", + "html_url": "https://github.com/neovim/neovim/milestone/10", + "id": 1183808, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/10/labels", + "node_id": "MDk6TWlsZXN0b25lMTE4MzgwOA==", + "number": 10, + "open_issues": 0, + "state": "closed", + "title": "0.2", + "updated_at": "2021-04-02T22:04:23Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/10" + }, + "node_id": "MDU6SXNzdWUxNDEwMzcxMTg=", + "number": 4454, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/4454/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "closed", + "state_reason": "completed", + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/4454/timeline", + "title": "Centre items in status/tagline", + "updated_at": "2023-12-06T11:21:14Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/4454", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/12588098?v=4", + "events_url": "https://api.github.com/users/tpict/events{/privacy}", + "followers_url": "https://api.github.com/users/tpict/followers", + "following_url": "https://api.github.com/users/tpict/following{/other_user}", + "gists_url": "https://api.github.com/users/tpict/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tpict", + "id": 12588098, + "login": "tpict", + "node_id": "MDQ6VXNlcjEyNTg4MDk4", + "organizations_url": "https://api.github.com/users/tpict/orgs", + "received_events_url": "https://api.github.com/users/tpict/received_events", + "repos_url": "https://api.github.com/users/tpict/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tpict/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tpict/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tpict" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/5052.json b/repositories/neovim/issues/5052.json new file mode 100644 index 00000000..5da8f5b4 --- /dev/null +++ b/repositories/neovim/issues/5052.json @@ -0,0 +1,942 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "- `nvim --version`: 0.1.4\n- Operating system/version: macOS ver. 10.11.5\n- Terminal name/version: iTerm v. 3.0.4\n### Actual behaviour\n\nWhen I select text and press cmd + c, it does not copy text to the system clipboard. Can I make this work? I know I can use 'y' to copy text and that works, however I have certain functions like 'search selected text in google' that require me to use cmd + c to copy the text. Is it possible to make this work? \n### Expected behaviour\n\nI select text, press cmd + c and the text gets copied to my clipboard.\n\nThank you for any help on this.\n", + "closed_at": "2016-07-12T09:43:53Z", + "comment_data": [ + { + "author_association": "MEMBER", + "body": "Opposed to Vim, Neovim uses `mouse=a` by default. That means Vim uses the mouse for its own visual selections, so that iTerm won't even see them.\n\nEither put `set mouse=` in your init.vim, or hold `alt` while making the selection. See `:h 'mouse'` for more information.\n", + "created_at": "2016-07-12T09:43:53Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231990454", + "id": 231990454, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5MDQ1NA==", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231990454/reactions" + }, + "updated_at": "2016-07-12T09:43:53Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231990454", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/972014?v=4", + "events_url": "https://api.github.com/users/mhinz/events{/privacy}", + "followers_url": "https://api.github.com/users/mhinz/followers", + "following_url": "https://api.github.com/users/mhinz/following{/other_user}", + "gists_url": "https://api.github.com/users/mhinz/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mhinz", + "id": 972014, + "login": "mhinz", + "node_id": "MDQ6VXNlcjk3MjAxNA==", + "organizations_url": "https://api.github.com/users/mhinz/orgs", + "received_events_url": "https://api.github.com/users/mhinz/received_events", + "repos_url": "https://api.github.com/users/mhinz/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mhinz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mhinz/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mhinz" + } + }, + { + "author_association": "NONE", + "body": "I have tried putting 'set mouse=' in my init.vim but this does not work. It still does not save my selection to the clipboard.\n\nAnd I have the appropriate settings in iTerm too I believe : \n\n![2016-07-12 at 11 51](https://cloud.githubusercontent.com/assets/6391776/16762957/10d02c28-4827-11e6-85c0-c5dd401fb89d.png)\n\nSo in theory everything should work, but it doesn't :(\n\nHere is my [init.vim](https://github.com/nikitavoloboev/dotfiles/blob/master/vim/nvim/nvimrc), perhaps it has something that makes a conflict for this to not happen.\n", + "created_at": "2016-07-12T09:51:03Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231992236", + "id": 231992236, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5MjIzNg==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231992236/reactions" + }, + "updated_at": "2016-07-12T09:55:58Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231992236", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "MEMBER", + "body": "I use the same iTerm settings. What's the output of `:verb set mouse?`?\n", + "created_at": "2016-07-12T10:00:11Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231994419", + "id": 231994419, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5NDQxOQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231994419/reactions" + }, + "updated_at": "2016-07-12T10:01:54Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231994419", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/972014?v=4", + "events_url": "https://api.github.com/users/mhinz/events{/privacy}", + "followers_url": "https://api.github.com/users/mhinz/followers", + "following_url": "https://api.github.com/users/mhinz/following{/other_user}", + "gists_url": "https://api.github.com/users/mhinz/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mhinz", + "id": 972014, + "login": "mhinz", + "node_id": "MDQ6VXNlcjk3MjAxNA==", + "organizations_url": "https://api.github.com/users/mhinz/orgs", + "received_events_url": "https://api.github.com/users/mhinz/received_events", + "repos_url": "https://api.github.com/users/mhinz/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mhinz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mhinz/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mhinz" + } + }, + { + "author_association": "NONE", + "body": "Here is what I get when I type the command : \n\n![2016-07-12 at 12 04](https://cloud.githubusercontent.com/assets/6391776/16763382/de10a3ba-4828-11e6-942e-e5ff05d5ced9.png)\n\nAfter pressing enter, it just goes away.\n", + "created_at": "2016-07-12T10:05:23Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231995598", + "id": 231995598, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5NTU5OA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231995598/reactions" + }, + "updated_at": "2016-07-12T10:05:31Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231995598", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "MEMBER", + "body": "Hmm.. When you say \"select text\", you mean using the mouse, right?\n", + "created_at": "2016-07-12T10:07:17Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231995994", + "id": 231995994, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5NTk5NA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231995994/reactions" + }, + "updated_at": "2016-07-12T10:07:17Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231995994", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/972014?v=4", + "events_url": "https://api.github.com/users/mhinz/events{/privacy}", + "followers_url": "https://api.github.com/users/mhinz/followers", + "following_url": "https://api.github.com/users/mhinz/following{/other_user}", + "gists_url": "https://api.github.com/users/mhinz/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mhinz", + "id": 972014, + "login": "mhinz", + "node_id": "MDQ6VXNlcjk3MjAxNA==", + "organizations_url": "https://api.github.com/users/mhinz/orgs", + "received_events_url": "https://api.github.com/users/mhinz/received_events", + "repos_url": "https://api.github.com/users/mhinz/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mhinz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mhinz/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mhinz" + } + }, + { + "author_association": "NONE", + "body": "Just normal text selection with 'visual mode'. But selecting text with the mouse doesn't work as well. It selects the text, but pressing cmd + c on it, does not copy it to my clipboard.\n", + "created_at": "2016-07-12T10:08:06Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231996174", + "id": 231996174, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5NjE3NA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231996174/reactions" + }, + "updated_at": "2016-07-12T10:08:16Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231996174", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "MEMBER", + "body": "Well, it doesn't work like that. :) It's not possible in Vim either.\n\nIf you select something in Vim (that is with `v` and friends or with the mouse while `mouse=a`), iTerm never sees that selection, so `cmd+c` won't work either.\n\nIf you really need to use `cmd+c`, you have to use the mouse for selecting and set `mouse=`. I suggest fixing your script to use the output of `pbpaste` instead.\n", + "created_at": "2016-07-12T10:19:20Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231998598", + "id": 231998598, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5ODU5OA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231998598/reactions" + }, + "updated_at": "2016-07-12T10:19:20Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231998598", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/972014?v=4", + "events_url": "https://api.github.com/users/mhinz/events{/privacy}", + "followers_url": "https://api.github.com/users/mhinz/followers", + "following_url": "https://api.github.com/users/mhinz/following{/other_user}", + "gists_url": "https://api.github.com/users/mhinz/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mhinz", + "id": 972014, + "login": "mhinz", + "node_id": "MDQ6VXNlcjk3MjAxNA==", + "organizations_url": "https://api.github.com/users/mhinz/orgs", + "received_events_url": "https://api.github.com/users/mhinz/received_events", + "repos_url": "https://api.github.com/users/mhinz/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mhinz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mhinz/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mhinz" + } + }, + { + "author_association": "NONE", + "body": "I see. Well I just need it to have my dash selection and google selection working. That is I select text, press a hotkey and it will search documentation or google. I also want to add snippets to typinator from selection and all that require the use of cmd + c.\n\nI am not sure what I should modify to have it working. I really want this to work and I want to have it work without me having to select text with the mouse. So is there any way for iTerm to see and trigger cmd + c properly while I select text with v and friends? :(\n\nThank you for your help.\n", + "created_at": "2016-07-12T10:24:57Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-231999841", + "id": 231999841, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMTk5OTg0MQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231999841/reactions" + }, + "updated_at": "2016-07-12T10:25:38Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/231999841", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "MEMBER", + "body": "Use clipboard=unnamed \n", + "created_at": "2016-07-12T13:56:08Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232054806", + "id": 232054806, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjA1NDgwNg==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232054806/reactions" + }, + "updated_at": "2016-07-12T13:56:08Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232054806", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "NONE", + "body": "I have the line 'set clipboard=unnamed' in my init.vim already. This only allows me to have the text I copy with 'y' to be brought to system clipboard but I still cannot use cmd + c. Is that the command you meant?\n", + "created_at": "2016-07-12T14:03:12Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232057021", + "id": 232057021, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjA1NzAyMQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232057021/reactions" + }, + "updated_at": "2016-07-12T14:03:12Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232057021", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "MEMBER", + "body": "Ok, yes. You could setup iterm to send a unique sequence when cmd C is pressed. Then you could map that sequence in n/vim.\n", + "created_at": "2016-07-12T14:05:03Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232057608", + "id": 232057608, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjA1NzYwOA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232057608/reactions" + }, + "updated_at": "2016-07-12T14:05:03Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232057608", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "NONE", + "body": "hey justinmk,\n\nI am very new to nevim and vim and I am really not sure how I can do such a thing. How would I setup my iTerm in this way?\n\nThank you a lot for your help.\n", + "created_at": "2016-07-12T14:15:01Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232060525", + "id": 232060525, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjA2MDUyNQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232060525/reactions" + }, + "updated_at": "2016-07-12T14:15:01Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232060525", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "@nikitavoloboev \n\"screen\nand you can remap +c to save content to clipboard like:\n\n```\n vnoremap \"+y\n```\n", + "created_at": "2016-07-12T15:26:19Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232083842", + "id": 232083842, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjA4Mzg0Mg==", + "performed_via_github_app": null, + "reactions": { + "+1": 19, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 12, + "hooray": 9, + "laugh": 0, + "rocket": 0, + "total_count": 40, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232083842/reactions" + }, + "updated_at": "2016-07-12T19:10:42Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232083842", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/251450?v=4", + "events_url": "https://api.github.com/users/chemzqm/events{/privacy}", + "followers_url": "https://api.github.com/users/chemzqm/followers", + "following_url": "https://api.github.com/users/chemzqm/following{/other_user}", + "gists_url": "https://api.github.com/users/chemzqm/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/chemzqm", + "id": 251450, + "login": "chemzqm", + "node_id": "MDQ6VXNlcjI1MTQ1MA==", + "organizations_url": "https://api.github.com/users/chemzqm/orgs", + "received_events_url": "https://api.github.com/users/chemzqm/received_events", + "repos_url": "https://api.github.com/users/chemzqm/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/chemzqm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/chemzqm/subscriptions", + "type": "User", + "url": "https://api.github.com/users/chemzqm" + } + }, + { + "author_association": "NONE", + "body": "@chemzqm \n\nThis seems to nearly work. However there are two issues : \n1. Now for some reason, when I try to open anything with nevim now, it says that 'No mapping is found' like so : \n\n![2016-07-12 at 19 20](https://cloud.githubusercontent.com/assets/6391776/16776454/b6472682-4865-11e6-9537-a0b921717a01.png)\n1. Now cmd + c seems to cut the text rather than copy.\n\nWhat should I do to correct these issues. Also I am not really sure why this works. Now when I press command + c, it sends and escape sequence?\n\nThank you for your help.\n", + "created_at": "2016-07-12T17:22:44Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232116522", + "id": 232116522, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjExNjUyMg==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232116522/reactions" + }, + "updated_at": "2016-07-12T17:23:04Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232116522", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "@nikitavoloboev I've corrected the mapping, try typing `:vnoremap \"+y` and use `option` + `c` to check if selected content copied to your system clipboard.\n", + "created_at": "2016-07-12T19:14:54Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232149726", + "id": 232149726, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjE0OTcyNg==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232149726/reactions" + }, + "updated_at": "2016-07-12T19:14:54Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232149726", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/251450?v=4", + "events_url": "https://api.github.com/users/chemzqm/events{/privacy}", + "followers_url": "https://api.github.com/users/chemzqm/followers", + "following_url": "https://api.github.com/users/chemzqm/following{/other_user}", + "gists_url": "https://api.github.com/users/chemzqm/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/chemzqm", + "id": 251450, + "login": "chemzqm", + "node_id": "MDQ6VXNlcjI1MTQ1MA==", + "organizations_url": "https://api.github.com/users/chemzqm/orgs", + "received_events_url": "https://api.github.com/users/chemzqm/received_events", + "repos_url": "https://api.github.com/users/chemzqm/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/chemzqm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/chemzqm/subscriptions", + "type": "User", + "url": "https://api.github.com/users/chemzqm" + } + }, + { + "author_association": "NONE", + "body": "@justinmk \n\n[Here](https://github.com/nikitavoloboev/dotfiles/blob/master/vim/nvim/nvimrc) is my init.vim.\n\n@chemzqm \n\nI am not really sure how does the mapping work as +y is commented out for me due to \" being a comment : \n\n![2016-07-12 at 23 09](https://cloud.githubusercontent.com/assets/6391776/16783795/f007dd88-4885-11e6-9c2e-20b3bb97e399.png)\n\nI tried putting it and trying out option + c and it does not work. Also I want to have cmd + c working for that if I can and not option + c.\n", + "created_at": "2016-07-12T21:12:21Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-232182930", + "id": 232182930, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDIzMjE4MjkzMA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232182930/reactions" + }, + "updated_at": "2016-07-12T21:12:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/232182930", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } + }, + { + "author_association": "NONE", + "body": "We could make iterm2 send `Esc+`\r\n```\r\n\" config iTerm2 keys: Esc+Ac, Esc+As, Esc+Aa\r\nvnoremap c \"+y\r\nnnoremap s :up\r\ninoremap s :up\r\nnnoremap a ggVG\r\n\r\n```\r\n\"image\"\r\n\r\n", + "created_at": "2018-05-23T17:01:51Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-391424095", + "id": 391424095, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTQyNDA5NQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/391424095/reactions" + }, + "updated_at": "2022-12-05T05:24:15Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/391424095", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1781999?v=4", + "events_url": "https://api.github.com/users/ahuigo/events{/privacy}", + "followers_url": "https://api.github.com/users/ahuigo/followers", + "following_url": "https://api.github.com/users/ahuigo/following{/other_user}", + "gists_url": "https://api.github.com/users/ahuigo/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ahuigo", + "id": 1781999, + "login": "ahuigo", + "node_id": "MDQ6VXNlcjE3ODE5OTk=", + "organizations_url": "https://api.github.com/users/ahuigo/orgs", + "received_events_url": "https://api.github.com/users/ahuigo/received_events", + "repos_url": "https://api.github.com/users/ahuigo/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ahuigo/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ahuigo/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ahuigo" + } + }, + { + "author_association": "NONE", + "body": "* in my case i use alacritty\r\nas mention above to recognize CMD key in mac it maps to , but only works in macVim\r\nbut why limiting on using cmd key, i just remapping the ' \"+y ' to literally Control key ( ), and it works fine for me if i need to copy something from vim to my system clipboard\r\n ", + "created_at": "2022-12-04T15:11:23Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-1336436114", + "id": 1336436114, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "IC_kwDOAPphoM5PqGWS", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1336436114/reactions" + }, + "updated_at": "2022-12-04T15:12:28Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1336436114", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/96678035?v=4", + "events_url": "https://api.github.com/users/epsentosa/events{/privacy}", + "followers_url": "https://api.github.com/users/epsentosa/followers", + "following_url": "https://api.github.com/users/epsentosa/following{/other_user}", + "gists_url": "https://api.github.com/users/epsentosa/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/epsentosa", + "id": 96678035, + "login": "epsentosa", + "node_id": "U_kgDOBcMwkw", + "organizations_url": "https://api.github.com/users/epsentosa/orgs", + "received_events_url": "https://api.github.com/users/epsentosa/received_events", + "repos_url": "https://api.github.com/users/epsentosa/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/epsentosa/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/epsentosa/subscriptions", + "type": "User", + "url": "https://api.github.com/users/epsentosa" + } + }, + { + "author_association": "NONE", + "body": "This [link](https://www.reddit.com/r/neovim/comments/136j9fy/comment/jiqg26f/?utm_source=share&utm_medium=web2x&context=3) has the solution for the problem and it worked for me", + "created_at": "2023-12-06T02:52:17Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-1842001674", + "id": 1842001674, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "IC_kwDOAPphoM5tyrcK", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842001674/reactions" + }, + "updated_at": "2023-12-06T02:52:17Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842001674", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/34848914?v=4", + "events_url": "https://api.github.com/users/HiWilliam/events{/privacy}", + "followers_url": "https://api.github.com/users/HiWilliam/followers", + "following_url": "https://api.github.com/users/HiWilliam/following{/other_user}", + "gists_url": "https://api.github.com/users/HiWilliam/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/HiWilliam", + "id": 34848914, + "login": "HiWilliam", + "node_id": "MDQ6VXNlcjM0ODQ4OTE0", + "organizations_url": "https://api.github.com/users/HiWilliam/orgs", + "received_events_url": "https://api.github.com/users/HiWilliam/received_events", + "repos_url": "https://api.github.com/users/HiWilliam/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/HiWilliam/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/HiWilliam/subscriptions", + "type": "User", + "url": "https://api.github.com/users/HiWilliam" + } + }, + { + "author_association": "MEMBER", + "body": "> This [link](https://www.reddit.com/r/neovim/comments/136j9fy/comment/jiqg26f/?utm_source=share&utm_medium=web2x&context=3) has the solution for the problem and it worked for me\r\n\r\nThat link does not say anything about cmd+c ?", + "created_at": "2023-12-06T11:36:08Z", + "html_url": "https://github.com/neovim/neovim/issues/5052#issuecomment-1842697345", + "id": 1842697345, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "node_id": "IC_kwDOAPphoM5t1VSB", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842697345/reactions" + }, + "updated_at": "2023-12-06T11:36:08Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842697345", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comments": 20, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/5052/comments", + "created_at": "2016-07-12T09:22:21Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/5052/events", + "html_url": "https://github.com/neovim/neovim/issues/5052", + "id": 165031621, + "labels": [], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/5052/labels{/name}", + "locked": false, + "milestone": null, + "node_id": "MDU6SXNzdWUxNjUwMzE2MjE=", + "number": 5052, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/5052/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "closed", + "state_reason": "completed", + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/5052/timeline", + "title": "How can I have cmd + c work in neovim in iTerm on macOS?", + "updated_at": "2023-12-06T11:36:09Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/5052", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6391776?v=4", + "events_url": "https://api.github.com/users/nikitavoloboev/events{/privacy}", + "followers_url": "https://api.github.com/users/nikitavoloboev/followers", + "following_url": "https://api.github.com/users/nikitavoloboev/following{/other_user}", + "gists_url": "https://api.github.com/users/nikitavoloboev/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/nikitavoloboev", + "id": 6391776, + "login": "nikitavoloboev", + "node_id": "MDQ6VXNlcjYzOTE3NzY=", + "organizations_url": "https://api.github.com/users/nikitavoloboev/orgs", + "received_events_url": "https://api.github.com/users/nikitavoloboev/received_events", + "repos_url": "https://api.github.com/users/nikitavoloboev/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/nikitavoloboev/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/nikitavoloboev/subscriptions", + "type": "User", + "url": "https://api.github.com/users/nikitavoloboev" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/6875.json b/repositories/neovim/issues/6875.json index 93b7d496..2423f66a 100644 --- a/repositories/neovim/issues/6875.json +++ b/repositories/neovim/issues/6875.json @@ -16,15 +16,15 @@ "node_id": "MDEyOklzc3VlQ29tbWVudDMwOTE4NzA0Mw==", "performed_via_github_app": null, "reactions": { - "+1": 122, + "+1": 125, "-1": 0, "confused": 0, "eyes": 0, - "heart": 24, + "heart": 26, "hooray": 4, "laugh": 0, "rocket": 0, - "total_count": 150, + "total_count": 155, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/309187043/reactions" }, "updated_at": "2017-06-17T02:21:14Z", @@ -236,7 +236,7 @@ "node_id": "IC_kwDOAPphoM47mN2A", "performed_via_github_app": null, "reactions": { - "+1": 23, + "+1": 25, "-1": 0, "confused": 0, "eyes": 0, @@ -244,7 +244,7 @@ "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 23, + "total_count": 25, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/999873920/reactions" }, "updated_at": "2021-12-22T20:53:39Z", @@ -280,7 +280,7 @@ "node_id": "IC_kwDOAPphoM5In0Tu", "performed_via_github_app": null, "reactions": { - "+1": 10, + "+1": 12, "-1": 0, "confused": 0, "eyes": 0, @@ -288,7 +288,7 @@ "hooray": 0, "laugh": 3, "rocket": 0, - "total_count": 16, + "total_count": 18, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1218397422/reactions" }, "updated_at": "2022-08-17T19:16:31Z", @@ -500,15 +500,15 @@ "node_id": "IC_kwDOAPphoM5LVqo_", "performed_via_github_app": null, "reactions": { - "+1": 18, + "+1": 23, "-1": 0, "confused": 0, "eyes": 0, - "heart": 25, + "heart": 27, "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 43, + "total_count": 50, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1263970879/reactions" }, "updated_at": "2022-09-30T20:03:02Z", @@ -808,7 +808,7 @@ "node_id": "IC_kwDOAPphoM5fLZpj", "performed_via_github_app": null, "reactions": { - "+1": 2, + "+1": 4, "-1": 0, "confused": 0, "eyes": 0, @@ -816,7 +816,7 @@ "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 2, + "total_count": 4, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1596824163/reactions" }, "updated_at": "2023-06-19T09:20:04Z", @@ -940,7 +940,7 @@ "node_id": "IC_kwDOAPphoM5oc85U", "performed_via_github_app": null, "reactions": { - "+1": 0, + "+1": 5, "-1": 0, "confused": 0, "eyes": 0, @@ -948,7 +948,7 @@ "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 0, + "total_count": 5, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1752419924/reactions" }, "updated_at": "2023-10-09T06:37:27Z", @@ -973,9 +973,97 @@ "type": "User", "url": "https://api.github.com/users/roubaobaozi" } + }, + { + "author_association": "NONE", + "body": "considering how often this appears and deleting shada appears to have no negative effects can neovim automatically delete the damn thing when this error happens?", + "created_at": "2023-12-06T13:28:38Z", + "html_url": "https://github.com/neovim/neovim/issues/6875#issuecomment-1842878648", + "id": 1842878648, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/6875", + "node_id": "IC_kwDOAPphoM5t2Bi4", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842878648/reactions" + }, + "updated_at": "2023-12-06T13:28:38Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842878648", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/11765286?v=4", + "events_url": "https://api.github.com/users/peterino2/events{/privacy}", + "followers_url": "https://api.github.com/users/peterino2/followers", + "following_url": "https://api.github.com/users/peterino2/following{/other_user}", + "gists_url": "https://api.github.com/users/peterino2/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/peterino2", + "id": 11765286, + "login": "peterino2", + "node_id": "MDQ6VXNlcjExNzY1Mjg2", + "organizations_url": "https://api.github.com/users/peterino2/orgs", + "received_events_url": "https://api.github.com/users/peterino2/received_events", + "repos_url": "https://api.github.com/users/peterino2/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/peterino2/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/peterino2/subscriptions", + "type": "User", + "url": "https://api.github.com/users/peterino2" + } + }, + { + "author_association": "MEMBER", + "body": "> deleting shada appears to have no negative effects\r\n\r\nof course it does; it removes _all_ shared data. ", + "created_at": "2023-12-06T13:37:45Z", + "html_url": "https://github.com/neovim/neovim/issues/6875#issuecomment-1842904907", + "id": 1842904907, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/6875", + "node_id": "IC_kwDOAPphoM5t2H9L", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842904907/reactions" + }, + "updated_at": "2023-12-06T13:37:45Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842904907", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } } ], - "comments": 22, + "comments": 24, "comments_url": "https://api.github.com/repos/neovim/neovim/issues/6875/comments", "created_at": "2017-06-10T06:45:46Z", "events_url": "https://api.github.com/repos/neovim/neovim/issues/6875/events", @@ -1024,7 +1112,7 @@ "state_reason": "reopened", "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/6875/timeline", "title": "E576: Error while reading ShaDa file: there is an item at position 270498 that must not be there: Missing itemsare for internal uses only", - "updated_at": "2023-10-09T06:37:27Z", + "updated_at": "2023-12-06T13:37:46Z", "url": "https://api.github.com/repos/neovim/neovim/issues/6875", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/3297602?v=4", diff --git a/repositories/neovim/issues/7225.json b/repositories/neovim/issues/7225.json new file mode 100644 index 00000000..419d5b87 --- /dev/null +++ b/repositories/neovim/issues/7225.json @@ -0,0 +1,293 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "CONTRIBUTOR", + "body": "\r\n\r\n- `nvim --version`: \r\n\r\n```\r\nNVIM v0.2.0\r\nBuild type: Release\r\nCompilation: /usr/lib/ccache/bin/cc -specs=/void-packages/common/environment/configure/gccspecs/hardened-cc1 -fstack-protector-strong -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_MSGPACK_HAS_FLOAT32 -O2 -DNDEBUG -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -I/builddir/neovim-0.2.0/build/config -I/builddir/neovim-0.2.0/src -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/builddir/neovim-0.2.0/build/src/nvim/auto -I/builddir/neovim-0.2.0/build/include\r\nCompiled by void-buildslave@build\r\n\r\nOptional features included (+) or not (-): +acl +iconv -jemalloc +tui \r\nFor differences from Vim, see :help vim-differences\r\n\r\n system vimrc file: \"$VIM/sysinit.vim\"\r\n fall-back for $VIM: \"/usr/share/nvim\"\r\n```\r\n\r\n- Vim (version: ) behaves differently?\r\n\r\nVim has the same behavior.\r\n\r\n- Operating system/version:\r\n\r\nvoid-linux\r\n\r\n```\r\nuname -a\r\nLinux roxma-void-usb 4.12.9_1 #1 SMP PREEMPT Fri Aug 25 08:49:12 UTC 2017 x86_64 GNU/Linux\r\n```\r\n\r\n- Terminal name/version:\r\n- `$TERM`:\r\nxterm-256color\r\n\r\n\r\n### minimal vimrc\r\n\r\n```vim\r\nfiletype plugin indent on\r\nset encoding=utf-8 fileencodings=ucs-bom,utf-8,gbk,gb18030,latin1 termencoding=utf-8\r\n\r\nset completeopt=menu,menuone,noinsert,noselect\r\n\r\nfunc Foo()\r\n call complete(1, ['ffffoo'])\r\n return \"\"\r\nendfunc\r\n\r\nimap . =Foo()\r\n```\r\n\r\n### Actual behaviour\r\n\r\n![ctrl-l](https://user-images.githubusercontent.com/4538941/29851885-4f1fef58-8d69-11e7-8db0-53ac3bda85ae.gif)\r\n\r\n### Expected behaviour\r\n\r\nomnifunc version:\r\n\r\n```vim\r\nfiletype plugin indent on\r\nset encoding=utf-8 fileencodings=ucs-bom,utf-8,gbk,gb18030,latin1 termencoding=utf-8\r\n\r\nset completeopt=menu,menuone,noinsert,noselect\r\n\r\nfunc Foo(findstart, base)\r\n if a:findstart\r\n return 0\r\n endif\r\n return [\"ffffoo\"]\r\nendfunc\r\n\r\nset omnifunc=Foo\r\n```\r\n\r\n![omni](https://user-images.githubusercontent.com/4538941/29851963-d56e4ca8-8d69-11e7-97ab-6dba0bf3615c.gif)\r\n\r\n### Related issue\r\n\r\nhttps://github.com/roxma/nvim-completion-manager/issues/127\r\n", + "closed_at": null, + "comment_data": [ + { + "author_association": "CONTRIBUTOR", + "body": "It is beause, `compl_used_match` is TRUE in `complete()`.\r\nI don't know why though.\r\n\r\nhttps://github.com/neovim/neovim/blob/master/src/nvim/edit.c#L2428\r\n\r\nIf `compl_used_match` is TRUE, CTRL-L function is disabled.\r\n\r\nhttps://github.com/neovim/neovim/blob/master/src/nvim/edit.c#L641", + "created_at": "2017-08-30T03:19:11Z", + "html_url": "https://github.com/neovim/neovim/issues/7225#issuecomment-325868085", + "id": 325868085, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7225", + "node_id": "MDEyOklzc3VlQ29tbWVudDMyNTg2ODA4NQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/325868085/reactions" + }, + "updated_at": "2017-08-30T03:19:11Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/325868085", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/41495?v=4", + "events_url": "https://api.github.com/users/Shougo/events{/privacy}", + "followers_url": "https://api.github.com/users/Shougo/followers", + "following_url": "https://api.github.com/users/Shougo/following{/other_user}", + "gists_url": "https://api.github.com/users/Shougo/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Shougo", + "id": 41495, + "login": "Shougo", + "node_id": "MDQ6VXNlcjQxNDk1", + "organizations_url": "https://api.github.com/users/Shougo/orgs", + "received_events_url": "https://api.github.com/users/Shougo/received_events", + "repos_url": "https://api.github.com/users/Shougo/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Shougo/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Shougo/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Shougo" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "```diff\r\ndiff --git a/src/nvim/edit.c b/src/nvim/edit.c\r\nindex ca62679..4e52547 100644\r\n--- a/src/nvim/edit.c\r\n+++ b/src/nvim/edit.c\r\n@@ -2425,7 +2425,7 @@ void set_completion(colnr_T startcol, list_T *list)\r\n ins_compl_add_list(list);\r\n compl_matches = ins_compl_make_cyclic();\r\n compl_started = TRUE;\r\n- compl_used_match = TRUE;\r\n+ compl_used_match = false;\r\n compl_cont_status = 0;\r\n int save_w_wrow = curwin->w_wrow;\r\n int save_w_leftcol = curwin->w_leftcol;\r\n```", + "created_at": "2017-08-30T03:22:09Z", + "html_url": "https://github.com/neovim/neovim/issues/7225#issuecomment-325868481", + "id": 325868481, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7225", + "node_id": "MDEyOklzc3VlQ29tbWVudDMyNTg2ODQ4MQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 3, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 3, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/325868481/reactions" + }, + "updated_at": "2017-08-30T03:22:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/325868481", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/41495?v=4", + "events_url": "https://api.github.com/users/Shougo/events{/privacy}", + "followers_url": "https://api.github.com/users/Shougo/followers", + "following_url": "https://api.github.com/users/Shougo/following{/other_user}", + "gists_url": "https://api.github.com/users/Shougo/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Shougo", + "id": 41495, + "login": "Shougo", + "node_id": "MDQ6VXNlcjQxNDk1", + "organizations_url": "https://api.github.com/users/Shougo/orgs", + "received_events_url": "https://api.github.com/users/Shougo/received_events", + "repos_url": "https://api.github.com/users/Shougo/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Shougo/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Shougo/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Shougo" + } + }, + { + "author_association": "MEMBER", + "body": "If someone wants to send a patch and a test, we can try this on master.", + "created_at": "2017-09-01T07:34:12Z", + "html_url": "https://github.com/neovim/neovim/issues/7225#issuecomment-326511528", + "id": 326511528, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7225", + "node_id": "MDEyOklzc3VlQ29tbWVudDMyNjUxMTUyOA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/326511528/reactions" + }, + "updated_at": "2017-09-01T07:34:12Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/326511528", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "MEMBER", + "body": "Relate https://github.com/vim/vim/issues/7567 . restore to original code can make CTRL_L work. some old test cases will failed then.\r\n\r\n```diff\r\ndiff --git a/src/nvim/insexpand.c b/src/nvim/insexpand.c\r\nindex 2b207916a..0c2c1c272 100644\r\n--- a/src/nvim/insexpand.c\r\n+++ b/src/nvim/insexpand.c\r\n@@ -396,7 +396,7 @@ static bool ctrl_x_mode_eval(void)\r\n bool ctrl_x_mode_line_or_eval(void)\r\n FUNC_ATTR_PURE\r\n {\r\n- return ctrl_x_mode == CTRL_X_WHOLE_LINE || ctrl_x_mode == CTRL_X_EVAL;\r\n+ return ctrl_x_mode == CTRL_X_WHOLE_LINE;\r\n }\r\n```", + "created_at": "2023-12-06T10:47:30Z", + "html_url": "https://github.com/neovim/neovim/issues/7225#issuecomment-1842627949", + "id": 1842627949, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7225", + "node_id": "IC_kwDOAPphoM5t1EVt", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842627949/reactions" + }, + "updated_at": "2023-12-06T10:53:58Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842627949", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", + "events_url": "https://api.github.com/users/glepnir/events{/privacy}", + "followers_url": "https://api.github.com/users/glepnir/followers", + "following_url": "https://api.github.com/users/glepnir/following{/other_user}", + "gists_url": "https://api.github.com/users/glepnir/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/glepnir", + "id": 41671631, + "login": "glepnir", + "node_id": "MDQ6VXNlcjQxNjcxNjMx", + "organizations_url": "https://api.github.com/users/glepnir/orgs", + "received_events_url": "https://api.github.com/users/glepnir/received_events", + "repos_url": "https://api.github.com/users/glepnir/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/glepnir/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/glepnir/subscriptions", + "type": "User", + "url": "https://api.github.com/users/glepnir" + } + } + ], + "comments": 4, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/7225/comments", + "created_at": "2017-08-30T02:00:17Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/7225/events", + "html_url": "https://github.com/neovim/neovim/issues/7225", + "id": 253855648, + "labels": [ + { + "color": "F9D0C4", + "default": false, + "description": "wrong behavior inherited from vim", + "id": 154310492, + "name": "bug-vim", + "node_id": "MDU6TGFiZWwxNTQzMTA0OTI=", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug-vim" + }, + { + "color": "FBCA04", + "default": false, + "description": "upstream issue that needs to be fixed in vim first", + "id": 2639399975, + "name": "needs:vim-patch", + "node_id": "MDU6TGFiZWwyNjM5Mzk5OTc1", + "url": "https://api.github.com/repos/neovim/neovim/labels/needs:vim-patch" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/7225/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 592, + "created_at": "2014-05-10T20:43:04Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "Low priority. Not planned for the current target, may be reassigned.", + "due_on": null, + "html_url": "https://github.com/neovim/neovim/milestone/6", + "id": 655037, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", + "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", + "number": 6, + "open_issues": 427, + "state": "open", + "title": "backlog", + "updated_at": "2023-12-06T23:16:41Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/6" + }, + "node_id": "MDU6SXNzdWUyNTM4NTU2NDg=", + "number": 7225, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/7225/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/7225/timeline", + "title": "CTRL-L of popupmenu-keys is broken for complete() function", + "updated_at": "2023-12-06T11:58:50Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/7225", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/4538941?v=4", + "events_url": "https://api.github.com/users/roxma/events{/privacy}", + "followers_url": "https://api.github.com/users/roxma/followers", + "following_url": "https://api.github.com/users/roxma/following{/other_user}", + "gists_url": "https://api.github.com/users/roxma/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/roxma", + "id": 4538941, + "login": "roxma", + "node_id": "MDQ6VXNlcjQ1Mzg5NDE=", + "organizations_url": "https://api.github.com/users/roxma/orgs", + "received_events_url": "https://api.github.com/users/roxma/received_events", + "repos_url": "https://api.github.com/users/roxma/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/roxma/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/roxma/subscriptions", + "type": "User", + "url": "https://api.github.com/users/roxma" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/7769.json b/repositories/neovim/issues/7769.json new file mode 100644 index 00000000..8fbb6e47 --- /dev/null +++ b/repositories/neovim/issues/7769.json @@ -0,0 +1,377 @@ +{ + "active_lock_reason": null, + "assignee": { + "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", + "events_url": "https://api.github.com/users/glepnir/events{/privacy}", + "followers_url": "https://api.github.com/users/glepnir/followers", + "following_url": "https://api.github.com/users/glepnir/following{/other_user}", + "gists_url": "https://api.github.com/users/glepnir/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/glepnir", + "id": 41671631, + "login": "glepnir", + "node_id": "MDQ6VXNlcjQxNjcxNjMx", + "organizations_url": "https://api.github.com/users/glepnir/orgs", + "received_events_url": "https://api.github.com/users/glepnir/received_events", + "repos_url": "https://api.github.com/users/glepnir/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/glepnir/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/glepnir/subscriptions", + "type": "User", + "url": "https://api.github.com/users/glepnir" + }, + "assignees": [ + { + "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", + "events_url": "https://api.github.com/users/glepnir/events{/privacy}", + "followers_url": "https://api.github.com/users/glepnir/followers", + "following_url": "https://api.github.com/users/glepnir/following{/other_user}", + "gists_url": "https://api.github.com/users/glepnir/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/glepnir", + "id": 41671631, + "login": "glepnir", + "node_id": "MDQ6VXNlcjQxNjcxNjMx", + "organizations_url": "https://api.github.com/users/glepnir/orgs", + "received_events_url": "https://api.github.com/users/glepnir/received_events", + "repos_url": "https://api.github.com/users/glepnir/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/glepnir/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/glepnir/subscriptions", + "type": "User", + "url": "https://api.github.com/users/glepnir" + } + ], + "author_association": "NONE", + "body": "Currently Vim (and by bloodline also NeoVim) allows only single line completions. This is quite limiting as there is also no way to determine beginning and end of the completed text so this leaves us in the limbo where we need to do some hackish things to achieve things like multiline snippets.\r\n\r\nMost obvious way to do such thing would be to make (`:h complete-items`):\r\n\r\n```viml\r\n{ 'word': \"aaa\\nbbb\" }\r\n```\r\n\r\nto insert 2 lines:\r\n\r\n```\r\naaa\r\nbbb\r\n```\r\n\r\nCurrently it inserts\r\n\r\n```\r\naaa^@bbb\r\n```\r\n\r\nWhere `^@` is NUL character (`:h NL-used-for-NUL`).\r\n\r\nThe problems with multiline completion is that there will be open question how to handle indentation.\r\n\r\nAlternatively we could allow `List` as `'word'` parameter where each line would be one item.", + "closed_at": null, + "comment_data": [ + { + "author_association": "MEMBER", + "body": "> Alternatively we could allow List as 'word' parameter where each line would be one item.\r\n\r\nSomething like that sounds reasonable.", + "created_at": "2017-12-26T21:01:26Z", + "html_url": "https://github.com/neovim/neovim/issues/7769#issuecomment-354012815", + "id": 354012815, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7769", + "node_id": "MDEyOklzc3VlQ29tbWVudDM1NDAxMjgxNQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354012815/reactions" + }, + "updated_at": "2017-12-26T21:01:26Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354012815", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "NONE", + "body": "@justinmk probably, but the first proposal is on par with `'info'` field of `complete-items`. The only problem is that in such case you cannot complete entries containing `NUL` character.", + "created_at": "2017-12-26T22:15:23Z", + "html_url": "https://github.com/neovim/neovim/issues/7769#issuecomment-354018805", + "id": 354018805, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7769", + "node_id": "MDEyOklzc3VlQ29tbWVudDM1NDAxODgwNQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354018805/reactions" + }, + "updated_at": "2017-12-26T22:15:23Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354018805", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/291639?v=4", + "events_url": "https://api.github.com/users/hauleth/events{/privacy}", + "followers_url": "https://api.github.com/users/hauleth/followers", + "following_url": "https://api.github.com/users/hauleth/following{/other_user}", + "gists_url": "https://api.github.com/users/hauleth/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/hauleth", + "id": 291639, + "login": "hauleth", + "node_id": "MDQ6VXNlcjI5MTYzOQ==", + "organizations_url": "https://api.github.com/users/hauleth/orgs", + "received_events_url": "https://api.github.com/users/hauleth/received_events", + "repos_url": "https://api.github.com/users/hauleth/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/hauleth/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/hauleth/subscriptions", + "type": "User", + "url": "https://api.github.com/users/hauleth" + } + }, + { + "author_association": "NONE", + "body": "Thinking out loud but if this made it in, it's conceptually similar to the [floating windows](https://github.com/neovim/neovim/pull/6619) that are also incoming isn't it?\r\n\r\nWould there be plans to make the omnicompletion popup use a floating window instead of a specialised popup?", + "created_at": "2017-12-28T13:36:18Z", + "html_url": "https://github.com/neovim/neovim/issues/7769#issuecomment-354289391", + "id": 354289391, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7769", + "node_id": "MDEyOklzc3VlQ29tbWVudDM1NDI4OTM5MQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354289391/reactions" + }, + "updated_at": "2017-12-28T13:53:43Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354289391", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/9536682?v=4", + "events_url": "https://api.github.com/users/joereynolds/events{/privacy}", + "followers_url": "https://api.github.com/users/joereynolds/followers", + "following_url": "https://api.github.com/users/joereynolds/following{/other_user}", + "gists_url": "https://api.github.com/users/joereynolds/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/joereynolds", + "id": 9536682, + "login": "joereynolds", + "node_id": "MDQ6VXNlcjk1MzY2ODI=", + "organizations_url": "https://api.github.com/users/joereynolds/orgs", + "received_events_url": "https://api.github.com/users/joereynolds/received_events", + "repos_url": "https://api.github.com/users/joereynolds/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/joereynolds/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/joereynolds/subscriptions", + "type": "User", + "url": "https://api.github.com/users/joereynolds" + } + }, + { + "author_association": "NONE", + "body": "@joereynolds this isn't related to #6619 in any way, as this is only about inserting text, not about displaying it in popup window.", + "created_at": "2017-12-28T14:45:35Z", + "html_url": "https://github.com/neovim/neovim/issues/7769#issuecomment-354299170", + "id": 354299170, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7769", + "node_id": "MDEyOklzc3VlQ29tbWVudDM1NDI5OTE3MA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354299170/reactions" + }, + "updated_at": "2017-12-28T14:45:35Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354299170", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/291639?v=4", + "events_url": "https://api.github.com/users/hauleth/events{/privacy}", + "followers_url": "https://api.github.com/users/hauleth/followers", + "following_url": "https://api.github.com/users/hauleth/following{/other_user}", + "gists_url": "https://api.github.com/users/hauleth/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/hauleth", + "id": 291639, + "login": "hauleth", + "node_id": "MDQ6VXNlcjI5MTYzOQ==", + "organizations_url": "https://api.github.com/users/hauleth/orgs", + "received_events_url": "https://api.github.com/users/hauleth/received_events", + "repos_url": "https://api.github.com/users/hauleth/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/hauleth/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/hauleth/subscriptions", + "type": "User", + "url": "https://api.github.com/users/hauleth" + } + }, + { + "author_association": "NONE", + "body": "I have also created vim/vim#2505 issue with proposition of such feature.", + "created_at": "2017-12-28T14:46:46Z", + "html_url": "https://github.com/neovim/neovim/issues/7769#issuecomment-354299344", + "id": 354299344, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/7769", + "node_id": "MDEyOklzc3VlQ29tbWVudDM1NDI5OTM0NA==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354299344/reactions" + }, + "updated_at": "2017-12-28T14:46:46Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/354299344", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/291639?v=4", + "events_url": "https://api.github.com/users/hauleth/events{/privacy}", + "followers_url": "https://api.github.com/users/hauleth/followers", + "following_url": "https://api.github.com/users/hauleth/following{/other_user}", + "gists_url": "https://api.github.com/users/hauleth/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/hauleth", + "id": 291639, + "login": "hauleth", + "node_id": "MDQ6VXNlcjI5MTYzOQ==", + "organizations_url": "https://api.github.com/users/hauleth/orgs", + "received_events_url": "https://api.github.com/users/hauleth/received_events", + "repos_url": "https://api.github.com/users/hauleth/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/hauleth/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/hauleth/subscriptions", + "type": "User", + "url": "https://api.github.com/users/hauleth" + } + } + ], + "comments": 5, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/7769/comments", + "created_at": "2017-12-26T20:34:15Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/7769/events", + "html_url": "https://github.com/neovim/neovim/issues/7769", + "id": 284606936, + "labels": [ + { + "color": "c2e0c6", + "default": true, + "description": "feature request", + "id": 77997476, + "name": "enhancement", + "node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==", + "url": "https://api.github.com/repos/neovim/neovim/labels/enhancement" + }, + { + "color": "C5DEF5", + "default": false, + "description": "Nvim built-in (omni)completion", + "id": 3214348835, + "name": "completion", + "node_id": "MDU6TGFiZWwzMjE0MzQ4ODM1", + "url": "https://api.github.com/repos/neovim/neovim/labels/completion" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/7769/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 592, + "created_at": "2014-05-10T20:43:04Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "Low priority. Not planned for the current target, may be reassigned.", + "due_on": null, + "html_url": "https://github.com/neovim/neovim/milestone/6", + "id": 655037, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", + "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", + "number": 6, + "open_issues": 427, + "state": "open", + "title": "backlog", + "updated_at": "2023-12-06T23:16:41Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/6" + }, + "node_id": "MDU6SXNzdWUyODQ2MDY5MzY=", + "number": 7769, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/7769/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/7769/timeline", + "title": "Multiline completion", + "updated_at": "2023-12-06T11:10:54Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/7769", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/291639?v=4", + "events_url": "https://api.github.com/users/hauleth/events{/privacy}", + "followers_url": "https://api.github.com/users/hauleth/followers", + "following_url": "https://api.github.com/users/hauleth/following{/other_user}", + "gists_url": "https://api.github.com/users/hauleth/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/hauleth", + "id": 291639, + "login": "hauleth", + "node_id": "MDQ6VXNlcjI5MTYzOQ==", + "organizations_url": "https://api.github.com/users/hauleth/orgs", + "received_events_url": "https://api.github.com/users/hauleth/received_events", + "repos_url": "https://api.github.com/users/hauleth/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/hauleth/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/hauleth/subscriptions", + "type": "User", + "url": "https://api.github.com/users/hauleth" + } +} \ No newline at end of file diff --git a/repositories/neovim/issues/9800.json b/repositories/neovim/issues/9800.json new file mode 100644 index 00000000..17066f3a --- /dev/null +++ b/repositories/neovim/issues/9800.json @@ -0,0 +1,628 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "- `nvim --version`: v0.3.4\r\n- Vim (version: v8.1, patches 1-577) behaves differently?\r\n- Operating system/version: macOS 10.13.6 (High Sierra)\r\n- Terminal name/version: iTerm2\r\n- `$TERM`: tmux-256color (but behavior is same outside tmux with xterm-256color)\r\n\r\n### Steps to reproduce using `nvim -u NORC`\r\n\r\n```\r\n# Create two files to diff, a and b, containing some text with some differences, then:\r\nnvim -u NONE -d a b\r\n```\r\n\r\nTurn on `'cursorline'` and define a highlight group for it that does not contain an underline.\r\n\r\n```\r\n:set cursorline\r\n:hi clear CursorLine\r\n:hi CursorLine gui=bold\r\n```\r\n\r\n### Actual behaviour\r\n\r\nOn moving the cursor through a changed region in the diff, the lines get underline styling applied, as though `CursorLine` had `gui=bold,underline`. Move the cursor onto a line outside the changed region and see the lines no longer have underline, only bold.\r\n\r\nDoesn't happen if `CursorLine` has a fg color (eg. `guifg=#ff0000`), although in practice you probably don't ever want to assign a fg color to `CursorLine`.\r\n\r\nNote the underlining on the cursor line in the left-hand pane visible in the screenshot:\r\n\r\n\"diff\"\r\n\r\n### Expected behaviour\r\n\r\nThe cursorline shouldn't have underline styling applied when within changed regions in diff mode, unless `CursorLine` actually has underline style turned on.", + "closed_at": null, + "comment_data": [ + { + "author_association": "MEMBER", + "body": "> Doesn't happen if CursorLine has a fg color (eg. guifg=#ff0000), \r\n\r\nBecause then CursorLine is \"high priority\". Otherwise it's \"low priority\".\r\n\r\n> although in practice you probably don't ever want to assign a fg color to CursorLine.\r\n\r\nIf your DiffChange/DiffAdd has a bg color, then before #9028 was implemented, `CursorLine` would be unreadable for foreground text that did not highly contrast the DiffChange/DiffAdd bg color. Now it's always readable, but the tradeoff is that it shows a underline.\r\n\r\nI guess now we need a `CursorLineDiff` highlight group as promised in https://github.com/neovim/neovim/pull/9028#discussion_r236479290", + "created_at": "2019-03-27T23:01:15Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-477379409", + "id": 477379409, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "MDEyOklzc3VlQ29tbWVudDQ3NzM3OTQwOQ==", + "performed_via_github_app": null, + "reactions": { + "+1": 11, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 11, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/477379409/reactions" + }, + "updated_at": "2019-03-27T23:02:37Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/477379409", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "+1 for this feature. Also, why can't the diff highlighting behavior be inferred from the highlighting set for `CursorLine`? Re: the comment in #9028, I count myself among the unknown number of people who consider it worse to have an underline, and I imagine you could roughly guess at this group's membership based on the existing `CursorLine` highlight settings. (It's possible that this isn't doable for underlying architectural reasons but if so I'd be interested to understand why).", + "created_at": "2020-11-29T21:24:17Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-735455966", + "id": 735455966, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "MDEyOklzc3VlQ29tbWVudDczNTQ1NTk2Ng==", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/735455966/reactions" + }, + "updated_at": "2020-11-29T21:26:24Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/735455966", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/802511?v=4", + "events_url": "https://api.github.com/users/ddickstein/events{/privacy}", + "followers_url": "https://api.github.com/users/ddickstein/followers", + "following_url": "https://api.github.com/users/ddickstein/following{/other_user}", + "gists_url": "https://api.github.com/users/ddickstein/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/ddickstein", + "id": 802511, + "login": "ddickstein", + "node_id": "MDQ6VXNlcjgwMjUxMQ==", + "organizations_url": "https://api.github.com/users/ddickstein/orgs", + "received_events_url": "https://api.github.com/users/ddickstein/received_events", + "repos_url": "https://api.github.com/users/ddickstein/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/ddickstein/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ddickstein/subscriptions", + "type": "User", + "url": "https://api.github.com/users/ddickstein" + } + }, + { + "author_association": "NONE", + "body": "Is there a chance that https://github.com/neovim/neovim/pull/9028#discussion_r236479290 will make it in v0.5.1?", + "created_at": "2021-08-30T06:07:01Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-908056625", + "id": 908056625, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM42H9gx", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/908056625/reactions" + }, + "updated_at": "2021-08-30T06:07:01Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/908056625", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/300146?v=4", + "events_url": "https://api.github.com/users/savchenko/events{/privacy}", + "followers_url": "https://api.github.com/users/savchenko/followers", + "following_url": "https://api.github.com/users/savchenko/following{/other_user}", + "gists_url": "https://api.github.com/users/savchenko/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/savchenko", + "id": 300146, + "login": "savchenko", + "node_id": "MDQ6VXNlcjMwMDE0Ng==", + "organizations_url": "https://api.github.com/users/savchenko/orgs", + "received_events_url": "https://api.github.com/users/savchenko/received_events", + "repos_url": "https://api.github.com/users/savchenko/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/savchenko/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/savchenko/subscriptions", + "type": "User", + "url": "https://api.github.com/users/savchenko" + } + }, + { + "author_association": "NONE", + "body": "Commenting to document the fact it's also broken *with* correctly set `ctermfg` - 2 use cases where it actually lowers readability because diff isn't indicated on the cursor line + visual example on screens in #16295:\r\n1. `nvim --clean -d +\"windo set cul nu\" +\"hi CursorLine cterm=none ctermbg=blue | hi DiffText cterm=underline ctermbg=darkmagenta\" <(echo -e \"lorem\\nipsum\\ndolor sit\\namet\\n\\n\") <(echo -e \"lorem\\nipsum\\ndolor sores\\nerratum\\n\\n\")`\r\n2. `nvim --clean -d +\"windo set cul nu\" +\"hi CursorLine cterm=none ctermbg=blue ctermfg=white | hi DiffText cterm=none\" <(echo -e \"lorem\\nipsum\\ndolor sit\\namet\\n\\n\") <(echo -e \"lorem\\nipsum\\ndolor sores\\nerratum\\n\\n\")`\r\n\r\nIs there a recommended maintained fork that patches this?", + "created_at": "2021-11-12T12:18:37Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-967068943", + "id": 967068943, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM45pE0P", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/967068943/reactions" + }, + "updated_at": "2021-11-12T23:21:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/967068943", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6132708?v=4", + "events_url": "https://api.github.com/users/cprn/events{/privacy}", + "followers_url": "https://api.github.com/users/cprn/followers", + "following_url": "https://api.github.com/users/cprn/following{/other_user}", + "gists_url": "https://api.github.com/users/cprn/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/cprn", + "id": 6132708, + "login": "cprn", + "node_id": "MDQ6VXNlcjYxMzI3MDg=", + "organizations_url": "https://api.github.com/users/cprn/orgs", + "received_events_url": "https://api.github.com/users/cprn/received_events", + "repos_url": "https://api.github.com/users/cprn/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/cprn/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/cprn/subscriptions", + "type": "User", + "url": "https://api.github.com/users/cprn" + } + }, + { + "author_association": "NONE", + "body": "So I guess the workaround in termguicolor terminals is to set `ctermfg=white` since this setting is not used anyway.. Well at least this awful underline is gone 😃 ", + "created_at": "2022-04-18T21:17:37Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-1101776120", + "id": 1101776120, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM5Bq8T4", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1101776120/reactions" + }, + "updated_at": "2022-04-18T21:17:37Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1101776120", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/19708025?v=4", + "events_url": "https://api.github.com/users/tummetott/events{/privacy}", + "followers_url": "https://api.github.com/users/tummetott/followers", + "following_url": "https://api.github.com/users/tummetott/following{/other_user}", + "gists_url": "https://api.github.com/users/tummetott/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tummetott", + "id": 19708025, + "login": "tummetott", + "node_id": "MDQ6VXNlcjE5NzA4MDI1", + "organizations_url": "https://api.github.com/users/tummetott/orgs", + "received_events_url": "https://api.github.com/users/tummetott/received_events", + "repos_url": "https://api.github.com/users/tummetott/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tummetott/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tummetott/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tummetott" + } + }, + { + "author_association": "NONE", + "body": "Does anyone know a solution with item2 to remove it? \r\n\"image\"\r\n", + "created_at": "2022-08-04T05:30:20Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-1204778874", + "id": 1204778874, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM5Hz3d6", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1204778874/reactions" + }, + "updated_at": "2022-08-04T05:30:20Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1204778874", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1819?v=4", + "events_url": "https://api.github.com/users/cj/events{/privacy}", + "followers_url": "https://api.github.com/users/cj/followers", + "following_url": "https://api.github.com/users/cj/following{/other_user}", + "gists_url": "https://api.github.com/users/cj/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/cj", + "id": 1819, + "login": "cj", + "node_id": "MDQ6VXNlcjE4MTk=", + "organizations_url": "https://api.github.com/users/cj/orgs", + "received_events_url": "https://api.github.com/users/cj/received_events", + "repos_url": "https://api.github.com/users/cj/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/cj/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/cj/subscriptions", + "type": "User", + "url": "https://api.github.com/users/cj" + } + }, + { + "author_association": "NONE", + "body": "I've noticed this as well. Playing around, it seems that setting the `Normal` highlight group might help. e.g.:\r\n\r\n```vim\r\nhi Normal ctermbg=White ctermfg=Black\r\n```\r\n\r\nEdit: I don't think this was as helpful as I'd hoped! I still get the underline.\r\n\r\n", + "created_at": "2022-08-22T11:34:14Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-1222229083", + "id": 1222229083, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM5I2bxb", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1222229083/reactions" + }, + "updated_at": "2022-08-24T18:55:40Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1222229083", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/566719?v=4", + "events_url": "https://api.github.com/users/casr/events{/privacy}", + "followers_url": "https://api.github.com/users/casr/followers", + "following_url": "https://api.github.com/users/casr/following{/other_user}", + "gists_url": "https://api.github.com/users/casr/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/casr", + "id": 566719, + "login": "casr", + "node_id": "MDQ6VXNlcjU2NjcxOQ==", + "organizations_url": "https://api.github.com/users/casr/orgs", + "received_events_url": "https://api.github.com/users/casr/received_events", + "repos_url": "https://api.github.com/users/casr/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/casr/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/casr/subscriptions", + "type": "User", + "url": "https://api.github.com/users/casr" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "> So I guess the workaround in termguicolor terminals is to set `ctermfg=white` since this setting is not used anyway.. Well at least this awful underline is gone 😃\r\n\r\nworked for me 🙂", + "created_at": "2023-01-04T01:23:12Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-1370388776", + "id": 1370388776, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM5Rrnko", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1370388776/reactions" + }, + "updated_at": "2023-01-04T01:23:12Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1370388776", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/10135646?v=4", + "events_url": "https://api.github.com/users/mikesmithgh/events{/privacy}", + "followers_url": "https://api.github.com/users/mikesmithgh/followers", + "following_url": "https://api.github.com/users/mikesmithgh/following{/other_user}", + "gists_url": "https://api.github.com/users/mikesmithgh/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mikesmithgh", + "id": 10135646, + "login": "mikesmithgh", + "node_id": "MDQ6VXNlcjEwMTM1NjQ2", + "organizations_url": "https://api.github.com/users/mikesmithgh/orgs", + "received_events_url": "https://api.github.com/users/mikesmithgh/received_events", + "repos_url": "https://api.github.com/users/mikesmithgh/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mikesmithgh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mikesmithgh/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mikesmithgh" + } + }, + { + "author_association": "CONTRIBUTOR", + "body": "@justinmk I think it's better to fix this issue before enabling `tgc` in #26407", + "created_at": "2023-12-06T09:41:01Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-1842525134", + "id": 1842525134, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM5t0rPO", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842525134/reactions" + }, + "updated_at": "2023-12-06T09:41:55Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842525134", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/27911493?v=4", + "events_url": "https://api.github.com/users/mortezadadgar/events{/privacy}", + "followers_url": "https://api.github.com/users/mortezadadgar/followers", + "following_url": "https://api.github.com/users/mortezadadgar/following{/other_user}", + "gists_url": "https://api.github.com/users/mortezadadgar/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mortezadadgar", + "id": 27911493, + "login": "mortezadadgar", + "node_id": "MDQ6VXNlcjI3OTExNDkz", + "organizations_url": "https://api.github.com/users/mortezadadgar/orgs", + "received_events_url": "https://api.github.com/users/mortezadadgar/received_events", + "repos_url": "https://api.github.com/users/mortezadadgar/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mortezadadgar/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mortezadadgar/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mortezadadgar" + } + }, + { + "author_association": "MEMBER", + "body": "Is this even still an issue with the new default colorscheme? ", + "created_at": "2023-12-06T10:09:01Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-1842570552", + "id": 1842570552, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM5t02U4", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842570552/reactions" + }, + "updated_at": "2023-12-06T10:34:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842570552", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "NONE", + "body": "@clason im still experiencing this issue with nvim 0.10", + "created_at": "2023-12-06T10:27:24Z", + "html_url": "https://github.com/neovim/neovim/issues/9800#issuecomment-1842598336", + "id": 1842598336, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "node_id": "IC_kwDOAPphoM5t09HA", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842598336/reactions" + }, + "updated_at": "2023-12-06T10:34:33Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842598336", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/19708025?v=4", + "events_url": "https://api.github.com/users/tummetott/events{/privacy}", + "followers_url": "https://api.github.com/users/tummetott/followers", + "following_url": "https://api.github.com/users/tummetott/following{/other_user}", + "gists_url": "https://api.github.com/users/tummetott/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/tummetott", + "id": 19708025, + "login": "tummetott", + "node_id": "MDQ6VXNlcjE5NzA4MDI1", + "organizations_url": "https://api.github.com/users/tummetott/orgs", + "received_events_url": "https://api.github.com/users/tummetott/received_events", + "repos_url": "https://api.github.com/users/tummetott/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/tummetott/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tummetott/subscriptions", + "type": "User", + "url": "https://api.github.com/users/tummetott" + } + } + ], + "comments": 11, + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/9800/comments", + "created_at": "2019-03-27T22:38:45Z", + "events_url": "https://api.github.com/repos/neovim/neovim/issues/9800/events", + "html_url": "https://github.com/neovim/neovim/issues/9800", + "id": 426214240, + "labels": [ + { + "color": "C5DEF5", + "default": false, + "description": "compatibility with Vim or older Neovim", + "id": 109899712, + "name": "compatibility", + "node_id": "MDU6TGFiZWwxMDk4OTk3MTI=", + "url": "https://api.github.com/repos/neovim/neovim/labels/compatibility" + }, + { + "color": "f9d0c4", + "default": false, + "description": "wrong behavior that was introduced in a previous commit (please bisect)", + "id": 619474658, + "name": "bug-regression", + "node_id": "MDU6TGFiZWw2MTk0NzQ2NTg=", + "url": "https://api.github.com/repos/neovim/neovim/labels/bug-regression" + }, + { + "color": "c5def5", + "default": false, + "description": "redraw", + "id": 718084050, + "name": "display", + "node_id": "MDU6TGFiZWw3MTgwODQwNTA=", + "url": "https://api.github.com/repos/neovim/neovim/labels/display" + }, + { + "color": "c5def5", + "default": false, + "description": "Nvim core functionality or code", + "id": 858327504, + "name": "core", + "node_id": "MDU6TGFiZWw4NTgzMjc1MDQ=", + "url": "https://api.github.com/repos/neovim/neovim/labels/core" + }, + { + "color": "c5def5", + "default": false, + "description": "", + "id": 1786207367, + "name": "highlight", + "node_id": "MDU6TGFiZWwxNzg2MjA3MzY3", + "url": "https://api.github.com/repos/neovim/neovim/labels/highlight" + } + ], + "labels_url": "https://api.github.com/repos/neovim/neovim/issues/9800/labels{/name}", + "locked": false, + "milestone": { + "closed_at": null, + "closed_issues": 592, + "created_at": "2014-05-10T20:43:04Z", + "creator": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "description": "Low priority. Not planned for the current target, may be reassigned.", + "due_on": null, + "html_url": "https://github.com/neovim/neovim/milestone/6", + "id": 655037, + "labels_url": "https://api.github.com/repos/neovim/neovim/milestones/6/labels", + "node_id": "MDk6TWlsZXN0b25lNjU1MDM3", + "number": 6, + "open_issues": 427, + "state": "open", + "title": "backlog", + "updated_at": "2023-12-06T23:16:41Z", + "url": "https://api.github.com/repos/neovim/neovim/milestones/6" + }, + "node_id": "MDU6SXNzdWU0MjYyMTQyNDA=", + "number": 9800, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/9800/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/neovim", + "state": "open", + "state_reason": null, + "timeline_url": "https://api.github.com/repos/neovim/neovim/issues/9800/timeline", + "title": "Cursorline has unwanted underline in DiffChange/DiffAdd regions", + "updated_at": "2023-12-06T10:34:33Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/9800", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7074?v=4", + "events_url": "https://api.github.com/users/wincent/events{/privacy}", + "followers_url": "https://api.github.com/users/wincent/followers", + "following_url": "https://api.github.com/users/wincent/following{/other_user}", + "gists_url": "https://api.github.com/users/wincent/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/wincent", + "id": 7074, + "login": "wincent", + "node_id": "MDQ6VXNlcjcwNzQ=", + "organizations_url": "https://api.github.com/users/wincent/orgs", + "received_events_url": "https://api.github.com/users/wincent/received_events", + "repos_url": "https://api.github.com/users/wincent/repos", + "site_admin": true, + "starred_url": "https://api.github.com/users/wincent/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/wincent/subscriptions", + "type": "User", + "url": "https://api.github.com/users/wincent" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/21370.json b/repositories/neovim/pulls/21370.json index 036d0c6a..1566dacd 100644 --- a/repositories/neovim/pulls/21370.json +++ b/repositories/neovim/pulls/21370.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5000, - "forks_count": 5000, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -94,8 +94,8 @@ "name": "neovim", "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", - "open_issues": 1690, - "open_issues_count": 1690, + "open_issues": 1707, + "open_issues_count": 1707, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-11-22T01:50:28Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 234192, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71096, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-11-21T23:18:53Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71096, - "watchers_count": 71096, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "70da793c5eda9f3e533a137ac0c0e31db1df0324", @@ -487,9 +487,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/clason/neovim/pulls{/number}", - "pushed_at": "2023-11-21T21:40:58Z", + "pushed_at": "2023-12-06T14:39:51Z", "releases_url": "https://api.github.com/repos/clason/neovim/releases{/id}", - "size": 231455, + "size": 238533, "ssh_url": "git@github.com:clason/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/clason/neovim/stargazers", @@ -567,7 +567,7 @@ "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/58c23318c6fb5e8cd4cd70851c347b06e53325eb", "title": "fix(highlight): corrections for on_yank with virtualedit", - "updated_at": "2023-11-21T08:30:19Z", + "updated_at": "2023-12-06T14:39:51Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/21370", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", diff --git a/repositories/neovim/pulls/22649.json b/repositories/neovim/pulls/22649.json new file mode 100644 index 00000000..6b75a1e3 --- /dev/null +++ b/repositories/neovim/pulls/22649.json @@ -0,0 +1,407 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/22649/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/22649/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/22649" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/22649" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/22649/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/22649" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/bf18cb1a01185797a6c9f84c2db8154429ab0bd5" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "fd2ece278b0941ec6673489e88868120e86b834a", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "ref fd2ece278b09", + "closed_at": "2023-03-13T00:13:33Z", + "comment_data": [], + "comment_regular_data": [ + { + "author_association": "MEMBER", + "body": "https://github.com/neovim/neovim/pull/22648", + "created_at": "2023-03-13T00:13:32Z", + "html_url": "https://github.com/neovim/neovim/pull/22649#issuecomment-1465341046", + "id": 1465341046, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/22649", + "node_id": "IC_kwDOAPphoM5XV1R2", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1465341046/reactions" + }, + "updated_at": "2023-03-13T00:13:32Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1465341046", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/22649/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/22649/commits", + "created_at": "2023-03-13T00:13:13Z", + "diff_url": "https://github.com/neovim/neovim/pull/22649.diff", + "draft": false, + "head": { + "label": "justinmk:fixtest", + "ref": "fixtest", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/justinmk/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/justinmk/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/justinmk/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/justinmk/neovim/branches{/branch}", + "clone_url": "https://github.com/justinmk/neovim.git", + "collaborators_url": "https://api.github.com/repos/justinmk/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/justinmk/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/justinmk/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/justinmk/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/justinmk/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/justinmk/neovim/contributors", + "created_at": "2014-02-28T23:17:54Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/justinmk/neovim/deployments", + "description": "somewhere in todo.txt", + "disabled": false, + "downloads_url": "https://api.github.com/repos/justinmk/neovim/downloads", + "events_url": "https://api.github.com/repos/justinmk/neovim/events", + "fork": true, + "forks": 1, + "forks_count": 1, + "forks_url": "https://api.github.com/repos/justinmk/neovim/forks", + "full_name": "justinmk/neovim", + "git_commits_url": "https://api.github.com/repos/justinmk/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/justinmk/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/justinmk/neovim/git/tags{/sha}", + "git_url": "git://github.com/justinmk/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": false, + "has_wiki": false, + "homepage": "http://neovim.io", + "hooks_url": "https://api.github.com/repos/justinmk/neovim/hooks", + "html_url": "https://github.com/justinmk/neovim", + "id": 17302877, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/justinmk/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/justinmk/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/justinmk/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/justinmk/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/justinmk/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/justinmk/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/justinmk/neovim/merges", + "milestones_url": "https://api.github.com/repos/justinmk/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNzMwMjg3Nw==", + "notifications_url": "https://api.github.com/repos/justinmk/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/justinmk/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:26:59Z", + "releases_url": "https://api.github.com/repos/justinmk/neovim/releases{/id}", + "size": 237709, + "ssh_url": "git@github.com:justinmk/neovim.git", + "stargazers_count": 1, + "stargazers_url": "https://api.github.com/repos/justinmk/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/justinmk/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/justinmk/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/justinmk/neovim/subscription", + "svn_url": "https://github.com/justinmk/neovim", + "tags_url": "https://api.github.com/repos/justinmk/neovim/tags", + "teams_url": "https://api.github.com/repos/justinmk/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/justinmk/neovim/git/trees{/sha}", + "updated_at": "2023-07-25T13:51:02Z", + "url": "https://api.github.com/repos/justinmk/neovim", + "visibility": "public", + "watchers": 1, + "watchers_count": 1, + "web_commit_signoff_required": false + }, + "sha": "bf18cb1a01185797a6c9f84c2db8154429ab0bd5", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/22649", + "id": 1272480449, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/22649", + "labels": [ + { + "color": "c5def5", + "default": false, + "description": "", + "id": 110418643, + "name": "test", + "node_id": "MDU6TGFiZWwxMTA0MTg2NDM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/test" + } + ], + "locked": false, + "merge_commit_sha": "dec91098b8b8f80a1b6ebdf9791b338263f5a86d", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5L2ILB", + "number": 22649, + "patch_url": "https://github.com/neovim/neovim/pull/22649.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/22649/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/bf18cb1a01185797a6c9f84c2db8154429ab0bd5", + "title": "test: add sum_scroll_delta to screen tests", + "updated_at": "2023-12-06T15:21:18Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/22649", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/25154.json b/repositories/neovim/pulls/25154.json index b06d779d..37858476 100644 --- a/repositories/neovim/pulls/25154.json +++ b/repositories/neovim/pulls/25154.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "2e92065686f62851318150a315591c30b8306a4b", @@ -1892,7 +1892,7 @@ } ], "locked": false, - "merge_commit_sha": "96b376bfe8a7173c1ad7a4f14d1c67e4eec262d0", + "merge_commit_sha": "1c5fa7a0105d63efbdb6c25d6a12246d91214f9a", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5aVNbm", diff --git a/repositories/neovim/pulls/25289.json b/repositories/neovim/pulls/25289.json index 96335bd9..5f6078a9 100644 --- a/repositories/neovim/pulls/25289.json +++ b/repositories/neovim/pulls/25289.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/25289" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/2bb13443d022c113b97fb4ef49a2b35973abb65a" + "href": "https://api.github.com/repos/neovim/neovim/statuses/961c8ac254cd3cba4795ce4d21a54281d5d889ce" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5021, - "forks_count": 5021, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -94,8 +94,8 @@ "name": "neovim", "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", - "open_issues": 1692, - "open_issues_count": 1692, + "open_issues": 1707, + "open_issues_count": 1707, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-11-28T00:15:26Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 236645, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71282, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-11-28T01:47:09Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71282, - "watchers_count": 71282, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "5b765fcab42308cd4d97a4c37da0c2b1cdb3514d", + "sha": "8bb5089974e14f043a0b0c17e4d38dbd0b9a9ab2", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -266,9 +266,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/justinmk/neovim/pulls{/number}", - "pushed_at": "2023-11-27T14:31:33Z", + "pushed_at": "2023-12-07T01:26:59Z", "releases_url": "https://api.github.com/repos/justinmk/neovim/releases{/id}", - "size": 230853, + "size": 237709, "ssh_url": "git@github.com:justinmk/neovim.git", "stargazers_count": 1, "stargazers_url": "https://api.github.com/repos/justinmk/neovim/stargazers", @@ -287,7 +287,7 @@ "watchers_count": 1, "web_commit_signoff_required": false }, - "sha": "2bb13443d022c113b97fb4ef49a2b35973abb65a", + "sha": "961c8ac254cd3cba4795ce4d21a54281d5d889ce", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", "events_url": "https://api.github.com/users/justinmk/events{/privacy}", @@ -324,7 +324,7 @@ } ], "locked": false, - "merge_commit_sha": "cc00d1c63cdcb75f256dead2892273c7e725ec7b", + "merge_commit_sha": "85fc05b88d4d9bd09b00999f462f8a7269418487", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5a30V0", @@ -335,9 +335,9 @@ "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/25289/comments", "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/2bb13443d022c113b97fb4ef49a2b35973abb65a", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/961c8ac254cd3cba4795ce4d21a54281d5d889ce", "title": "docs", - "updated_at": "2023-11-27T14:31:37Z", + "updated_at": "2023-12-06T22:09:15Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/25289", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", diff --git a/repositories/neovim/pulls/25461.json b/repositories/neovim/pulls/25461.json index 1b0be834..8f256007 100644 --- a/repositories/neovim/pulls/25461.json +++ b/repositories/neovim/pulls/25461.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 4983, - "forks_count": 4983, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -94,8 +94,8 @@ "name": "neovim", "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", - "open_issues": 1682, - "open_issues_count": 1682, + "open_issues": 1707, + "open_issues_count": 1707, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-11-16T01:54:47Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 230640, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 70930, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-11-16T01:40:26Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 70930, - "watchers_count": 70930, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "d92dd2a0c05148154c353f0e7cd2099b2427308a", @@ -662,7 +662,7 @@ } }, "author_association": "NONE", - "body": "How would I do that nicely given that I have to format the string inside the `[[...]]`?\r\n\r\nI thought it would be nice not to have the file name/content hard coded in the string 30 times to make the code easier to maintain, but if that style of creating the literals is not in line with the rest of the tests I can change it.", + "body": "@justinmk How would I do that nicely given that I have to format the string inside the `[[...]]`?\r\n\r\nI thought it would be nice not to have the file name/content hard coded in the string 30 times to make the code easier to maintain, but if that style of creating the literals is not in line with the rest of the tests I can change it.", "commit_id": "95a9a75a92806e69bea97c88538d8b2403d6a91c", "created_at": "2023-11-15T21:41:55Z", "diff_hunk": "@@ -182,6 +182,109 @@ describe(\"jumpoptions=stack behaves like 'tagstack'\", function()\n end)\n end)\n \n+describe('buffer deletion', function()\n+ local base_file = 'Xtest-functional-buffer-deletion'\n+ local file1 = base_file..'1'\n+ local file2 = base_file..'2'\n+ local file3 = base_file..'3'\n+ local base_content = 'text'\n+ local content1 = base_content..'1'\n+ local content2 = base_content..'2'\n+ local content3 = base_content..'3'\n+ local function delete_buf(file)\n+ local bufnr = funcs.bufnr(file)\n+ command('bw '..bufnr)\n+ end\n+\n+ before_each(function()\n+ clear()\n+ command('clearjumps')\n+\n+ write_file(file1, content1, false, false)\n+ write_file(file2, content2, false, false)\n+ write_file(file3, content3, false, false)\n+\n+ command(\"edit \" .. file1)\n+ command(\"edit \" .. file2)\n+ command(\"edit \" .. file3)\n+ end)\n+\n+ it('deletes jump list entries when the current buffer is deleted', function()\n+ command(\"edit \" .. file1)\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 3 1 0 '..content1..'\\n'\n+ .. ' 2 1 0 '..file2..'\\n'\n+ .. ' 1 1 0 '..file3..'\\n'\n+ .. '>',\n+ exec_capture('jumps'))\n+\n+ command('bw')\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '> 0 1 0 '..content3,\n+ exec_capture('jumps'))\n+ end)\n+\n+ it('deletes jump list entries when another buffer is deleted', function()\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 2 1 0 '..file1..'\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '>',", @@ -695,7 +695,7 @@ "start_line": 229, "start_side": "RIGHT", "subject_type": "line", - "updated_at": "2023-11-15T21:45:13Z", + "updated_at": "2023-11-21T11:24:30Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1394839520", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/24727270?v=4", @@ -717,6 +717,212 @@ "type": "User", "url": "https://api.github.com/users/vE5li" } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/25461#discussion_r1417289123" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/25461" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417289123" + } + }, + "author_association": "NONE", + "body": "@justinmk I really don't want to be pushy and I know you're a busy guy but it would be really great if you could help me out here and tell me what else I need to do before merging", + "commit_id": "95a9a75a92806e69bea97c88538d8b2403d6a91c", + "created_at": "2023-12-06T13:20:30Z", + "diff_hunk": "@@ -182,6 +182,109 @@ describe(\"jumpoptions=stack behaves like 'tagstack'\", function()\n end)\n end)\n \n+describe('buffer deletion', function()\n+ local base_file = 'Xtest-functional-buffer-deletion'\n+ local file1 = base_file..'1'\n+ local file2 = base_file..'2'\n+ local file3 = base_file..'3'\n+ local base_content = 'text'\n+ local content1 = base_content..'1'\n+ local content2 = base_content..'2'\n+ local content3 = base_content..'3'\n+ local function delete_buf(file)\n+ local bufnr = funcs.bufnr(file)\n+ command('bw '..bufnr)\n+ end\n+\n+ before_each(function()\n+ clear()\n+ command('clearjumps')\n+\n+ write_file(file1, content1, false, false)\n+ write_file(file2, content2, false, false)\n+ write_file(file3, content3, false, false)\n+\n+ command(\"edit \" .. file1)\n+ command(\"edit \" .. file2)\n+ command(\"edit \" .. file3)\n+ end)\n+\n+ it('deletes jump list entries when the current buffer is deleted', function()\n+ command(\"edit \" .. file1)\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 3 1 0 '..content1..'\\n'\n+ .. ' 2 1 0 '..file2..'\\n'\n+ .. ' 1 1 0 '..file3..'\\n'\n+ .. '>',\n+ exec_capture('jumps'))\n+\n+ command('bw')\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '> 0 1 0 '..content3,\n+ exec_capture('jumps'))\n+ end)\n+\n+ it('deletes jump list entries when another buffer is deleted', function()\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 2 1 0 '..file1..'\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '>',", + "html_url": "https://github.com/neovim/neovim/pull/25461#discussion_r1417289123", + "id": 1417289123, + "in_reply_to_id": 1392596770, + "line": 233, + "node_id": "PRRC_kwDOAPphoM5Ueh2j", + "original_commit_id": "bf6678877793fb7ffb85cd0c9d0b0f913cf99d08", + "original_line": 237, + "original_position": 56, + "original_start_line": 233, + "path": "test/functional/editor/jump_spec.lua", + "position": 52, + "pull_request_review_id": 1767536828, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/25461", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417289123/reactions" + }, + "side": "RIGHT", + "start_line": 229, + "start_side": "RIGHT", + "subject_type": "line", + "updated_at": "2023-12-06T13:20:31Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417289123", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/24727270?v=4", + "events_url": "https://api.github.com/users/vE5li/events{/privacy}", + "followers_url": "https://api.github.com/users/vE5li/followers", + "following_url": "https://api.github.com/users/vE5li/following{/other_user}", + "gists_url": "https://api.github.com/users/vE5li/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/vE5li", + "id": 24727270, + "login": "vE5li", + "node_id": "MDQ6VXNlcjI0NzI3Mjcw", + "organizations_url": "https://api.github.com/users/vE5li/orgs", + "received_events_url": "https://api.github.com/users/vE5li/received_events", + "repos_url": "https://api.github.com/users/vE5li/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/vE5li/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/vE5li/subscriptions", + "type": "User", + "url": "https://api.github.com/users/vE5li" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/25461#discussion_r1418116077" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/25461" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418116077" + } + }, + "author_association": "MEMBER", + "body": "> I thought it would be nice not to have the file name/content hard coded in the string\r\n\r\ndefinitely. sometimes it's worth using a trick like replacing a token, e.g. `(([[foo {file1} ...]]):gsub('%{file1%}', 'x'))`\r\n\r\ndon't need to block on this, though.", + "commit_id": "95a9a75a92806e69bea97c88538d8b2403d6a91c", + "created_at": "2023-12-06T23:38:06Z", + "diff_hunk": "@@ -182,6 +182,109 @@ describe(\"jumpoptions=stack behaves like 'tagstack'\", function()\n end)\n end)\n \n+describe('buffer deletion', function()\n+ local base_file = 'Xtest-functional-buffer-deletion'\n+ local file1 = base_file..'1'\n+ local file2 = base_file..'2'\n+ local file3 = base_file..'3'\n+ local base_content = 'text'\n+ local content1 = base_content..'1'\n+ local content2 = base_content..'2'\n+ local content3 = base_content..'3'\n+ local function delete_buf(file)\n+ local bufnr = funcs.bufnr(file)\n+ command('bw '..bufnr)\n+ end\n+\n+ before_each(function()\n+ clear()\n+ command('clearjumps')\n+\n+ write_file(file1, content1, false, false)\n+ write_file(file2, content2, false, false)\n+ write_file(file3, content3, false, false)\n+\n+ command(\"edit \" .. file1)\n+ command(\"edit \" .. file2)\n+ command(\"edit \" .. file3)\n+ end)\n+\n+ it('deletes jump list entries when the current buffer is deleted', function()\n+ command(\"edit \" .. file1)\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 3 1 0 '..content1..'\\n'\n+ .. ' 2 1 0 '..file2..'\\n'\n+ .. ' 1 1 0 '..file3..'\\n'\n+ .. '>',\n+ exec_capture('jumps'))\n+\n+ command('bw')\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '> 0 1 0 '..content3,\n+ exec_capture('jumps'))\n+ end)\n+\n+ it('deletes jump list entries when another buffer is deleted', function()\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 2 1 0 '..file1..'\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '>',", + "html_url": "https://github.com/neovim/neovim/pull/25461#discussion_r1418116077", + "id": 1418116077, + "in_reply_to_id": 1392596770, + "line": 233, + "node_id": "PRRC_kwDOAPphoM5Uhrvt", + "original_commit_id": "bf6678877793fb7ffb85cd0c9d0b0f913cf99d08", + "original_line": 237, + "original_position": 56, + "original_start_line": 233, + "path": "test/functional/editor/jump_spec.lua", + "position": 52, + "pull_request_review_id": 1768842029, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/25461", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418116077/reactions" + }, + "side": "RIGHT", + "start_line": 229, + "start_side": "RIGHT", + "subject_type": "line", + "updated_at": "2023-12-06T23:38:06Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418116077", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/25461#discussion_r1418129363" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/25461" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418129363" + } + }, + "author_association": "MEMBER", + "body": "there is also `:help getjumplist()`, would that be useful for checking this instead of a `:jumps` screentest?\r\n\r\n(note: the existing tests in this file were added before `getjumplist()` was added).\r\n\r\n```suggestion\r\n eq({ ... }, funcs.getjumplist())\r\n```", + "commit_id": "95a9a75a92806e69bea97c88538d8b2403d6a91c", + "created_at": "2023-12-06T23:53:19Z", + "diff_hunk": "@@ -182,6 +182,105 @@ describe(\"jumpoptions=stack behaves like 'tagstack'\", function()\n end)\n end)\n \n+describe('buffer deletion', function()\n+ local base_file = 'Xtest-functional-buffer-deletion'\n+ local file1 = base_file..'1'\n+ local file2 = base_file..'2'\n+ local file3 = base_file..'3'\n+ local base_content = 'text'\n+ local content1 = base_content..'1'\n+ local content2 = base_content..'2'\n+ local content3 = base_content..'3'\n+\n+ before_each(function()\n+ clear()\n+ command('clearjumps')\n+\n+ write_file(file1, content1, false, false)\n+ write_file(file2, content2, false, false)\n+ write_file(file3, content3, false, false)\n+\n+ command(\"edit \" .. file1)\n+ command(\"edit \" .. file2)\n+ command(\"edit \" .. file3)\n+ end)\n+\n+ it('deletes jump list entries when the current buffer is deleted', function()\n+ command(\"edit \" .. file1)\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 3 1 0 '..content1..'\\n'\n+ .. ' 2 1 0 '..file2..'\\n'\n+ .. ' 1 1 0 '..file3..'\\n'\n+ .. '>',\n+ exec_capture('jumps'))\n+\n+ command('bwipeout')\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '> 0 1 0 '..content3,\n+ exec_capture('jumps'))\n+ end)\n+\n+ it('deletes jump list entries when another buffer is deleted', function()\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 2 1 0 '..file1..'\\n'\n+ .. ' 1 1 0 '..file2..'\\n'\n+ .. '>',\n+ exec_capture('jumps'))\n+\n+ command('bwipeout '..file2)\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 1 1 0 '..file1..'\\n'\n+ .. '>',\n+ exec_capture('jumps'))\n+ end)\n+\n+ it('sets the correct jump index when the current buffer is deleted', function()\n+ feed('')\n+\n+ eq( ''\n+ .. ' jump line col file/text\\n'\n+ .. ' 1 1 0 '..file1..'\\n'\n+ .. '> 0 1 0 '..content2..'\\n'\n+ .. ' 1 1 0 '..file3,\n+ exec_capture('jumps'))", + "html_url": "https://github.com/neovim/neovim/pull/25461#discussion_r1418129363", + "id": 1418129363, + "line": 253, + "node_id": "PRRC_kwDOAPphoM5Uhu_T", + "original_commit_id": "95a9a75a92806e69bea97c88538d8b2403d6a91c", + "original_line": 253, + "original_position": 72, + "original_start_line": 248, + "path": "test/functional/editor/jump_spec.lua", + "position": 72, + "pull_request_review_id": 1768854392, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/25461", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418129363/reactions" + }, + "side": "RIGHT", + "start_line": 248, + "start_side": "RIGHT", + "subject_type": "line", + "updated_at": "2023-12-06T23:53:20Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418129363", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } } ], "comment_regular_data": [ @@ -939,6 +1145,50 @@ "type": "User", "url": "https://api.github.com/users/justinmk" } + }, + { + "author_association": "MEMBER", + "body": "> I really don't want to be pushy and I know you're a busy guy but it would be really great if you could help me out here and tell me what else I need to do before merging\r\n\r\n- Pinging is helpful, so thanks the for the ping :)\r\n- It is extremely helpful to keep the PR fresh (rebased on latest master). Even though it might sit for awhile, it saves time for everyone if the PR is ready to go when a reviewer gets to it. It also means the latest CI runs against it.\r\n- It looks like CI is failing, did you check those?\r\n - If it goes away after rebasing, it's possible that it was fixed on master. But this failure looks related to this PR since it involves `xfmark_T`.\r\n ```\r\n RUN T5130 float window with only one tabpage, deleting the last non-floating window's buffer closes other windows with that buffer when there are other buffers if called from non-floating window: 110.00 ms OK\r\n ==================== File /home/runner/work/neovim/neovim/build/log/asan.28132 ====================\r\n = /home/runner/work/neovim/neovim/src/nvim/buffer.c:1417:30: runtime error: index -1 out of bounds for type 'xfmark_T[100]' (aka 'struct xfilemark[100]')\r\n = #0 0x55ab8a61becc in do_buffer /home/runner/work/neovim/neovim/src/nvim/buffer.c:1417:58\r\n = #1 0x55ab8a385337 in nvim_buf_delete /home/runner/work/neovim/neovim/src/nvim/api/buffer.c:1113:16\r\n = #2 0x55ab8a45cda5 in handle_nvim_buf_delete /home/runner/work/neovim/neovim/build/src/nvim/auto/api/private/dispatch_wrappers.generated.h:2668:3\r\n = #3 0x55ab8b1d7aea in request_event /home/runner/work/neovim/neovim/src/nvim/msgpack_rpc/channel.c:441:19\r\n = #4 0x55ab8b84e05d in state_handle_k_event /home/runner/work/neovim/neovim/src/nvim/state.c:114:7\r\n = #5 0x55ab8b265a90 in nv_event /home/runner/work/neovim/neovim/src/nvim/normal.c:6626:3\r\n = #6 0x55ab8b229251 in normal_execute /home/runner/work/neovim/neovim/src/nvim/normal.c:1224:3\r\n = #7 0x55ab8b84ddd9 in state_enter /home/runner/work/neovim/neovim/src/nvim/state.c:96:26\r\n = #8 0x55ab8b20b6d4 in normal_enter /home/runner/work/neovim/neovim/src/nvim/normal.c:513:3\r\n = #9 0x55ab8a2ebb9b in main /home/runner/work/neovim/neovim/src/nvim/main.c:634:3\r\n = #10 0x7f22d9029d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16\r\n = #11 0x7f22d9029e3f in __libc_start_main csu/../csu/libc-start.c:392:3\r\n = #12 0x55ab8a20ef34 in _start (/home/runner/work/neovim/neovim/build/bin/nvim+0xbcdf34) (BuildId: 11f2a7e818f3896d5facd604dc4e68e21dd2ebd1)\r\n = \r\n = SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/runner/work/neovim/neovim/src/nvim/buffer.c:1417:30 in \r\n ===================================================================================================\r\n nan ms test/helpers.lua:334: Found runtime errors in logfile(s): /home/runner/work/neovim/neovim/build/log/asan.28132\r\n\r\n stack traceback:\r\n test/helpers.lua:334: in function 'check_logs'\r\n test/functional/helpers.lua:959: in function \r\n ```\r\n", + "created_at": "2023-12-06T23:43:13Z", + "html_url": "https://github.com/neovim/neovim/pull/25461#issuecomment-1843865794", + "id": 1843865794, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/25461", + "node_id": "IC_kwDOAPphoM5t5yjC", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843865794/reactions" + }, + "updated_at": "2023-12-06T23:47:58Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843865794", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } } ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/25461/comments", @@ -1034,9 +1284,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/vE5li/neovim/pulls{/number}", - "pushed_at": "2023-11-15T21:44:22Z", + "pushed_at": "2023-12-06T05:21:15Z", "releases_url": "https://api.github.com/repos/vE5li/neovim/releases{/id}", - "size": 224155, + "size": 231432, "ssh_url": "git@github.com:vE5li/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/vE5li/neovim/stargazers", @@ -1092,7 +1342,7 @@ } ], "locked": false, - "merge_commit_sha": "ed8c0bb8beed5f0ce439e3bce59865a5c6e6aa78", + "merge_commit_sha": "2700a623b1e202830d805f975c9923f0ae7f9962", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5bnbbJ", @@ -1105,7 +1355,7 @@ "state": "open", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/95a9a75a92806e69bea97c88538d8b2403d6a91c", "title": "fix(jumplist): update jump list when deleting buffers", - "updated_at": "2023-11-15T21:44:25Z", + "updated_at": "2023-12-06T23:53:24Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/25461", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/24727270?v=4", diff --git a/repositories/neovim/pulls/25564.json b/repositories/neovim/pulls/25564.json index 4054ba3a..edb2d2e8 100644 --- a/repositories/neovim/pulls/25564.json +++ b/repositories/neovim/pulls/25564.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/25564" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/c72dd3774ba042e28ae165a9275bc08aa738d45e" + "href": "https://api.github.com/repos/neovim/neovim/statuses/92478b17db0275f3699886b7f46cf94a82d4c929" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 4912, - "forks_count": 4912, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -94,8 +94,8 @@ "name": "neovim", "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", - "open_issues": 1653, - "open_issues_count": 1653, + "open_issues": 1707, + "open_issues_count": 1707, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-10-10T01:53:17Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 252665, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 70016, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-10-10T00:53:55Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 70016, - "watchers_count": 70016, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "6c0f900699293937435591412e4285e313703bc7", + "sha": "f64e4b43e1191ff30d902730f752875aa55682ce", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -170,9 +170,348 @@ } }, "body": "I believe I have fixed the json_decode function so that it allows for json objects with empty string keys as it should.\r\n\r\nResolves #20757.", - "closed_at": null, - "comment_data": [], - "comment_regular_data": [], + "closed_at": "2023-12-06T15:56:04Z", + "comment_data": [ + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/25564#discussion_r1417433419" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/25564" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417433419" + } + }, + "author_association": "MEMBER", + "body": "why was the `obj.val.vval.v_string == NULL` check removed?", + "commit_id": "92478b17db0275f3699886b7f46cf94a82d4c929", + "created_at": "2023-12-06T14:40:46Z", + "diff_hunk": "@@ -170,11 +168,9 @@ static inline int json_decoder_pop(ValuesStackItem obj, ValuesStack *const stack\n tv_clear(&obj.val);\n return FAIL;\n }\n- // Handle empty key and key represented as special dictionary\n+ // Handle special dictionaries\n if (last_container.special_val == NULL\n && (obj.is_special_string\n- || obj.val.vval.v_string == NULL\n- || *obj.val.vval.v_string == NUL", + "html_url": "https://github.com/neovim/neovim/pull/25564#discussion_r1417433419", + "id": 1417433419, + "line": 177, + "node_id": "PRRC_kwDOAPphoM5UfFFL", + "original_commit_id": "f2f34d90c2e9b862c4e7189e435b0b12314bfad2", + "original_line": 177, + "original_position": 20, + "original_start_line": null, + "path": "src/nvim/eval/decode.c", + "position": 20, + "pull_request_review_id": 1767748916, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/25564", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417433419/reactions" + }, + "side": "LEFT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T14:40:47Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417433419", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/25564#discussion_r1417434439" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/25564" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417434439" + } + }, + "author_association": "MEMBER", + "body": "Leaving this as a TODO for now, I guess... (edit: https://github.com/neovim/neovim/pull/26426 )\r\n\r\nFrom 7c01d5ff9286d262097484c680e3a4eab49e2911", + "commit_id": "92478b17db0275f3699886b7f46cf94a82d4c929", + "created_at": "2023-12-06T14:41:29Z", + "diff_hunk": "@@ -577,6 +576,8 @@ describe('json_encode() function', function()\n eq('{}', eval('json_encode({})'))\n eq('{\"d\": []}', funcs.json_encode({d={}}))\n eq('{\"d\": [], \"e\": []}', funcs.json_encode({d={}, e={}}))\n+ -- Empty keys not allowed (yet?) in object_to_vim(). #25564\n+ -- eq('{\"\": []}', funcs.json_encode({['']={}}))", + "html_url": "https://github.com/neovim/neovim/pull/25564#discussion_r1417434439", + "id": 1417434439, + "line": 580, + "node_id": "PRRC_kwDOAPphoM5UfFVH", + "original_commit_id": "f2f34d90c2e9b862c4e7189e435b0b12314bfad2", + "original_line": 580, + "original_position": 31, + "original_start_line": null, + "path": "test/functional/vimscript/json_functions_spec.lua", + "position": 31, + "pull_request_review_id": 1767750654, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/25564", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417434439/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T16:25:25Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417434439", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/25564#discussion_r1417481197" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/25564" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417481197" + } + }, + "author_association": "MEMBER", + "body": "I reverted that. https://github.com/neovim/neovim/pull/25564/commits/92478b17db0275f3699886b7f46cf94a82d4c929", + "commit_id": "92478b17db0275f3699886b7f46cf94a82d4c929", + "created_at": "2023-12-06T15:09:04Z", + "diff_hunk": "@@ -170,11 +168,9 @@ static inline int json_decoder_pop(ValuesStackItem obj, ValuesStack *const stack\n tv_clear(&obj.val);\n return FAIL;\n }\n- // Handle empty key and key represented as special dictionary\n+ // Handle special dictionaries\n if (last_container.special_val == NULL\n && (obj.is_special_string\n- || obj.val.vval.v_string == NULL\n- || *obj.val.vval.v_string == NUL", + "html_url": "https://github.com/neovim/neovim/pull/25564#discussion_r1417481197", + "id": 1417481197, + "in_reply_to_id": 1417433419, + "line": 177, + "node_id": "PRRC_kwDOAPphoM5UfQvt", + "original_commit_id": "f2f34d90c2e9b862c4e7189e435b0b12314bfad2", + "original_line": 177, + "original_position": 20, + "original_start_line": null, + "path": "src/nvim/eval/decode.c", + "position": 20, + "pull_request_review_id": 1767827408, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/25564", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417481197/reactions" + }, + "side": "LEFT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T15:36:18Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417481197", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comment_regular_data": [ + { + "author_association": "CONTRIBUTOR", + "body": "I would really like to see this merged, I would really appreciate if you could take a look @justinmk. :)", + "created_at": "2023-12-06T07:20:16Z", + "html_url": "https://github.com/neovim/neovim/pull/25564#issuecomment-1842226056", + "id": 1842226056, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/25564", + "node_id": "IC_kwDOAPphoM5tziOI", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842226056/reactions" + }, + "updated_at": "2023-12-06T07:22:17Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842226056", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/29512047?v=4", + "events_url": "https://api.github.com/users/Quaqqer/events{/privacy}", + "followers_url": "https://api.github.com/users/Quaqqer/followers", + "following_url": "https://api.github.com/users/Quaqqer/following{/other_user}", + "gists_url": "https://api.github.com/users/Quaqqer/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Quaqqer", + "id": 29512047, + "login": "Quaqqer", + "node_id": "MDQ6VXNlcjI5NTEyMDQ3", + "organizations_url": "https://api.github.com/users/Quaqqer/orgs", + "received_events_url": "https://api.github.com/users/Quaqqer/received_events", + "repos_url": "https://api.github.com/users/Quaqqer/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Quaqqer/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Quaqqer/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Quaqqer" + } + }, + { + "author_association": "MEMBER", + "body": "edit: I pushed these changes to the PR myself. (but please consider these for future PRs)\r\n\r\n- `:help msgpack-special-dict` was not updated.\r\n- is there a similar test for `vim.json.decode`? if not please add one here: https://github.com/neovim/neovim/blob/040369e1e4b86c4655a6885b36ee89ad4f10ca16/test/functional/lua/json_spec.lua#L7\r\n- the last 2 comments in https://github.com/neovim/neovim/issues/20757 share useful context that should be included/discussed (concisely) in the commit message. at minimum, mention:\r\n\r\n> https://github.com/neovim/neovim/pull/4131 added this \"special dict\" to support roundtripping, but:\r\n> - there is no explicit discussion of empty keys (which are allowed in JSON)\r\n> - empty keys are already supported when using vim.call:\r\n> ```\r\n> :echo v:lua.vim.call('json_decode', '{\"\": \"1\"}')\r\n> ```", + "created_at": "2023-12-06T14:01:12Z", + "html_url": "https://github.com/neovim/neovim/pull/25564#issuecomment-1842948895", + "id": 1842948895, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/25564", + "node_id": "IC_kwDOAPphoM5t2Ssf", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842948895/reactions" + }, + "updated_at": "2023-12-06T14:43:14Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842948895", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "MEMBER", + "body": "Note that we still (currently) disallow empty keys in msgpack => Vim conversion (since 7c01d5ff9286d262097484c680e3a4eab49e2911):\r\n\r\nhttps://github.com/neovim/neovim/blob/f64e4b43e1191ff30d902730f752875aa55682ce/src/nvim/api/private/converter.c#L333-L334", + "created_at": "2023-12-06T14:37:13Z", + "html_url": "https://github.com/neovim/neovim/pull/25564#issuecomment-1843014753", + "id": 1843014753, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/25564", + "node_id": "IC_kwDOAPphoM5t2ixh", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843014753/reactions" + }, + "updated_at": "2023-12-06T15:02:46Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843014753", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/25564/comments", "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/25564/commits", "created_at": "2023-10-09T16:37:51Z", @@ -266,9 +605,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/Quaqqer/neovim/pulls{/number}", - "pushed_at": "2023-10-09T17:04:09Z", + "pushed_at": "2023-12-06T15:08:55Z", "releases_url": "https://api.github.com/repos/Quaqqer/neovim/releases{/id}", - "size": 251814, + "size": 240821, "ssh_url": "git@github.com:Quaqqer/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/Quaqqer/neovim/stargazers", @@ -287,7 +626,7 @@ "watchers_count": 0, "web_commit_signoff_required": false }, - "sha": "c72dd3774ba042e28ae165a9275bc08aa738d45e", + "sha": "92478b17db0275f3699886b7f46cf94a82d4c929", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/29512047?v=4", "events_url": "https://api.github.com/users/Quaqqer/events{/privacy}", @@ -314,8 +653,8 @@ "issue_url": "https://api.github.com/repos/neovim/neovim/issues/25564", "labels": [], "locked": false, - "merge_commit_sha": "91db1cd370f295e6d8a76cdb0c6fc3fa55eb7caf", - "merged_at": null, + "merge_commit_sha": "e057b38e7037808b3593fb1035794595b4e4a45e", + "merged_at": "2023-12-06T15:56:04Z", "milestone": null, "node_id": "PR_kwDOAPphoM5cR5g3", "number": 25564, @@ -324,10 +663,10 @@ "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/25564/comments", - "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/c72dd3774ba042e28ae165a9275bc08aa738d45e", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/92478b17db0275f3699886b7f46cf94a82d4c929", "title": "fix(json): allow objects with empty keys", - "updated_at": "2023-10-09T17:04:14Z", + "updated_at": "2023-12-06T15:56:04Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/25564", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/29512047?v=4", diff --git a/repositories/neovim/pulls/25599.json b/repositories/neovim/pulls/25599.json index 71e2c2d6..ed20b290 100644 --- a/repositories/neovim/pulls/25599.json +++ b/repositories/neovim/pulls/25599.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 4962, - "forks_count": 4962, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -94,8 +94,8 @@ "name": "neovim", "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", - "open_issues": 1681, - "open_issues_count": 1681, + "open_issues": 1707, + "open_issues_count": 1707, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-11-06T01:31:09Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 237090, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 70644, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-11-06T01:53:30Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 70644, - "watchers_count": 70644, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "0a3505eb9df8d57a9a0bcecf02bb3dda1c8edd29", @@ -487,9 +487,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/clason/neovim/pulls{/number}", - "pushed_at": "2023-11-05T20:57:00Z", + "pushed_at": "2023-12-06T14:39:51Z", "releases_url": "https://api.github.com/repos/clason/neovim/releases{/id}", - "size": 234115, + "size": 238533, "ssh_url": "git@github.com:clason/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/clason/neovim/stargazers", @@ -576,7 +576,7 @@ "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/da6dd0792619df97ad81bd844696e4893f21d076", "title": "build(deps): bump gettext to 0.22.3, libiconv to 1.17", - "updated_at": "2023-11-05T11:23:35Z", + "updated_at": "2023-12-06T14:39:52Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/25599", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", diff --git a/repositories/neovim/pulls/25990.json b/repositories/neovim/pulls/25990.json index 39633587..be47077b 100644 --- a/repositories/neovim/pulls/25990.json +++ b/repositories/neovim/pulls/25990.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 4975, - "forks_count": 4975, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -94,8 +94,8 @@ "name": "neovim", "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", - "open_issues": 1688, - "open_issues_count": 1688, + "open_issues": 1707, + "open_issues_count": 1707, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-11-12T01:57:45Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 236501, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 70813, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-11-12T01:42:45Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 70813, - "watchers_count": 70813, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "b2ca768196af87b93c90e315747d166f5d8d931c", @@ -266,9 +266,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/clason/neovim/pulls{/number}", - "pushed_at": "2023-11-11T23:22:33Z", + "pushed_at": "2023-12-06T14:39:51Z", "releases_url": "https://api.github.com/repos/clason/neovim/releases{/id}", - "size": 232824, + "size": 238533, "ssh_url": "git@github.com:clason/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/clason/neovim/stargazers", @@ -337,7 +337,7 @@ "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/8a43592a6fd7cb76f0593b642c7988d228d91b10", "title": "vim-patch:5994329667a6", - "updated_at": "2023-11-11T14:12:05Z", + "updated_at": "2023-12-06T14:39:45Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/25990", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", diff --git a/repositories/neovim/pulls/26198.json b/repositories/neovim/pulls/26198.json index 21c876b0..50829f44 100644 --- a/repositories/neovim/pulls/26198.json +++ b/repositories/neovim/pulls/26198.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5010, - "forks_count": 5010, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -94,8 +94,8 @@ "name": "neovim", "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", - "open_issues": 1699, - "open_issues_count": 1699, + "open_issues": 1707, + "open_issues_count": 1707, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-11-24T23:21:05Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 239822, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71210, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-11-25T01:42:01Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71210, - "watchers_count": 71210, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "53cc835b51546f9ff68facebab2e0c6e97585e5b", @@ -170,7 +170,7 @@ } }, "body": "Yield from this coroutine will schedule it onto the mian event loop.\r\n\r\n---\r\n\r\nNot sure if this is a good idea or not.\r\n", - "closed_at": null, + "closed_at": "2023-12-06T11:21:09Z", "comment_data": [], "comment_regular_data": [ { @@ -304,6 +304,50 @@ "type": "User", "url": "https://api.github.com/users/lewis6991" } + }, + { + "author_association": "MEMBER", + "body": "Not convinced this is worth pursuing.", + "created_at": "2023-12-06T11:21:09Z", + "html_url": "https://github.com/neovim/neovim/pull/26198#issuecomment-1842676612", + "id": 1842676612, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26198", + "node_id": "IC_kwDOAPphoM5t1QOE", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842676612/reactions" + }, + "updated_at": "2023-12-06T11:21:09Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842676612", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } } ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26198/comments", @@ -399,9 +443,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/lewis6991/neovim/pulls{/number}", - "pushed_at": "2023-11-24T13:32:23Z", + "pushed_at": "2023-12-05T15:43:51Z", "releases_url": "https://api.github.com/repos/lewis6991/neovim/releases{/id}", - "size": 235138, + "size": 238124, "ssh_url": "git@github.com:lewis6991/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/lewis6991/neovim/stargazers", @@ -475,7 +519,7 @@ } ], "locked": false, - "merge_commit_sha": "2b6efa49e6f22a0c46760089ddf8dcbd8f87c090", + "merge_commit_sha": "e9b36dd85154be54e2b27cf59bbb6d6a7cafeb2f", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5gTyrE", @@ -485,10 +529,10 @@ "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26198/comments", - "state": "open", + "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/1d49491bd3012f9f2e2c81753256f452fecc2167", "title": "WIP: run luv callbacks in a coroutine", - "updated_at": "2023-11-24T16:43:54Z", + "updated_at": "2023-12-06T11:21:10Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26198", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", diff --git a/repositories/neovim/pulls/26381.json b/repositories/neovim/pulls/26381.json index a88d5534..2461d122 100644 --- a/repositories/neovim/pulls/26381.json +++ b/repositories/neovim/pulls/26381.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26381" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/cbf0c8bebdcd6ef347574a325847094ea336db9b" + "href": "https://api.github.com/repos/neovim/neovim/statuses/8f10362cdc5835a1cd86c8195ce8e3b10ab85384" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "589f4761ee896cea5c8d1b1dad6655bd0b78fc2d", + "sha": "ca7f8786a0eb578895400e23cd21e25cc0f91800", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -170,8 +170,77 @@ } }, "body": "related #26372", - "closed_at": null, - "comment_data": [], + "closed_at": "2023-12-06T18:58:03Z", + "comment_data": [ + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26381#discussion_r1417360209" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26381" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417360209" + } + }, + "author_association": "MEMBER", + "body": "Just to be extra safe/explicit, set `pending_default_colors` first?\r\n\r\n```suggestion\r\n pending_default_colors = false;\r\n ui_call_default_colors_set(normal_fg, normal_bg, normal_sp,\r\n cterm_normal_fg_color, cterm_normal_bg_color);\r\n```", + "commit_id": "8f10362cdc5835a1cd86c8195ce8e3b10ab85384", + "created_at": "2023-12-06T13:55:32Z", + "diff_hunk": "@@ -283,8 +284,21 @@ void ui_schedule_refresh(void)\n \n void ui_default_colors_set(void)\n {\n- ui_call_default_colors_set(normal_fg, normal_bg, normal_sp,\n- cterm_normal_fg_color, cterm_normal_bg_color);\n+ // Throttle setting of default colors at startup, so it only happens once\n+ // if the user sets the colorscheme in startup.\n+ pending_default_colors = true;\n+ if (starting == 0) {\n+ ui_may_set_default_colors();\n+ }\n+}\n+\n+static void ui_may_set_default_colors(void)\n+{\n+ if (pending_default_colors) {\n+ ui_call_default_colors_set(normal_fg, normal_bg, normal_sp,\n+ cterm_normal_fg_color, cterm_normal_bg_color);\n+ pending_default_colors = false;", + "html_url": "https://github.com/neovim/neovim/pull/26381#discussion_r1417360209", + "id": 1417360209, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UezNR", + "original_commit_id": "d2fbf05717c6b6538b8da5bc7d70401d20c423a8", + "original_line": 300, + "original_position": 27, + "original_start_line": 298, + "path": "src/nvim/ui.c", + "position": null, + "pull_request_review_id": 1767633928, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26381", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417360209/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": "RIGHT", + "subject_type": "line", + "updated_at": "2023-12-06T13:56:13Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417360209", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], "comment_regular_data": [ { "author_association": "CONTRIBUTOR", @@ -260,13 +329,101 @@ "type": "User", "url": "https://api.github.com/users/lewis6991" } + }, + { + "author_association": "CONTRIBUTOR", + "body": "I've just retried it and it doesn't seem to work well with `termguicolors` (like in [this comment](https://github.com/neovim/neovim/pull/26381#issuecomment-1838192503)). With `termguicolors` becoming default for terminal emulators that support it, this isn't really fixing #26372. Am I missing something?", + "created_at": "2023-12-06T19:10:17Z", + "html_url": "https://github.com/neovim/neovim/pull/26381#issuecomment-1843533157", + "id": 1843533157, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26381", + "node_id": "IC_kwDOAPphoM5t4hVl", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843533157/reactions" + }, + "updated_at": "2023-12-06T19:10:17Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843533157", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", + "events_url": "https://api.github.com/users/echasnovski/events{/privacy}", + "followers_url": "https://api.github.com/users/echasnovski/followers", + "following_url": "https://api.github.com/users/echasnovski/following{/other_user}", + "gists_url": "https://api.github.com/users/echasnovski/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/echasnovski", + "id": 24854248, + "login": "echasnovski", + "node_id": "MDQ6VXNlcjI0ODU0MjQ4", + "organizations_url": "https://api.github.com/users/echasnovski/orgs", + "received_events_url": "https://api.github.com/users/echasnovski/received_events", + "repos_url": "https://api.github.com/users/echasnovski/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/echasnovski/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/echasnovski/subscriptions", + "type": "User", + "url": "https://api.github.com/users/echasnovski" + } + }, + { + "author_association": "MEMBER", + "body": "I just chose to take one step at a time as I wasn't sure if termguicolors by default was decided yet, and this by itself fixes the issue for a lot of users so no reason to delay this PR. \r\n\r\nWill do a similar fix for the termguicolors event as a follow up.", + "created_at": "2023-12-06T20:54:57Z", + "html_url": "https://github.com/neovim/neovim/pull/26381#issuecomment-1843675673", + "id": 1843675673, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26381", + "node_id": "IC_kwDOAPphoM5t5EIZ", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843675673/reactions" + }, + "updated_at": "2023-12-06T20:54:57Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843675673", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", + "events_url": "https://api.github.com/users/bfredl/events{/privacy}", + "followers_url": "https://api.github.com/users/bfredl/followers", + "following_url": "https://api.github.com/users/bfredl/following{/other_user}", + "gists_url": "https://api.github.com/users/bfredl/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/bfredl", + "id": 1363104, + "login": "bfredl", + "node_id": "MDQ6VXNlcjEzNjMxMDQ=", + "organizations_url": "https://api.github.com/users/bfredl/orgs", + "received_events_url": "https://api.github.com/users/bfredl/received_events", + "repos_url": "https://api.github.com/users/bfredl/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/bfredl/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/bfredl/subscriptions", + "type": "User", + "url": "https://api.github.com/users/bfredl" + } } ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26381/comments", "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26381/commits", "created_at": "2023-12-04T08:47:20Z", "diff_url": "https://github.com/neovim/neovim/pull/26381.diff", - "draft": true, + "draft": false, "head": { "label": "bfredl:delaycolors", "ref": "delaycolors", @@ -355,9 +512,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/bfredl/neovim/pulls{/number}", - "pushed_at": "2023-12-04T08:46:23Z", + "pushed_at": "2023-12-06T17:42:30Z", "releases_url": "https://api.github.com/repos/bfredl/neovim/releases{/id}", - "size": 241346, + "size": 242465, "ssh_url": "git@github.com:bfredl/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/bfredl/neovim/stargazers", @@ -376,7 +533,7 @@ "watchers_count": 0, "web_commit_signoff_required": false }, - "sha": "cbf0c8bebdcd6ef347574a325847094ea336db9b", + "sha": "8f10362cdc5835a1cd86c8195ce8e3b10ab85384", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", "events_url": "https://api.github.com/users/bfredl/events{/privacy}", @@ -413,41 +570,20 @@ } ], "locked": false, - "merge_commit_sha": "f25dc9fbeac537358a67702eabfa7666a558c3f9", - "merged_at": null, + "merge_commit_sha": "8bb5089974e14f043a0b0c17e4d38dbd0b9a9ab2", + "merged_at": "2023-12-06T18:58:03Z", "milestone": null, "node_id": "PR_kwDOAPphoM5hBpOb", "number": 26381, "patch_url": "https://github.com/neovim/neovim/pull/26381.patch", - "requested_reviewers": [ - { - "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", - "events_url": "https://api.github.com/users/justinmk/events{/privacy}", - "followers_url": "https://api.github.com/users/justinmk/followers", - "following_url": "https://api.github.com/users/justinmk/following{/other_user}", - "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", - "gravatar_id": "", - "html_url": "https://github.com/justinmk", - "id": 1359421, - "login": "justinmk", - "node_id": "MDQ6VXNlcjEzNTk0MjE=", - "organizations_url": "https://api.github.com/users/justinmk/orgs", - "received_events_url": "https://api.github.com/users/justinmk/received_events", - "repos_url": "https://api.github.com/users/justinmk/repos", - "site_admin": false, - "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", - "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", - "type": "User", - "url": "https://api.github.com/users/justinmk" - } - ], + "requested_reviewers": [], "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26381/comments", - "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/cbf0c8bebdcd6ef347574a325847094ea336db9b", - "title": "TEST: delay setting of default colors to avoid flicker", - "updated_at": "2023-12-05T09:32:25Z", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/8f10362cdc5835a1cd86c8195ce8e3b10ab85384", + "title": "fix(startup): only send one default_colors_set event during startup", + "updated_at": "2023-12-06T20:54:58Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26381", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", diff --git a/repositories/neovim/pulls/26384.json b/repositories/neovim/pulls/26384.json index 34a06de3..2579e201 100644 --- a/repositories/neovim/pulls/26384.json +++ b/repositories/neovim/pulls/26384.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26384" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/4952766d916c526772b1d23c303fd5ef9b73af65" + "href": "https://api.github.com/repos/neovim/neovim/statuses/d3233c501e9070e0e59cdc1b66a0e5f4265120f5" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "0b74ad0a641f28d9d3da5353e98372d87078bd9d", + "sha": "040369e1e4b86c4655a6885b36ee89ad4f10ca16", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -186,7 +186,7 @@ }, "author_association": "MEMBER", "body": "This is not backward-compatible.", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T11:46:29Z", "diff_hunk": "@@ -1002,6 +1003,8 @@ Integer nvim_open_term(Buffer buffer, DictionaryOf(LuaRef) opts, Error *err)\n }\n \n LuaRef cb = LUA_NOREF;\n+ // LF\n+ bool newline_conv = true;", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413759199", @@ -254,7 +254,7 @@ }, "author_association": "MEMBER", "body": "`opts` can be changed to a keyset.", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T11:46:38Z", "diff_hunk": "@@ -985,6 +985,7 @@ Buffer nvim_create_buf(Boolean listed, Boolean scratch, Error *err)\n /// as a \"\\r\", not as a \"\\n\". |textlock| applies. It is possible\n /// to call |nvim_chan_send()| directly in the callback however.\n /// [\"input\", term, bufnr, data]\n+/// - newline_conv: boolean convert \\n to \\r\\n\n /// @param[out] err Error details, if any\n /// @return Channel id, or 0 on error\n Integer nvim_open_term(Buffer buffer, DictionaryOf(LuaRef) opts, Error *err)", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413759441", @@ -322,7 +322,7 @@ }, "author_association": "MEMBER", "body": "okay..do you think this patch is correct ", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T11:51:20Z", "diff_hunk": "@@ -1002,6 +1003,8 @@ Integer nvim_open_term(Buffer buffer, DictionaryOf(LuaRef) opts, Error *err)\n }\n \n LuaRef cb = LUA_NOREF;\n+ // LF\n+ bool newline_conv = true;", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413764563", @@ -391,7 +391,7 @@ }, "author_association": "MEMBER", "body": "It should default to `false`.", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:10:19Z", "diff_hunk": "@@ -1002,6 +1003,8 @@ Integer nvim_open_term(Buffer buffer, DictionaryOf(LuaRef) opts, Error *err)\n }\n \n LuaRef cb = LUA_NOREF;\n+ // LF\n+ bool newline_conv = true;", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413784935", @@ -460,7 +460,7 @@ }, "author_association": "MEMBER", "body": "has been changed to false. need rebase after your refactor merge then.", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:11:35Z", "diff_hunk": "@@ -1002,6 +1003,8 @@ Integer nvim_open_term(Buffer buffer, DictionaryOf(LuaRef) opts, Error *err)\n }\n \n LuaRef cb = LUA_NOREF;\n+ // LF\n+ bool newline_conv = true;", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413786222", @@ -529,7 +529,7 @@ }, "author_association": "MEMBER", "body": "better to use something like `kvec_t(char)` while building the string to avoid frequent reallocation. ", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:29:20Z", "diff_hunk": "@@ -786,7 +786,26 @@ void terminal_receive(Terminal *term, char *data, size_t len)\n return;\n }\n \n- vterm_input_write(term->vt, data, len);\n+ if (term->opts.newline_conv) {\n+ String crlf_data = { .data = NULL, .size = 0 };\n+ for (size_t i = 0; i < len; i++) {\n+ if (data[i] == '\\n') {\n+ crlf_data.data = xrealloc(crlf_data.data, crlf_data.size + 2);", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413804831", @@ -597,7 +597,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n• Added \"newline_conv\" option field in |nvim_open_term()|. \r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:32:38Z", "diff_hunk": "@@ -331,6 +331,8 @@ The following changes to existing APIs or features add new behavior.\n \n • |vim.wait()| is no longer allowed to be called in |api-fast|.\n \n+• add |newlin_conv| option field in |nvim_open_term()|. ", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413808227", @@ -665,7 +665,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n/// - newline_conv: (boolean, default false) Convert \"\\n\" to \"\\r\\n\".\r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:33:20Z", "diff_hunk": "@@ -985,9 +985,10 @@ Buffer nvim_create_buf(Boolean listed, Boolean scratch, Error *err)\n /// as a \"\\r\", not as a \"\\n\". |textlock| applies. It is possible\n /// to call |nvim_chan_send()| directly in the callback however.\n /// [\"input\", term, bufnr, data]\n+/// - newline_conv: (false) convert \"\\n\" to \"\\r\\n\"", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413808946", @@ -733,7 +733,7 @@ }, "author_association": "MEMBER", "body": "Or `StringBuilder`", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:34:53Z", "diff_hunk": "@@ -786,7 +786,26 @@ void terminal_receive(Terminal *term, char *data, size_t len)\n return;\n }\n \n- vterm_input_write(term->vt, data, len);\n+ if (term->opts.newline_conv) {\n+ String crlf_data = { .data = NULL, .size = 0 };\n+ for (size_t i = 0; i < len; i++) {\n+ if (data[i] == '\\n') {\n+ crlf_data.data = xrealloc(crlf_data.data, crlf_data.size + 2);", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413810569", @@ -802,7 +802,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n• Added \"newline_conv\" option field in |nvim_open_term()|.\r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:58:33Z", "diff_hunk": "@@ -331,6 +331,8 @@ The following changes to existing APIs or features add new behavior.\n \n • |vim.wait()| is no longer allowed to be called in |api-fast|.\n \n+• Added |newlin_conv| option field in |nvim_open_term()|.", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413837504", @@ -870,7 +870,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n/// - newline_conv: (boolean, default false) Convert \"\\n\" to \"\\r\\n\".\r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T12:58:52Z", "diff_hunk": "@@ -985,9 +985,10 @@ Buffer nvim_create_buf(Boolean listed, Boolean scratch, Error *err)\n /// as a \"\\r\", not as a \"\\n\". |textlock| applies. It is possible\n /// to call |nvim_chan_send()| directly in the callback however.\n /// [\"input\", term, bufnr, data]\n+/// - newline_conv: (boolean, false) Convert \"\\n\" to \"\\r\\n\".", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413837801", @@ -938,7 +938,7 @@ }, "author_association": "MEMBER", "body": "sry forget filed shouldn't use `|` ..", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:07:20Z", "diff_hunk": "@@ -331,6 +331,8 @@ The following changes to existing APIs or features add new behavior.\n \n • |vim.wait()| is no longer allowed to be called in |api-fast|.\n \n+• Added |newlin_conv| option field in |nvim_open_term()|.", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413848539", @@ -1007,7 +1007,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n• Added \"newline_conv\" option field in |nvim_open_term()|.\r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:08:12Z", "diff_hunk": "@@ -331,6 +331,8 @@ The following changes to existing APIs or features add new behavior.\n \n • |vim.wait()| is no longer allowed to be called in |api-fast|.\n \n+• Added \"newlin_conv\" option field in |nvim_open_term()|.", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413849397", @@ -1075,7 +1075,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n .newline_conv = opts->newline_conv,\r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:16:25Z", "diff_hunk": "@@ -1029,6 +1020,7 @@ Integer nvim_open_term(Buffer buffer, DictionaryOf(LuaRef) opts, Error *err)\n .write_cb = term_write,\n .resize_cb = term_resize,\n .close_cb = term_close,\n+ .newline_conv = HAS_KEY(opts, open_term, newline_conv) ? opts->newline_conv : false,", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413859020", @@ -1143,7 +1143,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:17:48Z", "diff_hunk": "@@ -786,7 +788,24 @@ void terminal_receive(Terminal *term, const char *data, size_t len)\n return;\n }\n \n- vterm_input_write(term->vt, data, len);\n+ if (term->opts.newline_conv) {\n+ StringBuilder crlf_data = KV_INITIAL_VALUE;\n+\n+ for (size_t i = 0; i < len; i++) {\n+ if (data[i] == '\\n') {\n+ kv_push(crlf_data, '\\r');\n+ kv_push(crlf_data, '\\n');\n+ } else {\n+ kv_push(crlf_data, data[i]);\n+ }\n+ }\n+\n+ kv_push(crlf_data, '\\0');", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413860566", @@ -1211,7 +1211,7 @@ }, "author_association": "MEMBER", "body": "The only precedent I could find (`git grep -Pi '\\@param\\b.*newline'`) is `replace_nl`: https://github.com/neovim/neovim/blob/66f1563c7a48d76f99c89e32de030e57af2abfb4/src/nvim/api/buffer.c#L1456\r\n\r\nI think we'd probably use a \"force\" prefix typically, e.g. `force_crlf`\r\n```suggestion\r\n • force_crlf: (boolean, default false) Convert \"\\n\" to\r\n```\r\n", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:43:07Z", "diff_hunk": "@@ -1231,6 +1231,8 @@ nvim_open_term({buffer}, {opts}) *nvim_open_term()*\n is sent as a \"\\r\", not as a \"\\n\". |textlock| applies. It\n is possible to call |nvim_chan_send()| directly in the\n callback however. [\"input\", term, bufnr, data]\n+ • newline_conv: (boolean, default false) Convert \"\\n\" to", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413890318", @@ -1279,19 +1279,19 @@ }, "author_association": "MEMBER", "body": "does this belong in the \"terminal input\" test group? https://github.com/neovim/neovim/blob/66f1563c7a48d76f99c89e32de030e57af2abfb4/test/functional/terminal/buffer_spec.lua#L422", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:47:45Z", "diff_hunk": "@@ -198,4 +198,18 @@ describe('no crash when TermOpen autocommand', function()\n ]]}\n assert_alive()\n end)\n+\n+ it('convert newline when using nvim_open_term()', function()", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413896352", "id": 1413896352, - "line": 202, + "line": null, "node_id": "PRRC_kwDOAPphoM5URlig", "original_commit_id": "8a442c0b835eef8edcfa71495140429c4b18737c", "original_line": 202, "original_position": 5, "original_start_line": null, "path": "test/functional/terminal/channel_spec.lua", - "position": 5, + "position": null, "pull_request_review_id": 1762441164, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26384", "reactions": { @@ -1347,7 +1347,7 @@ }, "author_association": "MEMBER", "body": "what if `data[i-1] == '\\r'` ?", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:49:08Z", "diff_hunk": "@@ -786,7 +788,23 @@ void terminal_receive(Terminal *term, const char *data, size_t len)\n return;\n }\n \n- vterm_input_write(term->vt, data, len);\n+ if (term->opts.newline_conv) {\n+ StringBuilder crlf_data = KV_INITIAL_VALUE;\n+\n+ for (size_t i = 0; i < len; i++) {\n+ if (data[i] == '\\n') {", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413898324", @@ -1415,7 +1415,7 @@ }, "author_association": "MEMBER", "body": "https://github.com/neovim/neovim/issues/14557#issuecomment-1366194970 mentions that the default should be `true`. Why is it false in this PR?", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:51:41Z", "diff_hunk": "@@ -985,9 +985,10 @@ Buffer nvim_create_buf(Boolean listed, Boolean scratch, Error *err)\n /// as a \"\\r\", not as a \"\\n\". |textlock| applies. It is possible\n /// to call |nvim_chan_send()| directly in the callback however.\n /// [\"input\", term, bufnr, data]\n+/// - newline_conv: (boolean, default false) Convert \"\\n\" to \"\\r\\n\".", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413901497", @@ -1483,20 +1483,20 @@ }, "author_association": "MEMBER", "body": "No. It's output.", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-04T13:52:41Z", "diff_hunk": "@@ -198,4 +198,18 @@ describe('no crash when TermOpen autocommand', function()\n ]]}\n assert_alive()\n end)\n+\n+ it('convert newline when using nvim_open_term()', function()", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1413902701", "id": 1413902701, "in_reply_to_id": 1413896352, - "line": 202, + "line": null, "node_id": "PRRC_kwDOAPphoM5URnFt", "original_commit_id": "8a442c0b835eef8edcfa71495140429c4b18737c", "original_line": 202, "original_position": 5, "original_start_line": null, "path": "test/functional/terminal/channel_spec.lua", - "position": 5, + "position": null, "pull_request_review_id": 1762451286, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26384", "reactions": { @@ -1552,7 +1552,7 @@ }, "author_association": "MEMBER", "body": "see this comment https://github.com/neovim/neovim/pull/26384#discussion_r1413784935", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-05T06:27:57Z", "diff_hunk": "@@ -985,9 +985,10 @@ Buffer nvim_create_buf(Boolean listed, Boolean scratch, Error *err)\n /// as a \"\\r\", not as a \"\\n\". |textlock| applies. It is possible\n /// to call |nvim_chan_send()| directly in the callback however.\n /// [\"input\", term, bufnr, data]\n+/// - newline_conv: (boolean, default false) Convert \"\\n\" to \"\\r\\n\".", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1414938204", @@ -1621,7 +1621,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n• Added \"force_crlf\" option field in |nvim_open_term()|.\r\n```", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-05T08:26:12Z", "diff_hunk": "@@ -331,6 +331,8 @@ The following changes to existing APIs or features add new behavior.\n \n • |vim.wait()| is no longer allowed to be called in |api-fast|.\n \n+• Added \"newline_conv\" option field in |nvim_open_term()|.", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1415119525", @@ -1689,7 +1689,7 @@ }, "author_association": "MEMBER", "body": "I think we should try it. It was already broken, this likely improves more than it breaks. \r\n\r\n@zeertzjq any strong objection?", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-05T13:33:54Z", "diff_hunk": "@@ -985,9 +985,10 @@ Buffer nvim_create_buf(Boolean listed, Boolean scratch, Error *err)\n /// as a \"\\r\", not as a \"\\n\". |textlock| applies. It is possible\n /// to call |nvim_chan_send()| directly in the callback however.\n /// [\"input\", term, bufnr, data]\n+/// - newline_conv: (boolean, default false) Convert \"\\n\" to \"\\r\\n\".", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1415621751", @@ -1758,19 +1758,19 @@ }, "author_association": "MEMBER", "body": "also test the result of sending `\\r\\n`. (don't add another it() block, just add another case to this test.)\r\n\r\nperhaps also worth thinking about other edge cases such as `\\n\\n`. please think about edge cases for all future PRs, it should be a common practice.", - "commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "created_at": "2023-12-05T13:52:45Z", "diff_hunk": "@@ -198,4 +198,18 @@ describe('no crash when TermOpen autocommand', function()\n ]]}\n assert_alive()\n end)\n+\n+ it('convert newline when using nvim_open_term()', function()\n+ local buf = meths.create_buf(false, true)\n+ local win = meths.get_current_win()\n+ local term = meths.open_term(buf, {force_crlf = true})\n+ meths.win_set_buf(win, buf)\n+ meths.chan_send(term, 'here\\nthere')", "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1415649020", "id": 1415649020, - "line": 207, + "line": 238, "node_id": "PRRC_kwDOAPphoM5UYRb8", "original_commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", - "original_line": 207, + "original_line": 238, "original_position": 10, "original_start_line": null, "path": "test/functional/terminal/channel_spec.lua", - "position": 10, + "position": 41, "pull_request_review_id": 1765136002, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26384", "reactions": { @@ -1811,6 +1811,280 @@ "type": "User", "url": "https://api.github.com/users/justinmk" } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26384#discussion_r1416718767" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26384" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416718767" + } + }, + "author_association": "MEMBER", + "body": "test case updated.", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", + "created_at": "2023-12-06T06:05:08Z", + "diff_hunk": "@@ -198,4 +198,18 @@ describe('no crash when TermOpen autocommand', function()\n ]]}\n assert_alive()\n end)\n+\n+ it('convert newline when using nvim_open_term()', function()\n+ local buf = meths.create_buf(false, true)\n+ local win = meths.get_current_win()\n+ local term = meths.open_term(buf, {force_crlf = true})\n+ meths.win_set_buf(win, buf)\n+ meths.chan_send(term, 'here\\nthere')", + "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1416718767", + "id": 1416718767, + "in_reply_to_id": 1415649020, + "line": 238, + "node_id": "PRRC_kwDOAPphoM5UcWmv", + "original_commit_id": "4952766d916c526772b1d23c303fd5ef9b73af65", + "original_line": 238, + "original_position": 10, + "original_start_line": null, + "path": "test/functional/terminal/channel_spec.lua", + "position": 41, + "pull_request_review_id": 1766720580, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26384", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416718767/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T06:05:08Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416718767", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", + "events_url": "https://api.github.com/users/glepnir/events{/privacy}", + "followers_url": "https://api.github.com/users/glepnir/followers", + "following_url": "https://api.github.com/users/glepnir/following{/other_user}", + "gists_url": "https://api.github.com/users/glepnir/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/glepnir", + "id": 41671631, + "login": "glepnir", + "node_id": "MDQ6VXNlcjQxNjcxNjMx", + "organizations_url": "https://api.github.com/users/glepnir/orgs", + "received_events_url": "https://api.github.com/users/glepnir/received_events", + "repos_url": "https://api.github.com/users/glepnir/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/glepnir/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/glepnir/subscriptions", + "type": "User", + "url": "https://api.github.com/users/glepnir" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26384#discussion_r1417156276" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26384" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417156276" + } + }, + "author_association": "MEMBER", + "body": "```suggestion\r\n it('nvim_open_term({force_crlf=true}) converts newlines', function()\r\n```", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", + "created_at": "2023-12-06T11:45:29Z", + "diff_hunk": "@@ -198,4 +198,64 @@ describe('no crash when TermOpen autocommand', function()\n ]]}\n assert_alive()\n end)\n+\n+ it('convert newline when using nvim_open_term()', function()", + "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1417156276", + "id": 1417156276, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeBa0", + "original_commit_id": "23725184e4a16ec672e72c8e99689cc69bb47d51", + "original_line": 202, + "original_position": 5, + "original_start_line": null, + "path": "test/functional/terminal/channel_spec.lua", + "position": null, + "pull_request_review_id": 1767350268, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26384", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417156276/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:45:29Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417156276", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26384#discussion_r1417158819" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26384" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417158819" + } + }, + "author_association": "MEMBER", + "body": "can't all (or most) of these cases be sent in one chan_send, then tested with a single screen:expect?\r\n\r\nalso need a test case for `force_crlf=false`.", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", + "created_at": "2023-12-06T11:48:01Z", + "diff_hunk": "@@ -198,4 +198,64 @@ describe('no crash when TermOpen autocommand', function()\n ]]}\n assert_alive()\n end)\n+\n+ it('nvim_open_term({force_crlf=true}) converts newlines', function()\n+ local buf = meths.create_buf(false, true)\n+ local win = meths.get_current_win()\n+ local term = meths.open_term(buf, {force_crlf = true})\n+ screen:try_resize(8, 10)\n+ meths.win_set_buf(win, buf)\n+ meths.chan_send(term, 'here\\nthere\\n')\n+ screen:expect{grid=[[\n+ ^here |\n+ there |\n+ |\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ |\n+ ]]}\n+ meths.chan_send(term, 'foo\\r\\nbar\\n')", + "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1417158819", + "id": 1417158819, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeCCj", + "original_commit_id": "33c57bd7fa1770e1caa796508c9ed5cc0d722903", + "original_line": 221, + "original_position": 24, + "original_start_line": null, + "path": "test/functional/terminal/channel_spec.lua", + "position": null, + "pull_request_review_id": 1767354274, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26384", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417158819/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:48:02Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417158819", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26384#discussion_r1417168741" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26384" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417168741" + } + }, + "author_association": "MEMBER", + "body": "can be in one channel .but still need a test case for first is \\n in single send.", + "commit_id": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", + "created_at": "2023-12-06T11:57:21Z", + "diff_hunk": "@@ -198,4 +198,64 @@ describe('no crash when TermOpen autocommand', function()\n ]]}\n assert_alive()\n end)\n+\n+ it('nvim_open_term({force_crlf=true}) converts newlines', function()\n+ local buf = meths.create_buf(false, true)\n+ local win = meths.get_current_win()\n+ local term = meths.open_term(buf, {force_crlf = true})\n+ screen:try_resize(8, 10)\n+ meths.win_set_buf(win, buf)\n+ meths.chan_send(term, 'here\\nthere\\n')\n+ screen:expect{grid=[[\n+ ^here |\n+ there |\n+ |\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ {0:~ }|\n+ |\n+ ]]}\n+ meths.chan_send(term, 'foo\\r\\nbar\\n')", + "html_url": "https://github.com/neovim/neovim/pull/26384#discussion_r1417168741", + "id": 1417168741, + "in_reply_to_id": 1417158819, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeEdl", + "original_commit_id": "33c57bd7fa1770e1caa796508c9ed5cc0d722903", + "original_line": 221, + "original_position": 24, + "original_start_line": null, + "path": "test/functional/terminal/channel_spec.lua", + "position": null, + "pull_request_review_id": 1767370092, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26384", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417168741/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:58:15Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417168741", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", + "events_url": "https://api.github.com/users/glepnir/events{/privacy}", + "followers_url": "https://api.github.com/users/glepnir/followers", + "following_url": "https://api.github.com/users/glepnir/following{/other_user}", + "gists_url": "https://api.github.com/users/glepnir/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/glepnir", + "id": 41671631, + "login": "glepnir", + "node_id": "MDQ6VXNlcjQxNjcxNjMx", + "organizations_url": "https://api.github.com/users/glepnir/orgs", + "received_events_url": "https://api.github.com/users/glepnir/received_events", + "repos_url": "https://api.github.com/users/glepnir/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/glepnir/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/glepnir/subscriptions", + "type": "User", + "url": "https://api.github.com/users/glepnir" + } } ], "comment_regular_data": [], @@ -1907,9 +2181,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/glepnir/neovim/pulls{/number}", - "pushed_at": "2023-12-05T11:42:39Z", + "pushed_at": "2023-12-06T12:05:56Z", "releases_url": "https://api.github.com/repos/glepnir/neovim/releases{/id}", - "size": 240246, + "size": 238203, "ssh_url": "git@github.com:glepnir/neovim.git", "stargazers_count": 1, "stargazers_url": "https://api.github.com/repos/glepnir/neovim/stargazers", @@ -1928,7 +2202,7 @@ "watchers_count": 1, "web_commit_signoff_required": false }, - "sha": "4952766d916c526772b1d23c303fd5ef9b73af65", + "sha": "d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", "events_url": "https://api.github.com/users/glepnir/events{/privacy}", @@ -1974,7 +2248,7 @@ } ], "locked": false, - "merge_commit_sha": "66754172c042c4d678ccc704337ffe84c6e05686", + "merge_commit_sha": "eeb315eedef9e027438d538cbc1fe75a0744a1bf", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5hClrA", @@ -2006,9 +2280,9 @@ "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26384/comments", "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/4952766d916c526772b1d23c303fd5ef9b73af65", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/d3233c501e9070e0e59cdc1b66a0e5f4265120f5", "title": "feat(terminal): convert newline", - "updated_at": "2023-12-05T13:52:45Z", + "updated_at": "2023-12-06T12:05:58Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26384", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", diff --git a/repositories/neovim/pulls/26390.json b/repositories/neovim/pulls/26390.json index c0277b3d..2763d62f 100644 --- a/repositories/neovim/pulls/26390.json +++ b/repositories/neovim/pulls/26390.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26390" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/ee5011d59e9df3eda633665e2a3ffd779b10b55a" + "href": "https://api.github.com/repos/neovim/neovim/statuses/05a22daf7bc4831d09c2a05556501ed420c2bda5" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "ca4fe083e5b1a7c2e93cf77aa849fbec72757627", + "sha": "f22e9e10f9ad77d2cce7f52837c5724877505a08", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -170,7 +170,7 @@ } }, "body": "Problem:\r\nWhen `vim._foldupdate()` is invoked inside a scheduled callback, the cursor may have moved to a line with a closed fold, e.g., after `dd` on the line that is one line above a folded region. Then it opens the fold, which is unnecessary and distracting. Legacy foldexprs do not have this issue.\r\n\r\nSolution:\r\nDon't explicitly open folds on cursor.\r\n\r\nNote:\r\nThis doesn't completely prevent spurious opening of folds. That is due to bugs in treesitter foldexpr algorithm, which should be addressed separately.", - "closed_at": null, + "closed_at": "2023-12-06T11:00:05Z", "comment_data": [ { "_links": { @@ -186,19 +186,19 @@ }, "author_association": "MEMBER", "body": "Without the comment, it's not clear what the purpose of this function is. Do we still need `vim._foldupdate()` or can `zx` be used?", - "commit_id": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "commit_id": "05a22daf7bc4831d09c2a05556501ed420c2bda5", "created_at": "2023-12-04T17:28:42Z", "diff_hunk": "@@ -536,11 +536,9 @@ static int nlua_iconv(lua_State *lstate)\n return 1;\n }\n \n-// Like 'zx' but don't call newFoldLevel()\n static int nlua_foldupdate(lua_State *lstate)", "html_url": "https://github.com/neovim/neovim/pull/26390#discussion_r1414245399", "id": 1414245399, - "line": 543, + "line": 542, "node_id": "PRRC_kwDOAPphoM5US6wX", "original_commit_id": "39fd80ab6bd4883d430dfe4fe904890b8093b0f3", - "original_line": 543, + "original_line": 542, "original_position": 5, "original_start_line": null, "path": "src/nvim/lua/stdlib.c", - "position": 9, + "position": 8, "pull_request_review_id": 1763007121, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26390", "reactions": { @@ -254,20 +254,20 @@ }, "author_association": "CONTRIBUTOR", "body": "This function evaluates foldexpr for all lines (vim.treesitter.foldexpr caches the values, so this is fast) and updates the current window's folds based on those values. This function is necessary because the actual computation done in vim.treesitter.foldexpr is vim.schedule-ed to avoid textlock. \r\nhttps://github.com/neovim/neovim/blob/66f1563c7a48d76f99c89e32de030e57af2abfb4/runtime/lua/vim/treesitter/_fold.lua#L243-L254\r\n\r\n `zx` (and the old version of this function) has the additional side effect of opening the folds under cursor, so it's not suitable here.", - "commit_id": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "commit_id": "05a22daf7bc4831d09c2a05556501ed420c2bda5", "created_at": "2023-12-04T17:50:10Z", "diff_hunk": "@@ -536,11 +536,9 @@ static int nlua_iconv(lua_State *lstate)\n return 1;\n }\n \n-// Like 'zx' but don't call newFoldLevel()\n static int nlua_foldupdate(lua_State *lstate)", "html_url": "https://github.com/neovim/neovim/pull/26390#discussion_r1414269981", "id": 1414269981, "in_reply_to_id": 1414245399, - "line": 543, + "line": 542, "node_id": "PRRC_kwDOAPphoM5UTAwd", "original_commit_id": "39fd80ab6bd4883d430dfe4fe904890b8093b0f3", - "original_line": 543, + "original_line": 542, "original_position": 5, "original_start_line": null, "path": "src/nvim/lua/stdlib.c", - "position": 9, + "position": 8, "pull_request_review_id": 1763047804, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26390", "reactions": { @@ -323,20 +323,20 @@ }, "author_association": "MEMBER", "body": "Above info is worth adding to the commit message.\r\n\r\n> `zx` has the additional side effect of opening the folds under cursor,\r\n\r\nSeems like that is worth a 1-line code comment on the function. ", - "commit_id": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "commit_id": "05a22daf7bc4831d09c2a05556501ed420c2bda5", "created_at": "2023-12-04T18:26:41Z", "diff_hunk": "@@ -536,11 +536,9 @@ static int nlua_iconv(lua_State *lstate)\n return 1;\n }\n \n-// Like 'zx' but don't call newFoldLevel()\n static int nlua_foldupdate(lua_State *lstate)", "html_url": "https://github.com/neovim/neovim/pull/26390#discussion_r1414320601", "id": 1414320601, "in_reply_to_id": 1414245399, - "line": 543, + "line": 542, "node_id": "PRRC_kwDOAPphoM5UTNHZ", "original_commit_id": "39fd80ab6bd4883d430dfe4fe904890b8093b0f3", - "original_line": 543, + "original_line": 542, "original_position": 5, "original_start_line": null, "path": "src/nvim/lua/stdlib.c", - "position": 9, + "position": 8, "pull_request_review_id": 1763123820, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26390", "reactions": { @@ -392,20 +392,20 @@ }, "author_association": "CONTRIBUTOR", "body": "Added to the comment", - "commit_id": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "commit_id": "05a22daf7bc4831d09c2a05556501ed420c2bda5", "created_at": "2023-12-05T10:28:19Z", "diff_hunk": "@@ -536,11 +536,9 @@ static int nlua_iconv(lua_State *lstate)\n return 1;\n }\n \n-// Like 'zx' but don't call newFoldLevel()\n static int nlua_foldupdate(lua_State *lstate)", "html_url": "https://github.com/neovim/neovim/pull/26390#discussion_r1415318122", "id": 1415318122, "in_reply_to_id": 1414245399, - "line": 543, + "line": 542, "node_id": "PRRC_kwDOAPphoM5UXApq", "original_commit_id": "39fd80ab6bd4883d430dfe4fe904890b8093b0f3", - "original_line": 543, + "original_line": 542, "original_position": 5, "original_start_line": null, "path": "src/nvim/lua/stdlib.c", - "position": 9, + "position": 8, "pull_request_review_id": 1764673931, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26390", "reactions": { @@ -461,7 +461,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n curwin->w_foldinvalid = true; // recompute folds\r\n```", - "commit_id": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "commit_id": "05a22daf7bc4831d09c2a05556501ed420c2bda5", "created_at": "2023-12-05T14:44:02Z", "diff_hunk": "@@ -536,11 +536,15 @@ static int nlua_iconv(lua_State *lstate)\n return 1;\n }\n \n-// Like 'zx' but don't call newFoldLevel()\n+// Update foldlevels (e.g., by evaluating `foldexpr`) for all lines in the current window without\n+// invoking other side effects. Unlike `zx`, it does not close manually opened folds and does not\n+// open folds under the cursor. This is used in treesitter folding (vim.treesitter.foldexpr()),\n+// where the actual computation of foldlevels is done in a `vim.schedule`d callback and then cached.\n static int nlua_foldupdate(lua_State *lstate)\n {\n- curwin->w_foldinvalid = true; // recompute folds\n- foldOpenCursor();\n+ curwin->w_foldinvalid = true;", "html_url": "https://github.com/neovim/neovim/pull/26390#discussion_r1415732276", @@ -529,19 +529,19 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\n// Update foldlevels (e.g., by evaluating 'foldexpr') for all lines in the current window without\r\n```", - "commit_id": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "commit_id": "05a22daf7bc4831d09c2a05556501ed420c2bda5", "created_at": "2023-12-06T01:04:13Z", "diff_hunk": "@@ -536,11 +536,15 @@ static int nlua_iconv(lua_State *lstate)\n return 1;\n }\n \n-// Like 'zx' but don't call newFoldLevel()\n+// Update foldlevels (e.g., by evaluating `foldexpr`) for all lines in the current window without", "html_url": "https://github.com/neovim/neovim/pull/26390#discussion_r1416498234", "id": 1416498234, - "line": 539, + "line": null, "node_id": "PRRC_kwDOAPphoM5Ubgw6", "original_commit_id": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", "original_line": 539, "original_position": 5, "original_start_line": null, "path": "src/nvim/lua/stdlib.c", - "position": 5, + "position": null, "pull_request_review_id": 1766403846, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26390", "reactions": { @@ -582,6 +582,74 @@ "type": "User", "url": "https://api.github.com/users/zeertzjq" } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26390#discussion_r1417055011" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26390" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417055011" + } + }, + "author_association": "MEMBER", + "body": "I'd remove this last sentence too.", + "commit_id": "05a22daf7bc4831d09c2a05556501ed420c2bda5", + "created_at": "2023-12-06T10:17:55Z", + "diff_hunk": "@@ -536,11 +536,15 @@ static int nlua_iconv(lua_State *lstate)\n return 1;\n }\n \n-// Like 'zx' but don't call newFoldLevel()\n+// Update foldlevels (e.g., by evaluating 'foldexpr') for all lines in the current window without\n+// invoking other side effects. Unlike `zx`, it does not close manually opened folds and does not\n+// open folds under the cursor. This is used in treesitter folding (vim.treesitter.foldexpr()),\n+// where the actual computation of foldlevels is done in a `vim.schedule`d callback and then cached.", + "html_url": "https://github.com/neovim/neovim/pull/26390#discussion_r1417055011", + "id": 1417055011, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Udosj", + "original_commit_id": "19377b2b074340698cb8cbd94470480e4c038586", + "original_line": 542, + "original_position": 8, + "original_start_line": 541, + "path": "src/nvim/lua/stdlib.c", + "position": null, + "pull_request_review_id": 1767191115, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26390", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417055011/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": "RIGHT", + "subject_type": "line", + "updated_at": "2023-12-06T10:17:55Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417055011", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } } ], "comment_regular_data": [ @@ -767,9 +835,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/tomtomjhj/neovim/pulls{/number}", - "pushed_at": "2023-12-05T17:03:25Z", + "pushed_at": "2023-12-06T11:02:06Z", "releases_url": "https://api.github.com/repos/tomtomjhj/neovim/releases{/id}", - "size": 237694, + "size": 228394, "ssh_url": "git@github.com:tomtomjhj/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/tomtomjhj/neovim/stargazers", @@ -788,7 +856,7 @@ "watchers_count": 0, "web_commit_signoff_required": false }, - "sha": "ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "sha": "05a22daf7bc4831d09c2a05556501ed420c2bda5", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/19489738?v=4", "events_url": "https://api.github.com/users/tomtomjhj/events{/privacy}", @@ -825,61 +893,20 @@ } ], "locked": false, - "merge_commit_sha": "8687cb511cb51660584436e31df1c9d914609a55", - "merged_at": null, + "merge_commit_sha": "040369e1e4b86c4655a6885b36ee89ad4f10ca16", + "merged_at": "2023-12-06T11:00:05Z", "milestone": null, "node_id": "PR_kwDOAPphoM5hEMhD", "number": 26390, "patch_url": "https://github.com/neovim/neovim/pull/26390.patch", - "requested_reviewers": [ - { - "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", - "events_url": "https://api.github.com/users/bfredl/events{/privacy}", - "followers_url": "https://api.github.com/users/bfredl/followers", - "following_url": "https://api.github.com/users/bfredl/following{/other_user}", - "gists_url": "https://api.github.com/users/bfredl/gists{/gist_id}", - "gravatar_id": "", - "html_url": "https://github.com/bfredl", - "id": 1363104, - "login": "bfredl", - "node_id": "MDQ6VXNlcjEzNjMxMDQ=", - "organizations_url": "https://api.github.com/users/bfredl/orgs", - "received_events_url": "https://api.github.com/users/bfredl/received_events", - "repos_url": "https://api.github.com/users/bfredl/repos", - "site_admin": false, - "starred_url": "https://api.github.com/users/bfredl/starred{/owner}{/repo}", - "subscriptions_url": "https://api.github.com/users/bfredl/subscriptions", - "type": "User", - "url": "https://api.github.com/users/bfredl" - }, - { - "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", - "events_url": "https://api.github.com/users/clason/events{/privacy}", - "followers_url": "https://api.github.com/users/clason/followers", - "following_url": "https://api.github.com/users/clason/following{/other_user}", - "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", - "gravatar_id": "", - "html_url": "https://github.com/clason", - "id": 2361214, - "login": "clason", - "node_id": "MDQ6VXNlcjIzNjEyMTQ=", - "organizations_url": "https://api.github.com/users/clason/orgs", - "received_events_url": "https://api.github.com/users/clason/received_events", - "repos_url": "https://api.github.com/users/clason/repos", - "site_admin": false, - "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", - "subscriptions_url": "https://api.github.com/users/clason/subscriptions", - "type": "User", - "url": "https://api.github.com/users/clason" - } - ], + "requested_reviewers": [], "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26390/comments", - "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/ee5011d59e9df3eda633665e2a3ffd779b10b55a", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/05a22daf7bc4831d09c2a05556501ed420c2bda5", "title": "fix(treesitter): don't forcefully open folds", - "updated_at": "2023-12-06T01:04:13Z", + "updated_at": "2023-12-06T11:02:06Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26390", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/19489738?v=4", diff --git a/repositories/neovim/pulls/26398.json b/repositories/neovim/pulls/26398.json index 5b468189..a56f5581 100644 --- a/repositories/neovim/pulls/26398.json +++ b/repositories/neovim/pulls/26398.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26398" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/11ec252beb6effcc3ce54d4005f601b9ff349683" + "href": "https://api.github.com/repos/neovim/neovim/statuses/ac1f3c03fa6621ef9033d20149e3c4282a8adbd5" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "c3836e40a2bffbc1d4e06531145b7825788dd818", + "sha": "3198598e6974ae2009e816aeb96462cdfc3c59e9", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -169,7 +169,7 @@ "url": "https://api.github.com/users/neovim" } }, - "body": "Problem:\r\nNot all Lua code is checked by stylua. Automating code-style is an important mechanism for reducing time spent on accidental (non-essential) complexity.\r\n\r\nSolution:\r\n- Enable stylua for entire `test/` directory.\r\n- TODO: how to check \"all directories\"? With `GLOB_DIRS *` and `/.deps/` (or `.deps/`) in `.styluaignore`, Lua code in `.deps/` is still checked...", + "body": "Problem:\r\nNot all Lua code is checked by stylua. Automating code-style is an important mechanism for reducing time spent on accidental (non-essential) complexity.\r\n\r\nSolution:\r\n- Enable stylua for entire `test/` directory.\r\n- Exclude these high-churn files until this issue is resolved: https://github.com/JohnnyMorganz/StyLua/issues/829\r\n ```\r\n test/functional/ui/decorations_spec.lua | 3560 ++++++++++++++++++++++++++++++++++++----------------\r\n test/functional/ui/float_spec.lua | 5826 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------\r\n test/functional/ui/multigrid_spec.lua | 1349 ++++++++++++++------\r\n ```\r\n- Make surgical changes to these files (or add `stylua: ignore` in some\r\n small scopes) to improve the result:\r\n ```\r\n test/functional/vimscript/msgpack_functions_spec.lua | 1414 +++++++++++++++------\r\n test/functional/api/buffer_spec.lua | 1389 +++++++++++----------\r\n test/functional/api/vim_spec.lua | 2740 +++++++++++++++++++++++-----------------\r\n ```\r\n- These \"high churn\" files are NOT excluded because the changes are\r\n largely an improvement:\r\n ```\r\n test/functional/plugin/lsp_spec.lua | 2198 ++++++++++++++++++---------------\r\n test/functional/plugin/shada_spec.lua | 4078 +++++++++++++++++++++++++++++++++++-------------------------\r\n test/functional/ui/cmdline_spec.lua | 1199 +++++++++++-------\r\n test/functional/ui/popupmenu_spec.lua | 1267 +++++++++++--------\r\n test/functional/ui/messages_spec.lua | 1643 +++++++++++++++---------\r\n ```\r\n- TODO: how to check \"all directories\"? With `GLOB_DIRS *` and `/.deps/` (or `.deps/`) in `.styluaignore`, Lua code in `.deps/` is still checked...", "closed_at": null, "comment_data": [ { @@ -186,7 +186,7 @@ }, "author_association": "MEMBER", "body": "Trying this", - "commit_id": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "created_at": "2023-12-04T23:25:21Z", "diff_hunk": "@@ -226,16 +226,16 @@ add_glob_target(\n FLAGS -ll ${PROJECT_SOURCE_DIR}/test/lua_runner.lua ${CMAKE_BINARY_DIR}/usr luacheck -q\n GLOB_DIRS runtime/ scripts/ src/ test/\n GLOB_PAT *.lua\n- TOUCH_STRATEGY SINGLE)\n+ TOUCH_STRATEGY PER_DIR)", "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1414628958", @@ -254,7 +254,7 @@ }, "author_association": "MEMBER", "body": "I tried `GLOB_DIRS *` , but then `make lintlua` checks `.deps`, even if `/.deps/` (or `.deps/`) is in `.styluaignore`.", - "commit_id": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "created_at": "2023-12-04T23:26:34Z", "diff_hunk": "@@ -226,16 +226,16 @@ add_glob_target(\n FLAGS -ll ${PROJECT_SOURCE_DIR}/test/lua_runner.lua ${CMAKE_BINARY_DIR}/usr luacheck -q\n GLOB_DIRS runtime/ scripts/ src/ test/\n GLOB_PAT *.lua\n- TOUCH_STRATEGY SINGLE)\n+ TOUCH_STRATEGY PER_DIR)\n add_dependencies(lintlua-luacheck lua-dev-deps)\n \n add_glob_target(\n TARGET lintlua-stylua\n COMMAND ${STYLUA_PRG}\n FLAGS --color=always --check --respect-ignores\n- GLOB_DIRS runtime/ scripts/ src/ test/unit/\n+ GLOB_DIRS runtime/ scripts/ src/ test/", "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1414629723", @@ -322,7 +322,7 @@ }, "author_association": "MEMBER", "body": "Lol, I was fonna suggest we remove `PER_DIR` since we don't use it, and trying to keep `--target help` clean feels like a pipe dream at this point in time.", - "commit_id": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "created_at": "2023-12-05T07:59:04Z", "diff_hunk": "@@ -226,16 +226,16 @@ add_glob_target(\n FLAGS -ll ${PROJECT_SOURCE_DIR}/test/lua_runner.lua ${CMAKE_BINARY_DIR}/usr luacheck -q\n GLOB_DIRS runtime/ scripts/ src/ test/\n GLOB_PAT *.lua\n- TOUCH_STRATEGY SINGLE)\n+ TOUCH_STRATEGY PER_DIR)", "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1415061089", @@ -391,7 +391,7 @@ }, "author_association": "MEMBER", "body": "I have a suspicion this could be related to the implementation in add_glob_target rather than a problem in stylua. Unsure though.", - "commit_id": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "created_at": "2023-12-05T08:02:03Z", "diff_hunk": "@@ -226,16 +226,16 @@ add_glob_target(\n FLAGS -ll ${PROJECT_SOURCE_DIR}/test/lua_runner.lua ${CMAKE_BINARY_DIR}/usr luacheck -q\n GLOB_DIRS runtime/ scripts/ src/ test/\n GLOB_PAT *.lua\n- TOUCH_STRATEGY SINGLE)\n+ TOUCH_STRATEGY PER_DIR)\n add_dependencies(lintlua-luacheck lua-dev-deps)\n \n add_glob_target(\n TARGET lintlua-stylua\n COMMAND ${STYLUA_PRG}\n FLAGS --color=always --check --respect-ignores\n- GLOB_DIRS runtime/ scripts/ src/ test/unit/\n+ GLOB_DIRS runtime/ scripts/ src/ test/", "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1415068150", @@ -460,7 +460,7 @@ }, "author_association": "MEMBER", "body": "Up to you. But generating thousands of touch-files (and targets) seems excessive so I thought it's worth seeing if we can be less noisy, if the computation is cheap.", - "commit_id": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "created_at": "2023-12-05T13:10:52Z", "diff_hunk": "@@ -226,16 +226,16 @@ add_glob_target(\n FLAGS -ll ${PROJECT_SOURCE_DIR}/test/lua_runner.lua ${CMAKE_BINARY_DIR}/usr luacheck -q\n GLOB_DIRS runtime/ scripts/ src/ test/\n GLOB_PAT *.lua\n- TOUCH_STRATEGY SINGLE)\n+ TOUCH_STRATEGY PER_DIR)", "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1415586580", @@ -529,7 +529,7 @@ }, "author_association": "MEMBER", "body": "Computation shouldn't be a problem, I was more thinking of reducing the complexity of add_glob_target since it's getting kinda beefy.\n\nHowever, rethinking it now the test files might actually be a perfect use case for `PER_DIR` since there are so many files neatly organized in folders, and per-file target is excessive while a single target is probably too coarse. OK I'm convinced, let's try out `PER_DIR`.", - "commit_id": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "created_at": "2023-12-05T13:28:27Z", "diff_hunk": "@@ -226,16 +226,16 @@ add_glob_target(\n FLAGS -ll ${PROJECT_SOURCE_DIR}/test/lua_runner.lua ${CMAKE_BINARY_DIR}/usr luacheck -q\n GLOB_DIRS runtime/ scripts/ src/ test/\n GLOB_PAT *.lua\n- TOUCH_STRATEGY SINGLE)\n+ TOUCH_STRATEGY PER_DIR)", "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1415613019", @@ -598,7 +598,7 @@ }, "author_association": "MEMBER", "body": "I take back what I said lol, after experiment around I think this is a stylua problem. It's not a big deal IMO. I'd say maybe slap on a comment and call it a day. Up to you though.", - "commit_id": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "created_at": "2023-12-05T21:50:31Z", "diff_hunk": "@@ -226,16 +226,16 @@ add_glob_target(\n FLAGS -ll ${PROJECT_SOURCE_DIR}/test/lua_runner.lua ${CMAKE_BINARY_DIR}/usr luacheck -q\n GLOB_DIRS runtime/ scripts/ src/ test/\n GLOB_PAT *.lua\n- TOUCH_STRATEGY SINGLE)\n+ TOUCH_STRATEGY PER_DIR)\n add_dependencies(lintlua-luacheck lua-dev-deps)\n \n add_glob_target(\n TARGET lintlua-stylua\n COMMAND ${STYLUA_PRG}\n FLAGS --color=always --check --respect-ignores\n- GLOB_DIRS runtime/ scripts/ src/ test/unit/\n+ GLOB_DIRS runtime/ scripts/ src/ test/", "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1416318507", @@ -652,9 +652,346 @@ "type": "User", "url": "https://api.github.com/users/dundargoc" } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26398#discussion_r1418188745" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26398" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418188745" + } + }, + "author_association": "MEMBER", + "body": "This is data so added `stylua: ignore`. Nice thing about `stylua: ignore` is that it is local to the scope.", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", + "created_at": "2023-12-07T01:29:32Z", + "diff_hunk": "@@ -20,17 +20,18 @@ describe('msgpack*() functions', function()\n \n -- Regression test: msgpack_list_write was failing to write buffer with zero\n -- length.\n- obj_test('are able to dump and restore {\"file\": \"\"}', {{file=''}})\n+ obj_test('are able to dump and restore {\"file\": \"\"}', { { file = '' } })\n -- Regression test: msgpack_list_write was failing to write buffer with NL at\n -- the end.\n- obj_test('are able to dump and restore {0, \"echo mpack\"}', {{0, 'echo mpack'}})\n- obj_test('are able to dump and restore \"Test\\\\n\"', {'Test\\n'})\n+ obj_test('are able to dump and restore {0, \"echo mpack\"}', { { 0, 'echo mpack' } })\n+ obj_test('are able to dump and restore \"Test\\\\n\"', { 'Test\\n' })\n -- Regression test: msgpack_list_write was failing to write buffer with NL\n -- inside.\n- obj_test('are able to dump and restore \"Test\\\\nTest 2\"', {'Test\\nTest 2'})\n+ obj_test('are able to dump and restore \"Test\\\\nTest 2\"', { 'Test\\nTest 2' })\n -- Test that big objects (requirement: dump to something that is bigger then\n -- IOSIZE) are also fine. This particular object is obtained by concatenating\n -- 5 identical shada files.\n+ -- stylua: ignore\n local big_obj = {\n 1, 1436711454, 78, {", + "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1418188745", + "id": 1418188745, + "line": 36, + "node_id": "PRRC_kwDOAPphoM5Uh9fJ", + "original_commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", + "original_line": 36, + "original_position": 21, + "original_start_line": null, + "path": "test/functional/vimscript/msgpack_functions_spec.lua", + "position": 21, + "pull_request_review_id": 1768940918, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26398", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418188745/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-07T01:29:33Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418188745", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26398#discussion_r1418190596" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26398" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418190596" + } + }, + "author_association": "MEMBER", + "body": "Adjusted some test titles so that stylua doesn't indent the `function()` body. It's a _good thing_ that stylua is encouraging less verbose test names... :)", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", + "created_at": "2023-12-07T01:32:44Z", + "diff_hunk": "@@ -1025,19 +1053,19 @@ describe('api/buf', function()\n \n eq({ 'This should be last' }, get_lines(0, -1, true))\n -- cursor should end up after 't' in 'last'\n- eq({1, 19}, curwin('get_cursor'))\n+ eq({ 1, 19 }, curwin('get_cursor'))\n -- immediate call to nvim_win_get_cursor should have returned the same position\n- eq({1, 19}, cursor)\n+ eq({ 1, 19 }, cursor)\n end)\n \n- it('adjusts cursor column to keep it valid in a row after start_row if it got smaller', function()\n+ it('adjusts cursor to valid column in row after start_row if it got smaller', function()", + "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1418190596", + "id": 1418190596, + "line": 1061, + "node_id": "PRRC_kwDOAPphoM5Uh98E", + "original_commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", + "original_line": 1061, + "original_position": 1137, + "original_start_line": null, + "path": "test/functional/api/buffer_spec.lua", + "position": 1137, + "pull_request_review_id": 1768943467, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26398", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418190596/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-07T01:32:44Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418190596", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26398#discussion_r1418192021" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26398" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418192021" + } + }, + "author_association": "MEMBER", + "body": "Using `string:format([[...]])` avoids stylua, and is much more readable than the old way anyways. We really should avoid building strings with `..`, it's almost always less readable.", + "commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", + "created_at": "2023-12-07T01:34:58Z", + "diff_hunk": "@@ -254,24 +325,38 @@ describe('API', function()\n local fname = tmpname()\n write_file(fname, 'echo \"hello\"\\n')\n local sourcing_fname = tmpname()\n- write_file(sourcing_fname, 'call nvim_exec2(\"source '..fname..'\", {\"output\": v:false})\\n')\n+ write_file(sourcing_fname, 'call nvim_exec2(\"source ' .. fname .. '\", {\"output\": v:false})\\n')\n meths.exec2('set verbose=2', { output = false })\n- local traceback_output = 'line 0: sourcing \"'..sourcing_fname..'\"\\n'..\n- 'line 0: sourcing \"'..fname..'\"\\n'..\n- 'hello\\n'..\n- 'finished sourcing '..fname..'\\n'..\n- 'continuing in nvim_exec2() called at '..sourcing_fname..':1\\n'..\n- 'finished sourcing '..sourcing_fname..'\\n'..\n- 'continuing in nvim_exec2() called at nvim_exec2():0'\n- eq({ output = traceback_output },\n- meths.exec2('call nvim_exec2(\"source '..sourcing_fname..'\", {\"output\": v:false})', { output = true }))\n+ local traceback_output = dedent([[\n+ line 0: sourcing \"%s\"\n+ line 0: sourcing \"%s\"\n+ hello", + "html_url": "https://github.com/neovim/neovim/pull/26398#discussion_r1418192021", + "id": 1418192021, + "line": 333, + "node_id": "PRRC_kwDOAPphoM5Uh-SV", + "original_commit_id": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", + "original_line": 333, + "original_position": 328, + "original_start_line": 259, + "path": "test/functional/api/vim_spec.lua", + "position": 328, + "pull_request_review_id": 1768945918, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26398", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418192021/reactions" + }, + "side": "RIGHT", + "start_line": 259, + "start_side": "LEFT", + "subject_type": "line", + "updated_at": "2023-12-07T01:35:45Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418192021", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comment_regular_data": [ + { + "author_association": "MEMBER", + "body": "I agree with this direction but unfortunately it still doesn't handle the \"keyword args\" style of `screen:expect{}` calls very well, which leads to a massive expansion of vertical space in screen test files. cf any file which makes heavy use of screen tests, like `ui/bufhl_spec.lua` for \"simple\" cases and `ui/float_spec.lua` for more complex ones.\r\n\r\nI opened an issue at stylua for what I think are the main root causes https://github.com/JohnnyMorganz/StyLua/issues/829", + "created_at": "2023-12-06T09:17:23Z", + "html_url": "https://github.com/neovim/neovim/pull/26398#issuecomment-1842487181", + "id": 1842487181, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26398", + "node_id": "IC_kwDOAPphoM5t0h-N", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842487181/reactions" + }, + "updated_at": "2023-12-06T09:17:23Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842487181", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", + "events_url": "https://api.github.com/users/bfredl/events{/privacy}", + "followers_url": "https://api.github.com/users/bfredl/followers", + "following_url": "https://api.github.com/users/bfredl/following{/other_user}", + "gists_url": "https://api.github.com/users/bfredl/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/bfredl", + "id": 1363104, + "login": "bfredl", + "node_id": "MDQ6VXNlcjEzNjMxMDQ=", + "organizations_url": "https://api.github.com/users/bfredl/orgs", + "received_events_url": "https://api.github.com/users/bfredl/received_events", + "repos_url": "https://api.github.com/users/bfredl/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/bfredl/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/bfredl/subscriptions", + "type": "User", + "url": "https://api.github.com/users/bfredl" + } + }, + { + "author_association": "MEMBER", + "body": "> cf any file which makes heavy use of screen tests, like `ui/bufhl_spec.lua` for \"simple\" cases and `ui/float_spec.lua` for more complex ones.\r\n\r\nFor now I'll add those and other high-churn files to the exclude-list. I agree with https://github.com/JohnnyMorganz/StyLua/issues/829 , hope it gets resolved.", + "created_at": "2023-12-06T11:54:56Z", + "html_url": "https://github.com/neovim/neovim/pull/26398#issuecomment-1842725135", + "id": 1842725135, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26398", + "node_id": "IC_kwDOAPphoM5t1cEP", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842725135/reactions" + }, + "updated_at": "2023-12-06T11:55:27Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842725135", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "MEMBER", + "body": "See updated description", + "created_at": "2023-12-07T01:22:58Z", + "html_url": "https://github.com/neovim/neovim/pull/26398#issuecomment-1843979944", + "id": 1843979944, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26398", + "node_id": "IC_kwDOAPphoM5t6Oao", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843979944/reactions" + }, + "updated_at": "2023-12-07T01:22:58Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843979944", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } } ], - "comment_regular_data": [], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26398/comments", "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26398/commits", "created_at": "2023-12-04T23:23:35Z", @@ -748,9 +1085,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/justinmk/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:22:54Z", + "pushed_at": "2023-12-07T01:26:59Z", "releases_url": "https://api.github.com/repos/justinmk/neovim/releases{/id}", - "size": 239100, + "size": 237709, "ssh_url": "git@github.com:justinmk/neovim.git", "stargazers_count": 1, "stargazers_url": "https://api.github.com/repos/justinmk/neovim/stargazers", @@ -769,7 +1106,7 @@ "watchers_count": 1, "web_commit_signoff_required": false }, - "sha": "11ec252beb6effcc3ce54d4005f601b9ff349683", + "sha": "ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", "events_url": "https://api.github.com/users/justinmk/events{/privacy}", @@ -806,7 +1143,7 @@ } ], "locked": false, - "merge_commit_sha": "35ffcb839772ffc13d8393f4906707d39caaa77c", + "merge_commit_sha": "77de85d7c8b85a41838413c8ac1e5b8a530d4743", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5hHOMm", @@ -838,9 +1175,9 @@ "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26398/comments", "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/11ec252beb6effcc3ce54d4005f601b9ff349683", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/ac1f3c03fa6621ef9033d20149e3c4282a8adbd5", "title": "build: enable lintlua for test/ dir", - "updated_at": "2023-12-05T22:05:18Z", + "updated_at": "2023-12-07T01:34:59Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26398", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", diff --git a/repositories/neovim/pulls/26401.json b/repositories/neovim/pulls/26401.json index df9e0b32..18accd64 100644 --- a/repositories/neovim/pulls/26401.json +++ b/repositories/neovim/pulls/26401.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "32c8f951bb117bcff39460c3b4dd4f05112af6b3", @@ -170,7 +170,7 @@ } }, "body": "Fix #7225", - "closed_at": null, + "closed_at": "2023-12-06T10:51:07Z", "comment_data": [], "comment_regular_data": [ { @@ -311,9 +311,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/glepnir/neovim/pulls{/number}", - "pushed_at": "2023-12-05T11:42:39Z", + "pushed_at": "2023-12-06T12:05:56Z", "releases_url": "https://api.github.com/repos/glepnir/neovim/releases{/id}", - "size": 240246, + "size": 238203, "ssh_url": "git@github.com:glepnir/neovim.git", "stargazers_count": 1, "stargazers_url": "https://api.github.com/repos/glepnir/neovim/stargazers", @@ -378,7 +378,7 @@ } ], "locked": false, - "merge_commit_sha": "408040224dfbe1535479e662f57f1d5bc78f42bd", + "merge_commit_sha": "c62bbcc38d2de889f09cffb70877534d9990c2ad", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5hKWkT", @@ -388,10 +388,10 @@ "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26401/comments", - "state": "open", + "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/92863f88ca12c8358c1c54941762240f180cf847", "title": "fix(completion): ctrl-l work with complete", - "updated_at": "2023-12-05T12:07:29Z", + "updated_at": "2023-12-06T10:51:07Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26401", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", diff --git a/repositories/neovim/pulls/26403.json b/repositories/neovim/pulls/26403.json index 87e603e7..15519cce 100644 --- a/repositories/neovim/pulls/26403.json +++ b/repositories/neovim/pulls/26403.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "4a1abc91a0ec71f85239dbaf0ffa1fe42c50e368", @@ -172,96 +172,7 @@ "body": "Bumps [actions/labeler](https://github.com/actions/labeler) from 4 to 5.\n
\nRelease notes\n

Sourced from actions/labeler's releases.

\n
\n

v5.0.0

\n

What's Changed

\n

This release contains the following breaking changes:

\n
    \n
  1. \n

    The ability to apply labels based on the names of base and/or head branches was added (#186 and #54). The match object for changed files was expanded with new combinations in order to make it more intuitive and flexible (#423 and #101). As a result, the configuration file structure was significantly redesigned and is not compatible with the structure of the previous version. Please read the action documentation to find out how to adapt your configuration files for use with the new action version.

    \n
    2. \n
  2. \n

    The bug related to the sync-labels input was fixed (#112). Now the input value is read correctly.

    \n
    3. \n
  3. \n

    By default, dot input is set to true. Now, paths starting with a dot (e.g. .github) are matched by default.

    \n
    4. \n
  4. \n

    Version 5 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.

    \n
    5. \n
\n

For more information, please read the action documentation.

\n

New Contributors

\n\n

Full Changelog: https://github.com/actions/labeler/compare/v4...v5.0.0

\n

v5.0.0-beta.1

\n

What's Changed

\n

In scope of this beta release, the structure of the configuration file (.github/labeler.yml) was changed from

\n
LabelName:\n- any:\n  - changed-files: ['list', 'of', 'globs']\n  - base-branch: ['list', 'of', 'regexps']\n  - head-branch: ['list', 'of', 'regexps']\n- all:\n  - changed-files: ['list', 'of', 'globs']\n  - base-branch: ['list', 'of', 'regexps']\n  - head-branch: ['list', 'of', 'regexps']\n
\n

to

\n
LabelName:\n- any:\n  - changed-files: \n    - AnyGlobToAnyFile: ['list', 'of', 'globs']\n    - AnyGlobToAllFiles: ['list', 'of', 'globs']\n    - AllGlobsToAnyFile: ['list', 'of', 'globs']\n    - AllGlobsToAllFiles: ['list', 'of', 'globs']\n  - base-branch: ['list', 'of', 'regexps']\n  - head-branch: ['list', 'of', 'regexps']\n- all:\n  - changed-files:\n    - AnyGlobToAnyFile: ['list', 'of', 'globs']\n    - AnyGlobToAllFiles: ['list', 'of', 'globs']\n    - AllGlobsToAnyFile: ['list', 'of', 'globs']\n</tr></table> \n
\n
\n

... (truncated)

\n
\n
\nCommits\n
    \n
  • 8558fd7 Merge pull request #709 from actions/v5.0.0-beta
    • \n
  • 000ca75 Merge pull request #700 from MaksimZhukov/apply-suggestions-and-update-docume...
    • \n
  • cb66c2f Update dist
    • \n
  • 9181355 Apply suggestions for the beta vesrion and update the documentation
    • \n
  • efe4c1c Merge pull request #699 from MaksimZhukov/update-node-runtime-and-dependencies
    • \n
  • c0957ad Run Prettier
    • \n
  • 8dc8d18 Update Node.js version in reusable workflows
    • \n
  • d0d0bbe Update documentation
    • \n
  • 1375c42 5.0.0
    • \n
  • ab7411e Change version of Node.js runtime to node20
    • \n
  • Additional commits viewable in compare view
    • \n
\n
\n
\n\n\n[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)\n\nDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.\n\n[//]: # (dependabot-automerge-start)\n[//]: # (dependabot-automerge-end)\n\n---\n\n
\nDependabot commands and options\n
\n\nYou can trigger Dependabot actions by commenting on this PR:\n- `@dependabot rebase` will rebase this PR\n- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it\n- `@dependabot merge` will merge this PR after your CI passes on it\n- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it\n- `@dependabot cancel merge` will cancel a previously requested merge and block automerging\n- `@dependabot reopen` will reopen this PR if it is closed\n- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually\n- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency\n- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)\n- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)\n- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)\n\n\n
", "closed_at": null, "comment_data": [], - "comment_regular_data": [ - { - "author_association": "MEMBER", - "body": "> The bug related to the sync-labels input was fixed ([#112](https://redirect.github.com/actions/labeler/issues/112)). Now the input value is read correctly.\r\n\r\nWE DID IT REDDIT!\r\n\r\n(only took them like 2 years to merge a finished PR, but better late than never I guess 🙄 )", - "created_at": "2023-12-05T22:40:44Z", - "html_url": "https://github.com/neovim/neovim/pull/26403#issuecomment-1841745369", - "id": 1841745369, - "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26403", - "node_id": "IC_kwDOAPphoM5txs3Z", - "performed_via_github_app": null, - "reactions": { - "+1": 0, - "-1": 0, - "confused": 0, - "eyes": 0, - "heart": 0, - "hooray": 1, - "laugh": 0, - "rocket": 0, - "total_count": 1, - "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841745369/reactions" - }, - "updated_at": "2023-12-05T22:42:21Z", - "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841745369", - "user": { - "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", - "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", - "followers_url": "https://api.github.com/users/dundargoc/followers", - "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", - "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", - "gravatar_id": "", - "html_url": "https://github.com/dundargoc", - "id": 33953936, - "login": "dundargoc", - "node_id": "MDQ6VXNlcjMzOTUzOTM2", - "organizations_url": "https://api.github.com/users/dundargoc/orgs", - "received_events_url": "https://api.github.com/users/dundargoc/received_events", - "repos_url": "https://api.github.com/users/dundargoc/repos", - "site_admin": false, - "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", - "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", - "type": "User", - "url": "https://api.github.com/users/dundargoc" - } - }, - { - "author_association": "MEMBER", - "body": "OK, somehow they made the action 10 times more convoluted. I'll need to study the yaml soup they've concocted before we can merge this.", - "created_at": "2023-12-05T22:53:43Z", - "html_url": "https://github.com/neovim/neovim/pull/26403#issuecomment-1841759144", - "id": 1841759144, - "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26403", - "node_id": "IC_kwDOAPphoM5txwOo", - "performed_via_github_app": null, - "reactions": { - "+1": 0, - "-1": 0, - "confused": 0, - "eyes": 0, - "heart": 0, - "hooray": 0, - "laugh": 0, - "rocket": 0, - "total_count": 0, - "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841759144/reactions" - }, - "updated_at": "2023-12-05T22:53:43Z", - "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841759144", - "user": { - "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", - "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", - "followers_url": "https://api.github.com/users/dundargoc/followers", - "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", - "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", - "gravatar_id": "", - "html_url": "https://github.com/dundargoc", - "id": 33953936, - "login": "dundargoc", - "node_id": "MDQ6VXNlcjMzOTUzOTM2", - "organizations_url": "https://api.github.com/users/dundargoc/orgs", - "received_events_url": "https://api.github.com/users/dundargoc/received_events", - "repos_url": "https://api.github.com/users/dundargoc/repos", - "site_admin": false, - "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", - "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", - "type": "User", - "url": "https://api.github.com/users/dundargoc" - } - } - ], + "comment_regular_data": [], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26403/comments", "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26403/commits", "created_at": "2023-12-05T12:50:32Z", @@ -292,8 +203,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -355,11 +266,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -377,11 +288,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "12dcdb59044e260104a4d24197f241bcd94f0f42", @@ -427,10 +338,19 @@ "name": "dependencies", "node_id": "MDU6TGFiZWwxMjA1NDAwNzA0", "url": "https://api.github.com/repos/neovim/neovim/labels/dependencies" + }, + { + "color": "B60205", + "default": false, + "description": "Nothing to see here; move along", + "id": 4135681637, + "name": "DO NOT MERGE", + "node_id": "LA_kwDOAPphoM72gX5l", + "url": "https://api.github.com/repos/neovim/neovim/labels/DO%20NOT%20MERGE" } ], "locked": false, - "merge_commit_sha": "4e73d300cf1880d8ebb4986bdbc5b1c9b8f71f3c", + "merge_commit_sha": "9b601baae98139d56ec19538575ca584df59458c", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5hLJgQ", @@ -504,7 +424,7 @@ "state": "open", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/12dcdb59044e260104a4d24197f241bcd94f0f42", "title": "ci: bump actions/labeler from 4 to 5", - "updated_at": "2023-12-05T22:53:44Z", + "updated_at": "2023-12-06T13:39:57Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26403", "user": { "avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4", diff --git a/repositories/neovim/pulls/26404.json b/repositories/neovim/pulls/26404.json index 71bcbbe0..89b9661c 100644 --- a/repositories/neovim/pulls/26404.json +++ b/repositories/neovim/pulls/26404.json @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "ca4fe083e5b1a7c2e93cf77aa849fbec72757627", @@ -362,12 +362,12 @@ "+1": 0, "-1": 0, "confused": 0, - "eyes": 0, + "eyes": 1, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 0, + "total_count": 1, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841693330/reactions" }, "updated_at": "2023-12-05T22:04:50Z", @@ -392,6 +392,50 @@ "type": "User", "url": "https://api.github.com/users/zeertzjq" } + }, + { + "author_association": "MEMBER", + "body": "ok, I'll make that one a range also. https://github.com/neovim/neovim/pull/26423", + "created_at": "2023-12-06T02:11:04Z", + "html_url": "https://github.com/neovim/neovim/pull/26404#issuecomment-1841970625", + "id": 1841970625, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26404", + "node_id": "IC_kwDOAPphoM5tyj3B", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841970625/reactions" + }, + "updated_at": "2023-12-06T15:22:43Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841970625", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } } ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26404/comments", @@ -487,9 +531,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/justinmk/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:22:54Z", + "pushed_at": "2023-12-07T01:26:59Z", "releases_url": "https://api.github.com/repos/justinmk/neovim/releases{/id}", - "size": 239100, + "size": 237709, "ssh_url": "git@github.com:justinmk/neovim.git", "stargazers_count": 1, "stargazers_url": "https://api.github.com/repos/justinmk/neovim/stargazers", @@ -567,7 +611,7 @@ "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/1fd29a28841dee3d25ff079eb24fc160eb02cb3c", "title": "test: fileio_spec is unreliable/flaky", - "updated_at": "2023-12-05T22:04:52Z", + "updated_at": "2023-12-06T15:22:43Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26404", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", diff --git a/repositories/neovim/pulls/26406.json b/repositories/neovim/pulls/26406.json index f726d2ef..12b86270 100644 --- a/repositories/neovim/pulls/26406.json +++ b/repositories/neovim/pulls/26406.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/86eb3c70c8547394fa92b9d14c85957282079f9c" + "href": "https://api.github.com/repos/neovim/neovim/statuses/2000abbdfe39f338c09796293f76ec8336d81b22" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "ca4fe083e5b1a7c2e93cf77aa849fbec72757627", + "sha": "3198598e6974ae2009e816aeb96462cdfc3c59e9", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -169,9 +169,1451 @@ "url": "https://api.github.com/users/neovim" } }, - "body": "Problem: The entire marktree needs to be traversed each time a sign is\r\n removed from the sentinel line.\r\nSolution: Remove sentinel line and instead keep track of the number of\r\n lines that hold up the 'signcolumn' in \"max_count\". Adjust this\r\n number when adding/removing signs, and set it to 0 when the\r\n maximum number of signs on a line changes. Only when\r\n \"max_count\" is decremented to 0 due to sign removal do we need\r\n to traverse the entire tree for signs. Only do this at the\r\n start of a redraw, if \"max_count\" changes before a redraw\r\n happens we also don't have to traverse the entire marktree.\r\n ---\r\n Also improve tree traversal when counting the number of signs.\r\n Instead of looping over the to be checked range and counting\r\n the overlap for each row, keep track of the overlap in a map\r\n and add this to the count.", + "body": "Problem: The entire marktree needs to be traversed each time a sign is removed from the sentinel line.\r\nSolution: Remove sentinel line and instead keep track of the number of lines that hold up the 'signcolumn' in \"max_count\". Adjust this number for added/removed signs, and set it to 0 when the maximum number of signs on a line changes. Only when \"max_count\" is decremented to 0 due to sign removal do we need to check the entire buffer.\r\n\r\nAlso replace \"invalid_top\" and \"invalid_bot\" with a map of invalid ranges, further reducing the number of lines to be checked.\r\n\r\nAlso improve tree traversal when counting the number of signs. Instead of looping over the to be checked range and counting the overlap for each row, keep track of the overlap in an array and add this to the count.", "closed_at": null, - "comment_data": [], + "comment_data": [ + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417013059" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417013059" + } + }, + "author_association": "MEMBER", + "body": "Why is this a 1 element array?", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T09:46:10Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw\n+ Map(int, int) invalid[1]; // map of invalid ranges to be checked", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417013059", + "id": 1417013059, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UdedD", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 709, + "original_position": 12, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1767125483, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417013059/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T10:13:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417013059", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417020795" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417020795" + } + }, + "author_association": "MEMBER", + "body": "I do think this is harder to read than what it was before.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T09:51:37Z", + "diff_hunk": "@@ -735,11 +735,8 @@ void decor_redraw_signs(win_T *wp, buf_T *buf, int row, SignTextAttrs sattrs[],\n }\n }\n \n- while (itr->x) {\n- MTKey mark = marktree_itr_current(itr);\n- if (mark.pos.row != row) {\n- break;\n- }\n+ MTKey mark;\n+ while ((mark = marktree_itr_current(itr)).pos.row == row) {", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417020795", + "id": 1417020795, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UdgV7", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 739, + "original_position": 65, + "original_start_line": null, + "path": "src/nvim/decoration.c", + "position": null, + "pull_request_review_id": 1767125483, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417020795/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T10:13:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417020795", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417026804" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417026804" + } + }, + "author_association": "MEMBER", + "body": "If range is a line number then I would rename the arguments to `line1` and `line2` and add\r\n\r\n```suggestion\r\nint row1 = line1 - 1;\r\nint row2 = line2 - 1;\r\n```", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T09:55:43Z", + "diff_hunk": "@@ -792,50 +789,95 @@ DecorSignHighlight *decor_find_sign(DecorInline decor)\n }\n }\n \n-// Increase the signcolumn size and update the sentinel line if necessary for\n-// the invalidated range.\n-void decor_validate_signcols(buf_T *buf, int max)\n+/// Add overlapping signs in current row to count. If it is greater than\n+/// current max, set it and make b_signcols valid. Adjust max_count if\n+/// row has or had max signs.\n+void buf_signcols_count_row(buf_T *buf, const int overlap[], int idx, int count, bool del)\n {\n- int signcols = 0; // highest value of count\n- int currow = buf->b_signcols.invalid_top - 1;\n- // TODO(bfredl): only need to use marktree_itr_get_overlap once.\n- // then we can process both start and end events and update state for each row\n- for (; currow < buf->b_signcols.invalid_bot; currow++) {\n- MarkTreeIter itr[1];\n- if (!marktree_itr_get_overlap(buf->b_marktree, currow, 0, itr)) {\n- continue;\n- }\n+ count += overlap[idx];\n+ if (count > buf->b_signcols.max) {\n+ buf->b_signcols.max = count;\n+ buf->b_signcols.resized = true;\n+ buf->b_signcols.max_count = 0;\n+ }\n+ buf->b_signcols.max_count += (count == buf->b_signcols.max - del) * (del ? -1 : 1);\n+}\n \n- int count = 0;\n- MTPair pair;\n- while (marktree_itr_step_overlap(buf->b_marktree, itr, &pair)) {\n- if (!mt_invalid(pair.start) && (pair.start.flags & MT_FLAG_DECOR_SIGNTEXT)) {\n- count++;\n- }\n- }\n+void buf_signcols_validate_range(buf_T *buf, int row1, int row2)\n+{\n+ bool del = row1 < 0;\n+ // Range for deleted sign is negative, make it positive.\n+ if (del) {\n+ row1 *= -1;\n+ row2 *= -1;\n+ }\n+ row1--; // Range is actually a line number, adjust for row.\n+ row2--;", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417026804", + "id": 1417026804, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Udhz0", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 815, + "original_position": 115, + "original_start_line": 814, + "path": "src/nvim/decoration.c", + "position": null, + "pull_request_review_id": 1767125483, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417026804/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": "RIGHT", + "subject_type": "line", + "updated_at": "2023-12-06T10:13:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417026804", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417032441" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417032441" + } + }, + "author_association": "MEMBER", + "body": "`overlap` and `idx` are only used once. I would move the count adjustment outside to make this function less convoluted.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T10:00:05Z", + "diff_hunk": "@@ -792,50 +789,95 @@ DecorSignHighlight *decor_find_sign(DecorInline decor)\n }\n }\n \n-// Increase the signcolumn size and update the sentinel line if necessary for\n-// the invalidated range.\n-void decor_validate_signcols(buf_T *buf, int max)\n+/// Add overlapping signs in current row to count. If it is greater than\n+/// current max, set it and make b_signcols valid. Adjust max_count if\n+/// row has or had max signs.\n+void buf_signcols_count_row(buf_T *buf, const int overlap[], int idx, int count, bool del)", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417032441", + "id": 1417032441, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UdjL5", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 795, + "original_position": 79, + "original_start_line": null, + "path": "src/nvim/decoration.c", + "position": null, + "pull_request_review_id": 1767125483, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417032441/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T10:13:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417032441", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417038634" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417038634" + } + }, + "author_association": "MEMBER", + "body": "Should this go in the same file as `buf_signcols_validate_range`?", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T10:05:01Z", + "diff_hunk": "@@ -1200,16 +1204,45 @@ void comp_col(void)\n set_vim_var_nr(VV_ECHOSPACE, sc_col - 1);\n }\n \n-static void redraw_win_signcol(win_T *wp)\n+static int buf_signcols_validate(win_T *wp, buf_T *buf, bool force)", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417038634", + "id": 1417038634, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Udksq", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 1207, + "original_position": 37, + "original_start_line": null, + "path": "src/nvim/drawscreen.c", + "position": null, + "pull_request_review_id": 1767125483, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417038634/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T10:13:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417038634", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417042650" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417042650" + } + }, + "author_association": "MEMBER", + "body": "Does this need to be state? It looks like this can be used as the return value for `buf_signcols_validate`, `buf_signcols_validate_range` and `buf_signcols_set_invalid`.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T10:08:11Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417042650", + "id": 1417042650, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Udlra", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 708, + "original_position": 11, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1767125483, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417042650/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T10:13:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417042650", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417048186" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417048186" + } + }, + "author_association": "MEMBER", + "body": "Is this change necessary?", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T10:12:24Z", + "diff_hunk": "@@ -67,18 +67,18 @@ void extmark_set(buf_T *buf, uint32_t ns_id, uint32_t *idp, int row, colnr_T col\n } else {\n assert(marktree_itr_valid(itr));\n if (old_mark.pos.row == row && old_mark.pos.col == col) {\n+ // not paired: we can revise in place\n if (mt_decor_any(old_mark)) {\n+ mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_DECOR_SIGNTEXT;\n buf_decor_remove(buf, row, row, mt_decor(old_mark), true);\n }\n-\n- // not paired: we can revise in place\n mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_EXTERNAL_MASK;\n mt_itr_rawkey(itr).flags |= flags;\n mt_itr_rawkey(itr).decor_data = decor.data;\n goto revised;\n }\n- buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);\n marktree_del_itr(buf->b_marktree, itr, false);\n+ buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417048186", + "id": 1417048186, + "line": 81, + "node_id": "PRRC_kwDOAPphoM5UdnB6", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 81, + "original_position": 18, + "original_start_line": null, + "path": "src/nvim/extmark.c", + "position": 18, + "pull_request_review_id": 1767125483, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417048186/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T10:13:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417048186", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417121540" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417121540" + } + }, + "author_association": "MEMBER", + "body": "Not sure tbh, to be consistent with `b_extmark_ns`. Presumably just to be able to call `map_` functions without taking the address.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T11:14:42Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw\n+ Map(int, int) invalid[1]; // map of invalid ranges to be checked", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417121540", + "id": 1417121540, + "in_reply_to_id": 1417013059, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ud48E", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 709, + "original_position": 12, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1767298580, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417121540/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:30:46Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417121540", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417126154" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417126154" + } + }, + "author_association": "MEMBER", + "body": "Sure, both are only used in `drawscreen.c` but have more to do with decorations I guess. Would `static` `drawscreen.c` functions be preferred or exported in `decorations.c`?", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T11:17:53Z", + "diff_hunk": "@@ -1200,16 +1204,45 @@ void comp_col(void)\n set_vim_var_nr(VV_ECHOSPACE, sc_col - 1);\n }\n \n-static void redraw_win_signcol(win_T *wp)\n+static int buf_signcols_validate(win_T *wp, buf_T *buf, bool force)", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417126154", + "id": 1417126154, + "in_reply_to_id": 1417038634, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ud6EK", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 1207, + "original_position": 37, + "original_start_line": null, + "path": "src/nvim/drawscreen.c", + "position": null, + "pull_request_review_id": 1767303759, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417126154/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:17:54Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417126154", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417129775" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417129775" + } + }, + "author_association": "MEMBER", + "body": "Sure, it's only used to determine whether 'statuscolumn' needs to be rebuild when 'signcolumn' is \"number/no\". Because `w_scwidth` is and stays 0 then.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T11:21:01Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417129775", + "id": 1417129775, + "in_reply_to_id": 1417042650, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ud68v", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 708, + "original_position": 11, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1767308764, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417129775/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:21:01Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417129775", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417132817" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417132817" + } + }, + "author_association": "MEMBER", + "body": "I think not `drawscreen.c`. I considered adding a new file just for column/signs, but if not that then maybe `decoration.c` for now.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T11:24:02Z", + "diff_hunk": "@@ -1200,16 +1204,45 @@ void comp_col(void)\n set_vim_var_nr(VV_ECHOSPACE, sc_col - 1);\n }\n \n-static void redraw_win_signcol(win_T *wp)\n+static int buf_signcols_validate(win_T *wp, buf_T *buf, bool force)", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417132817", + "id": 1417132817, + "in_reply_to_id": 1417038634, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ud7sR", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 1207, + "original_position": 37, + "original_start_line": null, + "path": "src/nvim/drawscreen.c", + "position": null, + "pull_request_review_id": 1767313452, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417132817/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:24:03Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417132817", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417134178" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417134178" + } + }, + "author_association": "MEMBER", + "body": "Hmm since the counting is now delayed to the start of a redraw it no longer is. Can revert I guess but I think it's more correct in this order in case `buf_decor_remove()` ever handles other side effects which expect the mark to already be removed from the marktree.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T11:25:24Z", + "diff_hunk": "@@ -67,18 +67,18 @@ void extmark_set(buf_T *buf, uint32_t ns_id, uint32_t *idp, int row, colnr_T col\n } else {\n assert(marktree_itr_valid(itr));\n if (old_mark.pos.row == row && old_mark.pos.col == col) {\n+ // not paired: we can revise in place\n if (mt_decor_any(old_mark)) {\n+ mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_DECOR_SIGNTEXT;\n buf_decor_remove(buf, row, row, mt_decor(old_mark), true);\n }\n-\n- // not paired: we can revise in place\n mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_EXTERNAL_MASK;\n mt_itr_rawkey(itr).flags |= flags;\n mt_itr_rawkey(itr).decor_data = decor.data;\n goto revised;\n }\n- buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);\n marktree_del_itr(buf->b_marktree, itr, false);\n+ buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417134178", + "id": 1417134178, + "in_reply_to_id": 1417048186, + "line": 81, + "node_id": "PRRC_kwDOAPphoM5Ud8Bi", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 81, + "original_position": 18, + "original_start_line": null, + "path": "src/nvim/extmark.c", + "position": 18, + "pull_request_review_id": 1767315556, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417134178/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:25:24Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417134178", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417170863" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417170863" + } + }, + "author_association": "MEMBER", + "body": "The other line only deletes an iterator. It doesn't change the marktree.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T11:59:17Z", + "diff_hunk": "@@ -67,18 +67,18 @@ void extmark_set(buf_T *buf, uint32_t ns_id, uint32_t *idp, int row, colnr_T col\n } else {\n assert(marktree_itr_valid(itr));\n if (old_mark.pos.row == row && old_mark.pos.col == col) {\n+ // not paired: we can revise in place\n if (mt_decor_any(old_mark)) {\n+ mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_DECOR_SIGNTEXT;\n buf_decor_remove(buf, row, row, mt_decor(old_mark), true);\n }\n-\n- // not paired: we can revise in place\n mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_EXTERNAL_MASK;\n mt_itr_rawkey(itr).flags |= flags;\n mt_itr_rawkey(itr).decor_data = decor.data;\n goto revised;\n }\n- buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);\n marktree_del_itr(buf->b_marktree, itr, false);\n+ buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417170863", + "id": 1417170863, + "in_reply_to_id": 1417048186, + "line": 81, + "node_id": "PRRC_kwDOAPphoM5UeE-v", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 81, + "original_position": 18, + "original_start_line": null, + "path": "src/nvim/extmark.c", + "position": 18, + "pull_request_review_id": 1767373380, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417170863/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T11:59:18Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417170863", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417191387" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417191387" + } + }, + "author_association": "MEMBER", + "body": "Uhm I don't think that's true. `marktree_del_itr()` removes the key pointed to by the iterator?\r\n\r\nPoint is that the pattern of edit marktree -> handle side effects seems safer, same as in https://github.com/neovim/neovim/pull/26361. But it's no longer needed for correctness in this PR, I'm fine to revert.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T12:19:06Z", + "diff_hunk": "@@ -67,18 +67,18 @@ void extmark_set(buf_T *buf, uint32_t ns_id, uint32_t *idp, int row, colnr_T col\n } else {\n assert(marktree_itr_valid(itr));\n if (old_mark.pos.row == row && old_mark.pos.col == col) {\n+ // not paired: we can revise in place\n if (mt_decor_any(old_mark)) {\n+ mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_DECOR_SIGNTEXT;\n buf_decor_remove(buf, row, row, mt_decor(old_mark), true);\n }\n-\n- // not paired: we can revise in place\n mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_EXTERNAL_MASK;\n mt_itr_rawkey(itr).flags |= flags;\n mt_itr_rawkey(itr).decor_data = decor.data;\n goto revised;\n }\n- buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);\n marktree_del_itr(buf->b_marktree, itr, false);\n+ buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417191387", + "id": 1417191387, + "in_reply_to_id": 1417048186, + "line": 81, + "node_id": "PRRC_kwDOAPphoM5UeJ_b", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 81, + "original_position": 18, + "original_start_line": null, + "path": "src/nvim/extmark.c", + "position": 18, + "pull_request_review_id": 1767406076, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417191387/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T12:22:01Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417191387", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417201050" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417201050" + } + }, + "author_association": "MEMBER", + "body": "Is it necessary to remove? It's more convenient as a globally accessible variable.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T12:28:27Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417201050", + "id": 1417201050, + "in_reply_to_id": 1417042650, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeMWa", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 708, + "original_position": 11, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1767421348, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417201050/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T12:28:27Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417201050", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417556798" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417556798" + } + }, + "author_association": "MEMBER", + "body": "No worries. I'm just being picky to reduce the diff.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T15:46:52Z", + "diff_hunk": "@@ -67,18 +67,18 @@ void extmark_set(buf_T *buf, uint32_t ns_id, uint32_t *idp, int row, colnr_T col\n } else {\n assert(marktree_itr_valid(itr));\n if (old_mark.pos.row == row && old_mark.pos.col == col) {\n+ // not paired: we can revise in place\n if (mt_decor_any(old_mark)) {\n+ mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_DECOR_SIGNTEXT;\n buf_decor_remove(buf, row, row, mt_decor(old_mark), true);\n }\n-\n- // not paired: we can revise in place\n mt_itr_rawkey(itr).flags &= (uint16_t) ~MT_FLAG_EXTERNAL_MASK;\n mt_itr_rawkey(itr).flags |= flags;\n mt_itr_rawkey(itr).decor_data = decor.data;\n goto revised;\n }\n- buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);\n marktree_del_itr(buf->b_marktree, itr, false);\n+ buf_decor_remove(buf, old_mark.pos.row, old_mark.pos.row, mt_decor(old_mark), true);", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417556798", + "id": 1417556798, + "in_reply_to_id": 1417048186, + "line": 81, + "node_id": "PRRC_kwDOAPphoM5UfjM-", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 81, + "original_position": 18, + "original_start_line": null, + "path": "src/nvim/extmark.c", + "position": 18, + "pull_request_review_id": 1767942592, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417556798/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T15:46:53Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417556798", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417579371" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417579371" + } + }, + "author_association": "MEMBER", + "body": "Global state should generally be avoided, especially in a repository with a regular rotation of contributors who don't always 100% understand the code they have inherited. There are plenty of resources that explain this (quick one from google: https://softwareengineering.stackexchange.com/questions/148108/why-is-global-state-so-evil).\r\n\r\n~I know this isn't exactly global state~ (EDIT: actually it is), but given the size of the buf_T struct, the same principles all apply.\r\n\r\nSometimes the benefits of convenience can justify it, time is a real constraint after all, but I don't think that's the case here. I think removing this piece of state will make the code cleaner, even though it is a little more effort.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T15:57:04Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417579371", + "id": 1417579371, + "in_reply_to_id": 1417042650, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ufotr", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 708, + "original_position": 11, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1767977126, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417579371/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T15:58:00Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417579371", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417600876" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417600876" + } + }, + "author_association": "MEMBER", + "body": "> Sometimes the benefits of convenience can justify it, time is a real constraint after all, but I don't think that's the case here. I think removing this piece of state will make the code cleaner, even though it is a little more effort.\r\n\r\nI had already done the work to remove it but I disagreed on it being cleaner. It requires a bunch of extra if statements to check the return value of the inner functions. And once I got to replacing this one I actually got stuck:\r\n```c\r\nvoid buf_signcols_invalidate_range(buf_T *buf, int line1, int line2)\r\n{\r\n if (!buf->b_signs_with_text) {\r\n buf->b_signcols.max = buf->b_signcols.max_count = 0;\r\n buf->b_signcols.resized = true;\r\n map_clear(int, buf->b_signcols.invalid);\r\n return;\r\n }\r\n```\r\n\r\nThe caller of this function doesn't care about `b_signcols.resized`, and it needs to stay `true` until the 'statuscolumn' check in `update_screen()`. So while avoiding global state might be better, I'm not sure it can be avoided here.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T16:10:57Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417600876", + "id": 1417600876, + "in_reply_to_id": 1417042650, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Uft9s", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 708, + "original_position": 11, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1768018177, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417600876/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T16:17:02Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417600876", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417615907" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417615907" + } + }, + "author_association": "MEMBER", + "body": "Ok, so in this case it does actually need to be state.", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T16:21:28Z", + "diff_hunk": "@@ -703,11 +703,10 @@ struct file_buffer {\n // may use a different synblock_T.\n \n struct {\n- int size; // last calculated number of sign columns\n- int max; // maximum value size is valid for.\n- linenr_T sentinel; // a line number which is holding up the signcolumn\n- linenr_T invalid_top; // first invalid line number that needs to be checked\n- linenr_T invalid_bot; // last invalid line number that needs to be checked\n+ int max; // maximum number of signs on a single line\n+ int max_count; // number of lines with max number of signs\n+ bool resized; // whether max changed at start of redraw", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417615907", + "id": 1417615907, + "in_reply_to_id": 1417042650, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ufxoj", + "original_commit_id": "31a3869a02ed1c91e7e8a56550b748467de87f3c", + "original_line": 708, + "original_position": 11, + "original_start_line": null, + "path": "src/nvim/buffer_defs.h", + "position": null, + "pull_request_review_id": 1768043296, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417615907/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T16:21:28Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417615907", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417617249" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417617249" + } + }, + "author_association": "MEMBER", + "body": "This is a bit of a random place to reset this. Shouldn't this be done at line 615?", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T16:22:29Z", + "diff_hunk": "@@ -619,6 +621,8 @@ int update_screen(void)\n screen_search_hl.rm.regprog = NULL;\n \n FOR_ALL_WINDOWS_IN_TAB(wp, curtab) {\n+ wp->w_buffer->b_signcols.resized = false;", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417617249", + "id": 1417617249, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ufx9h", + "original_commit_id": "86aa78357e654bf1f38c57b9fe11c46df58e2e14", + "original_line": 624, + "original_position": 27, + "original_start_line": null, + "path": "src/nvim/drawscreen.c", + "position": null, + "pull_request_review_id": 1768045530, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417617249/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T16:22:29Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417617249", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26406#discussion_r1417670659" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26406" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417670659" + } + }, + "author_association": "MEMBER", + "body": "Actually it needs to stay `true` until the above loop has ended. Otherwise, subsequent encountered windows displaying the same buffer will not have their statuscolumn rebuilt. I.e. this would fail:\r\nhttps://github.com/neovim/neovim/blob/ca7f8786a0eb578895400e23cd21e25cc0f91800/test/functional/ui/statuscolumn_spec.lua#L838-L845\r\n\r\nEDIT: I've moved the rebuild check to `win_redraw_signcols()` an the flag reset to another (seemingly random) place...", + "commit_id": "2000abbdfe39f338c09796293f76ec8336d81b22", + "created_at": "2023-12-06T17:00:45Z", + "diff_hunk": "@@ -619,6 +621,8 @@ int update_screen(void)\n screen_search_hl.rm.regprog = NULL;\n \n FOR_ALL_WINDOWS_IN_TAB(wp, curtab) {\n+ wp->w_buffer->b_signcols.resized = false;", + "html_url": "https://github.com/neovim/neovim/pull/26406#discussion_r1417670659", + "id": 1417670659, + "in_reply_to_id": 1417617249, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Uf_AD", + "original_commit_id": "86aa78357e654bf1f38c57b9fe11c46df58e2e14", + "original_line": 624, + "original_position": 27, + "original_start_line": null, + "path": "src/nvim/drawscreen.c", + "position": null, + "pull_request_review_id": 1768130219, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26406", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417670659/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-07T00:42:03Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417670659", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + } + ], "comment_regular_data": [ { "author_association": "MEMBER", @@ -238,7 +1680,7 @@ "total_count": 0, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841075445/reactions" }, - "updated_at": "2023-12-05T15:56:50Z", + "updated_at": "2023-12-06T04:57:30Z", "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841075445", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", @@ -282,7 +1724,7 @@ "total_count": 0, "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841579900/reactions" }, - "updated_at": "2023-12-05T20:42:23Z", + "updated_at": "2023-12-06T04:57:46Z", "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1841579900", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", @@ -304,13 +1746,145 @@ "type": "User", "url": "https://api.github.com/users/luukvbaal" } + }, + { + "author_association": "MEMBER", + "body": "Both the number of times we have to scan the entire buffer, and the number of lines checked is now significantly reduced.", + "created_at": "2023-12-06T05:07:07Z", + "html_url": "https://github.com/neovim/neovim/pull/26406#issuecomment-1842094652", + "id": 1842094652, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26406", + "node_id": "IC_kwDOAPphoM5tzCI8", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842094652/reactions" + }, + "updated_at": "2023-12-06T13:54:55Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842094652", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "author_association": "MEMBER", + "body": "Hmm, it fails to update the signcolumn width accordingly when removing multiple signs from a single line:\r\n```lua\r\nvim.o.signcolumn = \"auto:3\"\r\nvim.cmd.call(\"setline(1, ['aaaa']->repeat(10))\")\r\n_G.ns = vim.api.nvim_create_namespace('')\r\nvim.api.nvim_buf_set_extmark(0, ns, 0, 0, { invalidate = true, sign_text = 'S1', end_row = 2 })\r\nvim.api.nvim_buf_set_extmark(0, ns, 1, 0, { invalidate = true, sign_text = 'S2'})\r\nvim.api.nvim_buf_set_extmark(0, ns, 1, 0, { invalidate = true, sign_text = 'S3'})\r\nvim.cmd.redraw()\r\nvim.cmd.norm('2Gdd')\r\n```\r\n\r\nIf we want to keep the invalid map I think it needs to also store how many signs were removed from a line.", + "created_at": "2023-12-06T17:26:58Z", + "html_url": "https://github.com/neovim/neovim/pull/26406#issuecomment-1843341432", + "id": 1843341432, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26406", + "node_id": "IC_kwDOAPphoM5t3yh4", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843341432/reactions" + }, + "updated_at": "2023-12-06T20:20:47Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843341432", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } + }, + { + "author_association": "MEMBER", + "body": "> If we want to keep the invalid map I think it needs to also store how many signs were removed from a line.\r\n\r\nI've gone ahead and done this, unfortunately making the diff slightly bigger (also added a test). But like I said without adding the invalid map (just adding `b_signcols.max_count`), this PR actually increases the number of lines checked. Probably because the current `b_signcols.sentinel` is disproportionally effective in `make functionaltest`. Even so, now at least we can be sure it is a pure performance improvement.", + "created_at": "2023-12-06T20:20:35Z", + "html_url": "https://github.com/neovim/neovim/pull/26406#issuecomment-1843628815", + "id": 1843628815, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26406", + "node_id": "IC_kwDOAPphoM5t44sP", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843628815/reactions" + }, + "updated_at": "2023-12-06T20:29:59Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843628815", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", + "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", + "followers_url": "https://api.github.com/users/luukvbaal/followers", + "following_url": "https://api.github.com/users/luukvbaal/following{/other_user}", + "gists_url": "https://api.github.com/users/luukvbaal/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/luukvbaal", + "id": 31730729, + "login": "luukvbaal", + "node_id": "MDQ6VXNlcjMxNzMwNzI5", + "organizations_url": "https://api.github.com/users/luukvbaal/orgs", + "received_events_url": "https://api.github.com/users/luukvbaal/received_events", + "repos_url": "https://api.github.com/users/luukvbaal/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/luukvbaal/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/luukvbaal/subscriptions", + "type": "User", + "url": "https://api.github.com/users/luukvbaal" + } } ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26406/comments", "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26406/commits", "created_at": "2023-12-05T14:55:55Z", "diff_url": "https://github.com/neovim/neovim/pull/26406.diff", - "draft": true, + "draft": false, "head": { "label": "luukvbaal:maxcount", "ref": "maxcount", @@ -399,9 +1973,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/luukvbaal/neovim/pulls{/number}", - "pushed_at": "2023-12-06T00:32:48Z", + "pushed_at": "2023-12-07T01:29:01Z", "releases_url": "https://api.github.com/repos/luukvbaal/neovim/releases{/id}", - "size": 240266, + "size": 238193, "ssh_url": "git@github.com:luukvbaal/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/luukvbaal/neovim/stargazers", @@ -420,7 +1994,7 @@ "watchers_count": 0, "web_commit_signoff_required": false }, - "sha": "86eb3c70c8547394fa92b9d14c85957282079f9c", + "sha": "2000abbdfe39f338c09796293f76ec8336d81b22", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", "events_url": "https://api.github.com/users/luukvbaal/events{/privacy}", @@ -457,7 +2031,7 @@ } ], "locked": false, - "merge_commit_sha": "b55b19375905b1d8245b20543d05fecdd22f1f82", + "merge_commit_sha": "7eb93a726e8c5a2451ef47ea21918df4db39630a", "merged_at": null, "milestone": null, "node_id": "PR_kwDOAPphoM5hMHwU", @@ -468,9 +2042,9 @@ "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26406/comments", "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/86eb3c70c8547394fa92b9d14c85957282079f9c", - "title": "perf(column): keep track of number of signs that hold up the 'signcolumn'", - "updated_at": "2023-12-05T20:42:23Z", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/2000abbdfe39f338c09796293f76ec8336d81b22", + "title": "perf(column): keep track of number of lines that hold up the 'signcolumn'", + "updated_at": "2023-12-07T01:29:02Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26406", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/31730729?v=4", diff --git a/repositories/neovim/pulls/26407.json b/repositories/neovim/pulls/26407.json index 88526b3b..ae452961 100644 --- a/repositories/neovim/pulls/26407.json +++ b/repositories/neovim/pulls/26407.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26407" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/5d69983744b37fe22566ab6d65210c88bdba55c9" + "href": "https://api.github.com/repos/neovim/neovim/statuses/a5a346678a8211ea07f318de42e557ad3909f65e" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "cc38086039853d53157b30fec41babb148399038", + "sha": "ca7f8786a0eb578895400e23cd21e25cc0f91800", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -170,7 +170,7 @@ } }, "body": "Enable `'termguicolors'` automatically when Nvim can detect that truecolor is supported by the host terminal.\r\n\r\nIf `$COLORTERM` is set to \"truecolor\" or \"24bit\", or the terminal's terminfo entry contains capabilities for Tc, RGB, or setrgbf and setrgbb, then we assume that the terminal supports truecolor. Otherwise, the terminal is queried (using both XTGETTCAP and SGR + DECRQSS). If the terminal's response to these queries (if any) indicates that it supports truecolor, then `'termguicolors'` is enabled.\r\n\r\n---\r\n\r\nThis follows the process documented in https://github.com/termstandard/colors#checking-for-colorterm.\r\n\r\nExperimental/test results:\r\n\r\n`'termguicolors'` is correctly set on:\r\n\r\n* iTerm2\r\n* Ghostty\r\n* Wezterm\r\n* Kitty\r\n* Alacritty\r\n* tmux\r\n\r\nAll of the terminal emulators listed above set `$COLORTERM`, so `'termguicolors'` support is assumed from that. If we explicitly unset `$COLORTERM` and force `TERM=xterm-256color` (mimicking an SSH session lacking proper terminfo, for instance), the results are all still correct _except_ for Alacritty, which does not include `Tc`, `RGB`, `setrgbf`, or `setrgbb` in its terminfo and does not support XTGETTCAP or DECRQSS.\r\n\r\n`'termguicolors'` is correctly *not* set on:\r\n\r\n* Terminal.app\r\n\r\nI was not able to directly test foot or Xterm. I'm confident foot will work. Xterm _should_ work since it parses DECRQSS (and I even bent over backwards to ensure we parse Xterm's DECRQSS response, since it differs from everyone else's).", - "closed_at": null, + "closed_at": "2023-12-06T18:55:51Z", "comment_data": [ { "_links": { @@ -186,7 +186,7 @@ }, "author_association": "MEMBER", "body": "Depending on https://github.com/neovim/neovim/pull/26407#issuecomment-1841503049 ... \r\n\r\n```suggestion\r\n\tsupports 24-bit color and will disable this option if it does not (unless\r\n```", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T19:39:08Z", "diff_hunk": "@@ -6495,6 +6495,10 @@ A jump table for the options with a short description can be found at |Q_op|.\n \tattributes instead of \"cterm\" attributes. |guifg|\n \tRequires an ISO-8613-3 compatible terminal.\n \n+\tNvim will automatically attempt to determine if the host terminal\n+\tsupports 24-bit color and will enable this option if it does (unless", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416192608", @@ -254,7 +254,7 @@ }, "author_association": "MEMBER", "body": "Probably a good time to introduce a `_tui.lua` or `_tty.lua` file, since we will be adding more and more TUI stuff here.", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T19:47:25Z", "diff_hunk": "@@ -165,91 +165,92 @@ do\n })\n end\n \n---- Guess value of 'background' based on terminal color.\n----\n---- We write Operating System Command (OSC) 11 to the terminal to request the\n---- terminal's background color. We then wait for a response. If the response\n---- matches `rgba:RRRR/GGGG/BBBB/AAAA` where R, G, B, and A are hex digits, then\n---- compute the luminance[1] of the RGB color and classify it as light/dark\n---- accordingly. Note that the color components may have anywhere from one to\n---- four hex digits, and require scaling accordingly as values out of 4, 8, 12,\n---- or 16 bits. Also note the A(lpha) component is optional, and is parsed but\n---- ignored in the calculations.\n----\n---- [1] https://en.wikipedia.org/wiki/Luma_%28video%29\n-do\n- --- Parse a string of hex characters as a color.\n- ---\n- --- The string can contain 1 to 4 hex characters. The returned value is\n- --- between 0.0 and 1.0 (inclusive) representing the intensity of the color.\n- ---\n- --- For instance, if only a single hex char \"a\" is used, then this function\n- --- returns 0.625 (10 / 16), while a value of \"aa\" would return 0.664 (170 /\n- --- 256).\n- ---\n- --- @param c string Color as a string of hex chars\n- --- @return number? Intensity of the color\n- local function parsecolor(c)\n- if #c == 0 or #c > 4 then\n- return nil\n- end\n-\n- local val = tonumber(c, 16)\n- if not val then\n- return nil\n- end\n-\n- local max = tonumber(string.rep('f', #c), 16)\n- return val / max\n+-- Only do the following when the TUI is attached\n+local tty = nil\n+for _, ui in ipairs(vim.api.nvim_list_uis()) do\n+ if ui.chan == 1 and ui.stdout_tty then\n+ tty = ui\n+ break\n end\n+end\n \n- --- Parse an OSC 11 response\n- ---\n- --- Either of the two formats below are accepted:\n- ---\n- --- OSC 11 ; rgb://\n- ---\n- --- or\n- ---\n- --- OSC 11 ; rgba:///\n- ---\n- --- where\n+if tty then", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416200420", @@ -322,7 +322,7 @@ }, "author_association": "MEMBER", "body": "Looks like \"2.\" is missing :) Should we mention `_tui.lua` / `_tty.lua` here?", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T19:52:09Z", "diff_hunk": "@@ -1752,6 +1757,44 @@ static int unibi_find_ext_bool(unibi_term *ut, const char *name)\n return -1;\n }\n \n+/// Determine if the terminal supports truecolor or not:\n+///\n+/// 1. If $COLORTERM is \"24bit\" or \"truecolor\", return true\n+/// 3. Else, check terminfo for Tc, RGB, setrgbf, or setrgbb capabilities. If\n+/// found, return true\n+/// 4. Else, return false", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416204915", @@ -390,7 +390,7 @@ }, "author_association": "MEMBER", "body": "Updated to change the hardcoded default to enable.", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T22:28:16Z", "diff_hunk": "@@ -6495,6 +6495,10 @@ A jump table for the options with a short description can be found at |Q_op|.\n \tattributes instead of \"cterm\" attributes. |guifg|\n \tRequires an ISO-8613-3 compatible terminal.\n \n+\tNvim will automatically attempt to determine if the host terminal\n+\tsupports 24-bit color and will enable this option if it does (unless", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416350405", @@ -459,7 +459,7 @@ }, "author_association": "MEMBER", "body": "Fixed, thanks", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T22:28:25Z", "diff_hunk": "@@ -1752,6 +1757,44 @@ static int unibi_find_ext_bool(unibi_term *ut, const char *name)\n return -1;\n }\n \n+/// Determine if the terminal supports truecolor or not:\n+///\n+/// 1. If $COLORTERM is \"24bit\" or \"truecolor\", return true\n+/// 3. Else, check terminfo for Tc, RGB, setrgbf, or setrgbb capabilities. If\n+/// found, return true\n+/// 4. Else, return false", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416350506", @@ -528,7 +528,7 @@ }, "author_association": "MEMBER", "body": "also vim_diff.txt", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T22:38:44Z", "diff_hunk": "@@ -98,6 +98,9 @@ The following changes may require adaptations in user config or plugins.\n • Default color scheme has been updated to be \"Neovim branded\" and accessible.\n Use `:colorscheme vim` to revert to the old legacy color scheme.\n \n+• 'termguicolors' is enabled by default when Nvim is able to determine that\n+ the host terminal emulator supports 24-bit color.", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416360444", @@ -596,7 +596,7 @@ }, "author_association": "MEMBER", "body": "Looks like `settgc` is only ever called with `true`. Also, it looks possible that `settgc` is called twice, but the 2nd call will be ignored, is that intentional?", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T22:42:10Z", "diff_hunk": "@@ -311,4 +312,108 @@ do\n end\n end)\n end\n+\n+ --- If the TUI was unable to determine that the host terminal supports truecolor, disable\n+ --- 'termguicolors' and query the terminal. If the terminal's response indicates that it does\n+ --- support truecolor, re-enable 'termguicolors'.\n+ do\n+\n+ --- Set 'termguicolors', but only if it was not already set by the user.\n+ ---\n+ --- @param enable boolean If true, enable 'termguicolors', else disable\n+ local function settgc(enable)\n+ if not vim.api.nvim_get_option_info2('termguicolors', {}).was_set then\n+ vim.o.termguicolors = enable", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416362917", @@ -664,7 +664,7 @@ }, "author_association": "MEMBER", "body": "`settgc` can be called in indeterminate order, depending on when responses from the terminal arrive. We only want to set it if not already set by the user, which is why it's guarded.\r\n\r\nBut this is broken right now anyway, see my [earlier comment](https://github.com/neovim/neovim/pull/26407#issuecomment-1841743997). I need to think about this some more.", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T22:48:54Z", "diff_hunk": "@@ -311,4 +312,108 @@ do\n end\n end)\n end\n+\n+ --- If the TUI was unable to determine that the host terminal supports truecolor, disable\n+ --- 'termguicolors' and query the terminal. If the terminal's response indicates that it does\n+ --- support truecolor, re-enable 'termguicolors'.\n+ do\n+\n+ --- Set 'termguicolors', but only if it was not already set by the user.\n+ ---\n+ --- @param enable boolean If true, enable 'termguicolors', else disable\n+ local function settgc(enable)\n+ if not vim.api.nvim_get_option_info2('termguicolors', {}).was_set then\n+ vim.o.termguicolors = enable", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416370522", @@ -733,7 +733,7 @@ }, "author_association": "MEMBER", "body": "```suggestion\r\nstatic bool term_has_truecolor(TUIData *tui, const char *colorterm)\r\n```", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T22:50:50Z", "diff_hunk": "@@ -1752,6 +1757,44 @@ static int unibi_find_ext_bool(unibi_term *ut, const char *name)\n return -1;\n }\n \n+/// Determine if the terminal supports truecolor or not:\n+///\n+/// 1. If $COLORTERM is \"24bit\" or \"truecolor\", return true\n+/// 2. Else, check terminfo for Tc, RGB, setrgbf, or setrgbb capabilities. If\n+/// found, return true\n+/// 3. Else, return false\n+static bool term_supports_truecolor(TUIData *tui, const char *colorterm)", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416371792", @@ -801,7 +801,7 @@ }, "author_association": "MEMBER", "body": "Helpful to connect the moving parts :)\r\n\r\n```suggestion\r\n --- If the TUI (term_has_truecolor) was unable to determine that the host terminal supports truecolor, disable\r\n```", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T22:51:34Z", "diff_hunk": "@@ -311,4 +312,108 @@ do\n end\n end)\n end\n+\n+ --- If the TUI was unable to determine that the host terminal supports truecolor, disable", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416372229", @@ -869,19 +869,19 @@ }, "author_association": "MEMBER", "body": "missing LANG=C ? also for others below.\r\n\r\ncontext for LANG=C : https://github.com/neovim/neovim/issues/5455#issuecomment-252501073\r\nlater, related: https://github.com/neovim/neovim/commit/5c08c8c00969b8945f1351f49b0afb7e3e8842fe\r\n\r\n", - "commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", "created_at": "2023-12-05T23:00:22Z", "diff_hunk": "@@ -2208,14 +2234,17 @@ describe(\"TUI 't_Co' (terminal colors)\", function()\n \n local function assert_term_colors(term, colorterm, maxcolors)\n clear({env={TERM=term}, args={}})\n- -- This is ugly because :term/termopen() forces TERM=xterm-256color.\n- -- TODO: Revisit this after jobstart/termopen accept `env` dict.\n- screen = thelpers.screen_setup(0, string.format(\n- [=[['sh', '-c', 'LANG=C TERM=%s %s %s -u NONE -i NONE --cmd \"colorscheme vim\" --cmd \"%s\"']]=],\n- term or \"\",\n- (colorterm ~= nil and \"COLORTERM=\"..colorterm or \"\"),\n- nvim_prog,\n- nvim_set))\n+ screen = setup_child_nvim({\n+ '-u', 'NONE',\n+ '-i', 'NONE',\n+ '--cmd', 'colorscheme vim',\n+ '--cmd', nvim_set,\n+ }, {\n+ env = {\n+ TERM = term or '',", "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416378396", "id": 1416378396, - "line": 2245, + "line": 2224, "node_id": "PRRC_kwDOAPphoM5UbDgc", "original_commit_id": "d2eb05ef9a1bb4d1c47b0f99bc7bdda104a0ff7c", - "original_line": 2245, + "original_line": 2224, "original_position": 179, "original_start_line": null, "path": "test/functional/terminal/tui_spec.lua", - "position": 180, + "position": 177, "pull_request_review_id": 1766263164, "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26407", "reactions": { @@ -922,6 +922,143 @@ "type": "User", "url": "https://api.github.com/users/justinmk" } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26407#discussion_r1416555811" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26407" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416555811" + } + }, + "author_association": "MEMBER", + "body": "this one is still missing LANG", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", + "created_at": "2023-12-06T02:03:30Z", + "diff_hunk": "@@ -2540,14 +2572,13 @@ describe(\"TUI\", function()\n -- Runs (child) `nvim` in a TTY (:terminal), to start the builtin TUI.\n local function nvim_tui(extra_args)\n clear()\n- -- This is ugly because :term/termopen() forces TERM=xterm-256color.\n- -- TODO: Revisit this after jobstart/termopen accept `env` dict.\n- local cmd = string.format(\n- [=[['sh', '-c', 'LANG=C %s -u NONE -i NONE %s --cmd \"colorscheme vim\" --cmd \"%s\"']]=],\n- nvim_prog,\n- extra_args or \"\",\n- nvim_set)\n- screen = thelpers.screen_setup(0, cmd)\n+ screen = setup_child_nvim({", + "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416555811", + "id": 1416555811, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ubu0j", + "original_commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "original_line": 2575, + "original_position": 224, + "original_start_line": null, + "path": "test/functional/terminal/tui_spec.lua", + "position": null, + "pull_request_review_id": 1766481972, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26407", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416555811/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T02:03:30Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416555811", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26407#discussion_r1416567367" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26407" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416567367" + } + }, + "author_association": "MEMBER", + "body": "Thanks, fixed.", + "commit_id": "a5a346678a8211ea07f318de42e557ad3909f65e", + "created_at": "2023-12-06T02:13:33Z", + "diff_hunk": "@@ -2540,14 +2572,13 @@ describe(\"TUI\", function()\n -- Runs (child) `nvim` in a TTY (:terminal), to start the builtin TUI.\n local function nvim_tui(extra_args)\n clear()\n- -- This is ugly because :term/termopen() forces TERM=xterm-256color.\n- -- TODO: Revisit this after jobstart/termopen accept `env` dict.\n- local cmd = string.format(\n- [=[['sh', '-c', 'LANG=C %s -u NONE -i NONE %s --cmd \"colorscheme vim\" --cmd \"%s\"']]=],\n- nvim_prog,\n- extra_args or \"\",\n- nvim_set)\n- screen = thelpers.screen_setup(0, cmd)\n+ screen = setup_child_nvim({", + "html_url": "https://github.com/neovim/neovim/pull/26407#discussion_r1416567367", + "id": 1416567367, + "in_reply_to_id": 1416555811, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UbxpH", + "original_commit_id": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "original_line": 2575, + "original_position": 224, + "original_start_line": null, + "path": "test/functional/terminal/tui_spec.lua", + "position": null, + "pull_request_review_id": 1766505088, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26407", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416567367/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T02:13:33Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416567367", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } } ], "comment_regular_data": [ @@ -1276,6 +1413,182 @@ "type": "User", "url": "https://api.github.com/users/gpanders" } + }, + { + "author_association": "MEMBER", + "body": "Last failing test:\r\n\r\n```\r\nFAILED 1 test, listed below:\r\nFAILED test/functional/terminal/tui_spec.lua @ 1851: TUI argv[0] can be overridden #23953\r\ntest/functional/terminal/tui_spec.lua:1865: Row 1 did not match.\r\nExpected:\r\n |*{1: } |\r\n |*{4:~ }|\r\n |*{4:~ }|\r\n |*{4:~ }|\r\n |*{5:[No Name] 0,0-1 All}|\r\n | |\r\n |{3:-- TERMINAL --} |\r\nActual:\r\n |* |\r\n |*[Process exited 0]{1: } |\r\n |* |\r\n |* |\r\n |* |\r\n | |\r\n |{3:-- TERMINAL --} |\r\n```\r\n\r\nBut this fails for me on master as well.\r\n\r\n**EDIT:** To clarify, this fails for me on master on macOS. I can't reproduce the failure on Linux on this branch, with any build options.", + "created_at": "2023-12-06T17:09:12Z", + "html_url": "https://github.com/neovim/neovim/pull/26407#issuecomment-1843311332", + "id": 1843311332, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26407", + "node_id": "IC_kwDOAPphoM5t3rLk", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843311332/reactions" + }, + "updated_at": "2023-12-06T17:49:20Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843311332", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } + }, + { + "author_association": "MEMBER", + "body": "Great work on the turnaround time for this!", + "created_at": "2023-12-06T19:03:55Z", + "html_url": "https://github.com/neovim/neovim/pull/26407#issuecomment-1843524268", + "id": 1843524268, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26407", + "node_id": "IC_kwDOAPphoM5t4fKs", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 2, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 2, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843524268/reactions" + }, + "updated_at": "2023-12-06T19:03:55Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843524268", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/7904185?v=4", + "events_url": "https://api.github.com/users/lewis6991/events{/privacy}", + "followers_url": "https://api.github.com/users/lewis6991/followers", + "following_url": "https://api.github.com/users/lewis6991/following{/other_user}", + "gists_url": "https://api.github.com/users/lewis6991/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/lewis6991", + "id": 7904185, + "login": "lewis6991", + "node_id": "MDQ6VXNlcjc5MDQxODU=", + "organizations_url": "https://api.github.com/users/lewis6991/orgs", + "received_events_url": "https://api.github.com/users/lewis6991/received_events", + "repos_url": "https://api.github.com/users/lewis6991/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/lewis6991/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/lewis6991/subscriptions", + "type": "User", + "url": "https://api.github.com/users/lewis6991" + } + }, + { + "author_association": "MEMBER", + "body": "This test is failing about 40% of the time now:\r\n\r\n```\r\nFAILED test/functional/terminal/tui_spec.lua @ 1449: TUI paste: streamed paste with isolated \"stop paste\" code\r\ntest/functional/terminal/tui_spec.lua:1493: Expected objects to be the same.\r\nPassed in:\r\n(table: 0x56350fb6d640) {\r\n [1] = 1\r\n [2] = 2\r\n *[3] = 2\r\n [4] = 3 }\r\nExpected:\r\n(table: 0x56350fb587a0) {\r\n [1] = 1\r\n [2] = 2\r\n *[3] = 3 }\r\n\r\nstack traceback:\r\n\t(tail call): ?\r\n\ttest/functional/terminal/tui_spec.lua:1493: in function \r\n```", + "created_at": "2023-12-06T21:02:52Z", + "html_url": "https://github.com/neovim/neovim/pull/26407#issuecomment-1843686439", + "id": 1843686439, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26407", + "node_id": "IC_kwDOAPphoM5t5Gwn", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843686439/reactions" + }, + "updated_at": "2023-12-06T21:02:52Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843686439", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "author_association": "MEMBER", + "body": "@justinmk should be fixed by https://github.com/neovim/neovim/pull/26437", + "created_at": "2023-12-07T01:44:21Z", + "html_url": "https://github.com/neovim/neovim/pull/26407#issuecomment-1844012282", + "id": 1844012282, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26407", + "node_id": "IC_kwDOAPphoM5t6WT6", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1844012282/reactions" + }, + "updated_at": "2023-12-07T01:44:21Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1844012282", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } } ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26407/comments", @@ -1371,9 +1684,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/gpanders/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:54:59Z", + "pushed_at": "2023-12-07T00:14:23Z", "releases_url": "https://api.github.com/repos/gpanders/neovim/releases{/id}", - "size": 238168, + "size": 237052, "ssh_url": "git@github.com:gpanders/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/gpanders/neovim/stargazers", @@ -1392,7 +1705,7 @@ "watchers_count": 0, "web_commit_signoff_required": false }, - "sha": "5d69983744b37fe22566ab6d65210c88bdba55c9", + "sha": "a5a346678a8211ea07f318de42e557ad3909f65e", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", "events_url": "https://api.github.com/users/gpanders/events{/privacy}", @@ -1438,8 +1751,8 @@ } ], "locked": false, - "merge_commit_sha": "aa101b4262f3c848ff48eb6b2602dbd17edaabaa", - "merged_at": null, + "merge_commit_sha": "08545bd45b80e3056fc8c6c4eb25e2ef1fddd897", + "merged_at": "2023-12-06T18:55:51Z", "milestone": null, "node_id": "PR_kwDOAPphoM5hNpw9", "number": 26407, @@ -1448,10 +1761,10 @@ "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26407/comments", - "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/5d69983744b37fe22566ab6d65210c88bdba55c9", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/a5a346678a8211ea07f318de42e557ad3909f65e", "title": "feat(defaults): enable 'termguicolors' by default when supported by terminal", - "updated_at": "2023-12-06T01:56:06Z", + "updated_at": "2023-12-07T01:44:22Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26407", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", diff --git a/repositories/neovim/pulls/26410.json b/repositories/neovim/pulls/26410.json index a724cf43..b8afd96c 100644 --- a/repositories/neovim/pulls/26410.json +++ b/repositories/neovim/pulls/26410.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/41250fbcd218597a8f54a8fd6d38148e901b758f" + "href": "https://api.github.com/repos/neovim/neovim/statuses/24d243d7981c719d095aa10030db922831d8e364" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,14 +140,14 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, - "sha": "27501d3b6a8d577cf3f5ecc3fe9e219f477586b7", + "sha": "040369e1e4b86c4655a6885b36ee89ad4f10ca16", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -169,10 +169,648 @@ "url": "https://api.github.com/users/neovim" } }, - "body": "runtime(vim): Update syntax file and syntax test (vim/vim#13632)\n\nAdd missing assignment operators (:let*=, :let/= and :let%=).\n\nhttps://github.com/vim/vim/commit/4e043b1fc7eeba2f726bbca3d50a4e872c8cb658\n\nCo-authored-by: dkearns \n", - "closed_at": null, - "comment_data": [], - "comment_regular_data": [], + "body": "runtime(vim): Update syntax file and syntax test (vim/vim#13632)\r\n\r\nAdd missing assignment operators (:let*=, :let/= and :let%=).\r\n\r\nhttps://github.com/vim/vim/commit/4e043b1fc7eeba2f726bbca3d50a4e872c8cb658\r\n\r\nCo-authored-by: dkearns \r\n\r\n---\r\nruntime(fortran): update syntax and ftplugins\r\ncloses: https://github.com/vim/vim/pull/13629\r\n\r\nSigned-off-by: Ajit-Thakkar <142174202+Ajit-Thakkar@users.noreply.github.com>\r\nSigned-off-by: Christian Brabandt \r\n", + "closed_at": "2023-12-06T13:59:38Z", + "comment_data": [ + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417153937" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417153937" + } + }, + "author_association": "MEMBER", + "body": "```suggestion\r\nfortran_do_enddo variable in your vimrc as follows >vim\r\n```\r\n\r\nNot super important, but I noticed a few prior mentions of `.vimrc` that were changed to `vimrc` at some point. Also, maybe these should be changed to `>vim` too?\r\n\r\nThere's a few such changes to syntax.txt that are also relevant.", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T11:43:12Z", + "diff_hunk": "@@ -711,26 +711,25 @@ FORTRAN\t\t\t\t\t\t\t*ft-fortran-indent*\n Block if, select case, where, and forall constructs are indented. So are\n type, interface, associate, block, and enum constructs. The indenting of\n subroutines, functions, modules, and program blocks is optional. Comments,\n-labelled statements and continuation lines are indented if the Fortran is in\n+labeled statements, and continuation lines are indented if the Fortran is in\n free source form, whereas they are not indented if the Fortran is in fixed\n source form because of the left margin requirements. Hence manual indent\n-corrections will be necessary for labelled statements and continuation lines\n+corrections will be necessary for labeled statements and continuation lines\n when fixed source form is being used. For further discussion of the method\n used for the detection of source format see |ft-fortran-syntax|.\n \n Do loops ~\n All do loops are left unindented by default. Do loops can be unstructured in\n-Fortran with (possibly multiple) loops ending on a labelled executable\n+Fortran with (possibly multiple) loops ending on a labeled executable\n statement of almost arbitrary type. Correct indentation requires\n-compiler-quality parsing. Old code with do loops ending on labelled statements\n-of arbitrary type can be indented with elaborate programs such as Tidy\n-(https://www.unb.ca/chem/ajit/f_tidy.htm). Structured do/continue loops are\n-also left unindented because continue statements are also used for purposes\n-other than ending a do loop. Programs such as Tidy can convert structured\n-do/continue loops to the do/enddo form. Do loops of the do/enddo variety can\n-be indented. If you use only structured loops of the do/enddo form, you should\n-declare this by setting the fortran_do_enddo variable in your vimrc as\n-follows >\n+compiler-quality parsing. Old code with do loops ending on labeled statements\n+of arbitrary type can be indented with elaborate programs such as Tidy.\n+Structured do/continue loops are also left unindented because continue\n+statements are used for purposes other than ending a do loop. Programs such\n+as Tidy can convert structured do/continue loops to the do/enddo form. Do\n+loops of the do/enddo variety can be indented. If you use only structured\n+loops of the do/enddo form, you should declare this by setting the\n+fortran_do_enddo variable in your .vimrc as follows >", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417153937", + "id": 1417153937, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeA2R", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 732, + "original_position": 34, + "original_start_line": null, + "path": "runtime/doc/indent.txt", + "position": null, + "pull_request_review_id": 1767346546, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417153937/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T12:30:05Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417153937", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6256228?v=4", + "events_url": "https://api.github.com/users/seandewar/events{/privacy}", + "followers_url": "https://api.github.com/users/seandewar/followers", + "following_url": "https://api.github.com/users/seandewar/following{/other_user}", + "gists_url": "https://api.github.com/users/seandewar/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/seandewar", + "id": 6256228, + "login": "seandewar", + "node_id": "MDQ6VXNlcjYyNTYyMjg=", + "organizations_url": "https://api.github.com/users/seandewar/orgs", + "received_events_url": "https://api.github.com/users/seandewar/received_events", + "repos_url": "https://api.github.com/users/seandewar/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/seandewar/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/seandewar/subscriptions", + "type": "User", + "url": "https://api.github.com/users/seandewar" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417186911" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417186911" + } + }, + "author_association": "MEMBER", + "body": "```suggestion\r\n :let fortran_extended_line_length=1\r\n```\r\n\r\nI think it should've been this. I'll leave a comment upstream.", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T12:14:38Z", + "diff_hunk": "@@ -1582,14 +1590,36 @@ neither of these variables have been set, the syntax script attempts to\n determine which source form has been used by examining the file extension\n using conventions common to the ifort, gfortran, Cray, NAG, and PathScale\n compilers (.f, .for, .f77 for fixed-source, .f90, .f95, .f03, .f08 for\n-free-source). If none of this works, then the script examines the first five\n-columns of the first 500 lines of your file. If no signs of free source form\n-are detected, then the file is assumed to be in fixed source form. The\n-algorithm should work in the vast majority of cases. In some cases, such as a\n-file that begins with 500 or more full-line comments, the script may\n-incorrectly decide that the fortran code is in fixed form. If that happens,\n-just add a non-comment statement beginning anywhere in the first five columns\n-of the first twenty-five lines, save (:w) and then reload (:e!) the file.\n+free-source). No default is used for the .fpp and .ftn file extensions because\n+different compilers treat them differently. If none of this works, then the\n+script examines the first five columns of the first 500 lines of your file. If\n+no signs of free source form are detected, then the file is assumed to be in\n+fixed source form. The algorithm should work in the vast majority of cases.\n+In some cases, such as a file that begins with 500 or more full-line comments,\n+the script may incorrectly decide that the code is in fixed form. If that\n+happens, just add a non-comment statement beginning anywhere in the first five\n+columns of the first twenty-five lines, save (:w), and then reload (:e!) the\n+file.\n+\n+Vendor extensions ~\n+Fixed-form Fortran requires a maximum line length of 72 characters but the\n+script allows a maximum line length of 80 characters as do all compilers\n+created in the last three decades. An even longer line length of 132\n+characters is allowed if you set the variable fortran_extended_line_length\n+with a command such as >\n+ :let fortran_line_length=1", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417186911", + "id": 1417186911, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeI5f", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 1610, + "original_position": 46, + "original_start_line": null, + "path": "runtime/doc/syntax.txt", + "position": null, + "pull_request_review_id": 1767346546, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417186911/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T12:30:05Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417186911", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6256228?v=4", + "events_url": "https://api.github.com/users/seandewar/events{/privacy}", + "followers_url": "https://api.github.com/users/seandewar/followers", + "following_url": "https://api.github.com/users/seandewar/following{/other_user}", + "gists_url": "https://api.github.com/users/seandewar/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/seandewar", + "id": 6256228, + "login": "seandewar", + "node_id": "MDQ6VXNlcjYyNTYyMjg=", + "organizations_url": "https://api.github.com/users/seandewar/orgs", + "received_events_url": "https://api.github.com/users/seandewar/received_events", + "repos_url": "https://api.github.com/users/seandewar/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/seandewar/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/seandewar/subscriptions", + "type": "User", + "url": "https://api.github.com/users/seandewar" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417191726" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417191726" + } + }, + "author_association": "MEMBER", + "body": "Might be best to omit these lines here and below as to not confuse them as a recommendation for `:syntax on` in Nvim configs.\r\n\r\nI guess it's more important anyway that these variables are defined before the Fortran syntax file is sourced, not necessarily prior to `:syntax on` itself.", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T12:19:26Z", + "diff_hunk": "@@ -1582,14 +1590,36 @@ neither of these variables have been set, the syntax script attempts to\n determine which source form has been used by examining the file extension\n using conventions common to the ifort, gfortran, Cray, NAG, and PathScale\n compilers (.f, .for, .f77 for fixed-source, .f90, .f95, .f03, .f08 for\n-free-source). If none of this works, then the script examines the first five\n-columns of the first 500 lines of your file. If no signs of free source form\n-are detected, then the file is assumed to be in fixed source form. The\n-algorithm should work in the vast majority of cases. In some cases, such as a\n-file that begins with 500 or more full-line comments, the script may\n-incorrectly decide that the fortran code is in fixed form. If that happens,\n-just add a non-comment statement beginning anywhere in the first five columns\n-of the first twenty-five lines, save (:w) and then reload (:e!) the file.\n+free-source). No default is used for the .fpp and .ftn file extensions because\n+different compilers treat them differently. If none of this works, then the\n+script examines the first five columns of the first 500 lines of your file. If\n+no signs of free source form are detected, then the file is assumed to be in\n+fixed source form. The algorithm should work in the vast majority of cases.\n+In some cases, such as a file that begins with 500 or more full-line comments,\n+the script may incorrectly decide that the code is in fixed form. If that\n+happens, just add a non-comment statement beginning anywhere in the first five\n+columns of the first twenty-five lines, save (:w), and then reload (:e!) the\n+file.\n+\n+Vendor extensions ~\n+Fixed-form Fortran requires a maximum line length of 72 characters but the\n+script allows a maximum line length of 80 characters as do all compilers\n+created in the last three decades. An even longer line length of 132\n+characters is allowed if you set the variable fortran_extended_line_length\n+with a command such as >\n+ :let fortran_line_length=1\n+placed prior to the :syntax on command.", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417191726", + "id": 1417191726, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeKEu", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 1611, + "original_position": 47, + "original_start_line": null, + "path": "runtime/doc/syntax.txt", + "position": null, + "pull_request_review_id": 1767346546, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417191726/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T12:30:05Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417191726", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6256228?v=4", + "events_url": "https://api.github.com/users/seandewar/events{/privacy}", + "followers_url": "https://api.github.com/users/seandewar/followers", + "following_url": "https://api.github.com/users/seandewar/following{/other_user}", + "gists_url": "https://api.github.com/users/seandewar/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/seandewar", + "id": 6256228, + "login": "seandewar", + "node_id": "MDQ6VXNlcjYyNTYyMjg=", + "organizations_url": "https://api.github.com/users/seandewar/orgs", + "received_events_url": "https://api.github.com/users/seandewar/received_events", + "repos_url": "https://api.github.com/users/seandewar/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/seandewar/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/seandewar/subscriptions", + "type": "User", + "url": "https://api.github.com/users/seandewar" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417192290" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417192290" + } + }, + "author_association": "MEMBER", + "body": "Good spot. Looks like upstream missed this one.", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T12:20:03Z", + "diff_hunk": "@@ -711,26 +711,25 @@ FORTRAN\t\t\t\t\t\t\t*ft-fortran-indent*\n Block if, select case, where, and forall constructs are indented. So are\n type, interface, associate, block, and enum constructs. The indenting of\n subroutines, functions, modules, and program blocks is optional. Comments,\n-labelled statements and continuation lines are indented if the Fortran is in\n+labeled statements, and continuation lines are indented if the Fortran is in\n free source form, whereas they are not indented if the Fortran is in fixed\n source form because of the left margin requirements. Hence manual indent\n-corrections will be necessary for labelled statements and continuation lines\n+corrections will be necessary for labeled statements and continuation lines", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417192290", + "id": 1417192290, + "line": 717, + "node_id": "PRRC_kwDOAPphoM5UeKNi", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 717, + "original_position": 9, + "original_start_line": null, + "path": "runtime/doc/indent.txt", + "position": 9, + "pull_request_review_id": 1767346546, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417192290/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T12:30:05Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417192290", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6256228?v=4", + "events_url": "https://api.github.com/users/seandewar/events{/privacy}", + "followers_url": "https://api.github.com/users/seandewar/followers", + "following_url": "https://api.github.com/users/seandewar/following{/other_user}", + "gists_url": "https://api.github.com/users/seandewar/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/seandewar", + "id": 6256228, + "login": "seandewar", + "node_id": "MDQ6VXNlcjYyNTYyMjg=", + "organizations_url": "https://api.github.com/users/seandewar/orgs", + "received_events_url": "https://api.github.com/users/seandewar/received_events", + "repos_url": "https://api.github.com/users/seandewar/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/seandewar/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/seandewar/subscriptions", + "type": "User", + "url": "https://api.github.com/users/seandewar" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417239038" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417239038" + } + }, + "author_association": "MEMBER", + "body": "So far, we have not added our code example annotations to \"inherited\" documentation. We could do so now (after making treesitter the default for help), but I think this would be better done as a single dedicated PR.", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T12:49:27Z", + "diff_hunk": "@@ -711,26 +711,25 @@ FORTRAN\t\t\t\t\t\t\t*ft-fortran-indent*\n Block if, select case, where, and forall constructs are indented. So are\n type, interface, associate, block, and enum constructs. The indenting of\n subroutines, functions, modules, and program blocks is optional. Comments,\n-labelled statements and continuation lines are indented if the Fortran is in\n+labeled statements, and continuation lines are indented if the Fortran is in\n free source form, whereas they are not indented if the Fortran is in fixed\n source form because of the left margin requirements. Hence manual indent\n-corrections will be necessary for labelled statements and continuation lines\n+corrections will be necessary for labeled statements and continuation lines\n when fixed source form is being used. For further discussion of the method\n used for the detection of source format see |ft-fortran-syntax|.\n \n Do loops ~\n All do loops are left unindented by default. Do loops can be unstructured in\n-Fortran with (possibly multiple) loops ending on a labelled executable\n+Fortran with (possibly multiple) loops ending on a labeled executable\n statement of almost arbitrary type. Correct indentation requires\n-compiler-quality parsing. Old code with do loops ending on labelled statements\n-of arbitrary type can be indented with elaborate programs such as Tidy\n-(https://www.unb.ca/chem/ajit/f_tidy.htm). Structured do/continue loops are\n-also left unindented because continue statements are also used for purposes\n-other than ending a do loop. Programs such as Tidy can convert structured\n-do/continue loops to the do/enddo form. Do loops of the do/enddo variety can\n-be indented. If you use only structured loops of the do/enddo form, you should\n-declare this by setting the fortran_do_enddo variable in your vimrc as\n-follows >\n+compiler-quality parsing. Old code with do loops ending on labeled statements\n+of arbitrary type can be indented with elaborate programs such as Tidy.\n+Structured do/continue loops are also left unindented because continue\n+statements are used for purposes other than ending a do loop. Programs such\n+as Tidy can convert structured do/continue loops to the do/enddo form. Do\n+loops of the do/enddo variety can be indented. If you use only structured\n+loops of the do/enddo form, you should declare this by setting the\n+fortran_do_enddo variable in your .vimrc as follows >", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417239038", + "id": 1417239038, + "in_reply_to_id": 1417153937, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeVn-", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 732, + "original_position": 34, + "original_start_line": null, + "path": "runtime/doc/indent.txt", + "position": null, + "pull_request_review_id": 1767467193, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417239038/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T12:49:27Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417239038", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417257207" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417257207" + } + }, + "author_association": "MEMBER", + "body": "(At a rough estimate, there are about 3100 unannotated codeblocks in our documentation, some of which are intentional. Many code snippets in the legacy docs are not valid expressions.)", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T12:56:38Z", + "diff_hunk": "@@ -711,26 +711,25 @@ FORTRAN\t\t\t\t\t\t\t*ft-fortran-indent*\n Block if, select case, where, and forall constructs are indented. So are\n type, interface, associate, block, and enum constructs. The indenting of\n subroutines, functions, modules, and program blocks is optional. Comments,\n-labelled statements and continuation lines are indented if the Fortran is in\n+labeled statements, and continuation lines are indented if the Fortran is in\n free source form, whereas they are not indented if the Fortran is in fixed\n source form because of the left margin requirements. Hence manual indent\n-corrections will be necessary for labelled statements and continuation lines\n+corrections will be necessary for labeled statements and continuation lines\n when fixed source form is being used. For further discussion of the method\n used for the detection of source format see |ft-fortran-syntax|.\n \n Do loops ~\n All do loops are left unindented by default. Do loops can be unstructured in\n-Fortran with (possibly multiple) loops ending on a labelled executable\n+Fortran with (possibly multiple) loops ending on a labeled executable\n statement of almost arbitrary type. Correct indentation requires\n-compiler-quality parsing. Old code with do loops ending on labelled statements\n-of arbitrary type can be indented with elaborate programs such as Tidy\n-(https://www.unb.ca/chem/ajit/f_tidy.htm). Structured do/continue loops are\n-also left unindented because continue statements are also used for purposes\n-other than ending a do loop. Programs such as Tidy can convert structured\n-do/continue loops to the do/enddo form. Do loops of the do/enddo variety can\n-be indented. If you use only structured loops of the do/enddo form, you should\n-declare this by setting the fortran_do_enddo variable in your vimrc as\n-follows >\n+compiler-quality parsing. Old code with do loops ending on labeled statements\n+of arbitrary type can be indented with elaborate programs such as Tidy.\n+Structured do/continue loops are also left unindented because continue\n+statements are used for purposes other than ending a do loop. Programs such\n+as Tidy can convert structured do/continue loops to the do/enddo form. Do\n+loops of the do/enddo variety can be indented. If you use only structured\n+loops of the do/enddo form, you should declare this by setting the\n+fortran_do_enddo variable in your .vimrc as follows >", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417257207", + "id": 1417257207, + "in_reply_to_id": 1417153937, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeaD3", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 732, + "original_position": 34, + "original_start_line": null, + "path": "runtime/doc/indent.txt", + "position": null, + "pull_request_review_id": 1767487941, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417257207/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T13:06:49Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417257207", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417274449" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417274449" + } + }, + "author_association": "MEMBER", + "body": "Also, 64 occurrences of `.vimrc`.", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T13:10:33Z", + "diff_hunk": "@@ -711,26 +711,25 @@ FORTRAN\t\t\t\t\t\t\t*ft-fortran-indent*\n Block if, select case, where, and forall constructs are indented. So are\n type, interface, associate, block, and enum constructs. The indenting of\n subroutines, functions, modules, and program blocks is optional. Comments,\n-labelled statements and continuation lines are indented if the Fortran is in\n+labeled statements, and continuation lines are indented if the Fortran is in\n free source form, whereas they are not indented if the Fortran is in fixed\n source form because of the left margin requirements. Hence manual indent\n-corrections will be necessary for labelled statements and continuation lines\n+corrections will be necessary for labeled statements and continuation lines\n when fixed source form is being used. For further discussion of the method\n used for the detection of source format see |ft-fortran-syntax|.\n \n Do loops ~\n All do loops are left unindented by default. Do loops can be unstructured in\n-Fortran with (possibly multiple) loops ending on a labelled executable\n+Fortran with (possibly multiple) loops ending on a labeled executable\n statement of almost arbitrary type. Correct indentation requires\n-compiler-quality parsing. Old code with do loops ending on labelled statements\n-of arbitrary type can be indented with elaborate programs such as Tidy\n-(https://www.unb.ca/chem/ajit/f_tidy.htm). Structured do/continue loops are\n-also left unindented because continue statements are also used for purposes\n-other than ending a do loop. Programs such as Tidy can convert structured\n-do/continue loops to the do/enddo form. Do loops of the do/enddo variety can\n-be indented. If you use only structured loops of the do/enddo form, you should\n-declare this by setting the fortran_do_enddo variable in your vimrc as\n-follows >\n+compiler-quality parsing. Old code with do loops ending on labeled statements\n+of arbitrary type can be indented with elaborate programs such as Tidy.\n+Structured do/continue loops are also left unindented because continue\n+statements are used for purposes other than ending a do loop. Programs such\n+as Tidy can convert structured do/continue loops to the do/enddo form. Do\n+loops of the do/enddo variety can be indented. If you use only structured\n+loops of the do/enddo form, you should declare this by setting the\n+fortran_do_enddo variable in your .vimrc as follows >", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417274449", + "id": 1417274449, + "in_reply_to_id": 1417153937, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeeRR", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 732, + "original_position": 34, + "original_start_line": null, + "path": "runtime/doc/indent.txt", + "position": null, + "pull_request_review_id": 1767514683, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417274449/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T13:10:33Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417274449", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26410#discussion_r1417290522" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26410" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417290522" + } + }, + "author_association": "MEMBER", + "body": "Ah. No problem then, sounds good! :+1: ", + "commit_id": "24d243d7981c719d095aa10030db922831d8e364", + "created_at": "2023-12-06T13:21:43Z", + "diff_hunk": "@@ -711,26 +711,25 @@ FORTRAN\t\t\t\t\t\t\t*ft-fortran-indent*\n Block if, select case, where, and forall constructs are indented. So are\n type, interface, associate, block, and enum constructs. The indenting of\n subroutines, functions, modules, and program blocks is optional. Comments,\n-labelled statements and continuation lines are indented if the Fortran is in\n+labeled statements, and continuation lines are indented if the Fortran is in\n free source form, whereas they are not indented if the Fortran is in fixed\n source form because of the left margin requirements. Hence manual indent\n-corrections will be necessary for labelled statements and continuation lines\n+corrections will be necessary for labeled statements and continuation lines\n when fixed source form is being used. For further discussion of the method\n used for the detection of source format see |ft-fortran-syntax|.\n \n Do loops ~\n All do loops are left unindented by default. Do loops can be unstructured in\n-Fortran with (possibly multiple) loops ending on a labelled executable\n+Fortran with (possibly multiple) loops ending on a labeled executable\n statement of almost arbitrary type. Correct indentation requires\n-compiler-quality parsing. Old code with do loops ending on labelled statements\n-of arbitrary type can be indented with elaborate programs such as Tidy\n-(https://www.unb.ca/chem/ajit/f_tidy.htm). Structured do/continue loops are\n-also left unindented because continue statements are also used for purposes\n-other than ending a do loop. Programs such as Tidy can convert structured\n-do/continue loops to the do/enddo form. Do loops of the do/enddo variety can\n-be indented. If you use only structured loops of the do/enddo form, you should\n-declare this by setting the fortran_do_enddo variable in your vimrc as\n-follows >\n+compiler-quality parsing. Old code with do loops ending on labeled statements\n+of arbitrary type can be indented with elaborate programs such as Tidy.\n+Structured do/continue loops are also left unindented because continue\n+statements are used for purposes other than ending a do loop. Programs such\n+as Tidy can convert structured do/continue loops to the do/enddo form. Do\n+loops of the do/enddo variety can be indented. If you use only structured\n+loops of the do/enddo form, you should declare this by setting the\n+fortran_do_enddo variable in your .vimrc as follows >", + "html_url": "https://github.com/neovim/neovim/pull/26410#discussion_r1417290522", + "id": 1417290522, + "in_reply_to_id": 1417153937, + "line": null, + "node_id": "PRRC_kwDOAPphoM5UeiMa", + "original_commit_id": "2e1afddf453687238742dfb05a9332961188c1a6", + "original_line": 732, + "original_position": 34, + "original_start_line": null, + "path": "runtime/doc/indent.txt", + "position": null, + "pull_request_review_id": 1767539074, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26410", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417290522/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T13:21:43Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417290522", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6256228?v=4", + "events_url": "https://api.github.com/users/seandewar/events{/privacy}", + "followers_url": "https://api.github.com/users/seandewar/followers", + "following_url": "https://api.github.com/users/seandewar/following{/other_user}", + "gists_url": "https://api.github.com/users/seandewar/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/seandewar", + "id": 6256228, + "login": "seandewar", + "node_id": "MDQ6VXNlcjYyNTYyMjg=", + "organizations_url": "https://api.github.com/users/seandewar/orgs", + "received_events_url": "https://api.github.com/users/seandewar/received_events", + "repos_url": "https://api.github.com/users/seandewar/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/seandewar/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/seandewar/subscriptions", + "type": "User", + "url": "https://api.github.com/users/seandewar" + } + } + ], + "comment_regular_data": [ + { + "author_association": "MEMBER", + "body": "> Turns out there's 3 more \"prior to the :syntax on command\" mentions from older Fortran syntax.txt updates that could be fixed too here if you'd like. 👍\r\n\r\nSounds good, but I only grepped two?", + "created_at": "2023-12-06T13:33:58Z", + "html_url": "https://github.com/neovim/neovim/pull/26410#issuecomment-1842892525", + "id": 1842892525, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26410", + "node_id": "IC_kwDOAPphoM5t2E7t", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842892525/reactions" + }, + "updated_at": "2023-12-06T13:33:58Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842892525", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + } + }, + { + "author_association": "MEMBER", + "body": "2 is correct, sorry! (I didn't have the PR checked out when I grepped :facepalm:)", + "created_at": "2023-12-06T13:37:04Z", + "html_url": "https://github.com/neovim/neovim/pull/26410#issuecomment-1842903860", + "id": 1842903860, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26410", + "node_id": "IC_kwDOAPphoM5t2Hs0", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842903860/reactions" + }, + "updated_at": "2023-12-06T13:37:04Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1842903860", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6256228?v=4", + "events_url": "https://api.github.com/users/seandewar/events{/privacy}", + "followers_url": "https://api.github.com/users/seandewar/followers", + "following_url": "https://api.github.com/users/seandewar/following{/other_user}", + "gists_url": "https://api.github.com/users/seandewar/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/seandewar", + "id": 6256228, + "login": "seandewar", + "node_id": "MDQ6VXNlcjYyNTYyMjg=", + "organizations_url": "https://api.github.com/users/seandewar/orgs", + "received_events_url": "https://api.github.com/users/seandewar/received_events", + "repos_url": "https://api.github.com/users/seandewar/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/seandewar/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/seandewar/subscriptions", + "type": "User", + "url": "https://api.github.com/users/seandewar" + } + } + ], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26410/comments", "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26410/commits", "created_at": "2023-12-05T22:04:31Z", @@ -266,9 +904,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/clason/neovim/pulls{/number}", - "pushed_at": "2023-12-05T22:04:30Z", + "pushed_at": "2023-12-06T14:39:51Z", "releases_url": "https://api.github.com/repos/clason/neovim/releases{/id}", - "size": 240075, + "size": 238533, "ssh_url": "git@github.com:clason/neovim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/clason/neovim/stargazers", @@ -287,7 +925,7 @@ "watchers_count": 0, "web_commit_signoff_required": false }, - "sha": "41250fbcd218597a8f54a8fd6d38148e901b758f", + "sha": "24d243d7981c719d095aa10030db922831d8e364", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", "events_url": "https://api.github.com/users/clason/events{/privacy}", @@ -313,6 +951,15 @@ "id": 1631293588, "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26410", "labels": [ + { + "color": "c5def5", + "default": false, + "description": "funtime", + "id": 120251370, + "name": "runtime", + "node_id": "MDU6TGFiZWwxMjAyNTEzNzA=", + "url": "https://api.github.com/repos/neovim/neovim/labels/runtime" + }, { "color": "e6e6e6", "default": false, @@ -324,61 +971,20 @@ } ], "locked": false, - "merge_commit_sha": "f8d89b3847b547db21d7ee9185f4f5889859fbbf", - "merged_at": null, + "merge_commit_sha": "f64e4b43e1191ff30d902730f752875aa55682ce", + "merged_at": "2023-12-06T13:59:38Z", "milestone": null, "node_id": "PR_kwDOAPphoM5hO5CU", "number": 26410, "patch_url": "https://github.com/neovim/neovim/pull/26410.patch", - "requested_reviewers": [ - { - "avatar_url": "https://avatars.githubusercontent.com/u/6256228?v=4", - "events_url": "https://api.github.com/users/seandewar/events{/privacy}", - "followers_url": "https://api.github.com/users/seandewar/followers", - "following_url": "https://api.github.com/users/seandewar/following{/other_user}", - "gists_url": "https://api.github.com/users/seandewar/gists{/gist_id}", - "gravatar_id": "", - "html_url": "https://github.com/seandewar", - "id": 6256228, - "login": "seandewar", - "node_id": "MDQ6VXNlcjYyNTYyMjg=", - "organizations_url": "https://api.github.com/users/seandewar/orgs", - "received_events_url": "https://api.github.com/users/seandewar/received_events", - "repos_url": "https://api.github.com/users/seandewar/repos", - "site_admin": false, - "starred_url": "https://api.github.com/users/seandewar/starred{/owner}{/repo}", - "subscriptions_url": "https://api.github.com/users/seandewar/subscriptions", - "type": "User", - "url": "https://api.github.com/users/seandewar" - }, - { - "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", - "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", - "followers_url": "https://api.github.com/users/zeertzjq/followers", - "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", - "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", - "gravatar_id": "", - "html_url": "https://github.com/zeertzjq", - "id": 35768171, - "login": "zeertzjq", - "node_id": "MDQ6VXNlcjM1NzY4MTcx", - "organizations_url": "https://api.github.com/users/zeertzjq/orgs", - "received_events_url": "https://api.github.com/users/zeertzjq/received_events", - "repos_url": "https://api.github.com/users/zeertzjq/repos", - "site_admin": false, - "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", - "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", - "type": "User", - "url": "https://api.github.com/users/zeertzjq" - } - ], + "requested_reviewers": [], "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26410/comments", - "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/41250fbcd218597a8f54a8fd6d38148e901b758f", - "title": "vim-patch:4e043b1fc7ee", - "updated_at": "2023-12-05T22:06:34Z", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/24d243d7981c719d095aa10030db922831d8e364", + "title": "vim-patch:4e043b1fc7ee,6863084d3bd0: update runtime files", + "updated_at": "2023-12-06T13:59:54Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26410", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", diff --git a/repositories/neovim/pulls/26415.json b/repositories/neovim/pulls/26415.json index ed29eaf0..946ccbf7 100644 --- a/repositories/neovim/pulls/26415.json +++ b/repositories/neovim/pulls/26415.json @@ -22,7 +22,7 @@ "href": "https://api.github.com/repos/neovim/neovim/pulls/26415" }, "statuses": { - "href": "https://api.github.com/repos/neovim/neovim/statuses/e80675d2ab34af2584e146e3f15c81df0624eefa" + "href": "https://api.github.com/repos/neovim/neovim/statuses/71115cc56a9830ce42213c7798625802aa56d89e" } }, "active_lock_reason": null, @@ -55,8 +55,8 @@ "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", "events_url": "https://api.github.com/repos/neovim/neovim/events", "fork": false, - "forks": 5040, - "forks_count": 5040, + "forks": 5038, + "forks_count": 5038, "forks_url": "https://api.github.com/repos/neovim/neovim/forks", "full_name": "neovim/neovim", "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:55:02Z", + "pushed_at": "2023-12-07T01:35:41Z", "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", - "size": 243418, + "size": 241695, "ssh_url": "git@github.com:neovim/neovim.git", - "stargazers_count": 71506, + "stargazers_count": 71531, "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", - "updated_at": "2023-12-06T00:51:48Z", + "updated_at": "2023-12-07T01:52:10Z", "url": "https://api.github.com/repos/neovim/neovim", "visibility": "public", - "watchers": 71506, - "watchers_count": 71506, + "watchers": 71531, + "watchers_count": 71531, "web_commit_signoff_required": false }, "sha": "cc38086039853d53157b30fec41babb148399038", @@ -170,7 +170,7 @@ } }, "body": "Problem:\r\nThe test for 'nofsync' swapfile preservation on a deadly signal, does not actually assert anything.\r\n\r\nfollowup to 1fd29a28841dee3d25ff079eb24fc160eb02cb3c\r\n\r\nSolution:\r\n- Check that swapfile contents are present after getting SIGTERM. \r\n- TODO: this doesn't really verify that 'fsync' was called; it still passes with this patch:\r\n\r\n```diff\r\ndiff --git a/src/nvim/main.c b/src/nvim/main.c\r\nindex 216e39f3e81c..7a635520401d 100644\r\n--- a/src/nvim/main.c\r\n+++ b/src/nvim/main.c\r\n@@ -838,7 +838,7 @@ void preserve_exit(const char *errmsg)\r\n if (errmsg != NULL) {\r\n os_errmsg(\"Vim: preserving files...\\r\\n\");\r\n }\r\n- ml_sync_all(false, false, true); // preserve all swap files\r\n+ ml_sync_all(false, false, false); // preserve all swap files\r\n break;\r\n }\r\n }\r\n```\r\n\r\nHowever it correctly fails with this patch, at least:\r\n\r\n```diff\r\ndiff --git a/src/nvim/main.c b/src/nvim/main.c\r\nindex 216e39f3e81c..f2306c310ddc 100644\r\n--- a/src/nvim/main.c\r\n+++ b/src/nvim/main.c\r\n@@ -838,7 +838,6 @@ void preserve_exit(const char *errmsg)\r\n if (errmsg != NULL) {\r\n os_errmsg(\"Vim: preserving files...\\r\\n\");\r\n }\r\n- ml_sync_all(false, false, true); // preserve all swap files\r\n break;\r\n }\r\n }\r\n```", - "closed_at": null, + "closed_at": "2023-12-06T15:11:36Z", "comment_data": [], "comment_regular_data": [], "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26415/comments", @@ -266,9 +266,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/justinmk/neovim/pulls{/number}", - "pushed_at": "2023-12-06T01:22:54Z", + "pushed_at": "2023-12-07T01:26:59Z", "releases_url": "https://api.github.com/repos/justinmk/neovim/releases{/id}", - "size": 239100, + "size": 237709, "ssh_url": "git@github.com:justinmk/neovim.git", "stargazers_count": 1, "stargazers_url": "https://api.github.com/repos/justinmk/neovim/stargazers", @@ -287,7 +287,7 @@ "watchers_count": 1, "web_commit_signoff_required": false }, - "sha": "e80675d2ab34af2584e146e3f15c81df0624eefa", + "sha": "71115cc56a9830ce42213c7798625802aa56d89e", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", "events_url": "https://api.github.com/users/justinmk/events{/privacy}", @@ -324,8 +324,8 @@ } ], "locked": false, - "merge_commit_sha": "6c1ba63efece7f137a6ac013c34d0a02ece216ae", - "merged_at": null, + "merge_commit_sha": "c84af395e88ba143c19f7e34674bd222622e08ee", + "merged_at": "2023-12-06T15:11:36Z", "milestone": null, "node_id": "PR_kwDOAPphoM5hPw5O", "number": 26415, @@ -334,10 +334,10 @@ "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26415/comments", - "state": "open", - "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/e80675d2ab34af2584e146e3f15c81df0624eefa", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/71115cc56a9830ce42213c7798625802aa56d89e", "title": "test: 'nofsync' with deadly signal", - "updated_at": "2023-12-06T01:25:34Z", + "updated_at": "2023-12-06T15:11:37Z", "url": "https://api.github.com/repos/neovim/neovim/pulls/26415", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", diff --git a/repositories/neovim/pulls/26416.json b/repositories/neovim/pulls/26416.json new file mode 100644 index 00000000..6b1e73d1 --- /dev/null +++ b/repositories/neovim/pulls/26416.json @@ -0,0 +1,431 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26416/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26416/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26416" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26416" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26416/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26416" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/e5fcca6e3898faa70289fbfaf287801b4a807d5d" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "cc38086039853d53157b30fec41babb148399038", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Fixes: https://github.com/neovim/neovim/issues/26409\n", + "closed_at": "2023-12-06T02:35:22Z", + "comment_data": [ + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26416#discussion_r1416566633" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26416" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416566633" + } + }, + "author_association": "MEMBER", + "body": "```suggestion\r\n--- Each element in the iterator is joined into a string separated by {delim}.\r\n```", + "commit_id": "e5fcca6e3898faa70289fbfaf287801b4a807d5d", + "created_at": "2023-12-06T02:12:30Z", + "diff_hunk": "@@ -356,6 +356,18 @@ function ListIter.totable(self)\n return self._table\n end\n \n+--- Collect the iterator into a delimited string.\n+---\n+--- Each element in the iterator is joined into a string seperated by {delim}.", + "html_url": "https://github.com/neovim/neovim/pull/26416#discussion_r1416566633", + "id": 1416566633, + "line": null, + "node_id": "PRRC_kwDOAPphoM5Ubxdp", + "original_commit_id": "6761b8323e5ec8053020583dbddf9d644cbfdc24", + "original_line": 361, + "original_position": 6, + "original_start_line": null, + "path": "runtime/lua/vim/iter.lua", + "position": null, + "pull_request_review_id": 1766503042, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26416", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416566633/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T02:12:30Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1416566633", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + } + ], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26416/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26416/commits", + "created_at": "2023-12-06T02:09:01Z", + "diff_url": "https://github.com/neovim/neovim/pull/26416.diff", + "draft": false, + "head": { + "label": "gpanders:iter-join", + "ref": "iter-join", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/gpanders/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/gpanders/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/gpanders/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/gpanders/neovim/branches{/branch}", + "clone_url": "https://github.com/gpanders/neovim.git", + "collaborators_url": "https://api.github.com/repos/gpanders/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/gpanders/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/gpanders/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/gpanders/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/gpanders/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/gpanders/neovim/contributors", + "created_at": "2021-06-11T03:58:44Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/gpanders/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/gpanders/neovim/downloads", + "events_url": "https://api.github.com/repos/gpanders/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/gpanders/neovim/forks", + "full_name": "gpanders/neovim", + "git_commits_url": "https://api.github.com/repos/gpanders/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/gpanders/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/gpanders/neovim/git/tags{/sha}", + "git_url": "git://github.com/gpanders/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/gpanders/neovim/hooks", + "html_url": "https://github.com/gpanders/neovim", + "id": 375899052, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/gpanders/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/gpanders/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/gpanders/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/gpanders/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/gpanders/neovim/labels{/name}", + "language": "Vim script", + "languages_url": "https://api.github.com/repos/gpanders/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/gpanders/neovim/merges", + "milestones_url": "https://api.github.com/repos/gpanders/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkzNzU4OTkwNTI=", + "notifications_url": "https://api.github.com/repos/gpanders/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/gpanders/neovim/pulls{/number}", + "pushed_at": "2023-12-07T00:14:23Z", + "releases_url": "https://api.github.com/repos/gpanders/neovim/releases{/id}", + "size": 237052, + "ssh_url": "git@github.com:gpanders/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/gpanders/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/gpanders/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/gpanders/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/gpanders/neovim/subscription", + "svn_url": "https://github.com/gpanders/neovim", + "tags_url": "https://api.github.com/repos/gpanders/neovim/tags", + "teams_url": "https://api.github.com/repos/gpanders/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/gpanders/neovim/git/trees{/sha}", + "updated_at": "2022-01-07T19:38:08Z", + "url": "https://api.github.com/repos/gpanders/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "e5fcca6e3898faa70289fbfaf287801b4a807d5d", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26416", + "id": 1631565279, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26416", + "labels": [ + { + "color": "c5def5", + "default": false, + "description": null, + "id": 573222693, + "name": "lua", + "node_id": "MDU6TGFiZWw1NzMyMjI2OTM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/lua" + } + ], + "locked": false, + "merge_commit_sha": "5b40a1c09dda83275784053b325ad16626fc55f2", + "merged_at": "2023-12-06T02:35:22Z", + "milestone": null, + "node_id": "PR_kwDOAPphoM5hP7Xf", + "number": 26416, + "patch_url": "https://github.com/neovim/neovim/pull/26416.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26416/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/e5fcca6e3898faa70289fbfaf287801b4a807d5d", + "title": "feat(lua): implement Iter:join()", + "updated_at": "2023-12-06T02:35:25Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26416", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26417.json b/repositories/neovim/pulls/26417.json new file mode 100644 index 00000000..0ac0f675 --- /dev/null +++ b/repositories/neovim/pulls/26417.json @@ -0,0 +1,371 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26417/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26417/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26417" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26417" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26417/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26417" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/1c238aabb65639f72a30782754d2003a85b0f296" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "5b40a1c09dda83275784053b325ad16626fc55f2", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Problem: SOPT type enums (`SOPT_NUM`, `SOPT_BOOL`, `SOPT_STRING`) are no longer used anywhere.\r\n\r\nSolution: Remove them.", + "closed_at": "2023-12-06T07:39:37Z", + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26417/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26417/commits", + "created_at": "2023-12-06T06:56:03Z", + "diff_url": "https://github.com/neovim/neovim/pull/26417.diff", + "draft": false, + "head": { + "label": "famiu:refactor/options/remove_SOPT", + "ref": "refactor/options/remove_SOPT", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/famiu/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/famiu/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/famiu/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/famiu/neovim/branches{/branch}", + "clone_url": "https://github.com/famiu/neovim.git", + "collaborators_url": "https://api.github.com/repos/famiu/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/famiu/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/famiu/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/famiu/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/famiu/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/famiu/neovim/contributors", + "created_at": "2021-10-11T04:58:58Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/famiu/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/famiu/neovim/downloads", + "events_url": "https://api.github.com/repos/famiu/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/famiu/neovim/forks", + "full_name": "famiu/neovim", + "git_commits_url": "https://api.github.com/repos/famiu/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/famiu/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/famiu/neovim/git/tags{/sha}", + "git_url": "git://github.com/famiu/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/famiu/neovim/hooks", + "html_url": "https://github.com/famiu/neovim", + "id": 415783665, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/famiu/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/famiu/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/famiu/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/famiu/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/famiu/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/famiu/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/famiu/neovim/merges", + "milestones_url": "https://api.github.com/repos/famiu/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOGMha8Q", + "notifications_url": "https://api.github.com/repos/famiu/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/29580810?v=4", + "events_url": "https://api.github.com/users/famiu/events{/privacy}", + "followers_url": "https://api.github.com/users/famiu/followers", + "following_url": "https://api.github.com/users/famiu/following{/other_user}", + "gists_url": "https://api.github.com/users/famiu/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/famiu", + "id": 29580810, + "login": "famiu", + "node_id": "MDQ6VXNlcjI5NTgwODEw", + "organizations_url": "https://api.github.com/users/famiu/orgs", + "received_events_url": "https://api.github.com/users/famiu/received_events", + "repos_url": "https://api.github.com/users/famiu/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/famiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/famiu/subscriptions", + "type": "User", + "url": "https://api.github.com/users/famiu" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/famiu/neovim/pulls{/number}", + "pushed_at": "2023-12-06T18:52:52Z", + "releases_url": "https://api.github.com/repos/famiu/neovim/releases{/id}", + "size": 237178, + "ssh_url": "git@github.com:famiu/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/famiu/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/famiu/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/famiu/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/famiu/neovim/subscription", + "svn_url": "https://github.com/famiu/neovim", + "tags_url": "https://api.github.com/repos/famiu/neovim/tags", + "teams_url": "https://api.github.com/repos/famiu/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/famiu/neovim/git/trees{/sha}", + "updated_at": "2022-08-29T10:09:33Z", + "url": "https://api.github.com/repos/famiu/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "1c238aabb65639f72a30782754d2003a85b0f296", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/29580810?v=4", + "events_url": "https://api.github.com/users/famiu/events{/privacy}", + "followers_url": "https://api.github.com/users/famiu/followers", + "following_url": "https://api.github.com/users/famiu/following{/other_user}", + "gists_url": "https://api.github.com/users/famiu/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/famiu", + "id": 29580810, + "login": "famiu", + "node_id": "MDQ6VXNlcjI5NTgwODEw", + "organizations_url": "https://api.github.com/users/famiu/orgs", + "received_events_url": "https://api.github.com/users/famiu/received_events", + "repos_url": "https://api.github.com/users/famiu/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/famiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/famiu/subscriptions", + "type": "User", + "url": "https://api.github.com/users/famiu" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26417", + "id": 1631822152, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26417", + "labels": [ + { + "color": "C5DEF5", + "default": false, + "description": "changes that are not features or bugfixes", + "id": 106949155, + "name": "refactor", + "node_id": "MDU6TGFiZWwxMDY5NDkxNTU=", + "url": "https://api.github.com/repos/neovim/neovim/labels/refactor" + }, + { + "color": "C5DEF5", + "default": false, + "description": "", + "id": 4242493821, + "name": "options", + "node_id": "LA_kwDOAPphoM7831F9", + "url": "https://api.github.com/repos/neovim/neovim/labels/options" + } + ], + "locked": false, + "merge_commit_sha": "e718866358652020e57fdb43bd9322f0c5732432", + "merged_at": "2023-12-06T07:39:37Z", + "milestone": null, + "node_id": "PR_kwDOAPphoM5hQ6FI", + "number": 26417, + "patch_url": "https://github.com/neovim/neovim/pull/26417.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26417/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/1c238aabb65639f72a30782754d2003a85b0f296", + "title": "refactor(options): remove SOPT type enums", + "updated_at": "2023-12-06T08:34:08Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26417", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/29580810?v=4", + "events_url": "https://api.github.com/users/famiu/events{/privacy}", + "followers_url": "https://api.github.com/users/famiu/followers", + "following_url": "https://api.github.com/users/famiu/following{/other_user}", + "gists_url": "https://api.github.com/users/famiu/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/famiu", + "id": 29580810, + "login": "famiu", + "node_id": "MDQ6VXNlcjI5NTgwODEw", + "organizations_url": "https://api.github.com/users/famiu/orgs", + "received_events_url": "https://api.github.com/users/famiu/received_events", + "repos_url": "https://api.github.com/users/famiu/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/famiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/famiu/subscriptions", + "type": "User", + "url": "https://api.github.com/users/famiu" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26418.json b/repositories/neovim/pulls/26418.json new file mode 100644 index 00000000..6426ab9f --- /dev/null +++ b/repositories/neovim/pulls/26418.json @@ -0,0 +1,362 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26418/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26418/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26418" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26418" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26418/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26418" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/de9f7133ca29e27f461fe91080b88af529cc4908" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "5b40a1c09dda83275784053b325ad16626fc55f2", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "#### vim-patch:8.1.1583: set_ref_in_list() only sets ref in items\n\nProblem: Set_ref_in_list() only sets ref in items.\nSolution: Rename to set_ref_in_list_items() to avoid confusion.\n\nhttps://github.com/vim/vim/commit/7be3ab25891fec711d8a2d9d242711a9155852b6\n\nOmit set_ref_in_list() and set_ref_in_dict(): only used in popup window,\nif_pyth and if_lua.\n\nCo-authored-by: Bram Moolenaar ", + "closed_at": "2023-12-06T07:48:16Z", + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26418/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26418/commits", + "created_at": "2023-12-06T07:33:41Z", + "diff_url": "https://github.com/neovim/neovim/pull/26418.diff", + "draft": false, + "head": { + "label": "zeertzjq:vim-8.1.1583", + "ref": "vim-8.1.1583", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/zeertzjq/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/zeertzjq/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/zeertzjq/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/zeertzjq/neovim/branches{/branch}", + "clone_url": "https://github.com/zeertzjq/neovim.git", + "collaborators_url": "https://api.github.com/repos/zeertzjq/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/zeertzjq/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/zeertzjq/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/zeertzjq/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/zeertzjq/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/zeertzjq/neovim/contributors", + "created_at": "2021-09-27T02:22:45Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/zeertzjq/neovim/deployments", + "description": null, + "disabled": false, + "downloads_url": "https://api.github.com/repos/zeertzjq/neovim/downloads", + "events_url": "https://api.github.com/repos/zeertzjq/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/zeertzjq/neovim/forks", + "full_name": "zeertzjq/neovim", + "git_commits_url": "https://api.github.com/repos/zeertzjq/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/zeertzjq/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/zeertzjq/neovim/git/tags{/sha}", + "git_url": "git://github.com/zeertzjq/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "", + "hooks_url": "https://api.github.com/repos/zeertzjq/neovim/hooks", + "html_url": "https://github.com/zeertzjq/neovim", + "id": 410715915, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/zeertzjq/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/zeertzjq/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/zeertzjq/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/zeertzjq/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/zeertzjq/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/zeertzjq/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/zeertzjq/neovim/merges", + "milestones_url": "https://api.github.com/repos/zeertzjq/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOGHsHCw", + "notifications_url": "https://api.github.com/repos/zeertzjq/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/zeertzjq/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:38Z", + "releases_url": "https://api.github.com/repos/zeertzjq/neovim/releases{/id}", + "size": 236307, + "ssh_url": "git@github.com:zeertzjq/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/zeertzjq/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/zeertzjq/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/zeertzjq/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/zeertzjq/neovim/subscription", + "svn_url": "https://github.com/zeertzjq/neovim", + "tags_url": "https://api.github.com/repos/zeertzjq/neovim/tags", + "teams_url": "https://api.github.com/repos/zeertzjq/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/zeertzjq/neovim/git/trees{/sha}", + "updated_at": "2023-02-18T11:19:39Z", + "url": "https://api.github.com/repos/zeertzjq/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "de9f7133ca29e27f461fe91080b88af529cc4908", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26418", + "id": 1631885529, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26418", + "labels": [ + { + "color": "e6e6e6", + "default": false, + "description": "See https://github.com/neovim/neovim/wiki/Merging-patches-from-upstream-Vim", + "id": 843184430, + "name": "vim-patch", + "node_id": "MDU6TGFiZWw4NDMxODQ0MzA=", + "url": "https://api.github.com/repos/neovim/neovim/labels/vim-patch" + } + ], + "locked": false, + "merge_commit_sha": "401ce9f3fdebed05a929de1b94e55c74d45e2ffb", + "merged_at": "2023-12-06T07:48:16Z", + "milestone": null, + "node_id": "PR_kwDOAPphoM5hRJjZ", + "number": 26418, + "patch_url": "https://github.com/neovim/neovim/pull/26418.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26418/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/de9f7133ca29e27f461fe91080b88af529cc4908", + "title": "vim-patch:8.1.1583: set_ref_in_list() only sets ref in items", + "updated_at": "2023-12-06T07:48:30Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26418", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26420.json b/repositories/neovim/pulls/26420.json new file mode 100644 index 00000000..c83672b4 --- /dev/null +++ b/repositories/neovim/pulls/26420.json @@ -0,0 +1,362 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26420/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26420/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26420" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26420" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26420/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26420" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/4bc4404d361cf405df05f6bd66de4cf205f7737f" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "401ce9f3fdebed05a929de1b94e55c74d45e2ffb", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "#### vim-patch:8.2.3695: confusing error for missing key\r\n\r\nProblem: Confusing error for missing key.\r\nSolution: Use the actualy key for the error.\r\n\r\nhttps://github.com/vim/vim/commit/5c1ec439f0a69e9aa7ece9bbb7d916f48f58be1e\r\n\r\nCo-authored-by: Bram Moolenaar ", + "closed_at": "2023-12-06T08:49:40Z", + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26420/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26420/commits", + "created_at": "2023-12-06T08:16:41Z", + "diff_url": "https://github.com/neovim/neovim/pull/26420.diff", + "draft": false, + "head": { + "label": "zeertzjq:vim-8.2.3695", + "ref": "vim-8.2.3695", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/zeertzjq/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/zeertzjq/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/zeertzjq/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/zeertzjq/neovim/branches{/branch}", + "clone_url": "https://github.com/zeertzjq/neovim.git", + "collaborators_url": "https://api.github.com/repos/zeertzjq/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/zeertzjq/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/zeertzjq/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/zeertzjq/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/zeertzjq/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/zeertzjq/neovim/contributors", + "created_at": "2021-09-27T02:22:45Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/zeertzjq/neovim/deployments", + "description": null, + "disabled": false, + "downloads_url": "https://api.github.com/repos/zeertzjq/neovim/downloads", + "events_url": "https://api.github.com/repos/zeertzjq/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/zeertzjq/neovim/forks", + "full_name": "zeertzjq/neovim", + "git_commits_url": "https://api.github.com/repos/zeertzjq/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/zeertzjq/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/zeertzjq/neovim/git/tags{/sha}", + "git_url": "git://github.com/zeertzjq/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "", + "hooks_url": "https://api.github.com/repos/zeertzjq/neovim/hooks", + "html_url": "https://github.com/zeertzjq/neovim", + "id": 410715915, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/zeertzjq/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/zeertzjq/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/zeertzjq/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/zeertzjq/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/zeertzjq/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/zeertzjq/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/zeertzjq/neovim/merges", + "milestones_url": "https://api.github.com/repos/zeertzjq/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOGHsHCw", + "notifications_url": "https://api.github.com/repos/zeertzjq/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/zeertzjq/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:38Z", + "releases_url": "https://api.github.com/repos/zeertzjq/neovim/releases{/id}", + "size": 236307, + "ssh_url": "git@github.com:zeertzjq/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/zeertzjq/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/zeertzjq/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/zeertzjq/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/zeertzjq/neovim/subscription", + "svn_url": "https://github.com/zeertzjq/neovim", + "tags_url": "https://api.github.com/repos/zeertzjq/neovim/tags", + "teams_url": "https://api.github.com/repos/zeertzjq/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/zeertzjq/neovim/git/trees{/sha}", + "updated_at": "2023-02-18T11:19:39Z", + "url": "https://api.github.com/repos/zeertzjq/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "4bc4404d361cf405df05f6bd66de4cf205f7737f", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26420", + "id": 1631980587, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26420", + "labels": [ + { + "color": "e6e6e6", + "default": false, + "description": "See https://github.com/neovim/neovim/wiki/Merging-patches-from-upstream-Vim", + "id": 843184430, + "name": "vim-patch", + "node_id": "MDU6TGFiZWw4NDMxODQ0MzA=", + "url": "https://api.github.com/repos/neovim/neovim/labels/vim-patch" + } + ], + "locked": false, + "merge_commit_sha": "f22e9e10f9ad77d2cce7f52837c5724877505a08", + "merged_at": "2023-12-06T08:49:40Z", + "milestone": null, + "node_id": "PR_kwDOAPphoM5hRgwr", + "number": 26420, + "patch_url": "https://github.com/neovim/neovim/pull/26420.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26420/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/4bc4404d361cf405df05f6bd66de4cf205f7737f", + "title": "vim-patch:8.2.3695: confusing error for missing key", + "updated_at": "2023-12-06T08:49:56Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26420", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26421.json b/repositories/neovim/pulls/26421.json new file mode 100644 index 00000000..04b2c324 --- /dev/null +++ b/repositories/neovim/pulls/26421.json @@ -0,0 +1,388 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26421/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26421/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26421" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26421" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26421/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26421" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/7f90042c397b31ccd5566b469a8f7176338a4d08" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "CONTRIBUTOR", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "040369e1e4b86c4655a6885b36ee89ad4f10ca16", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.\n
\nRelease notes\n

Sourced from actions/setup-python's releases.

\n
\n

v5.0.0

\n

What's Changed

\n

In scope of this release, we update node version runtime from node16 to node20 (actions/setup-python#772). Besides, we update dependencies to the latest versions.

\n

Full Changelog: https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0

\n

v4.8.0

\n

What's Changed

\n

In scope of this release we added support for GraalPy (actions/setup-python#694). You can use this snippet to set up GraalPy:

\n
steps:\n- uses: actions/checkout@v4\n- uses: actions/setup-python@v4 \n  with:\n    python-version: 'graalpy-22.3' \n- run: python my_script.py\n
\n

Besides, the release contains such changes as:

\n\n

New Contributors

\n\n

Full Changelog: https://github.com/actions/setup-python/compare/v4...v4.8.0

\n

v4.7.1

\n

What's Changed

\n\n

Full Changelog: https://github.com/actions/setup-python/compare/v4...v4.7.1

\n

v4.7.0

\n

In scope of this release, the support for reading python version from pyproject.toml was added (actions/setup-python#669).

\n
      - name: Setup Python\n        uses: actions/setup-python@v4\n</tr></table> \n
\n
\n

... (truncated)

\n
\n
\nCommits\n\n
\n
\n\n\n[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)\n\nDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.\n\n[//]: # (dependabot-automerge-start)\n[//]: # (dependabot-automerge-end)\n\n---\n\n
\nDependabot commands and options\n
\n\nYou can trigger Dependabot actions by commenting on this PR:\n- `@dependabot rebase` will rebase this PR\n- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it\n- `@dependabot merge` will merge this PR after your CI passes on it\n- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it\n- `@dependabot cancel merge` will cancel a previously requested merge and block automerging\n- `@dependabot reopen` will reopen this PR if it is closed\n- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually\n- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency\n- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)\n- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)\n- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)\n\n\n
", + "closed_at": null, + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26421/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26421/commits", + "created_at": "2023-12-06T12:22:15Z", + "diff_url": "https://github.com/neovim/neovim/pull/26421.diff", + "draft": true, + "head": { + "label": "neovim:dependabot/github_actions/actions/setup-python-5", + "ref": "dependabot/github_actions/actions/setup-python-5", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "7f90042c397b31ccd5566b469a8f7176338a4d08", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26421", + "id": 1632380143, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26421", + "labels": [ + { + "color": "e6e6e6", + "default": false, + "description": "automation for build, test, and release", + "id": 212701006, + "name": "ci", + "node_id": "MDU6TGFiZWwyMTI3MDEwMDY=", + "url": "https://api.github.com/repos/neovim/neovim/labels/ci" + }, + { + "color": "c5def5", + "default": false, + "description": "build dependencies (LuaJIT, LibUV, etc.)", + "id": 1205400704, + "name": "dependencies", + "node_id": "MDU6TGFiZWwxMjA1NDAwNzA0", + "url": "https://api.github.com/repos/neovim/neovim/labels/dependencies" + }, + { + "color": "B60205", + "default": false, + "description": "Nothing to see here; move along", + "id": 4135681637, + "name": "DO NOT MERGE", + "node_id": "LA_kwDOAPphoM72gX5l", + "url": "https://api.github.com/repos/neovim/neovim/labels/DO%20NOT%20MERGE" + } + ], + "locked": false, + "merge_commit_sha": "d8a98b2b33f9c7f3962a8800262ff64af0e470d2", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hTCTv", + "number": 26421, + "patch_url": "https://github.com/neovim/neovim/pull/26421.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26421/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/7f90042c397b31ccd5566b469a8f7176338a4d08", + "title": "ci: bump actions/setup-python from 4 to 5", + "updated_at": "2023-12-06T12:29:45Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26421", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4", + "events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}", + "followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/apps/dependabot", + "id": 49699333, + "login": "dependabot[bot]", + "node_id": "MDM6Qm90NDk2OTkzMzM=", + "organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs", + "received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events", + "repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions", + "type": "Bot", + "url": "https://api.github.com/users/dependabot%5Bbot%5D" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26423.json b/repositories/neovim/pulls/26423.json new file mode 100644 index 00000000..9f7d342d --- /dev/null +++ b/repositories/neovim/pulls/26423.json @@ -0,0 +1,362 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26423/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26423/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26423" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26423" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26423/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26423" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/3e459f71ed37219ad0a362d9d162b890ed2773d8" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "c84af395e88ba143c19f7e34674bd222622e08ee", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Followup to 27501d3b6a8d577cf3f5ecc3fe9e219f477586b7.\r\n\r\nProblem:\r\nCI sometimes fails. Something is triggering an extra fsync().\r\n\r\n FAILED test/functional/core/fileio_spec.lua @ 52: fileio fsync() with 'nofsync' #8304\r\n test/functional/core/fileio_spec.lua:100: Expected objects to be the same.\r\n Passed in:\r\n (number) 5\r\n Expected:\r\n (number) 4\r\n\r\nSolution:\r\nRelax the assertion.", + "closed_at": "2023-12-06T16:26:31Z", + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26423/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26423/commits", + "created_at": "2023-12-06T15:22:22Z", + "diff_url": "https://github.com/neovim/neovim/pull/26423.diff", + "draft": false, + "head": { + "label": "justinmk:fixtest", + "ref": "fixtest", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/justinmk/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/justinmk/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/justinmk/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/justinmk/neovim/branches{/branch}", + "clone_url": "https://github.com/justinmk/neovim.git", + "collaborators_url": "https://api.github.com/repos/justinmk/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/justinmk/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/justinmk/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/justinmk/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/justinmk/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/justinmk/neovim/contributors", + "created_at": "2014-02-28T23:17:54Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/justinmk/neovim/deployments", + "description": "somewhere in todo.txt", + "disabled": false, + "downloads_url": "https://api.github.com/repos/justinmk/neovim/downloads", + "events_url": "https://api.github.com/repos/justinmk/neovim/events", + "fork": true, + "forks": 1, + "forks_count": 1, + "forks_url": "https://api.github.com/repos/justinmk/neovim/forks", + "full_name": "justinmk/neovim", + "git_commits_url": "https://api.github.com/repos/justinmk/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/justinmk/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/justinmk/neovim/git/tags{/sha}", + "git_url": "git://github.com/justinmk/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": false, + "has_wiki": false, + "homepage": "http://neovim.io", + "hooks_url": "https://api.github.com/repos/justinmk/neovim/hooks", + "html_url": "https://github.com/justinmk/neovim", + "id": 17302877, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/justinmk/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/justinmk/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/justinmk/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/justinmk/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/justinmk/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/justinmk/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/justinmk/neovim/merges", + "milestones_url": "https://api.github.com/repos/justinmk/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNzMwMjg3Nw==", + "notifications_url": "https://api.github.com/repos/justinmk/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/justinmk/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:26:59Z", + "releases_url": "https://api.github.com/repos/justinmk/neovim/releases{/id}", + "size": 237709, + "ssh_url": "git@github.com:justinmk/neovim.git", + "stargazers_count": 1, + "stargazers_url": "https://api.github.com/repos/justinmk/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/justinmk/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/justinmk/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/justinmk/neovim/subscription", + "svn_url": "https://github.com/justinmk/neovim", + "tags_url": "https://api.github.com/repos/justinmk/neovim/tags", + "teams_url": "https://api.github.com/repos/justinmk/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/justinmk/neovim/git/trees{/sha}", + "updated_at": "2023-07-25T13:51:02Z", + "url": "https://api.github.com/repos/justinmk/neovim", + "visibility": "public", + "watchers": 1, + "watchers_count": 1, + "web_commit_signoff_required": false + }, + "sha": "3e459f71ed37219ad0a362d9d162b890ed2773d8", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26423", + "id": 1632722209, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26423", + "labels": [ + { + "color": "c5def5", + "default": false, + "description": "", + "id": 110418643, + "name": "test", + "node_id": "MDU6TGFiZWwxMTA0MTg2NDM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/test" + } + ], + "locked": false, + "merge_commit_sha": "ca7f8786a0eb578895400e23cd21e25cc0f91800", + "merged_at": "2023-12-06T16:26:31Z", + "milestone": null, + "node_id": "PR_kwDOAPphoM5hUV0h", + "number": 26423, + "patch_url": "https://github.com/neovim/neovim/pull/26423.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26423/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/3e459f71ed37219ad0a362d9d162b890ed2773d8", + "title": "test: unreliable 'nofsync' test", + "updated_at": "2023-12-06T16:26:32Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26423", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26426.json b/repositories/neovim/pulls/26426.json new file mode 100644 index 00000000..16423d0e --- /dev/null +++ b/repositories/neovim/pulls/26426.json @@ -0,0 +1,407 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26426/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26426/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26426" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26426" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26426/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26426" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/065b2f558389c38cdbbabcc397909ca998cf552f" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "3198598e6974ae2009e816aeb96462cdfc3c59e9", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "# Problem:\r\nSince e057b38e7037 #20757 we support empty key in JSON encode/decode, but we don't allow it in RPC object => Vim dict conversion. But empty string is a valid key in Vim dicts and the msgpack spec.\r\n\r\nEmpty string key was disallowed in 7c01d5ff9286 (2014) but that commit/PR doesn't explicitly discuss it, so presumably it was a \"seems reasonable\" decision (or Vimscript didn't allow empty keys until later).\r\n\r\n# Solution:\r\nRemove the check in `object_to_vim()`. Note that `tv_dict_item_alloc_len` will invoke `memcpy(…, 0)` but that's allowed by the C spec: https://stackoverflow.com/a/3751937/152142", + "closed_at": null, + "comment_data": [], + "comment_regular_data": [ + { + "author_association": "MEMBER", + "body": "The return type of `object_to_vim()` can now be changed to `void`.", + "created_at": "2023-12-06T16:50:08Z", + "html_url": "https://github.com/neovim/neovim/pull/26426#issuecomment-1843279934", + "id": 1843279934, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26426", + "node_id": "IC_kwDOAPphoM5t3jg-", + "performed_via_github_app": null, + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843279934/reactions" + }, + "updated_at": "2023-12-06T16:50:08Z", + "url": "https://api.github.com/repos/neovim/neovim/issues/comments/1843279934", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + } + ], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26426/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26426/commits", + "created_at": "2023-12-06T16:25:04Z", + "diff_url": "https://github.com/neovim/neovim/pull/26426.diff", + "draft": false, + "head": { + "label": "justinmk:mpackemptykey", + "ref": "mpackemptykey", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/justinmk/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/justinmk/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/justinmk/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/justinmk/neovim/branches{/branch}", + "clone_url": "https://github.com/justinmk/neovim.git", + "collaborators_url": "https://api.github.com/repos/justinmk/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/justinmk/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/justinmk/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/justinmk/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/justinmk/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/justinmk/neovim/contributors", + "created_at": "2014-02-28T23:17:54Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/justinmk/neovim/deployments", + "description": "somewhere in todo.txt", + "disabled": false, + "downloads_url": "https://api.github.com/repos/justinmk/neovim/downloads", + "events_url": "https://api.github.com/repos/justinmk/neovim/events", + "fork": true, + "forks": 1, + "forks_count": 1, + "forks_url": "https://api.github.com/repos/justinmk/neovim/forks", + "full_name": "justinmk/neovim", + "git_commits_url": "https://api.github.com/repos/justinmk/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/justinmk/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/justinmk/neovim/git/tags{/sha}", + "git_url": "git://github.com/justinmk/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": false, + "has_wiki": false, + "homepage": "http://neovim.io", + "hooks_url": "https://api.github.com/repos/justinmk/neovim/hooks", + "html_url": "https://github.com/justinmk/neovim", + "id": 17302877, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/justinmk/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/justinmk/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/justinmk/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/justinmk/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/justinmk/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/justinmk/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/justinmk/neovim/merges", + "milestones_url": "https://api.github.com/repos/justinmk/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNzMwMjg3Nw==", + "notifications_url": "https://api.github.com/repos/justinmk/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/justinmk/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:26:59Z", + "releases_url": "https://api.github.com/repos/justinmk/neovim/releases{/id}", + "size": 237709, + "ssh_url": "git@github.com:justinmk/neovim.git", + "stargazers_count": 1, + "stargazers_url": "https://api.github.com/repos/justinmk/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/justinmk/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/justinmk/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/justinmk/neovim/subscription", + "svn_url": "https://github.com/justinmk/neovim", + "tags_url": "https://api.github.com/repos/justinmk/neovim/tags", + "teams_url": "https://api.github.com/repos/justinmk/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/justinmk/neovim/git/trees{/sha}", + "updated_at": "2023-07-25T13:51:02Z", + "url": "https://api.github.com/repos/justinmk/neovim", + "visibility": "public", + "watchers": 1, + "watchers_count": 1, + "web_commit_signoff_required": false + }, + "sha": "065b2f558389c38cdbbabcc397909ca998cf552f", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26426", + "id": 1632845621, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26426", + "labels": [ + { + "color": "c7def8", + "default": false, + "description": null, + "id": 242522707, + "name": "rpc", + "node_id": "MDU6TGFiZWwyNDI1MjI3MDc=", + "url": "https://api.github.com/repos/neovim/neovim/labels/rpc" + } + ], + "locked": false, + "merge_commit_sha": "fbf99877659c84f6c7b38caec10276c081bc21b3", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hUz81", + "number": 26426, + "patch_url": "https://github.com/neovim/neovim/pull/26426.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26426/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/065b2f558389c38cdbbabcc397909ca998cf552f", + "title": "feat(rpc): allow empty string key in msgpack => Vim conversion", + "updated_at": "2023-12-07T00:21:38Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26426", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26429.json b/repositories/neovim/pulls/26429.json new file mode 100644 index 00000000..21519571 --- /dev/null +++ b/repositories/neovim/pulls/26429.json @@ -0,0 +1,412 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26429/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26429/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26429" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26429" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26429/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26429" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/059ddf6551b4c41959c9ad1550c3c0132adec466" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "ca7f8786a0eb578895400e23cd21e25cc0f91800", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Problem: Currently, `get_option_value()` returns 3 separate things: The actual value of the option, whether the option is hidden, and the option flags. This makes the function difficult to refactor, modify or otherwise reason about.\r\n\r\nSolution: Split `get_option_value()` into 3 functions, each with a single purpose. This also affects `get_option_value_for()`.", + "closed_at": null, + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26429/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26429/commits", + "created_at": "2023-12-06T18:42:30Z", + "diff_url": "https://github.com/neovim/neovim/pull/26429.diff", + "draft": false, + "head": { + "label": "famiu:refactor/options/get_option_value", + "ref": "refactor/options/get_option_value", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/famiu/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/famiu/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/famiu/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/famiu/neovim/branches{/branch}", + "clone_url": "https://github.com/famiu/neovim.git", + "collaborators_url": "https://api.github.com/repos/famiu/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/famiu/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/famiu/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/famiu/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/famiu/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/famiu/neovim/contributors", + "created_at": "2021-10-11T04:58:58Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/famiu/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/famiu/neovim/downloads", + "events_url": "https://api.github.com/repos/famiu/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/famiu/neovim/forks", + "full_name": "famiu/neovim", + "git_commits_url": "https://api.github.com/repos/famiu/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/famiu/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/famiu/neovim/git/tags{/sha}", + "git_url": "git://github.com/famiu/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/famiu/neovim/hooks", + "html_url": "https://github.com/famiu/neovim", + "id": 415783665, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/famiu/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/famiu/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/famiu/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/famiu/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/famiu/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/famiu/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/famiu/neovim/merges", + "milestones_url": "https://api.github.com/repos/famiu/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOGMha8Q", + "notifications_url": "https://api.github.com/repos/famiu/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/29580810?v=4", + "events_url": "https://api.github.com/users/famiu/events{/privacy}", + "followers_url": "https://api.github.com/users/famiu/followers", + "following_url": "https://api.github.com/users/famiu/following{/other_user}", + "gists_url": "https://api.github.com/users/famiu/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/famiu", + "id": 29580810, + "login": "famiu", + "node_id": "MDQ6VXNlcjI5NTgwODEw", + "organizations_url": "https://api.github.com/users/famiu/orgs", + "received_events_url": "https://api.github.com/users/famiu/received_events", + "repos_url": "https://api.github.com/users/famiu/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/famiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/famiu/subscriptions", + "type": "User", + "url": "https://api.github.com/users/famiu" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/famiu/neovim/pulls{/number}", + "pushed_at": "2023-12-06T18:52:52Z", + "releases_url": "https://api.github.com/repos/famiu/neovim/releases{/id}", + "size": 237178, + "ssh_url": "git@github.com:famiu/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/famiu/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/famiu/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/famiu/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/famiu/neovim/subscription", + "svn_url": "https://github.com/famiu/neovim", + "tags_url": "https://api.github.com/repos/famiu/neovim/tags", + "teams_url": "https://api.github.com/repos/famiu/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/famiu/neovim/git/trees{/sha}", + "updated_at": "2022-08-29T10:09:33Z", + "url": "https://api.github.com/repos/famiu/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "059ddf6551b4c41959c9ad1550c3c0132adec466", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/29580810?v=4", + "events_url": "https://api.github.com/users/famiu/events{/privacy}", + "followers_url": "https://api.github.com/users/famiu/followers", + "following_url": "https://api.github.com/users/famiu/following{/other_user}", + "gists_url": "https://api.github.com/users/famiu/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/famiu", + "id": 29580810, + "login": "famiu", + "node_id": "MDQ6VXNlcjI5NTgwODEw", + "organizations_url": "https://api.github.com/users/famiu/orgs", + "received_events_url": "https://api.github.com/users/famiu/received_events", + "repos_url": "https://api.github.com/users/famiu/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/famiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/famiu/subscriptions", + "type": "User", + "url": "https://api.github.com/users/famiu" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26429", + "id": 1633064090, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26429", + "labels": [ + { + "color": "C5DEF5", + "default": false, + "description": "changes that are not features or bugfixes", + "id": 106949155, + "name": "refactor", + "node_id": "MDU6TGFiZWwxMDY5NDkxNTU=", + "url": "https://api.github.com/repos/neovim/neovim/labels/refactor" + }, + { + "color": "C5DEF5", + "default": false, + "description": "", + "id": 4242493821, + "name": "options", + "node_id": "LA_kwDOAPphoM7831F9", + "url": "https://api.github.com/repos/neovim/neovim/labels/options" + } + ], + "locked": false, + "merge_commit_sha": "adc39895f1692ac6b6855dfdf4a5fee782ce8242", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hVpSa", + "number": 26429, + "patch_url": "https://github.com/neovim/neovim/pull/26429.patch", + "requested_reviewers": [ + { + "avatar_url": "https://avatars.githubusercontent.com/u/1363104?v=4", + "events_url": "https://api.github.com/users/bfredl/events{/privacy}", + "followers_url": "https://api.github.com/users/bfredl/followers", + "following_url": "https://api.github.com/users/bfredl/following{/other_user}", + "gists_url": "https://api.github.com/users/bfredl/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/bfredl", + "id": 1363104, + "login": "bfredl", + "node_id": "MDQ6VXNlcjEzNjMxMDQ=", + "organizations_url": "https://api.github.com/users/bfredl/orgs", + "received_events_url": "https://api.github.com/users/bfredl/received_events", + "repos_url": "https://api.github.com/users/bfredl/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/bfredl/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/bfredl/subscriptions", + "type": "User", + "url": "https://api.github.com/users/bfredl" + }, + { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + ], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26429/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/059ddf6551b4c41959c9ad1550c3c0132adec466", + "title": "refactor(options): split `get_option_value()` into smaller functions", + "updated_at": "2023-12-06T18:58:37Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26429", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/29580810?v=4", + "events_url": "https://api.github.com/users/famiu/events{/privacy}", + "followers_url": "https://api.github.com/users/famiu/followers", + "following_url": "https://api.github.com/users/famiu/following{/other_user}", + "gists_url": "https://api.github.com/users/famiu/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/famiu", + "id": 29580810, + "login": "famiu", + "node_id": "MDQ6VXNlcjI5NTgwODEw", + "organizations_url": "https://api.github.com/users/famiu/orgs", + "received_events_url": "https://api.github.com/users/famiu/received_events", + "repos_url": "https://api.github.com/users/famiu/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/famiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/famiu/subscriptions", + "type": "User", + "url": "https://api.github.com/users/famiu" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26430.json b/repositories/neovim/pulls/26430.json new file mode 100644 index 00000000..6aced193 --- /dev/null +++ b/repositories/neovim/pulls/26430.json @@ -0,0 +1,834 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26430/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26430" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26430" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/c4b6bd072f6d465e6edb1777160c9fc4da94004a" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "CONTRIBUTOR", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "8bb5089974e14f043a0b0c17e4d38dbd0b9a9ab2", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Close #25844\r\nMaybe #23581\r\n\r\nTODO:\r\n- [ ] doc\r\n- [ ] tests", + "closed_at": null, + "comment_data": [ + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26430#discussion_r1417964780" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417964780" + } + }, + "author_association": "MEMBER", + "body": "It might be too much noise for this PR, but as a fast-follow would it make sense to add the win parameter to `apply_autocmds`? Because we want to have this field for all events (though initially it can be a \"todo\").\r\n\r\nbtw why name it `do_autocmd_with_winid`? The existing functions are:\r\n\r\n```\r\napply_autocmds f src/nvim/autocmd.c \r\napply_autocmds_exarg f src/nvim/autocmd.c \r\napply_autocmds_group f src/nvim/autocmd.c \r\napply_autocmds_retval f src/nvim/autocmd.c\r\n```", + "commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "created_at": "2023-12-06T20:53:08Z", + "diff_hunk": "@@ -199,7 +199,7 @@ Window nvim_open_win(Buffer buffer, Boolean enter, Dict(float_config) *config, E\n Boolean noautocmd = !enter || fconfig.noautocmd;\n win_set_buf(wp, buf, noautocmd, err);\n if (!fconfig.noautocmd) {\n- apply_autocmds(EVENT_WINNEW, NULL, NULL, false, buf);\n+ do_autocmd_with_winid(EVENT_WINNEW, NULL, buf, wp->handle);", + "html_url": "https://github.com/neovim/neovim/pull/26430#discussion_r1417964780", + "id": 1417964780, + "line": 202, + "node_id": "PRRC_kwDOAPphoM5UhGzs", + "original_commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "original_line": 202, + "original_position": 5, + "original_start_line": null, + "path": "src/nvim/api/win_config.c", + "position": 5, + "pull_request_review_id": 1768598387, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417964780/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T20:53:08Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417964780", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26430#discussion_r1417967448" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417967448" + } + }, + "author_association": "MEMBER", + "body": "should this have the same signature as `apply_autocmds` (i.e. include the `force` parameter, so that it's easier to search-and-replace one or the other?\r\n\r\ni'd name it `apply_autocmds2` and mark `apply_autocmds` as deprecated.", + "commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "created_at": "2023-12-06T20:54:46Z", + "diff_hunk": "@@ -2568,6 +2568,15 @@ void may_trigger_vim_suspend_resume(bool suspend)\n }\n }\n \n+/// Give windows-id in event.data argument\n+void do_autocmd_with_winid(event_T event, char *fname, buf_T *buf, Window target_win)", + "html_url": "https://github.com/neovim/neovim/pull/26430#discussion_r1417967448", + "id": 1417967448, + "line": 2572, + "node_id": "PRRC_kwDOAPphoM5UhHdY", + "original_commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "original_line": 2572, + "original_position": 5, + "original_start_line": null, + "path": "src/nvim/autocmd.c", + "position": 5, + "pull_request_review_id": 1768602324, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "reactions": { + "+1": 0, + "-1": 1, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417967448/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T20:56:04Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1417967448", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26430#discussion_r1418060638" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418060638" + } + }, + "author_association": "CONTRIBUTOR", + "body": "That would be a big change, first we need to make a list of events (besides `Win*` events) that have a target window, to see how many there are, and how relevant it would be to include `winid`,\ne.g. for `InsertCharPre` the target window is `curwin`, so it feels redundant to add `winid`. If there aren't that many then I believe we don't need to add a new parameter to `apply_autocmds`.\r\n\r\nP.S.\r\nfound `BufWinEnter`, `BufWinLeave`, `CursorMoved`, `OptionSet`", + "commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "created_at": "2023-12-06T22:42:42Z", + "diff_hunk": "@@ -199,7 +199,7 @@ Window nvim_open_win(Buffer buffer, Boolean enter, Dict(float_config) *config, E\n Boolean noautocmd = !enter || fconfig.noautocmd;\n win_set_buf(wp, buf, noautocmd, err);\n if (!fconfig.noautocmd) {\n- apply_autocmds(EVENT_WINNEW, NULL, NULL, false, buf);\n+ do_autocmd_with_winid(EVENT_WINNEW, NULL, buf, wp->handle);", + "html_url": "https://github.com/neovim/neovim/pull/26430#discussion_r1418060638", + "id": 1418060638, + "in_reply_to_id": 1417964780, + "line": 202, + "node_id": "PRRC_kwDOAPphoM5UheNe", + "original_commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "original_line": 202, + "original_position": 5, + "original_start_line": null, + "path": "src/nvim/api/win_config.c", + "position": 5, + "pull_request_review_id": 1768761490, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418060638/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T22:55:09Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418060638", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/20646330?v=4", + "events_url": "https://api.github.com/users/BaraTudor2025/events{/privacy}", + "followers_url": "https://api.github.com/users/BaraTudor2025/followers", + "following_url": "https://api.github.com/users/BaraTudor2025/following{/other_user}", + "gists_url": "https://api.github.com/users/BaraTudor2025/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/BaraTudor2025", + "id": 20646330, + "login": "BaraTudor2025", + "node_id": "MDQ6VXNlcjIwNjQ2MzMw", + "organizations_url": "https://api.github.com/users/BaraTudor2025/orgs", + "received_events_url": "https://api.github.com/users/BaraTudor2025/received_events", + "repos_url": "https://api.github.com/users/BaraTudor2025/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/BaraTudor2025/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/BaraTudor2025/subscriptions", + "type": "User", + "url": "https://api.github.com/users/BaraTudor2025" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26430#discussion_r1418083406" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418083406" + } + }, + "author_association": "CONTRIBUTOR", + "body": "Also `do_autocmd_with_winid` was supposed to be a private function to `window.c`, but it also needed to be called from `nvim_open_win`, so I moved it to `autocmd.c` and made it public.", + "commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "created_at": "2023-12-06T23:05:52Z", + "diff_hunk": "@@ -199,7 +199,7 @@ Window nvim_open_win(Buffer buffer, Boolean enter, Dict(float_config) *config, E\n Boolean noautocmd = !enter || fconfig.noautocmd;\n win_set_buf(wp, buf, noautocmd, err);\n if (!fconfig.noautocmd) {\n- apply_autocmds(EVENT_WINNEW, NULL, NULL, false, buf);\n+ do_autocmd_with_winid(EVENT_WINNEW, NULL, buf, wp->handle);", + "html_url": "https://github.com/neovim/neovim/pull/26430#discussion_r1418083406", + "id": 1418083406, + "in_reply_to_id": 1417964780, + "line": 202, + "node_id": "PRRC_kwDOAPphoM5UhjxO", + "original_commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "original_line": 202, + "original_position": 5, + "original_start_line": null, + "path": "src/nvim/api/win_config.c", + "position": 5, + "pull_request_review_id": 1768813539, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418083406/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T23:05:52Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418083406", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/20646330?v=4", + "events_url": "https://api.github.com/users/BaraTudor2025/events{/privacy}", + "followers_url": "https://api.github.com/users/BaraTudor2025/followers", + "following_url": "https://api.github.com/users/BaraTudor2025/following{/other_user}", + "gists_url": "https://api.github.com/users/BaraTudor2025/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/BaraTudor2025", + "id": 20646330, + "login": "BaraTudor2025", + "node_id": "MDQ6VXNlcjIwNjQ2MzMw", + "organizations_url": "https://api.github.com/users/BaraTudor2025/orgs", + "received_events_url": "https://api.github.com/users/BaraTudor2025/received_events", + "repos_url": "https://api.github.com/users/BaraTudor2025/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/BaraTudor2025/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/BaraTudor2025/subscriptions", + "type": "User", + "url": "https://api.github.com/users/BaraTudor2025" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26430#discussion_r1418087057" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418087057" + } + }, + "author_association": "MEMBER", + "body": "`DirChanged[Pre]`, and maybe the `Tab*` events (note: because windows are globally-unique, we don't need a `tab` field)?\r\n\r\nAnyways, I'm thinking: autocmds can change windows, so all _event context_ such as \"current window\" is relevant to pretty much any event, just like buffer (``). Consider the following:\r\n\r\n```vim\r\nnvim --clean\r\n:edit a\r\n:rightbelow vsplit b\r\n:wincmd w\r\n:autocmd ColorScheme * wincmd w\r\n:autocmd ColorScheme * echomsg 'win='..winnr() 'buf='..expand('')\r\n:colorscheme blue\r\n```\r\n\r\nEven though the event triggered in window 1, the 2nd autocmd prints `win=2 buf=a`, it has no way of knowing the original window (but `` gives it the original buffer).", + "commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "created_at": "2023-12-06T23:09:20Z", + "diff_hunk": "@@ -199,7 +199,7 @@ Window nvim_open_win(Buffer buffer, Boolean enter, Dict(float_config) *config, E\n Boolean noautocmd = !enter || fconfig.noautocmd;\n win_set_buf(wp, buf, noautocmd, err);\n if (!fconfig.noautocmd) {\n- apply_autocmds(EVENT_WINNEW, NULL, NULL, false, buf);\n+ do_autocmd_with_winid(EVENT_WINNEW, NULL, buf, wp->handle);", + "html_url": "https://github.com/neovim/neovim/pull/26430#discussion_r1418087057", + "id": 1418087057, + "in_reply_to_id": 1417964780, + "line": 202, + "node_id": "PRRC_kwDOAPphoM5UhkqR", + "original_commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "original_line": 202, + "original_position": 5, + "original_start_line": null, + "path": "src/nvim/api/win_config.c", + "position": 5, + "pull_request_review_id": 1768816563, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418087057/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T23:16:03Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418087057", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26430#discussion_r1418095866" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418095866" + } + }, + "author_association": "MEMBER", + "body": "@zeertzjq is the objection because of merging vim-patches? What are your thoughts on https://github.com/neovim/neovim/pull/26430#discussion_r1418087057 ?", + "commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "created_at": "2023-12-06T23:17:54Z", + "diff_hunk": "@@ -2568,6 +2568,15 @@ void may_trigger_vim_suspend_resume(bool suspend)\n }\n }\n \n+/// Give windows-id in event.data argument\n+void do_autocmd_with_winid(event_T event, char *fname, buf_T *buf, Window target_win)", + "html_url": "https://github.com/neovim/neovim/pull/26430#discussion_r1418095866", + "id": 1418095866, + "in_reply_to_id": 1417967448, + "line": 2572, + "node_id": "PRRC_kwDOAPphoM5Uhmz6", + "original_commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "original_line": 2572, + "original_position": 5, + "original_start_line": null, + "path": "src/nvim/autocmd.c", + "position": 5, + "pull_request_review_id": 1768824466, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418095866/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T23:17:54Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418095866", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", + "followers_url": "https://api.github.com/users/justinmk/followers", + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/justinmk", + "id": 1359421, + "login": "justinmk", + "node_id": "MDQ6VXNlcjEzNTk0MjE=", + "organizations_url": "https://api.github.com/users/justinmk/orgs", + "received_events_url": "https://api.github.com/users/justinmk/received_events", + "repos_url": "https://api.github.com/users/justinmk/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", + "type": "User", + "url": "https://api.github.com/users/justinmk" + } + }, + { + "_links": { + "html": { + "href": "https://github.com/neovim/neovim/pull/26430#discussion_r1418101997" + }, + "pull_request": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26430" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418101997" + } + }, + "author_association": "MEMBER", + "body": "1. It's strange to mark an internal function as \"deprecated\", as there is no warning for using a \"deprecated\" function. It's better to either just add an extra argument or keep the shorter function for convenience without marking it as anything.\r\n2. Makes sense.", + "commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "created_at": "2023-12-06T23:24:20Z", + "diff_hunk": "@@ -2568,6 +2568,15 @@ void may_trigger_vim_suspend_resume(bool suspend)\n }\n }\n \n+/// Give windows-id in event.data argument\n+void do_autocmd_with_winid(event_T event, char *fname, buf_T *buf, Window target_win)", + "html_url": "https://github.com/neovim/neovim/pull/26430#discussion_r1418101997", + "id": 1418101997, + "in_reply_to_id": 1417967448, + "line": 2572, + "node_id": "PRRC_kwDOAPphoM5UhoTt", + "original_commit_id": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "original_line": 2572, + "original_position": 5, + "original_start_line": null, + "path": "src/nvim/autocmd.c", + "position": 5, + "pull_request_review_id": 1768829867, + "pull_request_url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "reactions": { + "+1": 1, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 1, + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418101997/reactions" + }, + "side": "RIGHT", + "start_line": null, + "start_side": null, + "subject_type": "line", + "updated_at": "2023-12-06T23:25:42Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/comments/1418101997", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + } + ], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26430/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26430/commits", + "created_at": "2023-12-06T20:03:14Z", + "diff_url": "https://github.com/neovim/neovim/pull/26430.diff", + "draft": true, + "head": { + "label": "BaraTudor2025:feat/winID", + "ref": "feat/winID", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/BaraTudor2025/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/BaraTudor2025/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/BaraTudor2025/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/BaraTudor2025/neovim/branches{/branch}", + "clone_url": "https://github.com/BaraTudor2025/neovim.git", + "collaborators_url": "https://api.github.com/repos/BaraTudor2025/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/BaraTudor2025/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/BaraTudor2025/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/BaraTudor2025/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/BaraTudor2025/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/BaraTudor2025/neovim/contributors", + "created_at": "2023-10-31T17:00:17Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/BaraTudor2025/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/BaraTudor2025/neovim/downloads", + "events_url": "https://api.github.com/repos/BaraTudor2025/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/BaraTudor2025/neovim/forks", + "full_name": "BaraTudor2025/neovim", + "git_commits_url": "https://api.github.com/repos/BaraTudor2025/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/BaraTudor2025/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/BaraTudor2025/neovim/git/tags{/sha}", + "git_url": "git://github.com/BaraTudor2025/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/BaraTudor2025/neovim/hooks", + "html_url": "https://github.com/BaraTudor2025/neovim", + "id": 712537242, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/BaraTudor2025/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/BaraTudor2025/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/BaraTudor2025/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/BaraTudor2025/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/BaraTudor2025/neovim/labels{/name}", + "language": null, + "languages_url": "https://api.github.com/repos/BaraTudor2025/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/BaraTudor2025/neovim/merges", + "milestones_url": "https://api.github.com/repos/BaraTudor2025/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOKnh0mg", + "notifications_url": "https://api.github.com/repos/BaraTudor2025/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/20646330?v=4", + "events_url": "https://api.github.com/users/BaraTudor2025/events{/privacy}", + "followers_url": "https://api.github.com/users/BaraTudor2025/followers", + "following_url": "https://api.github.com/users/BaraTudor2025/following{/other_user}", + "gists_url": "https://api.github.com/users/BaraTudor2025/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/BaraTudor2025", + "id": 20646330, + "login": "BaraTudor2025", + "node_id": "MDQ6VXNlcjIwNjQ2MzMw", + "organizations_url": "https://api.github.com/users/BaraTudor2025/orgs", + "received_events_url": "https://api.github.com/users/BaraTudor2025/received_events", + "repos_url": "https://api.github.com/users/BaraTudor2025/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/BaraTudor2025/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/BaraTudor2025/subscriptions", + "type": "User", + "url": "https://api.github.com/users/BaraTudor2025" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/BaraTudor2025/neovim/pulls{/number}", + "pushed_at": "2023-12-06T19:57:27Z", + "releases_url": "https://api.github.com/repos/BaraTudor2025/neovim/releases{/id}", + "size": 235910, + "ssh_url": "git@github.com:BaraTudor2025/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/BaraTudor2025/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/BaraTudor2025/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/BaraTudor2025/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/BaraTudor2025/neovim/subscription", + "svn_url": "https://github.com/BaraTudor2025/neovim", + "tags_url": "https://api.github.com/repos/BaraTudor2025/neovim/tags", + "teams_url": "https://api.github.com/repos/BaraTudor2025/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/BaraTudor2025/neovim/git/trees{/sha}", + "updated_at": "2023-10-31T17:00:17Z", + "url": "https://api.github.com/repos/BaraTudor2025/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/20646330?v=4", + "events_url": "https://api.github.com/users/BaraTudor2025/events{/privacy}", + "followers_url": "https://api.github.com/users/BaraTudor2025/followers", + "following_url": "https://api.github.com/users/BaraTudor2025/following{/other_user}", + "gists_url": "https://api.github.com/users/BaraTudor2025/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/BaraTudor2025", + "id": 20646330, + "login": "BaraTudor2025", + "node_id": "MDQ6VXNlcjIwNjQ2MzMw", + "organizations_url": "https://api.github.com/users/BaraTudor2025/orgs", + "received_events_url": "https://api.github.com/users/BaraTudor2025/received_events", + "repos_url": "https://api.github.com/users/BaraTudor2025/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/BaraTudor2025/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/BaraTudor2025/subscriptions", + "type": "User", + "url": "https://api.github.com/users/BaraTudor2025" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26430", + "id": 1633171091, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26430", + "labels": [], + "locked": false, + "merge_commit_sha": "32a85e65862b10a9036d59cb8611e765ec080fef", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hWDaT", + "number": 26430, + "patch_url": "https://github.com/neovim/neovim/pull/26430.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26430/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/c4b6bd072f6d465e6edb1777160c9fc4da94004a", + "title": "[WIP] Pass Window ID as a Callback Argument for Autocommands with the Win* events", + "updated_at": "2023-12-06T23:24:20Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26430", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/20646330?v=4", + "events_url": "https://api.github.com/users/BaraTudor2025/events{/privacy}", + "followers_url": "https://api.github.com/users/BaraTudor2025/followers", + "following_url": "https://api.github.com/users/BaraTudor2025/following{/other_user}", + "gists_url": "https://api.github.com/users/BaraTudor2025/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/BaraTudor2025", + "id": 20646330, + "login": "BaraTudor2025", + "node_id": "MDQ6VXNlcjIwNjQ2MzMw", + "organizations_url": "https://api.github.com/users/BaraTudor2025/orgs", + "received_events_url": "https://api.github.com/users/BaraTudor2025/received_events", + "repos_url": "https://api.github.com/users/BaraTudor2025/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/BaraTudor2025/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/BaraTudor2025/subscriptions", + "type": "User", + "url": "https://api.github.com/users/BaraTudor2025" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26431.json b/repositories/neovim/pulls/26431.json new file mode 100644 index 00000000..639c4b80 --- /dev/null +++ b/repositories/neovim/pulls/26431.json @@ -0,0 +1,380 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26431/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26431/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26431" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26431" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26431/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26431" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/9199f8cf66ebc1796a0f93ae286f7ec1ad53d041" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "8bb5089974e14f043a0b0c17e4d38dbd0b9a9ab2", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "\"Mom, can we rewrite neovim in rust?\"\n\"We have a rewrite at home\"\nRewrite at home:\n", + "closed_at": null, + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26431/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26431/commits", + "created_at": "2023-12-06T21:14:44Z", + "diff_url": "https://github.com/neovim/neovim/pull/26431.diff", + "draft": true, + "head": { + "label": "dundargoc:build/vcpkg", + "ref": "build/vcpkg", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/dundargoc/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/dundargoc/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/dundargoc/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/dundargoc/neovim/branches{/branch}", + "clone_url": "https://github.com/dundargoc/neovim.git", + "collaborators_url": "https://api.github.com/repos/dundargoc/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/dundargoc/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/dundargoc/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/dundargoc/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/dundargoc/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/dundargoc/neovim/contributors", + "created_at": "2021-06-20T10:14:48Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/dundargoc/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/dundargoc/neovim/downloads", + "events_url": "https://api.github.com/repos/dundargoc/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/dundargoc/neovim/forks", + "full_name": "dundargoc/neovim", + "git_commits_url": "https://api.github.com/repos/dundargoc/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/dundargoc/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/dundargoc/neovim/git/tags{/sha}", + "git_url": "git://github.com/dundargoc/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": false, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/dundargoc/neovim/hooks", + "html_url": "https://github.com/dundargoc/neovim", + "id": 378614899, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/dundargoc/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/dundargoc/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/dundargoc/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/dundargoc/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/dundargoc/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/dundargoc/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/dundargoc/neovim/merges", + "milestones_url": "https://api.github.com/repos/dundargoc/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkzNzg2MTQ4OTk=", + "notifications_url": "https://api.github.com/repos/dundargoc/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", + "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", + "followers_url": "https://api.github.com/users/dundargoc/followers", + "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", + "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/dundargoc", + "id": 33953936, + "login": "dundargoc", + "node_id": "MDQ6VXNlcjMzOTUzOTM2", + "organizations_url": "https://api.github.com/users/dundargoc/orgs", + "received_events_url": "https://api.github.com/users/dundargoc/received_events", + "repos_url": "https://api.github.com/users/dundargoc/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", + "type": "User", + "url": "https://api.github.com/users/dundargoc" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/dundargoc/neovim/pulls{/number}", + "pushed_at": "2023-12-06T21:36:35Z", + "releases_url": "https://api.github.com/repos/dundargoc/neovim/releases{/id}", + "size": 239139, + "ssh_url": "git@github.com:dundargoc/neovim.git", + "stargazers_count": 1, + "stargazers_url": "https://api.github.com/repos/dundargoc/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/dundargoc/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/dundargoc/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/dundargoc/neovim/subscription", + "svn_url": "https://github.com/dundargoc/neovim", + "tags_url": "https://api.github.com/repos/dundargoc/neovim/tags", + "teams_url": "https://api.github.com/repos/dundargoc/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/dundargoc/neovim/git/trees{/sha}", + "updated_at": "2023-07-31T17:43:26Z", + "url": "https://api.github.com/repos/dundargoc/neovim", + "visibility": "public", + "watchers": 1, + "watchers_count": 1, + "web_commit_signoff_required": false + }, + "sha": "9199f8cf66ebc1796a0f93ae286f7ec1ad53d041", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", + "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", + "followers_url": "https://api.github.com/users/dundargoc/followers", + "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", + "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/dundargoc", + "id": 33953936, + "login": "dundargoc", + "node_id": "MDQ6VXNlcjMzOTUzOTM2", + "organizations_url": "https://api.github.com/users/dundargoc/orgs", + "received_events_url": "https://api.github.com/users/dundargoc/received_events", + "repos_url": "https://api.github.com/users/dundargoc/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", + "type": "User", + "url": "https://api.github.com/users/dundargoc" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26431", + "id": 1633261672, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26431", + "labels": [ + { + "color": "c5def5", + "default": false, + "description": "building and installing Neovim using the provided scripts", + "id": 84723321, + "name": "build", + "node_id": "MDU6TGFiZWw4NDcyMzMyMQ==", + "url": "https://api.github.com/repos/neovim/neovim/labels/build" + }, + { + "color": "e6e6e6", + "default": false, + "description": "automation for build, test, and release", + "id": 212701006, + "name": "ci", + "node_id": "MDU6TGFiZWwyMTI3MDEwMDY=", + "url": "https://api.github.com/repos/neovim/neovim/labels/ci" + }, + { + "color": "c5def5", + "default": false, + "description": "build dependencies (LuaJIT, LibUV, etc.)", + "id": 1205400704, + "name": "dependencies", + "node_id": "MDU6TGFiZWwxMjA1NDAwNzA0", + "url": "https://api.github.com/repos/neovim/neovim/labels/dependencies" + } + ], + "locked": false, + "merge_commit_sha": "f6c591c0fd31612e52abaf7b4c01c2849b7306ac", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hWZho", + "number": 26431, + "patch_url": "https://github.com/neovim/neovim/pull/26431.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26431/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/9199f8cf66ebc1796a0f93ae286f7ec1ad53d041", + "title": "build: migrate to vcpkg [skip ci]", + "updated_at": "2023-12-06T21:36:36Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26431", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", + "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", + "followers_url": "https://api.github.com/users/dundargoc/followers", + "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", + "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/dundargoc", + "id": 33953936, + "login": "dundargoc", + "node_id": "MDQ6VXNlcjMzOTUzOTM2", + "organizations_url": "https://api.github.com/users/dundargoc/orgs", + "received_events_url": "https://api.github.com/users/dundargoc/received_events", + "repos_url": "https://api.github.com/users/dundargoc/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", + "type": "User", + "url": "https://api.github.com/users/dundargoc" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26434.json b/repositories/neovim/pulls/26434.json new file mode 100644 index 00000000..908d375e --- /dev/null +++ b/repositories/neovim/pulls/26434.json @@ -0,0 +1,371 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26434/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26434/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26434" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26434" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26434/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26434" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/f42ca8fe9b61f0bdf2611d873a68a97a339c0534" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "8bb5089974e14f043a0b0c17e4d38dbd0b9a9ab2", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": null, + "closed_at": "2023-12-06T23:15:37Z", + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26434/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26434/commits", + "created_at": "2023-12-06T22:45:13Z", + "diff_url": "https://github.com/neovim/neovim/pull/26434.diff", + "draft": false, + "head": { + "label": "zeertzjq:test-tui-tgc", + "ref": "test-tui-tgc", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/zeertzjq/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/zeertzjq/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/zeertzjq/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/zeertzjq/neovim/branches{/branch}", + "clone_url": "https://github.com/zeertzjq/neovim.git", + "collaborators_url": "https://api.github.com/repos/zeertzjq/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/zeertzjq/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/zeertzjq/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/zeertzjq/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/zeertzjq/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/zeertzjq/neovim/contributors", + "created_at": "2021-09-27T02:22:45Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/zeertzjq/neovim/deployments", + "description": null, + "disabled": false, + "downloads_url": "https://api.github.com/repos/zeertzjq/neovim/downloads", + "events_url": "https://api.github.com/repos/zeertzjq/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/zeertzjq/neovim/forks", + "full_name": "zeertzjq/neovim", + "git_commits_url": "https://api.github.com/repos/zeertzjq/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/zeertzjq/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/zeertzjq/neovim/git/tags{/sha}", + "git_url": "git://github.com/zeertzjq/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "", + "hooks_url": "https://api.github.com/repos/zeertzjq/neovim/hooks", + "html_url": "https://github.com/zeertzjq/neovim", + "id": 410715915, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/zeertzjq/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/zeertzjq/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/zeertzjq/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/zeertzjq/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/zeertzjq/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/zeertzjq/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/zeertzjq/neovim/merges", + "milestones_url": "https://api.github.com/repos/zeertzjq/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOGHsHCw", + "notifications_url": "https://api.github.com/repos/zeertzjq/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/zeertzjq/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:38Z", + "releases_url": "https://api.github.com/repos/zeertzjq/neovim/releases{/id}", + "size": 236307, + "ssh_url": "git@github.com:zeertzjq/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/zeertzjq/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/zeertzjq/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/zeertzjq/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/zeertzjq/neovim/subscription", + "svn_url": "https://github.com/zeertzjq/neovim", + "tags_url": "https://api.github.com/repos/zeertzjq/neovim/tags", + "teams_url": "https://api.github.com/repos/zeertzjq/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/zeertzjq/neovim/git/trees{/sha}", + "updated_at": "2023-02-18T11:19:39Z", + "url": "https://api.github.com/repos/zeertzjq/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "f42ca8fe9b61f0bdf2611d873a68a97a339c0534", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26434", + "id": 1633379598, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26434", + "labels": [ + { + "color": "c5def5", + "default": false, + "description": "", + "id": 110418643, + "name": "test", + "node_id": "MDU6TGFiZWwxMTA0MTg2NDM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/test" + }, + { + "color": "c5def5", + "default": false, + "description": "built-in :terminal or :shell", + "id": 212696822, + "name": "terminal", + "node_id": "MDU6TGFiZWwyMTI2OTY4MjI=", + "url": "https://api.github.com/repos/neovim/neovim/labels/terminal" + } + ], + "locked": false, + "merge_commit_sha": "6b00b8a369480a6535e7d286dd6ea27a6b0c94a5", + "merged_at": "2023-12-06T23:15:37Z", + "milestone": null, + "node_id": "PR_kwDOAPphoM5hW2UO", + "number": 26434, + "patch_url": "https://github.com/neovim/neovim/pull/26434.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26434/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/f42ca8fe9b61f0bdf2611d873a68a97a339c0534", + "title": "test(terminal): remove unnecessary string operations", + "updated_at": "2023-12-06T23:15:41Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26434", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26435.json b/repositories/neovim/pulls/26435.json new file mode 100644 index 00000000..83b824c0 --- /dev/null +++ b/repositories/neovim/pulls/26435.json @@ -0,0 +1,371 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26435/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26435/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26435" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26435" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26435/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26435" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/7d8af81d9fe0e74d0f3804df440d11affa3d35a6" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "6b00b8a369480a6535e7d286dd6ea27a6b0c94a5", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Avoid scheduling on main loop.\nFix #26425\n", + "closed_at": "2023-12-06T23:35:52Z", + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26435/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26435/commits", + "created_at": "2023-12-06T23:16:21Z", + "diff_url": "https://github.com/neovim/neovim/pull/26435.diff", + "draft": false, + "head": { + "label": "zeertzjq:tui-timer", + "ref": "tui-timer", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/zeertzjq/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/zeertzjq/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/zeertzjq/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/zeertzjq/neovim/branches{/branch}", + "clone_url": "https://github.com/zeertzjq/neovim.git", + "collaborators_url": "https://api.github.com/repos/zeertzjq/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/zeertzjq/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/zeertzjq/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/zeertzjq/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/zeertzjq/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/zeertzjq/neovim/contributors", + "created_at": "2021-09-27T02:22:45Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/zeertzjq/neovim/deployments", + "description": null, + "disabled": false, + "downloads_url": "https://api.github.com/repos/zeertzjq/neovim/downloads", + "events_url": "https://api.github.com/repos/zeertzjq/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/zeertzjq/neovim/forks", + "full_name": "zeertzjq/neovim", + "git_commits_url": "https://api.github.com/repos/zeertzjq/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/zeertzjq/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/zeertzjq/neovim/git/tags{/sha}", + "git_url": "git://github.com/zeertzjq/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "", + "hooks_url": "https://api.github.com/repos/zeertzjq/neovim/hooks", + "html_url": "https://github.com/zeertzjq/neovim", + "id": 410715915, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/zeertzjq/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/zeertzjq/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/zeertzjq/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/zeertzjq/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/zeertzjq/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/zeertzjq/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/zeertzjq/neovim/merges", + "milestones_url": "https://api.github.com/repos/zeertzjq/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOGHsHCw", + "notifications_url": "https://api.github.com/repos/zeertzjq/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/zeertzjq/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:38Z", + "releases_url": "https://api.github.com/repos/zeertzjq/neovim/releases{/id}", + "size": 236307, + "ssh_url": "git@github.com:zeertzjq/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/zeertzjq/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/zeertzjq/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/zeertzjq/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/zeertzjq/neovim/subscription", + "svn_url": "https://github.com/zeertzjq/neovim", + "tags_url": "https://api.github.com/repos/zeertzjq/neovim/tags", + "teams_url": "https://api.github.com/repos/zeertzjq/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/zeertzjq/neovim/git/trees{/sha}", + "updated_at": "2023-02-18T11:19:39Z", + "url": "https://api.github.com/repos/zeertzjq/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "7d8af81d9fe0e74d0f3804df440d11affa3d35a6", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26435", + "id": 1633408369, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26435", + "labels": [ + { + "color": "C5DEF5", + "default": false, + "description": "changes that are not features or bugfixes", + "id": 106949155, + "name": "refactor", + "node_id": "MDU6TGFiZWwxMDY5NDkxNTU=", + "url": "https://api.github.com/repos/neovim/neovim/labels/refactor" + }, + { + "color": "c5def5", + "default": false, + "description": "", + "id": 197254545, + "name": "tui", + "node_id": "MDU6TGFiZWwxOTcyNTQ1NDU=", + "url": "https://api.github.com/repos/neovim/neovim/labels/tui" + } + ], + "locked": false, + "merge_commit_sha": "3198598e6974ae2009e816aeb96462cdfc3c59e9", + "merged_at": "2023-12-06T23:35:52Z", + "milestone": null, + "node_id": "PR_kwDOAPphoM5hW9Vx", + "number": 26435, + "patch_url": "https://github.com/neovim/neovim/pull/26435.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26435/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/7d8af81d9fe0e74d0f3804df440d11affa3d35a6", + "title": "fix(tui): use uv_timer_t instead of TimeWatcher for input", + "updated_at": "2023-12-06T23:42:31Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26435", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26436.json b/repositories/neovim/pulls/26436.json new file mode 100644 index 00000000..c4d709a3 --- /dev/null +++ b/repositories/neovim/pulls/26436.json @@ -0,0 +1,412 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26436/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26436/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26436" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26436" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26436/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26436" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/a6c34c4506fcd97866836fdafc06e338df8b2627" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "3198598e6974ae2009e816aeb96462cdfc3c59e9", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": null, + "closed_at": null, + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26436/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26436/commits", + "created_at": "2023-12-07T00:14:23Z", + "diff_url": "https://github.com/neovim/neovim/pull/26436.diff", + "draft": false, + "head": { + "label": "gpanders:news-non-breaking", + "ref": "news-non-breaking", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/gpanders/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/gpanders/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/gpanders/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/gpanders/neovim/branches{/branch}", + "clone_url": "https://github.com/gpanders/neovim.git", + "collaborators_url": "https://api.github.com/repos/gpanders/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/gpanders/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/gpanders/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/gpanders/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/gpanders/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/gpanders/neovim/contributors", + "created_at": "2021-06-11T03:58:44Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/gpanders/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/gpanders/neovim/downloads", + "events_url": "https://api.github.com/repos/gpanders/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/gpanders/neovim/forks", + "full_name": "gpanders/neovim", + "git_commits_url": "https://api.github.com/repos/gpanders/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/gpanders/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/gpanders/neovim/git/tags{/sha}", + "git_url": "git://github.com/gpanders/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/gpanders/neovim/hooks", + "html_url": "https://github.com/gpanders/neovim", + "id": 375899052, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/gpanders/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/gpanders/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/gpanders/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/gpanders/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/gpanders/neovim/labels{/name}", + "language": "Vim script", + "languages_url": "https://api.github.com/repos/gpanders/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/gpanders/neovim/merges", + "milestones_url": "https://api.github.com/repos/gpanders/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkzNzU4OTkwNTI=", + "notifications_url": "https://api.github.com/repos/gpanders/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/gpanders/neovim/pulls{/number}", + "pushed_at": "2023-12-07T00:14:23Z", + "releases_url": "https://api.github.com/repos/gpanders/neovim/releases{/id}", + "size": 237052, + "ssh_url": "git@github.com:gpanders/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/gpanders/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/gpanders/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/gpanders/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/gpanders/neovim/subscription", + "svn_url": "https://github.com/gpanders/neovim", + "tags_url": "https://api.github.com/repos/gpanders/neovim/tags", + "teams_url": "https://api.github.com/repos/gpanders/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/gpanders/neovim/git/trees{/sha}", + "updated_at": "2022-01-07T19:38:08Z", + "url": "https://api.github.com/repos/gpanders/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "a6c34c4506fcd97866836fdafc06e338df8b2627", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26436", + "id": 1633453307, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26436", + "labels": [ + { + "color": "c5def5", + "default": true, + "description": "", + "id": 84744038, + "name": "documentation", + "node_id": "MDU6TGFiZWw4NDc0NDAzOA==", + "url": "https://api.github.com/repos/neovim/neovim/labels/documentation" + }, + { + "color": "4CD5CF", + "default": false, + "description": "automation: collect in one PR and then merge automatically on a schedule", + "id": 2973798833, + "name": "typo", + "node_id": "MDU6TGFiZWwyOTczNzk4ODMz", + "url": "https://api.github.com/repos/neovim/neovim/labels/typo" + } + ], + "locked": false, + "merge_commit_sha": "03c85626570dd4d8d65c423b3ac9479f1b215286", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hXIT7", + "number": 26436, + "patch_url": "https://github.com/neovim/neovim/pull/26436.patch", + "requested_reviewers": [ + { + "avatar_url": "https://avatars.githubusercontent.com/u/2361214?v=4", + "events_url": "https://api.github.com/users/clason/events{/privacy}", + "followers_url": "https://api.github.com/users/clason/followers", + "following_url": "https://api.github.com/users/clason/following{/other_user}", + "gists_url": "https://api.github.com/users/clason/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/clason", + "id": 2361214, + "login": "clason", + "node_id": "MDQ6VXNlcjIzNjEyMTQ=", + "organizations_url": "https://api.github.com/users/clason/orgs", + "received_events_url": "https://api.github.com/users/clason/received_events", + "repos_url": "https://api.github.com/users/clason/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/clason/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clason/subscriptions", + "type": "User", + "url": "https://api.github.com/users/clason" + }, + { + "avatar_url": "https://avatars.githubusercontent.com/u/33953936?v=4", + "events_url": "https://api.github.com/users/dundargoc/events{/privacy}", + "followers_url": "https://api.github.com/users/dundargoc/followers", + "following_url": "https://api.github.com/users/dundargoc/following{/other_user}", + "gists_url": "https://api.github.com/users/dundargoc/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/dundargoc", + "id": 33953936, + "login": "dundargoc", + "node_id": "MDQ6VXNlcjMzOTUzOTM2", + "organizations_url": "https://api.github.com/users/dundargoc/orgs", + "received_events_url": "https://api.github.com/users/dundargoc/received_events", + "repos_url": "https://api.github.com/users/dundargoc/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/dundargoc/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dundargoc/subscriptions", + "type": "User", + "url": "https://api.github.com/users/dundargoc" + } + ], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26436/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/a6c34c4506fcd97866836fdafc06e338df8b2627", + "title": "docs: move non-breaking change out of breaking change section", + "updated_at": "2023-12-07T01:15:59Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26436", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/8965202?v=4", + "events_url": "https://api.github.com/users/gpanders/events{/privacy}", + "followers_url": "https://api.github.com/users/gpanders/followers", + "following_url": "https://api.github.com/users/gpanders/following{/other_user}", + "gists_url": "https://api.github.com/users/gpanders/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/gpanders", + "id": 8965202, + "login": "gpanders", + "node_id": "MDQ6VXNlcjg5NjUyMDI=", + "organizations_url": "https://api.github.com/users/gpanders/orgs", + "received_events_url": "https://api.github.com/users/gpanders/received_events", + "repos_url": "https://api.github.com/users/gpanders/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/gpanders/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/gpanders/subscriptions", + "type": "User", + "url": "https://api.github.com/users/gpanders" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26437.json b/repositories/neovim/pulls/26437.json new file mode 100644 index 00000000..7224c1a0 --- /dev/null +++ b/repositories/neovim/pulls/26437.json @@ -0,0 +1,362 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26437/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26437/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26437" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26437" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26437/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26437" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/d87f0174e64d0741c837decb20a0025ca254713b" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "3198598e6974ae2009e816aeb96462cdfc3c59e9", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "Currently, the value of $COLORTERM in :terminal in tests depends on\r\nouter environment because of 'notermguicolors'.\r\n\r\nIf $COLORTERM is not set in :terminal, an inner Nvim instance will try\r\nto detect 'termguicolors' support, which may interfere with tests.\r\n\r\nSo set 'termguicolors' in outer Nvim instance unless $COLORTERM needs to\r\nbe overridden, and unset it in inner Nvim instance when running TUI.", + "closed_at": null, + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26437/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26437/commits", + "created_at": "2023-12-07T00:33:40Z", + "diff_url": "https://github.com/neovim/neovim/pull/26437.diff", + "draft": false, + "head": { + "label": "zeertzjq:test-tui-tgc", + "ref": "test-tui-tgc", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/zeertzjq/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/zeertzjq/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/zeertzjq/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/zeertzjq/neovim/branches{/branch}", + "clone_url": "https://github.com/zeertzjq/neovim.git", + "collaborators_url": "https://api.github.com/repos/zeertzjq/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/zeertzjq/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/zeertzjq/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/zeertzjq/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/zeertzjq/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/zeertzjq/neovim/contributors", + "created_at": "2021-09-27T02:22:45Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/zeertzjq/neovim/deployments", + "description": null, + "disabled": false, + "downloads_url": "https://api.github.com/repos/zeertzjq/neovim/downloads", + "events_url": "https://api.github.com/repos/zeertzjq/neovim/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/zeertzjq/neovim/forks", + "full_name": "zeertzjq/neovim", + "git_commits_url": "https://api.github.com/repos/zeertzjq/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/zeertzjq/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/zeertzjq/neovim/git/tags{/sha}", + "git_url": "git://github.com/zeertzjq/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "", + "hooks_url": "https://api.github.com/repos/zeertzjq/neovim/hooks", + "html_url": "https://github.com/zeertzjq/neovim", + "id": 410715915, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/zeertzjq/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/zeertzjq/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/zeertzjq/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/zeertzjq/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/zeertzjq/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/zeertzjq/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/zeertzjq/neovim/merges", + "milestones_url": "https://api.github.com/repos/zeertzjq/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "R_kgDOGHsHCw", + "notifications_url": "https://api.github.com/repos/zeertzjq/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/zeertzjq/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:38Z", + "releases_url": "https://api.github.com/repos/zeertzjq/neovim/releases{/id}", + "size": 236307, + "ssh_url": "git@github.com:zeertzjq/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/zeertzjq/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/zeertzjq/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/zeertzjq/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/zeertzjq/neovim/subscription", + "svn_url": "https://github.com/zeertzjq/neovim", + "tags_url": "https://api.github.com/repos/zeertzjq/neovim/tags", + "teams_url": "https://api.github.com/repos/zeertzjq/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/zeertzjq/neovim/git/trees{/sha}", + "updated_at": "2023-02-18T11:19:39Z", + "url": "https://api.github.com/repos/zeertzjq/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "d87f0174e64d0741c837decb20a0025ca254713b", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26437", + "id": 1633474576, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26437", + "labels": [ + { + "color": "c5def5", + "default": false, + "description": "", + "id": 110418643, + "name": "test", + "node_id": "MDU6TGFiZWwxMTA0MTg2NDM=", + "url": "https://api.github.com/repos/neovim/neovim/labels/test" + } + ], + "locked": false, + "merge_commit_sha": "d20b9e3544f3398ca230c2c269410a93b61c1c5a", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hXNgQ", + "number": 26437, + "patch_url": "https://github.com/neovim/neovim/pull/26437.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26437/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/d87f0174e64d0741c837decb20a0025ca254713b", + "title": "test: set 'termguicolors' in outer Nvim instance", + "updated_at": "2023-12-07T01:48:20Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26437", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/35768171?v=4", + "events_url": "https://api.github.com/users/zeertzjq/events{/privacy}", + "followers_url": "https://api.github.com/users/zeertzjq/followers", + "following_url": "https://api.github.com/users/zeertzjq/following{/other_user}", + "gists_url": "https://api.github.com/users/zeertzjq/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/zeertzjq", + "id": 35768171, + "login": "zeertzjq", + "node_id": "MDQ6VXNlcjM1NzY4MTcx", + "organizations_url": "https://api.github.com/users/zeertzjq/orgs", + "received_events_url": "https://api.github.com/users/zeertzjq/received_events", + "repos_url": "https://api.github.com/users/zeertzjq/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/zeertzjq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/zeertzjq/subscriptions", + "type": "User", + "url": "https://api.github.com/users/zeertzjq" + } +} \ No newline at end of file diff --git a/repositories/neovim/pulls/26438.json b/repositories/neovim/pulls/26438.json new file mode 100644 index 00000000..f6c64c41 --- /dev/null +++ b/repositories/neovim/pulls/26438.json @@ -0,0 +1,362 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26438/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26438/commits" + }, + "html": { + "href": "https://github.com/neovim/neovim/pull/26438" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/neovim/issues/26438" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26438/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/neovim/pulls/26438" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/neovim/statuses/ec80e4cb4d3145a0ab6c3f2820c9f21f2108d5ab" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "MEMBER", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/neovim/branches{/branch}", + "clone_url": "https://github.com/neovim/neovim.git", + "collaborators_url": "https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/neovim/contributors", + "created_at": "2014-01-31T13:39:22Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/neovim/deployments", + "description": "Vim-fork focused on extensibility and usability", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/neovim/downloads", + "events_url": "https://api.github.com/repos/neovim/neovim/events", + "fork": false, + "forks": 5038, + "forks_count": 5038, + "forks_url": "https://api.github.com/repos/neovim/neovim/forks", + "full_name": "neovim/neovim", + "git_commits_url": "https://api.github.com/repos/neovim/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/neovim/git/tags{/sha}", + "git_url": "git://github.com/neovim/neovim.git", + "has_discussions": true, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "https://neovim.io", + "hooks_url": "https://api.github.com/repos/neovim/neovim/hooks", + "html_url": "https://github.com/neovim/neovim", + "id": 16408992, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/neovim/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/neovim/neovim/merges", + "milestones_url": "https://api.github.com/repos/neovim/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==", + "notifications_url": "https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}", + "open_issues": 1707, + "open_issues_count": 1707, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/neovim/pulls{/number}", + "pushed_at": "2023-12-07T01:35:41Z", + "releases_url": "https://api.github.com/repos/neovim/neovim/releases{/id}", + "size": 241695, + "ssh_url": "git@github.com:neovim/neovim.git", + "stargazers_count": 71531, + "stargazers_url": "https://api.github.com/repos/neovim/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/neovim/subscription", + "svn_url": "https://github.com/neovim/neovim", + "tags_url": "https://api.github.com/repos/neovim/neovim/tags", + "teams_url": "https://api.github.com/repos/neovim/neovim/teams", + "topics": [ + "api", + "c", + "lua", + "neovim", + "nvim", + "text-editor", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/neovim/git/trees{/sha}", + "updated_at": "2023-12-07T01:52:10Z", + "url": "https://api.github.com/repos/neovim/neovim", + "visibility": "public", + "watchers": 71531, + "watchers_count": 71531, + "web_commit_signoff_required": false + }, + "sha": "3198598e6974ae2009e816aeb96462cdfc3c59e9", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": "16 bytes is not enough room for existing usage of the buffer by the\ntests, so the name may get truncated and cause log_spec test to fail:\n\n FAILED test/functional/core/log_spec.lua @ 30: log messages are formatted with name or test id\n test/helpers.lua:146: retry() attempts: 51\n test/helpers.lua:155: Pattern \"%.%d+%.%d/c +server_init:%d+: test log message\" not found in log (last 100 lines): Xtest_logging:\n ERR 2023-11-24T23:36:34.252 T1274.2445945.0 server_init:57: test log message\n ERR 2023-11-24T23:36:34.275 T1274.2445945.0 server_init:57: test log message", + "closed_at": null, + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/neovim/issues/26438/comments", + "commits_url": "https://api.github.com/repos/neovim/neovim/pulls/26438/commits", + "created_at": "2023-12-07T00:36:00Z", + "diff_url": "https://github.com/neovim/neovim/pull/26438.diff", + "draft": false, + "head": { + "label": "jamessan:log_spec-name", + "ref": "log_spec-name", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/jamessan/neovim/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/jamessan/neovim/assignees{/user}", + "blobs_url": "https://api.github.com/repos/jamessan/neovim/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/jamessan/neovim/branches{/branch}", + "clone_url": "https://github.com/jamessan/neovim.git", + "collaborators_url": "https://api.github.com/repos/jamessan/neovim/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/jamessan/neovim/comments{/number}", + "commits_url": "https://api.github.com/repos/jamessan/neovim/commits{/sha}", + "compare_url": "https://api.github.com/repos/jamessan/neovim/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/jamessan/neovim/contents/{+path}", + "contributors_url": "https://api.github.com/repos/jamessan/neovim/contributors", + "created_at": "2014-03-13T14:21:51Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/jamessan/neovim/deployments", + "description": "vim's rebirth for the 21st century", + "disabled": false, + "downloads_url": "https://api.github.com/repos/jamessan/neovim/downloads", + "events_url": "https://api.github.com/repos/jamessan/neovim/events", + "fork": true, + "forks": 1, + "forks_count": 1, + "forks_url": "https://api.github.com/repos/jamessan/neovim/forks", + "full_name": "jamessan/neovim", + "git_commits_url": "https://api.github.com/repos/jamessan/neovim/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/jamessan/neovim/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/jamessan/neovim/git/tags{/sha}", + "git_url": "git://github.com/jamessan/neovim.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": false, + "has_wiki": false, + "homepage": "http://neovim.org/", + "hooks_url": "https://api.github.com/repos/jamessan/neovim/hooks", + "html_url": "https://github.com/jamessan/neovim", + "id": 17712569, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/jamessan/neovim/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/jamessan/neovim/issues/events{/number}", + "issues_url": "https://api.github.com/repos/jamessan/neovim/issues{/number}", + "keys_url": "https://api.github.com/repos/jamessan/neovim/keys{/key_id}", + "labels_url": "https://api.github.com/repos/jamessan/neovim/labels{/name}", + "language": "Vim Script", + "languages_url": "https://api.github.com/repos/jamessan/neovim/languages", + "license": { + "key": "other", + "name": "Other", + "node_id": "MDc6TGljZW5zZTA=", + "spdx_id": "NOASSERTION", + "url": null + }, + "merges_url": "https://api.github.com/repos/jamessan/neovim/merges", + "milestones_url": "https://api.github.com/repos/jamessan/neovim/milestones{/number}", + "mirror_url": null, + "name": "neovim", + "node_id": "MDEwOlJlcG9zaXRvcnkxNzcxMjU2OQ==", + "notifications_url": "https://api.github.com/repos/jamessan/neovim/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/112971?v=4", + "events_url": "https://api.github.com/users/jamessan/events{/privacy}", + "followers_url": "https://api.github.com/users/jamessan/followers", + "following_url": "https://api.github.com/users/jamessan/following{/other_user}", + "gists_url": "https://api.github.com/users/jamessan/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/jamessan", + "id": 112971, + "login": "jamessan", + "node_id": "MDQ6VXNlcjExMjk3MQ==", + "organizations_url": "https://api.github.com/users/jamessan/orgs", + "received_events_url": "https://api.github.com/users/jamessan/received_events", + "repos_url": "https://api.github.com/users/jamessan/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/jamessan/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/jamessan/subscriptions", + "type": "User", + "url": "https://api.github.com/users/jamessan" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/jamessan/neovim/pulls{/number}", + "pushed_at": "2023-12-07T00:35:40Z", + "releases_url": "https://api.github.com/repos/jamessan/neovim/releases{/id}", + "size": 236253, + "ssh_url": "git@github.com:jamessan/neovim.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/jamessan/neovim/stargazers", + "statuses_url": "https://api.github.com/repos/jamessan/neovim/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/jamessan/neovim/subscribers", + "subscription_url": "https://api.github.com/repos/jamessan/neovim/subscription", + "svn_url": "https://github.com/jamessan/neovim", + "tags_url": "https://api.github.com/repos/jamessan/neovim/tags", + "teams_url": "https://api.github.com/repos/jamessan/neovim/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/jamessan/neovim/git/trees{/sha}", + "updated_at": "2022-12-09T14:31:18Z", + "url": "https://api.github.com/repos/jamessan/neovim", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "ec80e4cb4d3145a0ab6c3f2820c9f21f2108d5ab", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/112971?v=4", + "events_url": "https://api.github.com/users/jamessan/events{/privacy}", + "followers_url": "https://api.github.com/users/jamessan/followers", + "following_url": "https://api.github.com/users/jamessan/following{/other_user}", + "gists_url": "https://api.github.com/users/jamessan/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/jamessan", + "id": 112971, + "login": "jamessan", + "node_id": "MDQ6VXNlcjExMjk3MQ==", + "organizations_url": "https://api.github.com/users/jamessan/orgs", + "received_events_url": "https://api.github.com/users/jamessan/received_events", + "repos_url": "https://api.github.com/users/jamessan/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/jamessan/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/jamessan/subscriptions", + "type": "User", + "url": "https://api.github.com/users/jamessan" + } + }, + "html_url": "https://github.com/neovim/neovim/pull/26438", + "id": 1633476286, + "issue_url": "https://api.github.com/repos/neovim/neovim/issues/26438", + "labels": [ + { + "color": "fef2c0", + "default": false, + "description": "", + "id": 5363823255, + "name": "backport release-0.9", + "node_id": "LA_kwDOAPphoM8AAAABP7Vylw", + "url": "https://api.github.com/repos/neovim/neovim/labels/backport%20release-0.9" + } + ], + "locked": false, + "merge_commit_sha": "418cd97d09f39d5288957d6722c1d08339187b71", + "merged_at": null, + "milestone": null, + "node_id": "PR_kwDOAPphoM5hXN6-", + "number": 26438, + "patch_url": "https://github.com/neovim/neovim/pull/26438.patch", + "requested_reviewers": [], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/neovim/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/neovim/pulls/26438/comments", + "state": "open", + "statuses_url": "https://api.github.com/repos/neovim/neovim/statuses/ec80e4cb4d3145a0ab6c3f2820c9f21f2108d5ab", + "title": "fix(log): increase size of buffer for nvim instance name", + "updated_at": "2023-12-07T01:15:21Z", + "url": "https://api.github.com/repos/neovim/neovim/pulls/26438", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/112971?v=4", + "events_url": "https://api.github.com/users/jamessan/events{/privacy}", + "followers_url": "https://api.github.com/users/jamessan/followers", + "following_url": "https://api.github.com/users/jamessan/following{/other_user}", + "gists_url": "https://api.github.com/users/jamessan/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/jamessan", + "id": 112971, + "login": "jamessan", + "node_id": "MDQ6VXNlcjExMjk3MQ==", + "organizations_url": "https://api.github.com/users/jamessan/orgs", + "received_events_url": "https://api.github.com/users/jamessan/received_events", + "repos_url": "https://api.github.com/users/jamessan/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/jamessan/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/jamessan/subscriptions", + "type": "User", + "url": "https://api.github.com/users/jamessan" + } +} \ No newline at end of file diff --git a/repositories/nvim-lspconfig/issues/1220.json b/repositories/nvim-lspconfig/issues/1220.json new file mode 100644 index 00000000..9b967a2e --- /dev/null +++ b/repositories/nvim-lspconfig/issues/1220.json @@ -0,0 +1,248 @@ +{ + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "NONE", + "body": "\r\n\r\n- `nvim --version`:\r\n NVIM v0.5.0\r\n Build type: Release\r\n LuaJIT 2.0.5\r\n- nvim-lspconfig version(commit hash):\r\n 2f026f2177bff7c9599d8dc561a4bdb30626ad9c\r\n- Can you reproduce this behavior on other language servers offered in the nvim-lspconfig repo? (pyls -> pyright): lhs and texlab\r\n- Is the problem isolated to a particular language server: no\r\n- Operating system/version: archlinux\r\n\r\n### How to reproduce the problem from neovim startup\r\n:LspStop\r\n:setfiletype text.lhaskell\r\n:LspStart\r\n\r\n### Actual behaviour\r\nNo lsp started.\r\nUI remarks both fileytpes as detected\r\n```\r\n Language client log: /home/omega16/.cache/nvim/lsp.log\r\n Detected filetype: tex.lhaskell\r\n \r\n 0 client(s) attached to this buffer: \r\n \r\n Configured servers list: texlab, hls\r\n\r\n```\r\n\r\n\r\n### Expected behaviour\r\nRun at least one of lhs or texlab\r\n\r\n### Minimal init.vim or init.lua and code sample\r\n```\r\nrequire'lspconfig'.texlab.setup{\r\n settings = {\r\n texlab = {\r\n auxDirectory = \".\",\r\n bibtexFormatter = \"texlab\",\r\n build = {\r\n args = { \"-pdf\", \"-interaction=nonstopmode\", \"-synctex=1\", \"%f\" },\r\n executable = \"lualatex\",\r\n forwardSearchAfter = false,\r\n onSave = false\r\n },\r\n chktex = {\r\n onEdit = false,\r\n onOpenAndSave = false\r\n },\r\n diagnosticsDelay = 300,\r\n formatterLineLength = 80,\r\n forwardSearch = {\r\n args = {}\r\n },\r\n latexFormatter = \"latexindent\",\r\n latexindent = {\r\n modifyLineBreaks = false\r\n }\r\n }\r\n }\r\n}\r\n\r\n\r\n\r\n\r\nrequire'lspconfig'.hls.setup{default_config = {\r\n cmd = { 'haskell-language-server-wrapper', '--lsp' },\r\n filetypes = { 'haskell', 'lhaskell'},\r\n root_dir = require('lspconfig/util').root_pattern('*.cabal', 'stack.yaml', 'cabal.project', 'package.yaml', 'hie.yaml')\r\n }\r\n}\r\n```\r\n\r\n### Health check\r\n
\r\n\r\n\r\n```\r\nhealth#lspconfig#check\r\n========================================================================\r\n## Checking language server protocol configuration\r\n - INFO: texlab: configuration checked.\r\n - INFO: hls: configuration checked.\r\n```\r\n
\r\n\r\n\r\n\r\nI'm attempting to write pandoc markdown, latex and lhaskell in the same file. \r\nBoth texlab and lhs work if I set the filetype to tex or lhaskell.\r\n\r\n\r\n\r\nAs a side note: Thanks to all of you, having an easy way to config all my lsp in neovim is pretty nice! ", + "closed_at": "2021-09-05T01:19:14Z", + "comment_data": [ + { + "author_association": "CONTRIBUTOR", + "body": "If you want both language servers, modify the filetypes of the language servers in setup{} to operate on both filetypes", + "created_at": "2021-09-05T01:19:11Z", + "html_url": "https://github.com/neovim/nvim-lspconfig/issues/1220#issuecomment-913065809", + "id": 913065809, + "issue_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220", + "node_id": "IC_kwDODTQC1842bEdR", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/913065809/reactions" + }, + "updated_at": "2021-09-05T01:19:11Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/913065809", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/13316262?v=4", + "events_url": "https://api.github.com/users/mjlbach/events{/privacy}", + "followers_url": "https://api.github.com/users/mjlbach/followers", + "following_url": "https://api.github.com/users/mjlbach/following{/other_user}", + "gists_url": "https://api.github.com/users/mjlbach/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/mjlbach", + "id": 13316262, + "login": "mjlbach", + "node_id": "MDQ6VXNlcjEzMzE2MjYy", + "organizations_url": "https://api.github.com/users/mjlbach/orgs", + "received_events_url": "https://api.github.com/users/mjlbach/received_events", + "repos_url": "https://api.github.com/users/mjlbach/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/mjlbach/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mjlbach/subscriptions", + "type": "User", + "url": "https://api.github.com/users/mjlbach" + } + }, + { + "author_association": "NONE", + "body": "I append \r\n`tex.lhaskell, lhaskell.tex`\r\n\r\n if I open \"some.latex\" and set \r\n`:setfiletype tex.lhaskell`\r\n\r\nit just starts texlab \r\n```\r\n\r\n Language client log: /home/anon/.cache/nvim/lsp.log\r\n Detected filetype: tex.lhaskell\r\n \r\n 0 client(s) attached to this buffer: \r\n \r\n Configured servers list: texlab, hls\r\n```\r\n\r\n\r\nSame if i run\r\n`:setfiletype lhaskell.tex`\r\n\r\nNow if i just run \r\n`:setfiletype lhaskell`\r\n\r\nboth of them start\r\n```\r\n Language client log: /home/anon/.cache/nvim/lsp.log\r\n Detected filetype: lhaskell\r\n \r\n 2 client(s) attached to this buffer: \r\n \r\n Client: texlab (id: 1, pid: 18765, bufnr: [1, 1])\r\n \tfiletypes: tex, tex.lhaskell, lhaskell.text\r\n \tautostart: true\r\n \troot directory: /home/anon/projects/anon\r\n \tcmd: texlab\r\n \r\n Client: hls (id: 2, pid: 18859, bufnr: [1])\r\n \tfiletypes: haskell, lhaskell\r\n \tautostart: true\r\n \troot directory: /home/anon/projects/anon\r\n \tcmd: haskell-language-server-wrapper --lsp\r\n \tversion: haskell-language-server version: 1.3.0.0 (GHC: 8.10.4) (PATH: /home/anon/.ghcup/bin/haskell-language-server-wrapper-1.3.0) (GIT hash: e7c5e90b6df5dff2760d76169eddaea3bdd6a831)\r\n \r\n Configured servers list: texlab, hls\r\n```", + "created_at": "2021-09-05T01:34:01Z", + "html_url": "https://github.com/neovim/nvim-lspconfig/issues/1220#issuecomment-913067941", + "id": 913067941, + "issue_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220", + "node_id": "IC_kwDODTQC1842bE-l", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/913067941/reactions" + }, + "updated_at": "2021-09-05T01:34:01Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/913067941", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/73986926?v=4", + "events_url": "https://api.github.com/users/Luis-omega/events{/privacy}", + "followers_url": "https://api.github.com/users/Luis-omega/followers", + "following_url": "https://api.github.com/users/Luis-omega/following{/other_user}", + "gists_url": "https://api.github.com/users/Luis-omega/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Luis-omega", + "id": 73986926, + "login": "Luis-omega", + "node_id": "MDQ6VXNlcjczOTg2OTI2", + "organizations_url": "https://api.github.com/users/Luis-omega/orgs", + "received_events_url": "https://api.github.com/users/Luis-omega/received_events", + "repos_url": "https://api.github.com/users/Luis-omega/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Luis-omega/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Luis-omega/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Luis-omega" + } + }, + { + "author_association": "NONE", + "body": "To be clear, in the lat response i added `tex.lhaskell, lhaskell.tex` to both configs.\r\n\r\n` filetypes = {'tex','tex.lhaskell', 'lhaskell.tex'},`\r\n\r\n` filetypes = { 'haskell', 'lhaskell', 'tex.lhaskell', 'lhaskell.tex' },`", + "created_at": "2021-09-05T01:37:06Z", + "html_url": "https://github.com/neovim/nvim-lspconfig/issues/1220#issuecomment-913068542", + "id": 913068542, + "issue_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220", + "node_id": "IC_kwDODTQC1842bFH-", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/913068542/reactions" + }, + "updated_at": "2021-09-05T01:37:06Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/913068542", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/73986926?v=4", + "events_url": "https://api.github.com/users/Luis-omega/events{/privacy}", + "followers_url": "https://api.github.com/users/Luis-omega/followers", + "following_url": "https://api.github.com/users/Luis-omega/following{/other_user}", + "gists_url": "https://api.github.com/users/Luis-omega/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Luis-omega", + "id": 73986926, + "login": "Luis-omega", + "node_id": "MDQ6VXNlcjczOTg2OTI2", + "organizations_url": "https://api.github.com/users/Luis-omega/orgs", + "received_events_url": "https://api.github.com/users/Luis-omega/received_events", + "repos_url": "https://api.github.com/users/Luis-omega/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Luis-omega/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Luis-omega/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Luis-omega" + } + }, + { + "author_association": "NONE", + "body": "@mjlbach Are you sure nvim-lspconfig shouldn't split the filetype automatically? Both https://github.com/nvimtools/none-ls.nvim and https://github.com/dense-analysis/ale do this, (n)vim does this for syntax, ftplugins, etc. as well, it's just nvim-lspconfig that for some reason can't handle this…", + "created_at": "2023-12-06T23:15:40Z", + "html_url": "https://github.com/neovim/nvim-lspconfig/issues/1220#issuecomment-1843840657", + "id": 1843840657, + "issue_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220", + "node_id": "IC_kwDODTQC185t5saR", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/1843840657/reactions" + }, + "updated_at": "2023-12-06T23:15:40Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/1843840657", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/300342?v=4", + "events_url": "https://api.github.com/users/liskin/events{/privacy}", + "followers_url": "https://api.github.com/users/liskin/followers", + "following_url": "https://api.github.com/users/liskin/following{/other_user}", + "gists_url": "https://api.github.com/users/liskin/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/liskin", + "id": 300342, + "login": "liskin", + "node_id": "MDQ6VXNlcjMwMDM0Mg==", + "organizations_url": "https://api.github.com/users/liskin/orgs", + "received_events_url": "https://api.github.com/users/liskin/received_events", + "repos_url": "https://api.github.com/users/liskin/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/liskin/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/liskin/subscriptions", + "type": "User", + "url": "https://api.github.com/users/liskin" + } + } + ], + "comments": 4, + "comments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220/comments", + "created_at": "2021-09-05T01:13:29Z", + "events_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220/events", + "html_url": "https://github.com/neovim/nvim-lspconfig/issues/1220", + "id": 988398691, + "labels": [ + { + "color": "f9d0c4", + "default": true, + "description": "Something isn't working", + "id": 1674892761, + "name": "bug", + "node_id": "MDU6TGFiZWwxNjc0ODkyNzYx", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/labels/bug" + } + ], + "labels_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220/labels{/name}", + "locked": false, + "milestone": null, + "node_id": "MDU6SXNzdWU5ODgzOTg2OTE=", + "number": 1220, + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220/reactions" + }, + "repository_url": "https://api.github.com/repos/neovim/nvim-lspconfig", + "state": "closed", + "state_reason": "completed", + "timeline_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220/timeline", + "title": "multiple filetype fails", + "updated_at": "2023-12-06T23:15:41Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/1220", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/73986926?v=4", + "events_url": "https://api.github.com/users/Luis-omega/events{/privacy}", + "followers_url": "https://api.github.com/users/Luis-omega/followers", + "following_url": "https://api.github.com/users/Luis-omega/following{/other_user}", + "gists_url": "https://api.github.com/users/Luis-omega/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/Luis-omega", + "id": 73986926, + "login": "Luis-omega", + "node_id": "MDQ6VXNlcjczOTg2OTI2", + "organizations_url": "https://api.github.com/users/Luis-omega/orgs", + "received_events_url": "https://api.github.com/users/Luis-omega/received_events", + "repos_url": "https://api.github.com/users/Luis-omega/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/Luis-omega/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Luis-omega/subscriptions", + "type": "User", + "url": "https://api.github.com/users/Luis-omega" + } +} \ No newline at end of file diff --git a/repositories/nvim-lspconfig/issues/2765.json b/repositories/nvim-lspconfig/issues/2765.json index 13ef2460..5f853ade 100644 --- a/repositories/nvim-lspconfig/issues/2765.json +++ b/repositories/nvim-lspconfig/issues/2765.json @@ -357,9 +357,53 @@ "type": "User", "url": "https://api.github.com/users/rickboks" } + }, + { + "author_association": "NONE", + "body": "@stvhuang @rickboks check the issue I opened on the pyright repo here https://github.com/microsoft/pylance-release/issues/5220. It seems that this is a pyright issue and that VS Code just happens to be de-duplicating them on its own!", + "created_at": "2023-12-06T18:52:12Z", + "html_url": "https://github.com/neovim/nvim-lspconfig/issues/2765#issuecomment-1843505437", + "id": 1843505437, + "issue_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2765", + "node_id": "IC_kwDODTQC185t4akd", + "performed_via_github_app": null, + "reactions": { + "+1": 0, + "-1": 0, + "confused": 0, + "eyes": 0, + "heart": 0, + "hooray": 0, + "laugh": 0, + "rocket": 0, + "total_count": 0, + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/1843505437/reactions" + }, + "updated_at": "2023-12-06T18:52:12Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments/1843505437", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/92899389?v=4", + "events_url": "https://api.github.com/users/carschandler/events{/privacy}", + "followers_url": "https://api.github.com/users/carschandler/followers", + "following_url": "https://api.github.com/users/carschandler/following{/other_user}", + "gists_url": "https://api.github.com/users/carschandler/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/carschandler", + "id": 92899389, + "login": "carschandler", + "node_id": "U_kgDOBYmIPQ", + "organizations_url": "https://api.github.com/users/carschandler/orgs", + "received_events_url": "https://api.github.com/users/carschandler/received_events", + "repos_url": "https://api.github.com/users/carschandler/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/carschandler/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/carschandler/subscriptions", + "type": "User", + "url": "https://api.github.com/users/carschandler" + } } ], - "comments": 8, + "comments": 9, "comments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2765/comments", "created_at": "2023-08-15T18:06:27Z", "events_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2765/events", @@ -399,7 +443,7 @@ "state_reason": "not_planned", "timeline_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2765/timeline", "title": "List of references is duplicated for pyright", - "updated_at": "2023-10-23T12:09:25Z", + "updated_at": "2023-12-06T19:14:10Z", "url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2765", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/92899389?v=4", diff --git a/repositories/nvim-lspconfig/pulls/2923.json b/repositories/nvim-lspconfig/pulls/2923.json index 8b612ddd..ebdba472 100644 --- a/repositories/nvim-lspconfig/pulls/2923.json +++ b/repositories/nvim-lspconfig/pulls/2923.json @@ -28,7 +28,7 @@ "active_lock_reason": null, "assignee": null, "assignees": [], - "author_association": "FIRST_TIME_CONTRIBUTOR", + "author_association": "CONTRIBUTOR", "auto_merge": null, "base": { "label": "neovim:master", @@ -94,8 +94,8 @@ "name": "nvim-lspconfig", "node_id": "MDEwOlJlcG9zaXRvcnkyMjE1MTI0MDc=", "notifications_url": "https://api.github.com/repos/neovim/nvim-lspconfig/notifications{?since,all,participating}", - "open_issues": 54, - "open_issues_count": 54, + "open_issues": 53, + "open_issues_count": 53, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls{/number}", - "pushed_at": "2023-12-05T14:48:26Z", + "pushed_at": "2023-12-06T10:08:25Z", "releases_url": "https://api.github.com/repos/neovim/nvim-lspconfig/releases{/id}", - "size": 3453, + "size": 3463, "ssh_url": "git@github.com:neovim/nvim-lspconfig.git", - "stargazers_count": 8493, + "stargazers_count": 8499, "stargazers_url": "https://api.github.com/repos/neovim/nvim-lspconfig/stargazers", "statuses_url": "https://api.github.com/repos/neovim/nvim-lspconfig/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/nvim-lspconfig/subscribers", @@ -140,11 +140,11 @@ "vim" ], "trees_url": "https://api.github.com/repos/neovim/nvim-lspconfig/git/trees{/sha}", - "updated_at": "2023-12-06T01:25:21Z", + "updated_at": "2023-12-06T23:46:44Z", "url": "https://api.github.com/repos/neovim/nvim-lspconfig", "visibility": "public", - "watchers": 8493, - "watchers_count": 8493, + "watchers": 8499, + "watchers_count": 8499, "web_commit_signoff_required": false }, "sha": "cf3dd4a290084a868fac0e2e876039321d57111c", @@ -170,7 +170,7 @@ } }, "body": "Ref. #2716. The referenced PR changes got somehow lost when it came to the removal of the `on_new_config` function.\r\n\r\ncc. @gongfarmer ", - "closed_at": null, + "closed_at": "2023-12-06T08:57:05Z", "comment_data": [], "comment_regular_data": [], "comments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2923/comments", @@ -266,9 +266,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/waiting-for-dev/nvim-lspconfig/pulls{/number}", - "pushed_at": "2023-12-05T14:47:51Z", + "pushed_at": "2023-12-06T14:06:53Z", "releases_url": "https://api.github.com/repos/waiting-for-dev/nvim-lspconfig/releases{/id}", - "size": 3463, + "size": 3453, "ssh_url": "git@github.com:waiting-for-dev/nvim-lspconfig.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/waiting-for-dev/nvim-lspconfig/stargazers", @@ -314,8 +314,8 @@ "issue_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2923", "labels": [], "locked": false, - "merge_commit_sha": "2d4e4abcb1c0d91893e8429ec6dfde7aff4fa492", - "merged_at": null, + "merge_commit_sha": "53ff4f7358bcace4355edc2855b9671a38e82cd2", + "merged_at": "2023-12-06T08:57:05Z", "milestone": null, "node_id": "PR_kwDODTQC185hMET6", "number": 2923, @@ -345,10 +345,10 @@ "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2923/comments", - "state": "open", + "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/nvim-lspconfig/statuses/f830cbba03824f13e3c9144b10c61df94da05001", "title": "fix(rubocop): don't auto-detect bundler, to avoid surprising configuration behavior", - "updated_at": "2023-12-05T14:48:26Z", + "updated_at": "2023-12-06T14:06:53Z", "url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2923", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/52650?v=4", diff --git a/repositories/nvim-lspconfig/pulls/2924.json b/repositories/nvim-lspconfig/pulls/2924.json new file mode 100644 index 00000000..372d1425 --- /dev/null +++ b/repositories/nvim-lspconfig/pulls/2924.json @@ -0,0 +1,373 @@ +{ + "_links": { + "comments": { + "href": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2924/comments" + }, + "commits": { + "href": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2924/commits" + }, + "html": { + "href": "https://github.com/neovim/nvim-lspconfig/pull/2924" + }, + "issue": { + "href": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2924" + }, + "review_comment": { + "href": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/comments{/number}" + }, + "review_comments": { + "href": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2924/comments" + }, + "self": { + "href": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2924" + }, + "statuses": { + "href": "https://api.github.com/repos/neovim/nvim-lspconfig/statuses/2dbeb5bb412782777f3815ac3f14664f85bccb72" + } + }, + "active_lock_reason": null, + "assignee": null, + "assignees": [], + "author_association": "CONTRIBUTOR", + "auto_merge": null, + "base": { + "label": "neovim:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/neovim/nvim-lspconfig/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/neovim/nvim-lspconfig/assignees{/user}", + "blobs_url": "https://api.github.com/repos/neovim/nvim-lspconfig/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/neovim/nvim-lspconfig/branches{/branch}", + "clone_url": "https://github.com/neovim/nvim-lspconfig.git", + "collaborators_url": "https://api.github.com/repos/neovim/nvim-lspconfig/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/comments{/number}", + "commits_url": "https://api.github.com/repos/neovim/nvim-lspconfig/commits{/sha}", + "compare_url": "https://api.github.com/repos/neovim/nvim-lspconfig/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/neovim/nvim-lspconfig/contents/{+path}", + "contributors_url": "https://api.github.com/repos/neovim/nvim-lspconfig/contributors", + "created_at": "2019-11-13T17:12:28Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/deployments", + "description": "Quickstart configs for Nvim LSP", + "disabled": false, + "downloads_url": "https://api.github.com/repos/neovim/nvim-lspconfig/downloads", + "events_url": "https://api.github.com/repos/neovim/nvim-lspconfig/events", + "fork": false, + "forks": 1946, + "forks_count": 1946, + "forks_url": "https://api.github.com/repos/neovim/nvim-lspconfig/forks", + "full_name": "neovim/nvim-lspconfig", + "git_commits_url": "https://api.github.com/repos/neovim/nvim-lspconfig/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/neovim/nvim-lspconfig/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/neovim/nvim-lspconfig/git/tags{/sha}", + "git_url": "git://github.com/neovim/nvim-lspconfig.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": true, + "has_pages": false, + "has_projects": false, + "has_wiki": true, + "homepage": "", + "hooks_url": "https://api.github.com/repos/neovim/nvim-lspconfig/hooks", + "html_url": "https://github.com/neovim/nvim-lspconfig", + "id": 221512407, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/events{/number}", + "issues_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues{/number}", + "keys_url": "https://api.github.com/repos/neovim/nvim-lspconfig/keys{/key_id}", + "labels_url": "https://api.github.com/repos/neovim/nvim-lspconfig/labels{/name}", + "language": "Lua", + "languages_url": "https://api.github.com/repos/neovim/nvim-lspconfig/languages", + "license": { + "key": "apache-2.0", + "name": "Apache License 2.0", + "node_id": "MDc6TGljZW5zZTI=", + "spdx_id": "Apache-2.0", + "url": "https://api.github.com/licenses/apache-2.0" + }, + "merges_url": "https://api.github.com/repos/neovim/nvim-lspconfig/merges", + "milestones_url": "https://api.github.com/repos/neovim/nvim-lspconfig/milestones{/number}", + "mirror_url": null, + "name": "nvim-lspconfig", + "node_id": "MDEwOlJlcG9zaXRvcnkyMjE1MTI0MDc=", + "notifications_url": "https://api.github.com/repos/neovim/nvim-lspconfig/notifications{?since,all,participating}", + "open_issues": 53, + "open_issues_count": 53, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls{/number}", + "pushed_at": "2023-12-06T10:08:25Z", + "releases_url": "https://api.github.com/repos/neovim/nvim-lspconfig/releases{/id}", + "size": 3463, + "ssh_url": "git@github.com:neovim/nvim-lspconfig.git", + "stargazers_count": 8499, + "stargazers_url": "https://api.github.com/repos/neovim/nvim-lspconfig/stargazers", + "statuses_url": "https://api.github.com/repos/neovim/nvim-lspconfig/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/neovim/nvim-lspconfig/subscribers", + "subscription_url": "https://api.github.com/repos/neovim/nvim-lspconfig/subscription", + "svn_url": "https://github.com/neovim/nvim-lspconfig", + "tags_url": "https://api.github.com/repos/neovim/nvim-lspconfig/tags", + "teams_url": "https://api.github.com/repos/neovim/nvim-lspconfig/teams", + "topics": [ + "language-server", + "language-server-protocol", + "lsp", + "neovim", + "nvim", + "plugin", + "vim" + ], + "trees_url": "https://api.github.com/repos/neovim/nvim-lspconfig/git/trees{/sha}", + "updated_at": "2023-12-06T23:46:44Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig", + "visibility": "public", + "watchers": 8499, + "watchers_count": 8499, + "web_commit_signoff_required": false + }, + "sha": "53ff4f7358bcace4355edc2855b9671a38e82cd2", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", + "events_url": "https://api.github.com/users/neovim/events{/privacy}", + "followers_url": "https://api.github.com/users/neovim/followers", + "following_url": "https://api.github.com/users/neovim/following{/other_user}", + "gists_url": "https://api.github.com/users/neovim/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/neovim", + "id": 6471485, + "login": "neovim", + "node_id": "MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=", + "organizations_url": "https://api.github.com/users/neovim/orgs", + "received_events_url": "https://api.github.com/users/neovim/received_events", + "repos_url": "https://api.github.com/users/neovim/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/neovim/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/neovim/subscriptions", + "type": "Organization", + "url": "https://api.github.com/users/neovim" + } + }, + "body": null, + "closed_at": "2023-12-06T10:08:25Z", + "comment_data": [], + "comment_regular_data": [], + "comments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2924/comments", + "commits_url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2924/commits", + "created_at": "2023-12-06T09:55:38Z", + "diff_url": "https://github.com/neovim/nvim-lspconfig/pull/2924.diff", + "draft": false, + "head": { + "label": "StenAL:master", + "ref": "master", + "repo": { + "allow_forking": true, + "archive_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/{archive_format}{/ref}", + "archived": false, + "assignees_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/assignees{/user}", + "blobs_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/git/blobs{/sha}", + "branches_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/branches{/branch}", + "clone_url": "https://github.com/StenAL/nvim-lspconfig.git", + "collaborators_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/collaborators{/collaborator}", + "comments_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/comments{/number}", + "commits_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/commits{/sha}", + "compare_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/compare/{base}...{head}", + "contents_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/contents/{+path}", + "contributors_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/contributors", + "created_at": "2023-12-06T09:51:41Z", + "default_branch": "master", + "deployments_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/deployments", + "description": "Quickstart configs for Nvim LSP", + "disabled": true, + "downloads_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/downloads", + "events_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/events", + "fork": true, + "forks": 0, + "forks_count": 0, + "forks_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/forks", + "full_name": "StenAL/nvim-lspconfig", + "git_commits_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/git/commits{/sha}", + "git_refs_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/git/refs{/sha}", + "git_tags_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/git/tags{/sha}", + "git_url": "git://github.com/StenAL/nvim-lspconfig.git", + "has_discussions": false, + "has_downloads": true, + "has_issues": false, + "has_pages": false, + "has_projects": true, + "has_wiki": true, + "homepage": "", + "hooks_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/hooks", + "html_url": "https://github.com/StenAL/nvim-lspconfig", + "id": 728133069, + "is_template": false, + "issue_comment_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/issues/comments{/number}", + "issue_events_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/issues/events{/number}", + "issues_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/issues{/number}", + "keys_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/keys{/key_id}", + "labels_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/labels{/name}", + "language": "Lua", + "languages_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/languages", + "license": { + "key": "apache-2.0", + "name": "Apache License 2.0", + "node_id": "MDc6TGljZW5zZTI=", + "spdx_id": "Apache-2.0", + "url": "https://api.github.com/licenses/apache-2.0" + }, + "merges_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/merges", + "milestones_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/milestones{/number}", + "mirror_url": null, + "name": "nvim-lspconfig", + "node_id": "R_kgDOK2ZtzQ", + "notifications_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/notifications{?since,all,participating}", + "open_issues": 0, + "open_issues_count": 0, + "owner": { + "avatar_url": "https://avatars.githubusercontent.com/u/21343173?v=4", + "events_url": "https://api.github.com/users/StenAL/events{/privacy}", + "followers_url": "https://api.github.com/users/StenAL/followers", + "following_url": "https://api.github.com/users/StenAL/following{/other_user}", + "gists_url": "https://api.github.com/users/StenAL/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/StenAL", + "id": 21343173, + "login": "StenAL", + "node_id": "MDQ6VXNlcjIxMzQzMTcz", + "organizations_url": "https://api.github.com/users/StenAL/orgs", + "received_events_url": "https://api.github.com/users/StenAL/received_events", + "repos_url": "https://api.github.com/users/StenAL/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/StenAL/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/StenAL/subscriptions", + "type": "User", + "url": "https://api.github.com/users/StenAL" + }, + "private": false, + "pulls_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/pulls{/number}", + "pushed_at": "2023-12-06T09:53:59Z", + "releases_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/releases{/id}", + "size": 3463, + "ssh_url": "git@github.com:StenAL/nvim-lspconfig.git", + "stargazers_count": 0, + "stargazers_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/stargazers", + "statuses_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/statuses/{sha}", + "subscribers_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/subscribers", + "subscription_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/subscription", + "svn_url": "https://github.com/StenAL/nvim-lspconfig", + "tags_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/tags", + "teams_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/teams", + "topics": [], + "trees_url": "https://api.github.com/repos/StenAL/nvim-lspconfig/git/trees{/sha}", + "updated_at": "2023-12-06T11:17:36Z", + "url": "https://api.github.com/repos/StenAL/nvim-lspconfig", + "visibility": "public", + "watchers": 0, + "watchers_count": 0, + "web_commit_signoff_required": false + }, + "sha": "2dbeb5bb412782777f3815ac3f14664f85bccb72", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/21343173?v=4", + "events_url": "https://api.github.com/users/StenAL/events{/privacy}", + "followers_url": "https://api.github.com/users/StenAL/followers", + "following_url": "https://api.github.com/users/StenAL/following{/other_user}", + "gists_url": "https://api.github.com/users/StenAL/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/StenAL", + "id": 21343173, + "login": "StenAL", + "node_id": "MDQ6VXNlcjIxMzQzMTcz", + "organizations_url": "https://api.github.com/users/StenAL/orgs", + "received_events_url": "https://api.github.com/users/StenAL/received_events", + "repos_url": "https://api.github.com/users/StenAL/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/StenAL/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/StenAL/subscriptions", + "type": "User", + "url": "https://api.github.com/users/StenAL" + } + }, + "html_url": "https://github.com/neovim/nvim-lspconfig/pull/2924", + "id": 1632151015, + "issue_url": "https://api.github.com/repos/neovim/nvim-lspconfig/issues/2924", + "labels": [], + "locked": false, + "merge_commit_sha": "6c797ff9324094e333e2ace9526ca4a62ad9d1ca", + "merged_at": "2023-12-06T10:08:25Z", + "milestone": null, + "node_id": "PR_kwDODTQC185hSKXn", + "number": 2924, + "patch_url": "https://github.com/neovim/nvim-lspconfig/pull/2924.patch", + "requested_reviewers": [ + { + "avatar_url": "https://avatars.githubusercontent.com/u/41671631?v=4", + "events_url": "https://api.github.com/users/glepnir/events{/privacy}", + "followers_url": "https://api.github.com/users/glepnir/followers", + "following_url": "https://api.github.com/users/glepnir/following{/other_user}", + "gists_url": "https://api.github.com/users/glepnir/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/glepnir", + "id": 41671631, + "login": "glepnir", + "node_id": "MDQ6VXNlcjQxNjcxNjMx", + "organizations_url": "https://api.github.com/users/glepnir/orgs", + "received_events_url": "https://api.github.com/users/glepnir/received_events", + "repos_url": "https://api.github.com/users/glepnir/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/glepnir/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/glepnir/subscriptions", + "type": "User", + "url": "https://api.github.com/users/glepnir" + } + ], + "requested_teams": [], + "review_comment_url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/comments{/number}", + "review_comments_url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2924/comments", + "state": "closed", + "statuses_url": "https://api.github.com/repos/neovim/nvim-lspconfig/statuses/2dbeb5bb412782777f3815ac3f14664f85bccb72", + "title": "docs: fix grammar in lspconfig.txt EXAMPLE KEYBINDIGS section", + "updated_at": "2023-12-06T10:08:25Z", + "url": "https://api.github.com/repos/neovim/nvim-lspconfig/pulls/2924", + "user": { + "avatar_url": "https://avatars.githubusercontent.com/u/21343173?v=4", + "events_url": "https://api.github.com/users/StenAL/events{/privacy}", + "followers_url": "https://api.github.com/users/StenAL/followers", + "following_url": "https://api.github.com/users/StenAL/following{/other_user}", + "gists_url": "https://api.github.com/users/StenAL/gists{/gist_id}", + "gravatar_id": "", + "html_url": "https://github.com/StenAL", + "id": 21343173, + "login": "StenAL", + "node_id": "MDQ6VXNlcjIxMzQzMTcz", + "organizations_url": "https://api.github.com/users/StenAL/orgs", + "received_events_url": "https://api.github.com/users/StenAL/received_events", + "repos_url": "https://api.github.com/users/StenAL/repos", + "site_admin": false, + "starred_url": "https://api.github.com/users/StenAL/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/StenAL/subscriptions", + "type": "User", + "url": "https://api.github.com/users/StenAL" + } +} \ No newline at end of file diff --git a/repositories/pynvim/pulls/544.json b/repositories/pynvim/pulls/544.json index ce6dd295..cd8259f7 100644 --- a/repositories/pynvim/pulls/544.json +++ b/repositories/pynvim/pulls/544.json @@ -94,8 +94,8 @@ "name": "pynvim", "node_id": "MDEwOlJlcG9zaXRvcnkxOTU0ODc1MA==", "notifications_url": "https://api.github.com/repos/neovim/pynvim/notifications{?since,all,participating}", - "open_issues": 51, - "open_issues_count": 51, + "open_issues": 50, + "open_issues_count": 50, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/6471485?v=4", "events_url": "https://api.github.com/users/neovim/events{/privacy}", @@ -118,11 +118,11 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/neovim/pynvim/pulls{/number}", - "pushed_at": "2023-12-06T01:11:38Z", + "pushed_at": "2023-12-06T02:10:06Z", "releases_url": "https://api.github.com/repos/neovim/pynvim/releases{/id}", - "size": 705, + "size": 704, "ssh_url": "git@github.com:neovim/pynvim.git", - "stargazers_count": 1368, + "stargazers_count": 1370, "stargazers_url": "https://api.github.com/repos/neovim/pynvim/stargazers", "statuses_url": "https://api.github.com/repos/neovim/pynvim/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/neovim/pynvim/subscribers", @@ -132,11 +132,11 @@ "teams_url": "https://api.github.com/repos/neovim/pynvim/teams", "topics": [], "trees_url": "https://api.github.com/repos/neovim/pynvim/git/trees{/sha}", - "updated_at": "2023-12-05T10:21:54Z", + "updated_at": "2023-12-06T18:50:34Z", "url": "https://api.github.com/repos/neovim/pynvim", "visibility": "public", - "watchers": 1368, - "watchers_count": 1368, + "watchers": 1370, + "watchers_count": 1370, "web_commit_signoff_required": false }, "sha": "a699fe737a902ca76176b437fecc8e38d37b8e6d", @@ -162,7 +162,7 @@ } }, "body": null, - "closed_at": null, + "closed_at": "2023-12-06T02:10:06Z", "comment_data": [], "comment_regular_data": [ { @@ -267,11 +267,11 @@ "-1": 0, "confused": 0, "eyes": 0, - "heart": 0, + "heart": 1, "hooray": 0, "laugh": 0, "rocket": 0, - "total_count": 0, + "total_count": 1, "url": "https://api.github.com/repos/neovim/pynvim/issues/comments/1841909846/reactions" }, "updated_at": "2023-12-06T01:09:11Z", @@ -391,9 +391,9 @@ }, "private": false, "pulls_url": "https://api.github.com/repos/wookayin/pynvim/pulls{/number}", - "pushed_at": "2023-12-06T01:11:36Z", + "pushed_at": "2023-12-06T07:27:26Z", "releases_url": "https://api.github.com/repos/wookayin/pynvim/releases{/id}", - "size": 694, + "size": 703, "ssh_url": "git@github.com:wookayin/pynvim.git", "stargazers_count": 0, "stargazers_url": "https://api.github.com/repos/wookayin/pynvim/stargazers", @@ -439,8 +439,8 @@ "issue_url": "https://api.github.com/repos/neovim/pynvim/issues/544", "labels": [], "locked": false, - "merge_commit_sha": "37cf138945ad34d9ec8f89990d3b38bc37dafbea", - "merged_at": null, + "merge_commit_sha": "e74a7f6b9952b584ac3ba223b4da333500b3c444", + "merged_at": "2023-12-06T02:10:06Z", "milestone": null, "node_id": "PR_kwDOASpKTs5c8Ghn", "number": 544, @@ -449,10 +449,10 @@ "requested_teams": [], "review_comment_url": "https://api.github.com/repos/neovim/pynvim/pulls/comments{/number}", "review_comments_url": "https://api.github.com/repos/neovim/pynvim/pulls/544/comments", - "state": "open", + "state": "closed", "statuses_url": "https://api.github.com/repos/neovim/pynvim/statuses/7431a46f5b1d02191bc0632d32ca6f640f26e998", "title": "test: add tests for attaching through socket, tcp, and stdio", - "updated_at": "2023-12-06T01:11:37Z", + "updated_at": "2023-12-06T02:10:06Z", "url": "https://api.github.com/repos/neovim/pynvim/pulls/544", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1009873?v=4",