Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NestJs peer dependencies to 10/11 compat #342

Closed
NikolaPeevski opened this issue Jan 21, 2025 · 2 comments
Closed

Migrate NestJs peer dependencies to 10/11 compat #342

NikolaPeevski opened this issue Jan 21, 2025 · 2 comments

Comments

@NikolaPeevski
Copy link
Contributor

NikolaPeevski commented Jan 21, 2025

I'm submitting a...


[ ] Regression 
[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[x] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Currently the package supports the following peer dependencies as part of the NestJs ecosystem:

"@nestjs/common": "^8.0.0 || ^9.0.2",
"@nestjs/core": "^8.0.0 || ^9.0.2",
"@nestjs/platform-express": "^8.0.0 || ^9.0.2"

and uses version 8.4.7 as dev dependencies.

Expected behavior

Migrate the package so it supports latest and one version behind (11 and 10), preferably utilizing version 11 as dev deps.

Minimal reproduction of the problem with instructions

Locally:

  1. Clone the repo
  2. Bump package to 3.1.0
  3. Use yalc with yalc publish to add to the local feed
  4. Setup a basic nestJs project using nest new
  5. Install manually via yalc add @nestjs/[email protected]
  6. Do a simple rm -rf ./node_modules && npm i
  7. Observe the wall of conflicts by npm resolution attempts

What is the motivation / use case for changing the behavior?

Let the users using latest or one version prior of the Nest ecosystem to use this package without a --force npm install each time.

Environment

Nest version: X.Y.Z
10/11+

For Tooling issues:

  • Node version: N/A
  • Platform: N/A

Others:
Refs:

CC: @manekinekko @kamilmysliwiec

@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this?

@NikolaPeevski
Copy link
Contributor Author

@kamilmysliwiec Yes, please assign me to this issue, I'll log another one for the initial hurdle I started this series off haha, to migrate the Azure Storage to v11+ will ping you later for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants