Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-aci-fabric-pod-policy-group "Please add all options to edit" #175

Open
Hindasa opened this issue Nov 12, 2024 · 3 comments
Open

Comments

@Hindasa
Copy link

Hindasa commented Nov 12, 2024

For module terraform-aci-fabric-pod-policy-group

I can not add the BGP route reflector policy that I edited in system settings, and I test it out and it does not fill it in as default, also there other policy to edit for example COOP policy etc

@Hindasa
Copy link
Author

Hindasa commented Nov 12, 2024

module "aci_fabric_pod_policy_group" {
source = "netascode/nac-aci/aci//modules/terraform-aci-fabric-pod-policy-group"
version = ">= 0.8.0"

name = "POD1"
snmp_policy = "SNMP1"
date_time_policy = "DATE1"
management_access_policy = "MAP1"
}
Note the only mentioned part are the above where in ACI is much more I will attach a picture
19686fcc-3757-4e8f-9c38-26fdc5ce5ecc

therealdoug added a commit to therealdoug/terraform-aci-nac-aci that referenced this issue Nov 12, 2024
…roup.

Fix for terraform-aci-fabric-pod-policy-group "Please add all options to edit" netascode#175

M: defaults.yaml
M: aci_fabric_policies.tf
M: terraform-aci-fabric-pod-policy-group
therealdoug added a commit to therealdoug/terraform-aci-nac-aci that referenced this issue Nov 12, 2024
…roup.

Fix for terraform-aci-fabric-pod-policy-group "Please add all options to edit" netascode#175

M: defaults.yaml
M: aci_fabric_policies.tf
M: terraform-aci-fabric-pod-policy-group
therealdoug added a commit to therealdoug/terraform-aci-nac-aci that referenced this issue Nov 12, 2024
…roup.

Fix for terraform-aci-fabric-pod-policy-group "Please add all options to edit" netascode#175

M: defaults.yaml
M: aci_fabric_policies.tf
M: terraform-aci-fabric-pod-policy-group
@andbyrne
Copy link
Contributor

andbyrne commented Dec 5, 2024

Custom route reflector, ISIS, and COOP policies cannot be created (there is only the system default), and these do not need to be specified in the pod policy group. Even though technically you could specify "default", it gets applied without doing so.

Therefore it only makes sense to add the ability to configure a MACsec policy. This is not yet possible in the module, so perhaps you could consider adding a module for that in conjunction with being able to set it in the pod policy group?

@therealdoug
Copy link
Contributor

Can do. I've been updating my macsec policy to include creating fabric macsec policies. I can add this request into that.

I also noticed that there's no fabric spine/leaf interface policy group modules, so may create modules for that as well in a separate pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants