Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make payment providers optional #170

Open
victorferreira opened this issue Jan 29, 2019 · 1 comment
Open

Make payment providers optional #170

victorferreira opened this issue Jan 29, 2019 · 1 comment

Comments

@victorferreira
Copy link

- Do you want to request a feature or report a bug?
Bug

- What is the current behavior?
App crashes on first launch.

2019-01-29T11:30:52.336109+00:00 app[web.1]: time="2019-01-29T11:30:52Z" level=fatal msg="Error loading instance config: No payment providers enabled

- If the current behavior is a bug, please provide the steps to reproduce.
Deploy a new application to Heroku using the "Deploy to Heroku" button.

- What is the expected behavior?
App should lunch after deployed.

- Please mention your Go version, and operating system version.
Just using the standard Heroku buildpack.

I know it says the a I don't have payment provider enabled on the log, but here's a few things to consider:

  • The README doesn't list the Payment section as required
  • Even after adding PAYMENT_STRIPE_ENABLED=true and restarting the server, the app still does't launch.
@bcomnes bcomnes changed the title Crashes at lunch on Heroku. Make payment providers optional Jan 31, 2019
@bcomnes
Copy link
Contributor

bcomnes commented Jan 31, 2019

Agreed, app should launch even if payment providers are not configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants