Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP Integration - clarify documentation #22

Open
codebyuma opened this issue Oct 17, 2023 · 2 comments
Open

CSP Integration - clarify documentation #22

codebyuma opened this issue Oct 17, 2023 · 2 comments
Assignees

Comments

@codebyuma
Copy link

codebyuma commented Oct 17, 2023

We received some feedback through Zendesk to clarify and/or correct the readme documentation:

  1. Clarify that the integration won't work while a split test is enabled

    • This is a known limitation that requests to sites with split testing enabled won't execute edge functions, but we should make it clear that the EF limitations apply to this integration.
  2. Update the documentation for path to resolve a markdown error and clarify what the default value is/does.

    • Right now, it says the default is

      "/_".*

@stuckj
Copy link

stuckj commented Nov 1, 2023

Number 2 in that list above is confusing me right now. After enabling the integration for my site I'm not seeing the header added anywhere. I thought, perhaps, I needed to put something in here beyond the default, but nothing I use appears to be working.

@stuckj
Copy link

stuckj commented Nov 1, 2023

Using /* worked for me.

@jasonbarry jasonbarry self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants