Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor guidelines and CoC #9

Open
camillescott opened this issue Mar 30, 2018 · 4 comments
Open

Add contributor guidelines and CoC #9

camillescott opened this issue Mar 30, 2018 · 4 comments
Assignees
Milestone

Comments

@camillescott
Copy link
Contributor

No description provided.

@jarrodmillman
Copy link
Member

jarrodmillman commented Mar 30, 2018

It seems like it would be good to adopt existing contributor guidelines and CoC from upstream projects. To that end...

Here is the contributing overview for networkx:
https://github.com/networkx/networkx/blob/master/CONTRIBUTING.rst

It is almost identical to (with the head removed):
https://github.com/scikit-image/scikit-image/blob/master/CONTRIBUTING.txt

Both projects (as well as many others) also use:
https://github.com/matthew-brett/gitwash

I could make a PR if this seems like a reasonable start.

I don't have much experience with this, but here is the scipy CoC:
https://github.com/scipy/scipy/tree/master/doc/source/dev/conduct
https://github.com/scipy/scipy/blob/master/.github/CODE_OF_CONDUCT.md
If that seems reasonable, I could also make a PR for the CoC as well.

For both PRs I would do basic editing so that things are specific to grave and not the project I copy them from. I would submit them as separate PRs as they may have different lifetimes as a PR being reviewed even though they are related.

Thoughts?

@NelleV
Copy link
Contributor

NelleV commented Mar 30, 2018 via email

@camillescott
Copy link
Contributor Author

camillescott commented Mar 31, 2018 via email

@jarrodmillman
Copy link
Member

Harriet looks like a great choice and even better she is willing to do it! I'll create a PR later today.

@jarrodmillman jarrodmillman self-assigned this Mar 31, 2018
@jarrodmillman jarrodmillman added this to the 0.1 milestone Mar 31, 2018
This was referenced Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants