From 8c9aa41fc1faf86a32c52004fd57629865c64fea Mon Sep 17 00:00:00 2001 From: Stefan Haun Date: Sun, 24 Jul 2022 18:54:07 +0200 Subject: [PATCH 1/2] :children_crossing: Add handlers for udev and systemd reload --- handlers/main.yml | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 handlers/main.yml diff --git a/handlers/main.yml b/handlers/main.yml new file mode 100644 index 0000000..5ecf006 --- /dev/null +++ b/handlers/main.yml @@ -0,0 +1,9 @@ +- name: Force systemd to reread configs + ansible.builtin.systemd: + daemon_reload: yes + +- name: Restart ble-keykeeper service + ansible.builtin.systemd: + state: restarted + name: ble-keykeeper + enabled: yes From 5ab04f0e8544042c9eab0afa6c7bcb38a86ee6aa Mon Sep 17 00:00:00 2001 From: Stefan Haun Date: Sun, 24 Jul 2022 18:54:22 +0200 Subject: [PATCH 2/2] :children_crossing: Call handlers on changes instead of reloading every time This is between bug and QoL: * Do not restart the services when nothing happened. * Molecule tests would consider this a failure because a role is expected to converge. --- tasks/main.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/tasks/main.yml b/tasks/main.yml index be0898b..516047a 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -29,6 +29,7 @@ owner: root group: root mode: '0644' + notify: Force systemd to reread configs - name: Copy gen_coin executable ansible.builtin.copy: @@ -45,6 +46,7 @@ owner: "{{ ble_keykeeper_user }}" group: "{{ ble_keykeeper_group }}" mode: '0744' + notify: Restart ble-keykeeper service - name: Template service file ansible.builtin.template: @@ -53,6 +55,7 @@ owner: "{{ ble_keykeeper_user }}" group: "{{ ble_keykeeper_group }}" mode: '0644' + notify: Restart ble-keykeeper service - name: Make sure pip3 is installed apt: @@ -64,13 +67,4 @@ - name: Install python requirements pip: requirements: "{{ble_keykeeper_dir}}/requirements.txt" - -- name: Just force systemd to reread configs - ansible.builtin.systemd: - daemon_reload: yes - -- name: Restart ble-keykeeper service - ansible.builtin.systemd: - state: restarted - name: ble-keykeeper - enabled: yes + notify: Restart ble-keykeeper service