Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thorough reporting option #2

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Add thorough reporting option #2

merged 2 commits into from
Feb 17, 2025

Conversation

dbarbuzzi
Copy link
Collaborator

Add a feature to improve the thoroughness of JUnit reports generated:

  • Feature is enabled by setting the NMRE_JUNIT_FULL to 1
  • When enabled, it will configure the JUnit reports to include all captured test output (e.g., stdout and stderr channels) as well as include all of this information for passing tests (normally, it is only captured for failing tests)
  • When enabled, this does not set any other flags such as to create the report files, that must be done separately either manually or with other features from this plugin

Related changes:

  • The README is updated with details about the new feature
  • New tests are added/existing tests modified to include coverage for the new feature

@dbarbuzzi dbarbuzzi self-assigned this Feb 17, 2025
Copy link
Member

@dhuangnm dhuangnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question above.

Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbarbuzzi dbarbuzzi merged commit d273439 into main Feb 17, 2025
5 checks passed
@dbarbuzzi dbarbuzzi deleted the add-thorough-reporting branch February 17, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants