Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] - scipy is deprecating the wavelet function we use #325

Open
TomDonoghue opened this issue Feb 15, 2024 · 0 comments
Open

[MNT] - scipy is deprecating the wavelet function we use #325

TomDonoghue opened this issue Feb 15, 2024 · 0 comments
Labels
maintenance Code maintenance.

Comments

@TomDonoghue
Copy link
Member

In neurodsp.timefrequency.wavelets, we use the scipy.signal implementation of Morlet wavelets (which we also use for compute_spectrum_wavelet).

scipy is deprecating their morlet wavelet implementation (as of current version 1.12) and announced that they will remove it as of 1.15:
https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.morlet.html

We have a while before anything leaves, but worth keeping in mind that this will start to fail.

scipy itself recommends moving to using pywavelets. Assuming we are not going to implement our own wavelet code, I think the options we have here are:

  • add our own version of scipy.signal.morlet and use that
  • update to use pywavelets, and add it as a dependency (or maybe, as an optional dependency)
  • drop support for computing wavelets in neurodsp (and suggest people go use pywavelets, or maybe MNE)

I don't have any particularly strong feeling about this one way or another (I don't really use wavelets from ndsp, and don't have much sense of to what extent others do) so if anyone wants to advocate for any particular approach, let us know!

@TomDonoghue TomDonoghue added documentation Tasks related to documentation materials & code docs. maintenance Code maintenance. labels Feb 15, 2024
@TomDonoghue TomDonoghue changed the title scipy is deprecating the wavelet function we use [MNT] - scipy is deprecating the wavelet function we use Feb 15, 2024
@TomDonoghue TomDonoghue removed the documentation Tasks related to documentation materials & code docs. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance.
Projects
None yet
Development

No branches or pull requests

1 participant