Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to the docstring of time-domain HRV indices #1046

Closed
aweinstein opened this issue Nov 6, 2024 · 4 comments
Closed

Add units to the docstring of time-domain HRV indices #1046

aweinstein opened this issue Nov 6, 2024 · 4 comments

Comments

@aweinstein
Copy link

Function hrv_time return HRV indices. The units of these indices are milliseconds. However, the docstring does not mention that these are the units used.

Please add this information to the docstring.

Copy link

welcome bot commented Nov 6, 2024

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

@DominiqueMakowski
Copy link
Member

Hi @aweinstein, thanks for reporting, please would you mind helping us by doing a quick PR to add that? I'm a bit under the water the moment

@aweinstein aweinstein changed the title Add units to the doctstring of time-domain HRV indices Add units to the docstring of time-domain HRV indices Nov 15, 2024
@aweinstein
Copy link
Author

@DominiqueMakowski I just submitted the PR. I hope it helps.

@aweinstein
Copy link
Author

Fixed by #1049.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants