Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes: share to other account #41

Open
tobiasKaminsky opened this issue May 11, 2023 · 6 comments
Open

Notes: share to other account #41

tobiasKaminsky opened this issue May 11, 2023 · 6 comments
Assignees

Comments

@tobiasKaminsky
Copy link
Member

Requires: nextcloud/notes#1041

Once done, we can implement sharing to users on clients.

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team May 11, 2023
@jancborchardt jancborchardt changed the title Notes: share to other user Notes: share to other account Nov 26, 2024
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (max 2 entries / member) in 🤖 🍏 Clients team Dec 6, 2024
@tobiasKaminsky
Copy link
Member Author

PR: nextcloud/notes#1146

@luka-nextcloud can you help us a bit and tell us how you actually issue sharing a note to the other user, with correct sharing path?

@luka-nextcloud
Copy link

@tobiasKaminsky As I remember, sharing a note should be the same as sharing a file.

  1. Open notes app
  2. Open note detail (sidebar)
  3. Navigate to sharing tab
  4. Search user and submit share

@tobiasKaminsky
Copy link
Member Author

The important part is, that a path can be sent with:

{"path":"/Notes/share to tobi.md","permissions":5,"shareType":0,"shareWith":"tobi","expireDate":"","attributes":"[{\"value\":true,\"key\":\"download\",\"scope\":\"permissions\"}]"}

But how do you know the correct path? E.g. my user tobi could use a different notes folder?

@tobiasKaminsky
Copy link
Member Author

Confirmed.

  • changed on tobi from /Notes to /Notes2
  • user test will still try to share it to /Notes/3.md

@tobiasKaminsky
Copy link
Member Author

According to Julius, Nextcloud server will directly share it to correct notes folder of recipient, as it is smart enough to understand that it is a note.
So only sharing api is needed to be used.

@alperozturk96
Copy link

Using business and UI logic from Files client for the Notes app, not easily achievable due to tightly coupled dependencies. Thus, extracting it to the common library would not be the optimum solution.

However, we can implement same logic for the Notes app then extract common parts to the android-common library.

@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (max 2 entries / member) to 🏗️ In progress in 🤖 🍏 Clients team Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗️ In progress
Development

No branches or pull requests

4 participants