Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add disabled state to PillMenu and update Results view when there are no submissions #2530

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix: Add disabled state to PillMenu and update Results view when there are no submissions #2530

merged 1 commit into from
Jan 29, 2025

Conversation

Chartman123
Copy link
Collaborator

This fixes #2529 by enabling the user to unlink a spreadsheet file if there are currently no submissions

@Chartman123 Chartman123 added bug Something isn't working javascript Javascript related ticket 2. developing Work in progress feature: 📊 responses & statistics labels Jan 28, 2025
@Chartman123 Chartman123 added this to the 5.0 milestone Jan 28, 2025
@Chartman123 Chartman123 self-assigned this Jan 28, 2025
@Chartman123 Chartman123 force-pushed the fix/2529-unlink-without-responses branch from 8d80f42 to 695bbe4 Compare January 28, 2025 22:08
@Chartman123 Chartman123 mentioned this pull request Jan 28, 2025
Open
@Chartman123
Fix: Add disabled state to PillMenu and update Results view for no su…
391febd 
…bmissions

This enables the users to unlink a spreadsheet file if there are currently no submissions

Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 force-pushed the fix/2529-unlink-without-responses branch from 695bbe4 to 391febd Compare January 28, 2025 23:15
@Chartman123 Chartman123 marked this pull request as ready for review January 28, 2025 23:15
@Chartman123 Chartman123 requested a review from susnux January 28, 2025 23:15
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 28, 2025
susnux
susnux approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but please note that is is not good for accessibility.
Screen reader users will usually now do not get any information about the pill menu.
(disabled will hide it) But I do not see an easy solution for now.

@Chartman123
Copy link
Collaborator Author

Works, but please note that is is not good for accessibility. Screen reader users will usually now do not get any information about the pill menu. (disabled will hide it) But I do not see an easy solution for now.

This shouldn't matter too much, because it is only disabled as long as it's not needed at all. But if it's better from an a11y perspective, we can also put it behind a v-if and only show it when there are submissions?

@Chartman123 Chartman123 merged commit 862f39e into main Jan 29, 2025
48 checks passed
@Chartman123 Chartman123 deleted the fix/2529-unlink-without-responses branch January 29, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees

@Chartman123 Chartman123

Labels
3. to review Waiting for reviews bug Something isn't working feature: 📊 responses & statistics javascript Javascript related ticket
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Can't unlink spreadsheet if there are no responses
2 participants
@Chartman123 @susnux