Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check psalm failure on main #1422

Closed
juliusknorr opened this issue Nov 22, 2024 · 1 comment
Closed

Check psalm failure on main #1422

juliusknorr opened this issue Nov 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@juliusknorr
Copy link
Member

On main the psalm check is failing since recently

Error: lib/AppInfo/DashboardWidget.php:98:83: MoreSpecificReturnType: The declared return type 'list<OCP\Dashboard\Model\WidgetItem>' for OCA\Notes\AppInfo\DashboardWidget::getItems is more specific than the inferred return type 'array<array-key, OCP\Dashboard\Model\WidgetItem>' (see https://psalm.dev/070)
Error: lib/AppInfo/DashboardWidget.php:101:10: LessSpecificReturnStatement: The type 'array<array-key, OCP\Dashboard\Model\WidgetItem>' is more general than the declared return type 'list<OCP\Dashboard\Model\WidgetItem>' for OCA\Notes\AppInfo\DashboardWidget::getItems (see https://psalm.dev/129)
Error: lib/Service/TagService.php:24:56: ArgumentTypeCoercion: Argument 1 of OCP\ITags::getTagsForObjects expects list<int>, but parent type array<array-key, mixed> provided (see https://psalm.dev/193)

This might be a change on the server mkaing the typing more strict/concrete.

@juliusknorr juliusknorr added the bug Something isn't working label Nov 22, 2024
@juliusknorr
Copy link
Member Author

Fixed with #1427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant