Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit via fullscreen broken #2540

Closed
AndyScherzinger opened this issue Jul 9, 2024 · 5 comments
Closed

Edit via fullscreen broken #2540

AndyScherzinger opened this issue Jul 9, 2024 · 5 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working regression Regression of a previous working feature
Milestone

Comments

@AndyScherzinger
Copy link
Member

Describe the bug
no_file_type

fullscreen closes, clicking on the image again repeatedly just shows the top-right error until you do a full-refresh of the page

Expected behavior
open editor or hide edit option when lacking permissions or show error that permissions are lacking

Screenshots
see above

Desktop (please complete the following information):

  • OS: [e.g. iOS] Win11Pro
  • Browser [e.g. chrome, safari] Ff
  • Version [e.g. 22] 127.0.1

Browser log

Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.
How to access your browser console (Click to expand)

Chrome

  • Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
  • Alternative method:
    1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
    2. Click the “console” tab.

Safari

  • Press CMD + ALT + I to open the Web Inspector.
  • See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

IE9

  1. Press F12 to open the developer tools.
  2. Click the “console” tab.

Firefox

  • Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
  • or, if Firebug is installed (recommended):
    1. Press F12 to open Firebug.
    2. Click on the “console” tab.

Opera

  1. Press CTRL + SHIFT + I to open Dragonfly.
  2. Click on the “console” tab.

Additional context
Add any other context about the problem here.

@AndyScherzinger AndyScherzinger added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jul 9, 2024
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jul 9, 2024
@jancborchardt
Copy link
Member

cc @sorbaugh – maybe @skjnldsv since you worked on the editor?

@jancborchardt jancborchardt added the regression Regression of a previous working feature label Jul 9, 2024
@sorbaugh
Copy link

sorbaugh commented Jul 9, 2024

Also cc-ing @artonge

@jancborchardt jancborchardt moved this to 👓 Design review in 🖍 Design team Jul 9, 2024
@skjnldsv skjnldsv closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Jul 9, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Jul 9, 2024

Duplicate of #2516
Duplicate of nextcloud/server#45484
Duplicate of nextcloud/viewer#2323

@AndyScherzinger
Copy link
Member Author

Didn't spot the duplicates, Sry!

@RyoKub
Copy link

RyoKub commented Jul 19, 2024

I have updated Nextcloud 29.0.3. This issue is still not fixed. It is a pity. It is a good app. I hope someone kind will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

No branches or pull requests

5 participants