Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use wget instead of curl #229

Closed
wants to merge 2 commits into from
Closed

use wget instead of curl #229

wants to merge 2 commits into from

Conversation

suhrig
Copy link

@suhrig suhrig commented Oct 18, 2023

This PR resolves #169. It implements the suggested changes using wget instead of curl.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@suhrig suhrig marked this pull request as draft October 18, 2023 09:19
@suhrig suhrig mentioned this pull request Oct 18, 2023
Closed
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4e61f76

+| ✅ 148 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: lib/WorkflowFetchngs.groovy
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-18 09:34:00

@suhrig suhrig marked this pull request as ready for review October 18, 2023 14:42
@drpatelh
Copy link
Member

drpatelh commented Oct 31, 2023 •
edited
Loading

Thanks for this @suhrig ! 🤩 Be awesome if you can fix the merge conflict please.

@nicolae06 nicolae06 mentioned this pull request Dec 14, 2023
Merged
@drpatelh drpatelh added this to the 1.12.0 milestone Jan 3, 2024
@drpatelh
Copy link
Member

drpatelh commented Jan 4, 2024

Closing in favour of #241

Thanks @suhrig !

@drpatelh drpatelh closed this Jan 4, 2024
drpatelh added a commit that referenced this pull request Jan 4, 2024
@drpatelh
Merge pull request #241 from nicolae06/dev-Nicolae
a6f7d52 
Merge fix: "use wget instead of curl #229"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@suhrig @drpatelh