Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dp24 windowmasker #4924

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Dp24 windowmasker #4924

merged 6 commits into from
Feb 16, 2024

Conversation

DLBPointon
Copy link
Contributor

PR checklist

Updates to 2.15
Adding nf-test
Aligning stuff

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@DLBPointon DLBPointon self-assigned this Feb 15, 2024
@DLBPointon DLBPointon requested review from alxndrdiaz and a team as code owners February 15, 2024 16:06
@DLBPointon DLBPointon requested review from Aratz and removed request for a team February 15, 2024 16:06
@DLBPointon
Copy link
Contributor Author

DLBPointon commented Feb 15, 2024 •
edited
Loading

Turns out i forgot about the environment yaml!

pinin4fjords
pinin4fjords approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing controversial here

@DLBPointon DLBPointon added this pull request to the merge queue Feb 16, 2024
Merged via the queue into master with commit 32cac29 Feb 16, 2024
19 checks passed
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
@DLBPointon @jch-13
Dp24 windowmasker (nf-core#4924)
96c180a 
* Adding updated modules and nf-tests

* Remove pytest folders and edut the pytest file

* reverting convert to 2.14

* reverting convert to 2.15

* Forgot the conda environmrnt
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@DLBPointon @jennylsmith
Dp24 windowmasker (nf-core#4924)
e982959 
* Adding updated modules and nf-tests

* Remove pytest folders and edut the pytest file

* reverting convert to 2.14

* reverting convert to 2.15

* Forgot the conda environmrnt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

@alxndrdiaz alxndrdiaz Awaiting requested review from alxndrdiaz

@Aratz Aratz Awaiting requested review from Aratz Aratz was automatically assigned from nf-core/nf-test

Assignees

@DLBPointon DLBPointon

Labels
nf-test Ready for Review update module
Projects
nf-test Migration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DLBPointon @pinin4fjords