Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now using a minimal bioconda recipe for ltr_finder_parallel #4931

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Now using a minimal bioconda recipe for ltr_finder_parallel #4931

merged 2 commits into from
Feb 16, 2024

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Feb 15, 2024

PR checklist

Closes #4534

  • Now using a minimal bioconda recipe for ltr_finder_parallel
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@GallVp GallVp requested a review from a team as a code owner February 15, 2024 20:21
@GallVp GallVp requested review from kpadm and removed request for a team February 15, 2024 20:21
@GallVp
Copy link
Member Author

GallVp commented Feb 15, 2024

For visibility. @oushujun

@GallVp GallVp added this pull request to the merge queue Feb 16, 2024
Merged via the queue into nf-core:master with commit 85b12bc Feb 16, 2024
11 checks passed
@GallVp GallVp deleted the ltrfinder branch February 16, 2024 21:36
edmundmiller pushed a commit that referenced this pull request Feb 16, 2024
@GallVp @edmundmiller
Now using a minimal bioconda recipe for ltr_finder_parallel (#4931)
e323231 
* Now using a minimal bioconda recipe for ltr_finder_parallel

* Added missing tag
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
@GallVp @jch-13
Now using a minimal bioconda recipe for ltr_finder_parallel (nf-core#…
4fc252f 
…4931)

* Now using a minimal bioconda recipe for ltr_finder_parallel

* Added missing tag
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@GallVp @jennylsmith
Now using a minimal bioconda recipe for ltr_finder_parallel (nf-core#…
403b3cf 
…4931)

* Now using a minimal bioconda recipe for ltr_finder_parallel

* Added missing tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

@kpadm kpadm Awaiting requested review from kpadm kpadm was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: ltrfinder
2 participants
@GallVp @mahesh-panchal