Fix falco sample names

[MartinGrignard]

Hi 👋

This PR modifies the definition of the falco module so that the reported sample names are affected by the value of the prefix variable instead of the actual input file name.
To achieve this, it simply uses the same strategy as many other modules: Symlinks are now created to provide input files named after the desired prefix.
This makes it easier to include falco output in MultiQC reports.

In the meantime, I also updated the value of falco form 1.2.1 to 1.2.5.

[SPPearce]

You'll need to regenerate the test snapshots (nf-core modules test falco --update) and update the environment.yml to change the conda module version.

[MartinGrignard]

@SPPearce do you have any idea why nf-core modules lint reports the following warning:

╭─ [!] 1 Module Test Warning ─────────────────────────────────────────────────────────────────────────╮
│              ╷                               ╷                                                      │
│ Module name  │ File path                     │ Test message                                         │
│╶─────────────┼───────────────────────────────┼─────────────────────────────────────────────────────╴│
│ falco        │ modules/nf-core/falco/main.nf │ Container versions do not match                      │
│              ╵                               ╵                                                      │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────╯

It is clearly related with the tests not passing since the tests fail with singularity when I generate the snapshot with Docker and vice-versa.

I used the same tag for both containers, so the reason of this error is unclear to me.

[SPPearce]

I'm on my phone and GitHub thinks I have an unfinished review, not sure what that actually contains.

No, I don't see why it would be complaining, my first thought would be that the conda definition in the environment.yml would be different, but that isn't the case. They all look in sync to me

[SPPearce]

Suggested change

	: 'biocontainers/falco:1.2.5--h077b44d_0'}"
	: 'biocontainers/falco:1.2.5--h077b44d_0' }"

Could it potentially be this space not being there?

[MartinGrignard]

I tried with and without the space, with an additional new line, and nothing changes.
Actually, using the initial version of the module (1.2.1) yields the same result.

There is something iffy here... 🤔