Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated spotiflow tag and printed version #7492

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

kbestak
Copy link
Contributor

@kbestak kbestak commented Feb 17, 2025

PR checklist

Closes #7159

  • Tag changes
  • Removing environment.yml since the module was already excluded from conda testing and the env yml was causing linting issues
  • Updated version printing to the installed pip package instead of hardcoding (it's 0.3.0 instead of previous 0.0.3 - adapted test snapshot accordingly)

It should be noted the most recent release is 0.5.2 but this is still the 0.3.0 version using the same container!

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda -- not possible
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much controversy found, but please verify that the version output is correct

@@ -28,20 +25,18 @@ process SPOTIFLOW {

cat <<-END_VERSIONS > versions.yml
"${task.process}":
spotiflow: $VERSION
spotiflow: \"pip show spotiflow | grep 'Version:' | cut -d ' ' -f2\"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that this works correctly? That's not the typical way to write a command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for highlighting, it actually was not... I updated it to \$( python -m pip show --version spotiflow | grep "Version" | sed -e "s/Version: //g" ) which is used in some modules.

Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks

@kbestak kbestak added this pull request to the merge queue Feb 19, 2025
Merged via the queue into nf-core:master with commit d832eb5 Feb 19, 2025
21 checks passed
@kbestak kbestak deleted the spotiflow_tag branch February 19, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spotiflow not tagged as an "image" module
2 participants