Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version update clipkit (2.4.1) #7499

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Version update clipkit (2.4.1) #7499

merged 6 commits into from
Feb 19, 2025

Conversation

vagkaratzas
Copy link
Contributor

@vagkaratzas vagkaratzas commented Feb 19, 2025

(conda tests will pass as soon as update 2.4.1 is live)

New version allows trimming MSAs only at the ends.
Added log file output.
Added input option to change the output format.
Added alternative mode test, with gap threshold and trim ends only flag

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions but otherwise, LGTM! 🚀

vagkaratzas and others added 2 commits February 19, 2025 08:49
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
@vagkaratzas vagkaratzas added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit dc42c37 Feb 19, 2025
27 checks passed
@vagkaratzas vagkaratzas deleted the update--clipkit branch February 19, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants