You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After a bit more exploring, all methods belonging directly to the ngrok module have the same behaviour.
Either:
the type hints should be updated to reflect the true return types
explicit async methods should be implemented (ex. forward_async)
The second option is a better solution.
As my example hints at: the sync function calls forward and gets back an awaitable.
This is problematic because the sync method cannot await the listener. This means that it has to be refactored into an async function. It also means that the caller of sync either needs to be async itself, or run the function explicitly with asyncio.run() (or similar).
Edit: On reflecting on this, it might be a bug in how the code is detecting whether it should return an awaitable or not. That isn't a question I can speak to intelligently.
The text was updated successfully, but these errors were encountered:
There is no documentation indicating that ngrok.forward can return an
_asyncio.Task
.Running this code:
Gives this output:
After a bit more exploring, all methods belonging directly to the ngrok module have the same behaviour.
Either:
The second option is a better solution.
As my example hints at: the
sync
function callsforward
and gets back an awaitable.This is problematic because the sync method cannot await the listener. This means that it has to be refactored into an async function. It also means that the caller of
sync
either needs to be async itself, or run the function explicitly withasyncio.run()
(or similar).Edit: On reflecting on this, it might be a bug in how the code is detecting whether it should return an awaitable or not. That isn't a question I can speak to intelligently.
The text was updated successfully, but these errors were encountered: