-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hex logo #36
Comments
😍 Lovely! Linked to PR but left this open to add to README and pkgdown |
@Lextuga007 I've added the logo to the README and that looks fine. But it looks odd in the pkgdown and I'm not sure what to try next - maybe removing the NHSRcommunity logo? Is there a way of seeing what the pkgdown looks like before a PR, so I can test options? |
Good question. I had to look it up but https://github.com/r-lib/pkgdown?tab=readme-ov-file#usage
It might be that the logos need resizing but I'm not sure. |
Posit have their org logo in the footnote https://tidyr.tidyverse.org/ which is reasonable. |
I've removed the NHSR community logo, so the NHSRtheme logo is showing nicely in the README and pkgdown site. I'm not sure how to put the NHSR community logo in the footer. I can put the words in by editing the role of NHSR community in the DESCRIPTION, but think may need a yaml file to have the logo: https://pkgdown.r-lib.org/reference/build_home.html?q=authors#authors. |
@Lextuga007 I can add the NHSR community logo in the footer, but only if I update the role of NHSR community in the DESCRIPTION to either maintainer ("cre"), author ("aut") or funder ("fnd"). Which would be the best option? It is currently only copyright holder ("cph"), but we can add another role too. |
Can we have more than one maintainer? Might but an idea to put it as that and then a person as well or will that not work out too well? Alternatively perhaps funder is a good one to use. |
Thanks @Lextuga007. Is it ok to to put NHSRcommunity as a maintainer for now whilst the discussion is ongoing? |
Yes. And I can be listed too, I'm happy with that. |
Following the discussion in nhs-r-community/NHSR-way#168, I have not changed any roles in the DESCRIPTION and instead have a sentence at the top to say "This package is part of the NHS-R Community suite of R packages." with the NHS-R community logo too in #40. Happy to change this if it's not quite right. |
@all-contributors please add @anyaferguson for design |
I've put up a pull request to add @anyaferguson! 🎉 |
As part of creating a packages page for the NHSRcommunity website nhs-r-community/nhs-r-community#219, I've designed a hex sticker for this package. Will do a PR shortly with the code and logo, but happy to take feedback and tweak the design as desired.
The text was updated successfully, but these errors were encountered: