Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex logo #36

Closed
anyaferguson opened this issue Nov 15, 2024 · 12 comments · Fixed by #37
Closed

Hex logo #36

anyaferguson opened this issue Nov 15, 2024 · 12 comments · Fixed by #37

Comments

@anyaferguson
Copy link
Contributor

As part of creating a packages page for the NHSRcommunity website nhs-r-community/nhs-r-community#219, I've designed a hex sticker for this package. Will do a PR shortly with the code and logo, but happy to take feedback and tweak the design as desired.

@anyaferguson anyaferguson mentioned this issue Nov 15, 2024
3 tasks
@Lextuga007 Lextuga007 linked a pull request Nov 15, 2024 that will close this issue
3 tasks
@Lextuga007
Copy link
Member

😍 Lovely! Linked to PR but left this open to add to README and pkgdown

@anyaferguson
Copy link
Contributor Author

@Lextuga007 I've added the logo to the README and that looks fine. But it looks odd in the pkgdown and I'm not sure what to try next - maybe removing the NHSRcommunity logo? Is there a way of seeing what the pkgdown looks like before a PR, so I can test options?

@Lextuga007
Copy link
Member

Good question. I had to look it up but https://github.com/r-lib/pkgdown?tab=readme-ov-file#usage

# Preview your site locally before publishing
pkgdown::build_site()

It might be that the logos need resizing but I'm not sure.

@Lextuga007
Copy link
Member

Posit have their org logo in the footnote https://tidyr.tidyverse.org/ which is reasonable.

@anyaferguson
Copy link
Contributor Author

I've removed the NHSR community logo, so the NHSRtheme logo is showing nicely in the README and pkgdown site.

I'm not sure how to put the NHSR community logo in the footer. I can put the words in by editing the role of NHSR community in the DESCRIPTION, but think may need a yaml file to have the logo: https://pkgdown.r-lib.org/reference/build_home.html?q=authors#authors.

@anyaferguson
Copy link
Contributor Author

anyaferguson commented Nov 26, 2024

@Lextuga007 I can add the NHSR community logo in the footer, but only if I update the role of NHSR community in the DESCRIPTION to either maintainer ("cre"), author ("aut") or funder ("fnd"). Which would be the best option? It is currently only copyright holder ("cph"), but we can add another role too.

@Lextuga007
Copy link
Member

Lextuga007 commented Nov 26, 2024

Can we have more than one maintainer? Might but an idea to put it as that and then a person as well or will that not work out too well?

Alternatively perhaps funder is a good one to use.

@anyaferguson
Copy link
Contributor Author

Thanks @Lextuga007. Is it ok to to put NHSRcommunity as a maintainer for now whilst the discussion is ongoing?

@Lextuga007
Copy link
Member

Yes. And I can be listed too, I'm happy with that.

@anyaferguson
Copy link
Contributor Author

anyaferguson commented Nov 26, 2024

Following the discussion in nhs-r-community/NHSR-way#168, I have not changed any roles in the DESCRIPTION and instead have a sentence at the top to say "This package is part of the NHS-R Community suite of R packages." with the NHS-R community logo too in #40. Happy to change this if it's not quite right.

@anyaferguson
Copy link
Contributor Author

@all-contributors please add @anyaferguson for design

Copy link
Contributor

@anyaferguson

I've put up a pull request to add @anyaferguson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants