Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The registering of Service Messages and Descriptors is not part of the instantiate.vi using dynamic dispatching #403

Open
Arrowin-87 opened this issue Jan 22, 2025 · 0 comments

Comments

@Arrowin-87
Copy link

Arrowin-87 commented Jan 22, 2025

Proto files could have multiple services defined or multiple proto files each have a single service which results in multiple classes to be created by the (server) code generator. Although the registering of the messages and descriptors (server code) is only a single VI for all service classes it generates, it would be easier if the registering is part of a dynamic dispatch VI, one for each service class. The same principle is already implemented for the "Register gRPC Methods.vi"! Why not do this for the messages (data structures) and descriptors?
This will make the code easier to port to applications since both VI's (listed below by name) should be used as a (protected) SubVI within the instantiate.vi (which is actually already a dynamic dispatch VI) within the ServiceBase.lvclass. The user only has to use the Instantiate.vi from the API.

1st step:

  • Register gRPC Messages.vi
  • Register Descriptors.vi
    Both VI's to be placed under the Server API within the ServiceBase class as dynamic dispatch and to e overridden by the code generator.

2nd step:
Both VI's also to be added within Instantiate.vi

Image

AB#2991658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant