Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrectly handling live aborts #2

Open
dominictarr opened this issue Sep 23, 2016 · 0 comments
Open

incorrectly handling live aborts #2

dominictarr opened this issue Sep 23, 2016 · 0 comments

Comments

@dominictarr
Copy link

there is an edgecase in aborts which this does not handle correctly.
in early versions of pull-streams, you could only abort when you would do a read,
which generally worked, but sometimes a read may stall indefinitely,
say, you are waiting for a real time resource, that happens not to do anything for a long time.
Example, reading lines added to a log file (like, tail -f) except nothing gets written.

in that case, you need to call abort before the previous read has called back,
so, an abort while isResolving=true is okay, but never 2 calls,
and then the previous read should callback first, then the abort call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant