Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useSKStoreReviewControllerIfAvailable is ignored #296

Open
dtdw opened this issue Jun 19, 2017 · 4 comments
Open

useSKStoreReviewControllerIfAvailable is ignored #296

dtdw opened this issue Jun 19, 2017 · 4 comments

Comments

@dtdw
Copy link

dtdw commented Jun 19, 2017

useSKStoreReviewControllerIfAvailable is set to YES by default but not tested in code. The call should be like

if (!manual && [SKStoreReviewController class] && self. useSKStoreReviewControllerIfAvailable)
{
...
}

in - (void)promptForRating:(BOOL)manual

@nicklockwood
Copy link
Owner

Yes, this is a bug. It sounds like not using SKStoreReviewControllerIfAvailable may be prohibited on iOS 11 anyway, so I may just remove the option.

@mTuran
Copy link

mTuran commented Sep 5, 2017

Bug confirmed. useSKStoreReviewControllerIfAvailable is ignored.

@nicklockwood
Copy link
Owner

AFAIK, Apple is now rejecting apps that don't use SKStoreReviewControllerIfAvailable, so this seems like a low priority to fix.

@mTuran
Copy link

mTuran commented Sep 5, 2017

Yes, I heard this before but I submitted a lot of apps that does not use SKStoreReviewControllerIfAvailable and they approved without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants