New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It doesn't work with jQuery3 #7

Open

chamnap opened this issue Aug 12, 2017 · 1 comment

chamnap commented Aug 12, 2017

It turned out, this jquery syntax doesn't work with jQuery3:

$(document).on('ready', function() {

However, this below works both with jQuery 2 and 3:

$(document).ready(function() {

From jquery documentation, https://api.jquery.com/ready/:

There is also $(document).on( "ready", handler ), deprecated as of jQuery 1.8 and removed in jQuery 3.0. Note that if the DOM becomes ready before this event is attached, the handler will not be executed.

Owner

nicolasblanco commented Aug 13, 2017

Cool, can you just do a PR with the change, I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment