Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ws_autobahn to no longer use autobahn-testsuite #1631

Open
essen opened this issue Jan 26, 2024 · 2 comments
Open

Rewrite ws_autobahn to no longer use autobahn-testsuite #1631

essen opened this issue Jan 26, 2024 · 2 comments

Comments

@essen
Copy link
Member

essen commented Jan 26, 2024

The main problem is that the test suite requires Python 2 which is no longer available. No workaround, including using the Docker image, is satisfying.

We could "rewrite" by taking the list of test cases and implementing them in Erlang. We don't need to convert the source code, just ensure all tests have an equivalent Erlang test case so as to not lose anything. The RFC should provide enough details about what is expected from the test cases.

@mtrudel
Copy link

mtrudel commented Feb 1, 2024

FWIW I've been really happy with the approach I hacked up for Bandit. It's basically bombproof both locally and in CI

@essen
Copy link
Member Author

essen commented Feb 1, 2024

Thank you for the tips! Yes I considered using the docker method to enable it in Actions but there's little to gain from doing that as that part of the code base is super stable and not likely to break. I can still run it on my machine if necessary or setup a self-hosted runner.

A rewrite would allow me to test not only normal Websocket but also Websocket over HTTP/2 and HTTP/3 so there's benefits in taking that road at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants