-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run nitro-deploys CI on nitro PR #79
Comments
cc @pi0 |
Some (many) of our presets are set up with the ability to have one deployment and do not support preview branch deployments. Best we can do is to automate the |
@pi0 For the github integrated presets we can create a staging version if we don't have a preview branch support. Example with CFP (Note that CFP supports preview branch so it wouldn't be necessary)
This mean that the staging environments must be previewed sequentially as they are overwritten by new This is better than not testing or manual testing. (All of this is simpler if this is handled in the same repo.) |
Thanks for explaining. I'm aware of this possibility but presets need to have unit tests to be passed before merging them on a nitro PR. This repository is meant to be an end-to-end testing suit not only testing the latest nitro preset builds but also the platforms themselves to be compatible and working (a breaking change can happen in the platform, not by nitro changes!). A preview branch would be nice but again, not every preset is capable of supporting such a configuration. Right now even one branch deployment of many of them is partially working and breaking from time to time. Adding more complexity or combining such complexity to the main repo is not sensible. |
Describe the feature
When we make a PR in nitro for a new preset, there's no straightforward way to trigger
nitro-deploy
CI with the proposed changes./trigger deploy [preset-name]
command in the nitro PR.Additional information
The text was updated successfully, but these errors were encountered: