From 6bbe4d8190993f838f42b6410241a17ee3350849 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Fri, 16 Aug 2024 08:05:50 +0200 Subject: [PATCH 1/3] darwin/nix-experimental: disable uid-range we do not have auto-allocate-uid support enable so we cannot have this one. --- darwin/mixins/nix-experimental.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/darwin/mixins/nix-experimental.nix b/darwin/mixins/nix-experimental.nix index eda5fcaa..5935da94 100644 --- a/darwin/mixins/nix-experimental.nix +++ b/darwin/mixins/nix-experimental.nix @@ -19,7 +19,4 @@ ++ lib.optional (lib.versionAtLeast (lib.versions.majorMinor config.nix.package.version) "2.19") # Allow the use of the impure-env setting. "configurable-impure-env"; - - # for container in builds support - nix.settings.system-features = lib.mkDefault [ "uid-range" ]; } From 02c52bc1c42827418f4179f4a3cf72f6a20574f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Fri, 6 Dec 2024 01:27:59 +0100 Subject: [PATCH 2/3] mdns: don't explicilty unset multicast dns if useDHCP is not set --- nixos/mixins/mdns.nix | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/nixos/mixins/mdns.nix b/nixos/mixins/mdns.nix index 4ca4536f..1200c1e7 100644 --- a/nixos/mixins/mdns.nix +++ b/nixos/mixins/mdns.nix @@ -1,15 +1,6 @@ { config, lib, ... }: let - # The default value of useDHCP for individual interfaces is null! - mapInterfaceEnabled = i: lib.nameValuePair "40-${i.name}" (i.useDHCP == true); - mapMDNSConfig = enableMDNS: { - networkConfig.MulticastDNS = lib.mkDefault enableMDNS; - }; - - configs = { - "99-ethernet-default-dhcp" = config.networking.useDHCP; - "99-wireless-client-dhcp" = config.networking.useDHCP; - } // (lib.mapAttrs' (_: mapInterfaceEnabled) config.networking.interfaces); + dhcpInterfaces = lib.filterAttrs (i: i.useDHCP == true) config.networking.interfaces; in { # Avahi is an alternative implementation. If it's enabled, than we don't need the code below. @@ -17,6 +8,11 @@ in networking.firewall.allowedUDPPorts = [ 5353 ]; # Multicast DNS # Allows to find machines on the local network by name, i.e. useful for printer discovery - systemd.network.networks = builtins.mapAttrs (_: mapMDNSConfig) configs; + systemd.network.networks = + lib.optionalAttrs (config.networking.useDHCP) { + "99-ethernet-default-dhcp".networkConfig.MulticastDNS = lib.mkDefault true; + "99-wireless-client-dhcp".networkConfig.MulticastDNS = lib.mkDefault true; + } + // builtins.mapAttrs (_: { networkConfig.MulticastDNS = lib.mkDefault true; }) dhcpInterfaces; }; } From a48f731c4da642a465e169fcae1a00bb5e4d3e19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Thu, 26 Dec 2024 14:23:18 +0100 Subject: [PATCH 3/3] no longer set nixpkgs.flake.source both nix-darwin and nixpkgs already do this. On macOS in particular this causes a configuration conflict. --- shared/common/flake.nix | 5 ----- 1 file changed, 5 deletions(-) diff --git a/shared/common/flake.nix b/shared/common/flake.nix index cd909528..40c31fd4 100644 --- a/shared/common/flake.nix +++ b/shared/common/flake.nix @@ -43,11 +43,6 @@ in }; config = lib.mkIf (cfg.flake != null) { - - nixpkgs.flake = { - source = lib.mkDefault (cfg.flake.inputs.nixpkgs or null); - }; - nix.registry = lib.optionalAttrs cfg.registerSelf { self.to = lib.mkDefault { type = "path";