Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework pulse sequence #51

Open
7 tasks
Tracked by #32
NRayya opened this issue Oct 15, 2024 · 0 comments
Open
7 tasks
Tracked by #32

Rework pulse sequence #51

NRayya opened this issue Oct 15, 2024 · 0 comments
Labels
discussion This issue still needs discussion before resolving

Comments

@NRayya
Copy link
Contributor

NRayya commented Oct 15, 2024

https://terminology.nfdi4chem.de/ts/ontologies/nmrcv/terms?iri=http%3A%2F%2FnmrML.org%2FnmrCV%23NMR%3A1400037&obsoletes=false

  • Assert all the pulse sequences directly under NMR pulse sequence
  • Add further grouping classes for convenience:
    • NMR pulse sequence by dimension (we will have to add an object property called “has dimension”)
    • NMR pulse sequence by modularity (we will have to add an object property called “has modularity”)
    • NMR pulse sequence by Continuation (Active vs Legacy) - We can skip it for now and add it to later issue.
  • NMR Method - def and hierarchy #24
    • (we will have to add an object property called “has technique” )
@NRayya NRayya added the discussion This issue still needs discussion before resolving label Oct 15, 2024
@NRayya NRayya mentioned this issue Oct 15, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue still needs discussion before resolving
Projects
None yet
Development

No branches or pull requests

1 participant