Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spack-stack modulefiles #56

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Use spack-stack modulefiles #56

wants to merge 18 commits into from

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Oct 17, 2024 •
edited
Loading

  • manually test the build on all platforms
    e.g. 
    rm -rf build && cmake -B build && cmake --build build -j 4 && mpirun -n 1 ./build/bin/nexus -h
    • Hera Intel
    • WCOSS
    • Orion
    • Gaea C5 (with the two adjustments)
    • Derecho (note doesn't work on Casper)
  • revise the readme instructions

Closes #39

zmoon
zmoon commented Oct 17, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
zmoon
zmoon commented Oct 18, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
zmoon
zmoon commented Oct 18, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
zmoon
zmoon commented Oct 18, 2024
View reviewed changes
modulefiles/ufs_common.lua Outdated Show resolved Hide resolved
@bbakernoaa bbakernoaa added the enhancement New feature or request label Oct 18, 2024
@zmoon
Update readme with UFS module file info
bafd32d 
and remove most of the Ubuntu instructions
@bbakernoaa
Copy link
Member

@zmoon Compiled fine on wcoss

Did get a warning during the initial CMake step

CMake Warning (dev) at src/CMakeLists.txt:16 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable ESMF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/esmf/8.6.0

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found ESMF: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/esmf/8.6.0/lib/libesmf.a (found version "8.6.0")
CMake Warning (dev) at src/CMakeLists.txt:17 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable NetCDF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found NetCDF: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/include (found version "4.9.2") found components: Fortran
-- FindNetCDF defines targets:
--   - NetCDF_VERSION [4.9.2]
--   - NetCDF_PARALLEL [TRUE]
--   - NetCDF_C_CONFIG_EXECUTABLE [/apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/bin/nc-config]
--   - NetCDF::NetCDF_C [STATIC] [Root: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2] Lib: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/lib/libnetcdf.a
--   - NetCDF_Fortran_CONFIG_EXECUTABLE [/apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/bin/nf-config]
--   - NetCDF::NetCDF_Fortran [STATIC] [Root: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2] Lib: /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2/lib/libnetcdff.a
CMake Warning (dev) at src/nuopc/CMakeLists.txt:16 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable ESMF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/esmf/8.6.0

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at src/nuopc/CMakeLists.txt:17 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Environment variable NetCDF_ROOT is set to:

    /apps/prod/hpc-stack/i-19.1.3.304__m-8.1.12__h-1.14.0__n-4.9.2__p-2.5.10__e-8.6.0pnetcdf/intel-19.1.3.304/cray-mpich-8.1.12/netcdf/4.9.2

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

@zmoon
Copy link
Member Author

zmoon commented Oct 25, 2024 •
edited
Loading

We could explicitly set the policy as it suggests. For example

if(POLICY CMP0074)
  cmake_policy(SET CMP0074 OLD)
endif()

I don't see UWM doing something like that in their repo though.

@zmoon
Set CMake policy 0074
6b7c815 
telling it to ignore _ROOT variables
since we have special find scripts for those

on WCOSS2, it was warning about these being set for NetCDF and ESMF
zmoon
zmoon commented Oct 30, 2024
View reviewed changes
modulefiles/ufs_gaea.intel.lua Outdated Show resolved Hide resolved
zmoon
zmoon commented Oct 30, 2024
View reviewed changes
modulefiles/ufs_gaea.intel.lua Outdated Show resolved Hide resolved
@bbakernoaa bbakernoaa marked this pull request as ready for review October 30, 2024 23:38
@zmoon
Copy link
Member Author

zmoon commented Oct 31, 2024

@bbakernoaa does revised readme look okay to you?

zmoon
zmoon commented Oct 31, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
zmoon and others added 3 commits November 1, 2024 12:02
@zmoon
gha-esmf moved to ARL org
9be36a7
@zmoon
Try unsetting WCOSS vars instead
08547f8
@zmoon
Print $ENV{FC}
1d57259 
note it seems CMake compiler discovery modifies this result
from command to full path
@bbakernoaa
Copy link
Member

whats left for this?

@zmoon
Copy link
Member Author

zmoon commented Nov 14, 2024

whats left for this?

Were you able to try WCOSS from fresh again after the change? see if works and without warnings?

@bbakernoaa
Copy link
Member

compiled

@zmoon
Copy link
Member Author

zmoon commented Nov 14, 2024

compiled

And you didn't get those warnings from earlier in this thread?

@bbakernoaa
Copy link
Member

bbakernoaa commented Nov 15, 2024 via email

@zmoon
Copy link
Member Author

zmoon commented Nov 15, 2024

No warning. Compiled just fine

Great, do you want to approve then (seems I can't since I opened this PR, even though it's from your fork)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakernoaa bbakernoaa bbakernoaa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to spack-stack
2 participants
@zmoon @bbakernoaa