Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v21.x failing modules #1033

Closed
RafaelGSS opened this issue Nov 30, 2023 · 11 comments
Closed

v21.x failing modules #1033

RafaelGSS opened this issue Nov 30, 2023 · 11 comments

Comments

@RafaelGSS
Copy link
Member

RafaelGSS commented Nov 30, 2023 •
edited
Loading

The last 3 runs failed on Node.js 21. I've run against v21.x just to confirm it's nothing related to the v21.3.0 proposal

Modules:

citgm.jest-v29.7.0 #1032
citgm.ember-cli-v5.4.1 - @stefanpenner, @rwjblue, @Turbo87, @kellyselden
citgm.yeoman-generator-v7.1.1 - @SBoudrias, @sindresorhus
citgm.nan-v2.18.0 - @nodejs/addon-api
citgm.q-v1.5.1 - @kriskowal
@RafaelGSS RafaelGSS mentioned this issue Nov 30, 2023
Closed
@ljharb
Copy link
Member

ljharb commented Nov 30, 2023

i believe maxogden → @max-mapper

@arcanis
Copy link
Contributor

arcanis commented Nov 30, 2023

How can we check the logs? The @yarnpkg/cli logs seem unrelated to Yarn (ConnectTimeoutError: Connect Timeout Error), but perhaps I'm looking at the wrong place.

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Nov 30, 2023 •
edited
Loading

@arcanis some of them might be related to the machine, yeah. I just want to make sure these timeouts aren't flaky on yarnpkg/cli but something with our machine

The ci.nodejs.org links are the ones with logs.

@novemberborn
Copy link
Contributor

AVA's failure is (most likely) a known issue, fixed in main but not yet released.

@mourner
Copy link

mourner commented Dec 3, 2023

I tried looking into what might be the problem in binary-split, but it seems to work fine with Node v21.3. The logs for the failure above also says ConnectTimeoutError: Connect Timeout Error, so perhaps it's just a flaky test and not something that needs fixing?

@RafaelGSS
Copy link
Member Author

Timeout errors are usually machine issues since we run tests in parallel and the CPU can get stale causing timeouts. If this persists we can reduce/remove the concurrency - but it might affect the time elapsed of CITGM, which is undesirable.

@lpinca
Copy link
Member

lpinca commented Dec 3, 2023 •
edited
Loading

The ws failure is the same and on the same platform for all runs. On macOS, that test also fails on GHA sometimes. I would prefer not to do it, but I think I can skip it on macOS.

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Dec 4, 2023 •
edited
Loading

I've just removed for the issue description the modules where the authors/maintainers confirmed the issues aren't related to the package itself. Thank you!

I'll wait maintainers' input for the other ones.

@targos targos pinned this issue Dec 6, 2023
RafaelGSS added a commit to RafaelGSS/citgm that referenced this issue Dec 12, 2023
@RafaelGSS
lib: skip "q" on Node.js >= 21
94d7805 
Ref: nodejs#1033
RafaelGSS added a commit to RafaelGSS/citgm that referenced this issue Dec 12, 2023
@RafaelGSS
lib: skip "yeoman-generator" on Node.js >= 21
845febd 
Ref: nodejs#1033
RafaelGSS added a commit to RafaelGSS/citgm that referenced this issue Dec 12, 2023
@RafaelGSS
lib: skip "ember-cli" on Node.js >= 21
3faa1bc 
Ref: nodejs#1033
@RafaelGSS RafaelGSS mentioned this issue Dec 12, 2023
Merged
@RafaelGSS
Copy link
Member Author

I've read all the lists again and removed the ones failing with timeout, which tends to be a machine issue and I've created a PR to skip the non-machine-related failing on Node.js 21. #1035

RafaelGSS added a commit that referenced this issue Dec 14, 2023
@RafaelGSS
lib: skip flaky modules on v21 (#1035)
29c14c7 
* lib: skip "q" on Node.js >= 21

Ref: #1033

* lib: skip "yeoman-generator" on Node.js >= 21

Ref: #1033

* lib: skip "ember-cli" on Node.js >= 21

Ref: #1033
@RafaelGSS
Copy link
Member Author

RafaelGSS commented Jan 15, 2024 •
edited
Loading

Last v21.x run:

Failures:

@RafaelGSS RafaelGSS mentioned this issue May 22, 2024
Open
@RafaelGSS
Copy link
Member Author

Closing in favour of #1060

@RafaelGSS RafaelGSS unpinned this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mourner @novemberborn @ljharb @arcanis @lpinca @RafaelGSS