From dbb86acd43de5d34905c8e7cb47cff7afc8a6071 Mon Sep 17 00:00:00 2001 From: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Mon, 8 Apr 2024 14:58:42 +0100 Subject: [PATCH] chore: update condition for clearing warning comment on release PRs (#4739) # Description ## Problem\* Resolves ## Summary\* This is not triggering correctly atm so I'm switching to a more explicit syntax. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index badcd3af2dd..d27fac0e039 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -131,7 +131,7 @@ jobs: # We need to specify the PR on which to make the comment as workflow is triggered by push. number: ${{ fromJSON(needs.release-please.outputs.release-pr).number }} # delete the comment in case failures have been fixed - delete: ${{ !env.FAIL }} + delete: ${{ env.FAIL == false }} message: "The release workflow has not completed successfully. Releasing now will result in a broken release" - name: Report overall success