Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement print builtin that does not insert a newline #2912

Closed
vezenovm opened this issue Sep 29, 2023 · 3 comments
Closed

Implement print builtin that does not insert a newline #2912

vezenovm opened this issue Sep 29, 2023 · 3 comments
Labels
compiler enhancement New feature or request good first issue Good for newcomers nargo Noir's CLI development tool

Comments

@vezenovm
Copy link
Contributor

Problem

We have a println builtin function in our standard lib but this restricts developers to have to print with a new line.

Happy Case

Developers should be able to call a print function that gives the option to print without a newline. Our existing println function can then be reimplemented where it calls this new print function.

Alternatives Considered

N/A or else developers will not be able to have a normal print.

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@vezenovm vezenovm added enhancement New feature or request good first issue Good for newcomers compiler nargo Noir's CLI development tool P-LOW labels Sep 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 29, 2023
@yekxp
Copy link

yekxp commented Sep 30, 2023 •
edited
Loading

Hello, my name is Jakub and I am a student of Technical University in Kosice and software developer in Siemens Healthineers and I would be very happy if I could work on this issue. It would be the part of the course where we have to help a project on GitHub. Could you assign me to it, please?

@grasshopper47 grasshopper47 mentioned this issue Dec 3, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
@grasshopper47 @jfecher
feat: Implement print without newline (#3650)
9827dfe 
# Description

## Problem\*

Resolves  **#3575
Resolves **#2912 (duplicate)

Continuation of #3576
## Summary\*

Refactors `println_oracle` method into `print` with boolean indicator,
allowing `print` to coexist with `println` under the same `ForeignCall`
string symbol.
Updates appropriate tests, and logging.md documentation.
Add a subchapter to `03_string.md` documentation for the `fmtstr` type

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: jfecher <[email protected]>
@grasshopper47
Copy link
Contributor

@vezenovm This can be closed

@vezenovm
Copy link
Contributor Author

vezenovm commented Dec 5, 2023

#3650

@vezenovm vezenovm closed this as completed Dec 5, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler enhancement New feature or request good first issue Good for newcomers nargo Noir's CLI development tool
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vezenovm @grasshopper47 @yekxp