Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssa): Update the missing Brillig constraint SSA check to process EnableSideEffectsIf #6713

Open
rkarabut opened this issue Dec 5, 2024 · 0 comments · May be fixed by #7060
Open

feat(ssa): Update the missing Brillig constraint SSA check to process EnableSideEffectsIf #6713

rkarabut opened this issue Dec 5, 2024 · 0 comments · May be fixed by #7060
Assignees
Labels
enhancement New feature or request

Comments

@rkarabut
Copy link
Contributor

rkarabut commented Dec 5, 2024

Problem

EnableSideEffectsIf instruction isn't handled by the check although it can lead to false positives, leaving Brillig call results descendants affected untainted.

Happy Case

EnableSideEffectsIf should be handled correctly, marking the results affected by a condition using Brillig output as also using Brillig output.

Workaround

None

Workaround Description

No response

Additional Context

The issue has been brought up in #6658 (comment).

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@rkarabut rkarabut added the enhancement New feature or request label Dec 5, 2024
@rkarabut rkarabut self-assigned this Dec 5, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 5, 2024
@rkarabut rkarabut linked a pull request Jan 14, 2025 that will close this issue
5 tasks
@rkarabut rkarabut linked a pull request Jan 15, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant