-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isEnd is falsely false on cubeEffect #7866
Comments
t0ggles-create swiper |
Task nolimits4web/SWIPER-153 was created |
slideChange is not a proper event for that. use |
Task nolimits4web/SWIPER-153 status changed to Done |
Thx @nolimits4web I'll do |
Hi @nolimits4web . I've implement the I'm using the this.swiper$()?.on('slideChange', (e) => {
const actualFoo = this.fooQuery$.data()?.[e.realIndex - 1]
if (actualFoo?.id) {
this._location.replaceState('/foo/' + actualFoo.id)
} else {
if (e.isEnd) {
this._location.replaceState('/foo')
} else if (this.myMoodQuery$.data()?.id) {
this._location.replaceState('/foo/me')
} else {
this._focusTitleInput()
this._location.replaceState('/foo/new')
}
}
})
// End fix
this.swiper$()?.on('reachEnd', (e) => {
this._location.replaceState('/foo')
}) The problem here, is that the bug does not only happen with the What would be your proposal at that point ? Here's an example of the impact of the code on the url |
Check that this is really a bug
Reproduction link
https://codesandbox.io/p/sandbox/swiper-effect-cube-forked-g4vw9w
Bug description
isEnd
will still befalse
Expected Behavior
Being
true
Actual Behavior
Is
false
Screen.Recording.2025-01-26.at.22.16.19.mov
Swiper version
v11.2.1
Platform/Target and Browser Versions
macOS Chrom v131.0.6778.265
Validations
Would you like to open a PR for this bug?
The text was updated successfully, but these errors were encountered: