-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update derivative generation to use derivative rodeo to skip *TN.jpg and .READER.pdf
files
#431
Comments
Prior to this commit, we were generating derivatives for all of the PDFs. This could be both an archival and access PDF. And we did not need those duplicate derivatives. With this commit, we're skipping derivative processing for any of the non-archival PDFs. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/311 References: - notch8/utk-hyku#353
Prior to this commit, we were generating derivatives for all of the PDFs. This could be both an archival and access PDF. And we did not need those duplicate derivatives. With this commit, we're skipping derivative processing for any of the non-archival PDFs. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/311 References: - notch8/utk-hyku#353
Prior to this commit, we were generating derivatives for all of the PDFs. This could be both an archival and access PDF. And we did not need those duplicate derivatives. With this commit, we're skipping derivative processing for any of the non-archival PDFs. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/311 References: - notch8/utk-hyku#353
Prior to this commit, we skipped generating derivatives on the `.reader.pdf` (see [313]). However, we also wanted to avoid splitting the reader PDFs. With this commit, we now have logic that avoids splitting `.reader.pdf` files into constituent pages. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/286 - https://github.com/scientist-softserv/adventist-dl/issues/311 [313]: #313
Team, can we exclude PDFs with .READER.pdf and also .pdf-r.pdf? I recently found a big batch of material our digitization center processed with the .pdf-r.pdf file naming convention at some point in the past. We'd like to exclude these files from the viewer, as they are Reader files (but just didn't receive the correct name). |
Absolutely going to add this bit of logic. |
I want to de-prioritize this as the derivative work that I’m doing this week should resolve/supercede the changes that I’ve made to attempt to address this ticket. (The importer process I'm working through will allow for significant improvements but is a complete re-architecture of the approach) Duplicated/replaced by: |
We also do not want to create derivatives for TN.jpg files. |
dependent on derivative rodeo work |
.READER.pdf
files.READER.pdf
files
We're seeing jobs that are trying to find the HOCR of a thumbnail; we don't need that HOCR and it's spawning 5 jobs that are unecessary. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/311
We're seeing jobs that are trying to find the HOCR of a thumbnail; we don't need that HOCR and it's spawning 5 jobs that are unecessary. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/311
We're seeing jobs that are trying to find the HOCR of a thumbnail; we don't need that HOCR and it's spawning 5 jobs that are unecessary. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/311
In the <2023-03-14 Tue> conversation with Katharine, we have the following situation:
We can and should skip derivative generation for PD for those secondary PDFs. All secondary PDFs have the suffix
.READER.pdf
(make sure to test in a case insensitve manner). Example: =32000812.READER.pdf=For a reference implementation (albeit with different rules):
Hyrax::ConditionalDerivativeDecorator
utk-hyku#353Related to:
We also do not want to create derivatives for TN.jpg files.
Testing Instructions
.READER.pdf
(e.g.my-file.READER.pdf
)The text was updated successfully, but these errors were encountered: