🐛 Bug Report: Notification fails due to subscriber not having channel configured for push channel

[jarredwitt]

📜 Description

We have a workflow that sends out an email and a push notification to all of our subscribers. Push notifications are opt-in on our platform so while the subscriber will have an email channel they may not have the push channel configured if they didn't opt-in. This leads to a lot of our notifications displaying like this in the activity feed:

IMO the notification didn't fail to send, the subscriber just didn't have the channel configured. Is it possible to skip a workflow step if a channel isn't configured for a subscriber? This is really bloating our activity feed with lots of failures when in fact they aren't actually failing. Our worker logs are also displaying a lot of the same errors and it's causing a lot of noise in our logging for no reason.

👟 Reproduction steps

Create workflow that has an email step and a push notification step. Send a notification to a subscriber that has the email channel configured, but not the push notification channel.

👍 Expected behavior

It should skip the push notification step if the subscriber doesn't have the channel configured.

👎 Actual Behavior with Screenshots

The notification fails due to the channel not being configured.

Novu version

0.21.0

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

• I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to submit PR?

None

[uncle-tee]

@jainpawan21 can I pick this for grabs, it's my first time here and I want to see if this is possible to achieve. Let me know if you want me to pick this.

[jainpawan21]

Hi @uncle-tee

Thanks for your interest in contribution. As this github issue is suggesting a change in how execution works, I will need to discuss this with team if we should go ahead as suggested in this issue.

[Pornpunnarai]

How to fixed this issue?

[paulwer]

Could this at least be treated different in the ui?

Some note: This also results in an issue where the frontend stops refreshing the status of the workflow in the local studio while executing a test run. Steps afterwards get executed, but this is not visible in the frontend.

[jarredwitt]

Is there a way this can be elevated? Our admin activity feed shows 400+ notification errors for this month because of this bug. It's creating a ton of false positives for us and additional work for our admins because we have to look at each failure to see if there is actually a problem.

[Reizar]

+1 this is also causing big issues for us.

It also means we can't use the retry logic. We have the same setup where users have emails on by default and push notifications are opt in. We can't use the retry logic because even though the email step in the workflow succeeds, the push notification step fails and then it retries the entire workflow. Which causes emails to be sent over and over again.

[bibhuti9]

Hey any solution?