Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Allow img tags and attributes in the In-App & Email Editor #5310

Closed
2 tasks done
efaraz27 opened this issue Mar 17, 2024 · 2 comments · Fixed by #5312
Closed
2 tasks done

🚀 Feature: Allow img tags and attributes in the In-App & Email Editor #5310

efaraz27 opened this issue Mar 17, 2024 · 2 comments · Fixed by #5312
Assignees
Labels

Comments

@efaraz27
Copy link
Contributor

🔖 Feature description

To allow images to be send in emails and in-app notification.

🎤 Why is this feature needed ?

Right now it is not possible to add images to emails and in-app notification, this PR aims to solve that.

✌️ How do you aim to achieve this?

Novu used an npm packaged called sanitize-html, the default allowed tags, doesnt include img tags, this PRs aims to include it as it was done for the style tag in this PR.

🔄️ Additional Information

Original discussion for discord.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

Copy link

linear bot commented Mar 17, 2024

@jainpawan21
Copy link
Member

@efaraz27

Assigned to you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants